[PATCH v3] shell: moving drag surface refine

2012-08-07 Thread juan . j . zhao
From: Juan Zhao When applications not directly based on toytoolkit, like simple-egl, efl applications is grabbed and moved, they may be moved to the place under the panel. Then they could not be grabbed again. Don't allow the pointer's bounding box move across the shell's active_regions. v3: use

Re: [PATCH v2] shell: moving drag surface refine

2012-08-07 Thread Juan Zhao
On Thu, 2012-08-02 at 12:01 -0400, Kristian Høgsberg wrote: > We need to loop through the rectangles in the region and make sure at > least one of them is at least boxsize wide and high. Consider a > common configuration: > > ++---+ > |

[PATCH weston] shell: Don't draw shadows for maximized windows.

2012-08-07 Thread Scott Moreau
This effectively fixes a bug where maximized windows appear to not maximize fully bacause of the shadow margin. Instead, we now maximize the window to the understood input region. --- This problem is much more easily and appropriately fixed in shell.c but it makes the assumption that the input_reg

Re: [PATCH 2/2 weston v3] toytoolkit: Don't draw shadows for maximized windows.

2012-08-07 Thread Scott Moreau
I found it now in weston_surface->input. I think I want to try rewriting this patch in shell.c because I think it makes more sense. So please hold off on this particular version for now. Thanks, Scott ___ wayland-devel mailing list wayland-devel@lists.

Re: [PATCH 2/2 weston v3] toytoolkit: Don't draw shadows for maximized windows.

2012-08-07 Thread Scott Moreau
The more I think about it, the more I think this functionality might fit better into shell.c, but this would mean shell would have to know the input region of the surface. Is there a way to get the input region set by the client? The region is set in toytoolkit here http://cgit.freedesktop.org/wayl

Re: [PATCH 1/2 weston] toytoolkit: Correct improper usage of opaque for button widgets.

2012-08-07 Thread Ander Conselvan de Oliveira
On 08/07/2012 02:03 PM, Scott Moreau wrote: Hi Ander, On Tue, Aug 7, 2012 at 2:57 AM, Ander Conselvan de Oliveira mailto:conselv...@gmail.com>> wrote: What exactly does this fix? Your commit message doesn't make it that obvious. I assumed the problem was obvious. The definition of t

Re: [PATCH 3/3] wayland-cursor: Adapt to new shm pool helper functions

2012-08-07 Thread Andre Heider
On Tue, Aug 7, 2012 at 2:15 PM, Ander Conselvan de Oliveira wrote: > void > wl_shm_mapping_set_resize_behavior(struct wl_shm_mapping *mapping, >enum wl_shm_mapping_resize_behavior > behavior); > > Or maybe have that as flags for wl_shm_mapping_create(). But the

Re: [PATCH 3/3] wayland-cursor: Adapt to new shm pool helper functions

2012-08-07 Thread Andre Heider
On Tue, Aug 7, 2012 at 2:15 PM, Ander Conselvan de Oliveira wrote: > I like to have the allocate function try to resize the pool if needed. All > users except wayland-cursor allocate a pool large enough, so they should > never reach and on the other hand its convenient not to have to write the > r

Re: [PATCH 2/3] wayland-client: Introduce shm pool helper function

2012-08-07 Thread Andre Heider
On Tue, Aug 7, 2012 at 2:03 PM, Ander Conselvan de Oliveira wrote: >> +#include "../shared/os-compatibility.h" > > You should have the Makefile set -I$(top_srcdir)/shared so you can do just > > #include "os-compatibility.h", > > but I think we don't need a libshared in this particular case. Wil

Re: [PATCH 0/3] Introduce shm pool helper functions

2012-08-07 Thread Andre Heider
On Tue, Aug 7, 2012 at 1:43 PM, Ander Conselvan de Oliveira wrote: > I think this could be called wl_shm_mapping and we get rid of the unmap > parameter to wl_shm_pool_helper_destroy(). In terms of a public API I think > it is bad idea to let the user leak the mapping. In simple-shm.c, > simple-to

[PATCH 2/2 weston v3] toytoolkit: Don't draw shadows for maximized windows.

2012-08-07 Thread Scott Moreau
This effectively fixes a bug where maximized windows appear to not maximize fully bacause of the shadow margin. Instead, we maximize the window to the input region. --- v3: * Applied the same logic to both instances of theme_get_location() so the resize cursors show properly for maximized windo

Re: [PATCH 3/3] wayland-cursor: Adapt to new shm pool helper functions

2012-08-07 Thread Ander Conselvan de Oliveira
On 08/04/2012 04:22 PM, Andre Heider wrote: --- cursor/wayland-cursor.c | 115 ++- 1 file changed, 24 insertions(+), 91 deletions(-) diff --git a/cursor/wayland-cursor.c b/cursor/wayland-cursor.c index 10e8f62..8e467f6 100644 --- a/cursor/wayland-c

Re: [PATCH 2/3] wayland-client: Introduce shm pool helper function

2012-08-07 Thread Ander Conselvan de Oliveira
On 08/04/2012 04:22 PM, Andre Heider wrote: Every client dealing with shm buffers requires code to set up pools. Wayland already implements this platform independent, so make public helper function available instead of putting the burden on every client. --- src/Makefile.am |6 ++- sr

Re: [PATCH 0/3] Introduce shm pool helper functions

2012-08-07 Thread Ander Conselvan de Oliveira
On 08/04/2012 04:22 PM, Andre Heider wrote: This set adds a couple of helper function to wayland-client to handle shm pools. Motivation: I noticed the amount of code duplication on client side. On top of that, wayland already maintains this platform independent. I'm not happy with the names of

[PATCH 2/2 weston v2] toytoolkit: Don't draw shadows for maximized windows.

2012-08-07 Thread Scott Moreau
This effectively fixes a bug where maximized windows appear to not maximize fully bacause of the shadow margin. Instead, we maximize the window to the input region. --- Hi Ander, thanks for your review. You are right, changing theme data directly is wrong. In this v2 patch, it's fixed so the use

Re: [PATCH 1/2 weston] toytoolkit: Correct improper usage of opaque for button widgets.

2012-08-07 Thread Scott Moreau
Hi Ander, On Tue, Aug 7, 2012 at 2:57 AM, Ander Conselvan de Oliveira < conselv...@gmail.com> wrote: > What exactly does this fix? Your commit message doesn't make it that > obvious. > I assumed the problem was obvious. The definition of the word opaque makes it clear. In frame_button_redraw_ha

Re: [PATCH 2/2 weston] toytoolkit: Don't draw shadows for maximized windows.

2012-08-07 Thread Ander Conselvan de Oliveira
On 08/07/2012 09:32 AM, Scott Moreau wrote: This effectively fixes a bug where maximized windows appear to not maximize fully bacause of the shadow margin. Instead, we now maximize the window to the understood input region. --- clients/window.c | 60 -

Re: [PATCH 1/2 weston] toytoolkit: Correct improper usage of opaque for button widgets.

2012-08-07 Thread Ander Conselvan de Oliveira
What exactly does this fix? Your commit message doesn't make it that obvious. Weston commit 010f98b0 added the opaque field to struct widget to "track and report [...] opaque regions", i.e., the region of a surface whose alpha channel is 1. It seems to me the frame button code is abusing this

Re: Java, touch screen support

2012-08-07 Thread Pekka Paalanen
On Tue, 7 Aug 2012 09:42:25 +0200 Hársszegi Tibor wrote: > Hello, > > I know that this is a complete noob question, but is there any way to do > graphics > on Wayland (via Cairo? maybe) on Java? I don't really know Java in that respect. > Also I assume if the Linux kernel supports a given tou

Java, touch screen support

2012-08-07 Thread Hársszegi Tibor
Hello, I know that this is a complete noob question, but is there any way to do graphics on Wayland (via Cairo? maybe) on Java? Also I assume if the Linux kernel supports a given touch screen by its kernel, then Wayland can use this as an input device, right? Sorry for the lame questions :( Regar

Re: [RFC PATCH 06/12] tablet-shell: Applications can run on tablet

2012-08-07 Thread Pekka Paalanen
On Tue, 07 Aug 2012 09:35:44 +0800 Juan Zhao wrote: > Thanks, Tiago. :) > It's helpful. > > On Mon, 2012-08-06 at 11:35 +0300, Tiago Vignatti wrote: > > Hi Juan, > > > > There's an intentional separation of the wl_shell_surface_interface > > on > > its own (desktop) shell file. Its purpose is

[PATCH 1/2 weston] toytoolkit: Correct improper usage of opaque for button widgets.

2012-08-07 Thread Scott Moreau
--- clients/window.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/clients/window.c b/clients/window.c index d0b7a7d..30a6167 100644 --- a/clients/window.c +++ b/clients/window.c @@ -1259,7 +1259,7 @@ frame_resize_handler(struct widget *widget, opaque_ma

[PATCH 2/2 weston] toytoolkit: Don't draw shadows for maximized windows.

2012-08-07 Thread Scott Moreau
This effectively fixes a bug where maximized windows appear to not maximize fully bacause of the shadow margin. Instead, we now maximize the window to the understood input region. --- clients/window.c | 60 1 file changed, 43 insertions(+),