Re: [PATCH libxkbcommon 1/2] makekeys: add all symbols converted to lower-case

2012-10-02 Thread Ran Benita
Hi David, On Mon, Oct 01, 2012 at 07:29:58PM +0200, David Herrmann wrote: xkb_keysym_from_name() uses a big lookup table generated by makekeys to find keysyms. It does this case-sensitive because we have keys like XKB_KEY_A and XKB_KEY_a. So if a user searches for a we must always return the

Re: Will Wayland also ship with broken keyboard layout switching?

2012-10-02 Thread Ran Benita
On Tue, Oct 02, 2012 at 12:35:31PM +1000, Daniel Stone wrote: Hi, On 2 October 2012 11:38, dar...@chaosreigns.com wrote: On 10/02, Фамилия Имя wrote: switch between different keyboard layouts (languages) using both alt keys. It was https://bugs.freedesktop.org/show_bug.cgi?id=4927

Re: [PATCH libxkbcommon 1/2] makekeys: add all symbols converted to lower-case

2012-10-02 Thread David Herrmann
Hi Ran On Tue, Oct 2, 2012 at 9:37 AM, Ran Benita ran...@gmail.com wrote: Hi David, On Mon, Oct 01, 2012 at 07:29:58PM +0200, David Herrmann wrote: xkb_keysym_from_name() uses a big lookup table generated by makekeys to find keysyms. It does this case-sensitive because we have keys like

[PATCH 1/4] editor: fix assert to take preedit string into account

2012-10-02 Thread Philipp Brüschweiler
--- clients/editor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/clients/editor.c b/clients/editor.c index 5643338..c656b06 100644 --- a/clients/editor.c +++ b/clients/editor.c @@ -500,7 +500,8 @@ text_entry_update_layout(struct text_entry *entry) { char *text;

[PATCH 2/4] editor: make selection a lighter shade of blue, much easier to read

2012-10-02 Thread Philipp Brüschweiler
--- clients/editor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/editor.c b/clients/editor.c index c656b06..7140e53 100644 --- a/clients/editor.c +++ b/clients/editor.c @@ -639,7 +639,7 @@ text_entry_draw_selection(struct text_entry *entry, cairo_t *cr)

[PATCH 4/4] editor: more intuitive cursor positioning

2012-10-02 Thread Philipp Brüschweiler
Compute the nearest glyph edge instead of taking the one to the left of the cursor. Also fixes a segfault when trying to compute the position for an empty buffer. --- clients/editor.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/clients/editor.c

Re: Will Wayland also ship with broken keyboard layout switching?

2012-10-02 Thread Daniel Stone
Hi, On 2 October 2012 17:51, Ran Benita ran...@gmail.com wrote: Well, speaking of XKB bugs, there's this one which is inherent to the specification: https://bugs.freedesktop.org/show_bug.cgi?id=865 We might want to consider some way to properly fix this? Indeed. I still can't think of a way

Re: [PATCH libxkbcommon 1/2] makekeys: add all symbols converted to lower-case

2012-10-02 Thread Ran Benita
On Tue, Oct 02, 2012 at 11:07:11AM +0200, David Herrmann wrote: On Tue, Oct 2, 2012 at 9:37 AM, Ran Benita ran...@gmail.com wrote: I like the idea, and it seems to work. First, one thing that's easy to miss, this should work: assert(test_string(xf86_switch_vt_5,

[PATCH 1/2] simple-shm: Don't attach the buffer to the surface for every redraw

2012-10-02 Thread Rob Bradford
From: Rob Bradford r...@linux.intel.com This will allow us to change just a sub region of the buffer. --- clients/simple-shm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/simple-shm.c b/clients/simple-shm.c index 252e040..e8dc620 100644 --- a/clients/simple-shm.c

[PATCH 2/2] simple-shm: Draw the test motif surrounded by a white border

2012-10-02 Thread Rob Bradford
From: Rob Bradford r...@linux.intel.com We can then use a wl_surface_damage to just trigger the compositor to update just a selected region of the buffer and thus test damaging a sub region. --- clients/simple-shm.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-)

[PATCH libxkbcommon v2 1/2] makekeys: use GNU gperf to generate perfect hashtables

2012-10-02 Thread David Herrmann
Instead of using a home-brew hashtable generator, we should instead use the gperf program which is known to work. This removes the makekeys programs and instead replaces it by a file that can generate input files for gperf. Gperf then generates hashtables for all of these input files and writes

[PATCH libxkbcommon v2 2/2] Add xkb_keysym_from_casename() with case-insensitive look

2012-10-02 Thread David Herrmann
Similar to strcasecmp() this function does an case-insensitive match. The match will _always_ be case-insensitive and return the lower-case character if there are conflicts. So if you want an exact match, you should use the normal lookup first and fallback to this. This should _never_ be used for

RE: [PATCH 2/2] simple-shm: Draw the test motif surrounded by a white border

2012-10-02 Thread Hársszegi Tibor
Call me lame, but what happens with small windows (e.g 20x20)? Feladó: Rob Bradford [r...@robster.org.uk] Küldve: 2012. október 2. 19:03 Címzett: wayland-devel@lists.freedesktop.org Másolatot kap: Rob Bradford Tárgy: [PATCH 2/2] simple-shm: Draw the test

Re: Will Wayland also ship with broken keyboard layout switching?

2012-10-02 Thread Bill Spitzak
Having read the bug, it seems extremely specific to layout switching with shift+ctrl. However there are a lot of other identical bugs that prevent things that are common on Windows from working on X: 1. One post mentions that hitting the windows key does some action, but that makes it

Comments on Weston's text interface

2012-10-02 Thread Pekka Vuorela
Hi guys, As mentioned earlier, I've been checking out a bit how the input method interface text has been proceeding in Weston. Nice stuff on the editor and virtual keyboard apps. Based on those, I came up with bunch of questions, suggestions and comments. First, how does this and normal hardware

Re: Will Wayland also ship with broken keyboard layout switching?

2012-10-02 Thread Daniel Stone
Hi, On 3 October 2012 05:34, Bill Spitzak spit...@gmail.com wrote: Having read the bug, it seems extremely specific to layout switching with shift+ctrl. It's not. However there are a lot of other identical bugs that prevent things that are common on Windows from working on X: 1. One post

[PATCH] desktop-shell: destroy data before exiting.

2012-10-02 Thread U. Artie Eoff
From: U. Artie Eoff ullysses.a.e...@intel.com desktop-shell never returned from display_run() since it was essentially killed when weston exited. To fix this, it is necessary to watch for EPOLLHUP in window.c so that toytoolkit clients will return from display_run() when weston quits. This

RE: [PATCH] desktop-shell: destroy data before exiting.

2012-10-02 Thread Eoff, Ullysses A
Although this is not a critical fix, it does increase unit test function coverage when weston is run with the desktop-shell (the default) ;-) U. Artie -Original Message- From: Eoff, Ullysses A Sent: Tuesday, October 02, 2012 9:13 PM To: wayland-devel@lists.freedesktop.org Cc: Eoff,

Re: [PATCH 2/2] simple-shm: Draw the test motif surrounded by a white border

2012-10-02 Thread Pekka Paalanen
On Tue, 2 Oct 2012 21:15:36 +0200 Hársszegi Tibor tibor.harssz...@scientificgames.hu wrote: Call me lame, but what happens with small windows (e.g 20x20)? simple-shm is not resizeable. Feladó: Rob Bradford [r...@robster.org.uk] Küldve: 2012. október

RE: [PATCH 2/2] simple-shm: Draw the test motif surrounded by a white border

2012-10-02 Thread Hársszegi Tibor
aok, thanks! -Original Message- From: Pekka Paalanen [mailto:ppaala...@gmail.com] Sent: Wednesday, October 03, 2012 7:32 AM To: Hársszegi Tibor Cc: Rob Bradford; wayland-devel@lists.freedesktop.org; Rob Bradford Subject: Re: [PATCH 2/2] simple-shm: Draw the test motif surrounded

Re: [PATCH] desktop-shell: destroy data before exiting.

2012-10-02 Thread Pekka Paalanen
On Tue, 2 Oct 2012 21:12:35 -0700 U. Artie Eoff ullysses.a.e...@intel.com wrote: From: U. Artie Eoff ullysses.a.e...@intel.com desktop-shell never returned from display_run() since it was essentially killed when weston exited. To fix this, it is necessary to watch for EPOLLHUP in window.c