Re: [PATCH wayland] protocol: remove implicit attach semantics

2013-03-19 Thread Kristian Høgsberg
On Thu, Mar 07, 2013 at 01:10:01PM +0200, Pekka Paalanen wrote: > To match the Weston commit e7144fd175d1d68b91aa0cec7ab63381b79385a9: > Author: Kristian Høgsberg > Date: Mon Mar 4 12:11:41 2013 -0500 > > compositor: Only send release event in response to wl_surface.attach > > Remove the i

Re: Auto key repeat in wayland.

2013-03-19 Thread Pekka Vuorela
On 19.03.2013 22:13, Bill Spitzak wrote: Yichao Yu wrote: I am just wondering if those clients also don't want auto-repeat for text input. If there is a way to turn off auto-repeat for a client, should that also turn off the auto-repeat when the input method grab the keyboard from the client?

Re: [PATCH v2] compositor: send a pointer motion if the focus surface moves under the pointer

2013-03-19 Thread Giulio Camuffo
Kristian, is the timespamp i'm using now correct? 2013/2/28 Giulio Camuffo : > This makes weston_device_repick() return an int, 1 if the pointer moved on the > same surface, 0 otherwise. notify_motion sends the motion event on its own, > while weston_compositor_repick() checks if it returns 1 and

Re: [PATCH 00/13] Clean up text protocol and move to wayland

2013-03-19 Thread Pekka Vuorela
On 18.03.2013 16:21, Jan Arne Petersen wrote: On 03/08/2013 09:17 PM, Pekka Vuorela wrote: Before moving to Wayland, one thing that I'd like to be covered good is the good old synchronization problem. Suppose input method commits "a", then "b", and then decides via some error correction mecha

Re: [PATCH v3] shell: grab the parent popup when a sub popup window is deleted or hidden

2013-03-19 Thread Giulio Camuffo
Any further comment on this? This functionality is needed to have a sane behaviour of popup menus in real apps. 2013/3/16 Giulio Camuffo : > If the client opens a popup menu and submenu, when it closes or hides the > submenu the pointer grab should return to the parent menu. > Furthermore, when cl

Re: Auto key repeat in wayland.

2013-03-19 Thread Bill Spitzak
Yichao Yu wrote: I am just wondering if those clients also don't want auto-repeat for text input. If there is a way to turn off auto-repeat for a client, should that also turn off the auto-repeat when the input method grab the keyboard from the client? That is a good point, the input method ap

[RFC weston] Change usage of wl_buffer to correspond to changes in libwayland

2013-03-19 Thread Jason Ekstrand
--- src/compositor.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index b734f67..305efe0 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -1060,7 +1060,7 @@ weston_buffer_reference_handle_destroy(struct wl_listener *

[RFC mesa] wayland-drm: Update wl_drm_buffer to use the new version of wl_buffer based on a wl_resource pointer

2013-03-19 Thread Jason Ekstrand
--- src/egl/wayland/wayland-drm/wayland-drm.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/src/egl/wayland/wayland-drm/wayland-drm.c b/src/egl/wayland/wayland-drm/wayland-drm.c index d02aab6..8d4972a 100644 --- a/src/egl/wayland/wayland-drm/wayland-drm

[RFC wayland] Make wl_buffer use a wl_resource pointer instead of including it directly

2013-03-19 Thread Jason Ekstrand
--- src/wayland-server.h | 3 ++- src/wayland-shm.c| 49 +++-- 2 files changed, 25 insertions(+), 27 deletions(-) diff --git a/src/wayland-server.h b/src/wayland-server.h index 2c6efc9..01ef7b5 100644 --- a/src/wayland-server.h +++ b/src/wayland-se

Re: [RFC 0/4] New wayland-egl functions for swapping

2013-03-19 Thread John Kåre Alsaker
wl_egl_window_take_buffer might also facilitate sharing wl_buffers between processes. On Mon, Mar 4, 2013 at 1:51 PM, John Kåre Alsaker wrote: > On Mon, Mar 4, 2013 at 11:56 AM, Pekka Paalanen wrote: >> On Mon, 4 Mar 2013 11:12:23 +0100 >> John Kåre Alsaker wrote: >> >>> On Mon, Mar 4, 2013 at

Re: On cursor theme and size

2013-03-19 Thread Kristian Høgsberg
On Thu, Mar 14, 2013 at 05:23:36PM +0100, Emilio Pozuelo Monfort wrote: > Hi, > > I was looking at why gtk+ clients use a different cursor theme and > size than other (toytoolkit) clients. gtk+ hardcodes the cursor size > to 32 as it has no way to get the preferred (default) size from the > compos

Re: [PATCH weston] weston-launch: cleanup - return failures in main with EXIT_FAILURE

2013-03-19 Thread Kristian Høgsberg
On Tue, Mar 12, 2013 at 02:36:52AM +0530, Siddharth Heroor wrote: > > Signed-off-by: Siddharth Heroor Thanks, committed. Kristian > src/weston-launch.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/src/weston-launch.c b/src/weston-launch.c > index bc7f8a

Re: [PATCH 2/3 v3] compositor: turn off the idle timer when sleeping

2013-03-19 Thread Kristian Høgsberg
On Sun, Mar 10, 2013 at 04:08:30PM +0100, Philipp Brüschweiler wrote: > Also updates the drm, fbdev and rpi backend to use > weston_compositor_set_sleeping() and not set the state manually. > > Fixes https://bugs.freedesktop.org/show_bug.cgi?id=61910 (rpi backend > untested). > > v2: don't set DP

Re: [PATCH 3/3] compositor-rpi: Use correct enum, removes a warning

2013-03-19 Thread Kristian Høgsberg
On Sun, Mar 10, 2013 at 04:08:31PM +0100, Philipp Brüschweiler wrote: Committed, thanks. Kristian > --- > src/compositor-rpi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/compositor-rpi.c b/src/compositor-rpi.c > index 9571e85..8163d85 100644 > --- a/src/composi

Re: [PATCH weston 1/2] weston-launch: move function calls out of assert()

2013-03-19 Thread Kristian Høgsberg
On Sat, Mar 09, 2013 at 07:38:56PM +0100, Philipp Brüschweiler wrote: > --- > src/weston-launch.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) Committed. Whie the patch certainly improves the situation, maybe we should just do actual error handling and exit with an error.

Re: [PATCH weston 2/2 v3] weston-launch: return better value if weston dies because of a signal

2013-03-19 Thread Kristian Høgsberg
On Sun, Mar 10, 2013 at 03:14:01PM +0100, Philipp Brüschweiler wrote: > Before this commit, weston-launch returned 0 if weston was killed by a > signal. This makes it hard to automatically test weston by using > weston-launch, as there is no way to know why weston was terminated. > > This commit m

Re: [PATCH weston v3] toytoolkit: avoid redrawing a window between maximize and configure

2013-03-19 Thread Kristian Høgsberg
On Sat, Mar 02, 2013 at 11:43:57PM +, MoD wrote: > Resolve a bad frame visible when maximizing toytoolkit programs with the the > maximize button in decorations. Windows now use wl_display.sync requests to > wait for a maximize to finish before drawing again, following suggestions from > http:/

Re: [PATCH 0/4] improve window maximize handling

2013-03-19 Thread Kristian Høgsberg
On Mon, Mar 11, 2013 at 07:26:52PM +0100, Rafal Mielniczuk wrote: > Hi > > This series of patches improves a bit handling of maximized windows in desktop > shell. > > There were some inconsistencies like window could be moved in maximized state > using mod+left button, window not reseting rotatio

DEPRECATED: wl_resource as a transparent structure

2013-03-19 Thread Jason Ekstrand
Devs, This is to let you know that we are going to try and depreciate wl_resource. I talked with Kristian about it this morning on IRC. This does not mean that wl_resource will be completely gone, just that it will become an opaque pointer like wl_proxy; you will not be able to directly access any

[PATCH wayland] Add accessor functions for wl_resource and deprecate wl_client_add_resource

2013-03-19 Thread Jason Ekstrand
This is the first step towards deprecating wl_resource as a transparent structure. In the future, wl_resource will be an opaque pointer type and client code will not have access to its memebers. --- src/wayland-server.c | 39 +++ src/wayland-server.h | 27

Re: Auto key repeat in wayland.

2013-03-19 Thread Daniel Barlow
On 19 March 2013 16:58, Scott Moreau wrote: > This is a good point. I think the plan here as discussed before is > that, eventually we'll have a way for clients to request 'raw events' > which means the compositor will hand events to the client with minimal > or no processing (including key repeat

Re: Auto key repeat in wayland.

2013-03-19 Thread Scott Moreau
Hi Brenden, On Tue, Mar 19, 2013 at 9:01 AM, Friar wrote: > Please also consider the case of video games that are running in > non-full-screen mode that don't WANT key auto-repeat. They should have a > way to turn off repeated notifications. Having to wade through a ton of > auto-repeated keybo

Re: surface buffer cardinality and outputs

2013-03-19 Thread Zygmunt Krynicki
W dniu wto, mar 19, 2013 o 5:19 ,nadawca Jerome Glisse napisał: > > See also: http://en.wikipedia.org/wiki/Subpixel_rendering#Checkered_RG-BW_layout AFAICT different RGB layout is a dead end and no longer pursue by anyone. Everyone seems to be moving toward higher dpi. None the less pr

Re: [PATCH 2/4] shell: reset rotation for maximized surface

2013-03-19 Thread Kristian Høgsberg
On Mon, Mar 11, 2013 at 07:26:54PM +0100, Rafal Mielniczuk wrote: > Surface will preserve its rotation transformation when maximizing, which > will cause incosistiencies (eg. no window shadows drawn) > > This patch removes rotation from maximized surface and restore it when > unmaximizing (just li

Re: surface buffer cardinality and outputs

2013-03-19 Thread Jerome Glisse
On Tue, Mar 19, 2013 at 11:34 AM, Jason Ekstrand wrote: > I'm not sure exactly what I think of all this surface transform > passing. I'll get back to that once I get a chance to think about it. > Part of the problem is that you don't want to try and make your > animations subpixel-perfect becaus

Re: [PATCH 1/4] shell: block move, rotate, resize in maximized state

2013-03-19 Thread Kristian Høgsberg
On Mon, Mar 11, 2013 at 07:26:53PM +0100, Rafal Mielniczuk wrote: > To remain consisten with client side window, which blocks moving and > resizing of window in maximized state, we should do so on the compositor > side as well. Yeah, makes sense. Committed (with a couple of white space edits as d

Re: Auto key repeat in wayland.

2013-03-19 Thread Yichao Yu
On Tue, Mar 19, 2013 at 11:01 AM, Friar wrote: > Please also consider the case of video games that are running in > non-full-screen mode that don't WANT key auto-repeat. They should have a > way to turn off repeated notifications. Having to wade through a ton of > auto-repeated keyboard events t

Re: surface buffer cardinality and outputs

2013-03-19 Thread Jason Ekstrand
I'm not sure exactly what I think of all this surface transform passing. I'll get back to that once I get a chance to think about it. Part of the problem is that you don't want to try and make your animations subpixel-perfect because that would require a lot of round-trips to make it right. One

Re: Auto key repeat in wayland.

2013-03-19 Thread Friar
Please also consider the case of video games that are running in non-full-screen mode that don't WANT key auto-repeat. They should have a way to turn off repeated notifications. Having to wade through a ton of auto-repeated keyboard events to find the actual up/down signals is likely to cause som

Re: [PATCH wayland v3] protocol: Add minimize/maximize protocol

2013-03-19 Thread Pekka Paalanen
Hi, just a fly-by comment from the sickbed here (well, recovering already). On Mon, 18 Mar 2013 14:24:17 -0600 Scott Moreau wrote: > Yes and again, I would like to thank you for taking the time out to > address this. I now have a couple of other outstanding cases I would > like to introduce to