Re: [patches] Add a color management framework to weston

2013-04-03 Thread John Kåre Alsaker
The weston_color_manager struct could lose the state field. The CMS plugins allocates it and can add state as needed. You should move the weston_cms_output_added call below weston_output_init (which initializes the compositor pointer in the outputs) and drop the first argument from output_added, ou

[PATCH v2 5/5] doc: use a dynamic list of man pages

2013-04-03 Thread Peter Hutterer
This requires that doxygen is run before the man target so find can actually find the man pages. Signed-off-by: Peter Hutterer --- Changes to v1: - use dist_MAN3_MANS - add comment how it works and why we use all-local doc/doxygen/Makefile.am | 57 ++-

[PATCH v2 4/5] doc: Improve "Library" and "Compositors" chapter

2013-04-03 Thread Peter Hutterer
Originally written Tiago Vignatti Some modifications to adjust for previously merged conflicting patches and link to the sections (instead of ). Signed-off-by: Peter Hutterer --- Changes to v2: - rebased to master, links added doc/publican/sources/Compositors.xml | 19 ++- doc

[PATCH v2 3/5] doc: create a fake make target to de-duplicate the xml merging process

2013-04-03 Thread Peter Hutterer
The only difference between the server and client xml files is the directories and files being named *server* and *client*, respectively. Add a new make target to get that process done to avoid duplication Signed-off-by: Peter Hutterer --- Changes to v2: - rebased to master doc/publican/Makefil

[PATCH v2 2/5] doc: generate server documentation from XML too

2013-04-03 Thread Peter Hutterer
Same as WaylandClientAPI.xml we now also generate WaylandServerAPI.xml for publication. Most of this hunk is just adding a client/ or server/ into the xml path to keep the two separate. The change in wayland.doxygen now causes a standard doxygen call to not generate anything - what is generated is

[PATCH v2 1/5] doc: Capitalize all Wayland occurrences

2013-04-03 Thread Peter Hutterer
From: Tiago Vignatti Signed-off-by: Tiago Vignatti Reviewed-by: Peter Hutterer [re-run of search/replace after rebasing] Signed-off-by: Peter Hutterer --- Changes to v1: - rebased to master doc/man/wl_display_connect.xml| 8 doc/publican/sources/Architecture.xml | 10

[PATCH RFC] doc: coerce doxygen into grouping man pages more sensibly

2013-04-03 Thread Peter Hutterer
The \file comment at the top is required to tell doxygen that this file actually has members (or use EXTRACT_ALL, which in our setup has the same effect since we restrict the source files) By default, all function's man pages end up as links to wayland-server.h.3, all structs have their own man pa

[PATCH] protocol: input documentation fixes

2013-04-03 Thread Peter Hutterer
Fix summary for wl_touch::motion, extend summary for wl_touch::down to match up/motion a bit better. Fix a typo in wl_touch, and claim that it's zero or more update events, not one or more. Signed-off-by: Peter Hutterer --- protocol/wayland.xml | 8 1 file changed, 4 insertions(+), 4 d

Re: [PATCH weston] Fix compiler warnings

2013-04-03 Thread Kristian Høgsberg
On Wed, Apr 03, 2013 at 09:29:03PM +0200, Armin K wrote: > This prevents compiler warnings when using libpng 1.6 and GCC 4.8 > --- > shared/image-loader.c | 1 + > 1 file changed, 1 insertion(+) Thanks, applied. Kristian > diff --git a/shared/image-loader.c b/shared/image-loader.c > index c9f15d

Re: [PATCH 10/18] doc: Add our own Legal Notice

2013-04-03 Thread Kristian Høgsberg
On Wed, Apr 03, 2013 at 02:56:06PM -0400, Kristian Høgsberg wrote: > On Tue, Apr 02, 2013 at 10:09:04AM +1000, Peter Hutterer wrote: > > From: Tiago Vignatti > > > > Previously, Publican was auto-generating a file with it and systems that > > don't > > have such tool can't benefit from it. This p

Re: [PATCH 5/4] doc: use a dynamic list of man pages

2013-04-03 Thread Peter Hutterer
On Wed, Apr 03, 2013 at 09:57:47PM +0200, Quentin Glidic wrote: > On 03/04/2013 07:34, Peter Hutterer wrote: > [snip] > >-man3_MANS= $(client_MANPAGES) $(server_MANPAGES) > >+man3_MANS= $(shell find man/man3/ -name "wl_*.3" -printf "man/man3/%P\n") > > You should use dist_man3_MANS here. > > > x

Weston now depends on libunwind v1.1

2013-04-03 Thread darxus
This dependency was recently added, and the version is newer than what is packaged by Debian, so I added it to http://wayland.freedesktop.org/building.html $ git clone git://git.sv.gnu.org/libunwind $ cd libunwind $ autoreconf -i $ ./configure --prefix=$installdir $ make && mak

Re: [PATCH 5/4] doc: use a dynamic list of man pages

2013-04-03 Thread Quentin Glidic
On 03/04/2013 07:34, Peter Hutterer wrote: [snip] -man3_MANS= $(client_MANPAGES) $(server_MANPAGES) +man3_MANS= $(shell find man/man3/ -name "wl_*.3" -printf "man/man3/%P\n") You should use dist_man3_MANS here. xml/client/index.xml: $(scanned_src_files_client) wayland.doxygen $(AM_V

Re: [PATCH 5/4] doc: use a dynamic list of man pages

2013-04-03 Thread Kristian Høgsberg
On Wed, Apr 03, 2013 at 03:34:45PM +1000, Peter Hutterer wrote: > This requires that doxygen is run before the man target so find can actually > find the man pages. > > Signed-off-by: Peter Hutterer > --- > On Wed, Apr 03, 2013 at 04:54:10AM +0100, Daniel Stone wrote: > > Is there any chance we >

[patches] Add a color management framework to weston

2013-04-03 Thread Richard Hughes
I've attached three patches for comments and review. I'm a GLib programmer at heart, so please be kind if I've made huge obvious architectural mistakes :) Patch 1 adds the framework code, patch 2 adds the ability to load CMS modules, and patch 3 adds a CMS module written for colord. With those thr

Re: [PATCH 0/4] doc: auto-generate man pages and server documentation

2013-04-03 Thread Kristian Høgsberg
On Tue, Apr 02, 2013 at 11:08:58AM +1000, Peter Hutterer wrote: > > Patches 2 and 3 can be merged into one, I just left them separate because it > makes them easier to understand. > > As for the server man pages - not overly useful at the moment since there's > not enough doxygen info in the sour

Re: [PATCH 3/3] protocol: fix two protocol description 'typos'

2013-04-03 Thread Kristian Høgsberg
On Tue, Apr 02, 2013 at 09:58:18AM +1000, Peter Hutterer wrote: > Remove "mice, for example", it's described in the wl_pointer interface in > detail. And remove space before the full stop. > > wl_seat_caps_mask doesn't exist anymore, rename accordingly. > > Signed-off-by: Peter Hutterer > --- >

[PATCH weston] Fix compiler warnings

2013-04-03 Thread Armin K
This prevents compiler warnings when using libpng 1.6 and GCC 4.8 --- shared/image-loader.c | 1 + 1 file changed, 1 insertion(+) diff --git a/shared/image-loader.c b/shared/image-loader.c index c9f15d4..9f65dea 100644 --- a/shared/image-loader.c +++ b/shared/image-loader.c @@ -25,6 +25,7 @@ #

Re: [PATCH 2/3] protocol: document wl_pointer, wl_keyboard, wl_touch

2013-04-03 Thread Kristian Høgsberg
On Tue, Apr 02, 2013 at 10:23:29AM +1000, Peter Hutterer wrote: > On Tue, Apr 02, 2013 at 09:58:17AM +1000, Peter Hutterer wrote: > > Most of this should be clear, but let's spell a few things out. > > > > Signed-off-by: Peter Hutterer > > --- > > ok, now seeing that Matthias has worked on this

Re: [PATCH 1/3] protocol: use "summary", not "description" for xkb_v1 format

2013-04-03 Thread Kristian Høgsberg
On Tue, Apr 02, 2013 at 09:58:16AM +1000, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- > protocol/wayland.xml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/protocol/wayland.xml b/protocol/wayland.xml > index 9d276f8..4750115 100644 > --- a/protocol/wayla

Re: [PATCH 00/18] doc: misc improvements

2013-04-03 Thread Kristian Høgsberg
On Tue, Apr 02, 2013 at 10:08:54AM +1000, Peter Hutterer wrote: > About half of those are Tiago's patches that I took from the list/his repo > that hadn't been merged yet. The rest are largely style fixes to improve on > the html/pdf output generated by publican. > > Possibly controversial: 14/18,

Re: [PATCH 17/18] doc: improve formatting of client-side documentation

2013-04-03 Thread Kristian Høgsberg
On Tue, Apr 02, 2013 at 10:09:11AM +1000, Peter Hutterer wrote: > A bunch of changes to the xsl transformation stylesheet to make Chapter 4 > (Client API) look nicer and more readable. > > Main changes: > - function synopsis listed > - lists for parameters and return values > - long function descr

Re: [PATCH 10/18] doc: Add our own Legal Notice

2013-04-03 Thread Kristian Høgsberg
On Tue, Apr 02, 2013 at 10:09:04AM +1000, Peter Hutterer wrote: > From: Tiago Vignatti > > Previously, Publican was auto-generating a file with it and systems that don't > have such tool can't benefit from it. This patch adds our own copy of Legal > Notice. > > Signed-off-by: Tiago Vignatti > S

Re: [PATCH 08/18] doc: Capitalize all Wayland occurrences

2013-04-03 Thread Kristian Høgsberg
On Tue, Apr 02, 2013 at 10:09:02AM +1000, Peter Hutterer wrote: > From: Tiago Vignatti > > Signed-off-by: Tiago Vignatti > Reviewed-by: Peter Hutterer > Signed-off-by: Peter Hutterer > --- > doc/Wayland/en_US/Architecture.xml | 10 +- > doc/Wayland/en_US/Book_Info.xml| 2 +- > do

Re: [PATCH 07/18] doc: Improve "Library" chapter, moving "Types of Compositor" as its section

2013-04-03 Thread Kristian Høgsberg
On Tue, Apr 02, 2013 at 10:09:01AM +1000, Peter Hutterer wrote: > From: Tiago Vignatti > > It was added a "Server API" section and "Types of Compositor" was moved there > also. I hope this gives a better structure for the documentation. > > Signed-off-by: Tiago Vignatti > Reviewed-by: Peter Hut

Re: [PATCH weston] shell: the move, resize, rotate bindings work on the parent of popups

2013-04-03 Thread Kristian Høgsberg
On Wed, Apr 03, 2013 at 05:20:41PM +0200, Giulio Camuffo wrote: > this makes the move, resize and rotate bindings check whenever the > focus surface is a popup, and if it is it will walk the surface > hierarchy unitil it finds a non-popup one, and will apply the > effect on that > --- > src/shell.

Re: [PATCH weston] autotools: Add a libunwind configure switch

2013-04-03 Thread Kristian Høgsberg
On Wed, Apr 03, 2013 at 08:19:45PM +0200, Quentin Glidic wrote: > From: Quentin Glidic > > Signed-off-by: Quentin Glidic > --- > configure.ac | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) Thanks, that's better, it also lets us pass --enable-libunwind and fail if it's not

[PATCH weston] autotools: Add a libunwind configure switch

2013-04-03 Thread Quentin Glidic
From: Quentin Glidic Signed-off-by: Quentin Glidic --- configure.ac | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index ed06d0b..316ee11 100644 --- a/configure.ac +++ b/configure.ac @@ -299,12 +299,14 @@ if test "x$GCC" = "xyes"; th

Re: protocol questions

2013-04-03 Thread Thiago Macieira
On quarta-feira, 3 de abril de 2013 12.43.35, Kristian Høgsberg wrote: > > But the client may still want to popup a grabbing window (e.g. system-tray > > menu) in response to other event (e.g. dbus event) indirectly caused > > (handler in another process) by the user input. > > I can't think of any

Re: protocol questions

2013-04-03 Thread Yichao Yu
On Wed, Apr 3, 2013 at 1:18 PM, Daniel Stone wrote: > Hi, > > On 3 April 2013 18:01, Yichao Yu wrote: > > Yes I am talking about menu not notification (sorry the name is status > > notifier[1] instead of status notification), which is the system tray > > protocol. > > Ah OK, I see. In this case

Re: protocol questions

2013-04-03 Thread Daniel Stone
Hi, On 3 April 2013 18:01, Yichao Yu wrote: > Yes I am talking about menu not notification (sorry the name is status > notifier[1] instead of status notification), which is the system tray > protocol. Ah OK, I see. In this case though, there's still a user input event which triggers it, so I do

[PATCH weston v3 3/3] clients: Add simple-notification

2013-04-03 Thread Quentin Glidic
From: Quentin Glidic Signed-off-by: Quentin Glidic --- A copy of simple-shm to test the usage of the notification interface clients/.gitignore| 3 + clients/Makefile.am | 11 ++ clients/simple-notification.c | 387 ++ 3 files ch

[PATCH weston v3 2/3] shell: Implement wl_notification_daemon

2013-04-03 Thread Quentin Glidic
From: Quentin Glidic Implement the "bubbles list" style notifications. Corner anchor, margin and order can be changed in the configuration. Signed-off-by: Quentin Glidic --- Nothing really new here, just using the configure callback to place the surfaces correctly when a new buffer is attached

[PATCH weston v3 1/3] protocol: Add wl_notification_daemon interface

2013-04-03 Thread Quentin Glidic
From: Quentin Glidic Signed-off-by: Quentin Glidic --- I moved the protocol bit to Weston for now, to test it further protocol/Makefile.am| 3 ++- protocol/wl-notification-daemon.xml | 50 + 2 files changed, 52 insertions(+), 1 deletion(-)

Re: protocol questions

2013-04-03 Thread Yichao Yu
On Wed, Apr 3, 2013 at 12:56 PM, Daniel Stone wrote: > Hi Yichao, > > On 3 April 2013 17:50, Yichao Yu wrote: > > On Wed, Apr 3, 2013 at 12:43 PM, Kristian Høgsberg > > wrote: > >> I can't think of anything that does this in any desktop environment > >> I've ever seen. If as usecase for this c

Re: protocol questions

2013-04-03 Thread Daniel Stone
Hi Yichao, On 3 April 2013 17:50, Yichao Yu wrote: > On Wed, Apr 3, 2013 at 12:43 PM, Kristian Høgsberg > wrote: >> I can't think of anything that does this in any desktop environment >> I've ever seen. If as usecase for this comes up we can certainly add >> it, or any desktop environment can d

Re: protocol questions

2013-04-03 Thread Yichao Yu
On Wed, Apr 3, 2013 at 12:43 PM, Kristian Høgsberg wrote: > On Wed, Apr 03, 2013 at 12:04:46PM -0400, Yichao Yu wrote: > > On Wed, Apr 3, 2013 at 11:16 AM, Kristian Høgsberg >wrote: > > > > > On Wed, Apr 3, 2013 at 10:59 AM, Yichao Yu wrote: > > > > > > > > > > > > > > > > On Wed, Apr 3, 2013 at

Re: [PATCH wayland] utils: const-ify some function arguments

2013-04-03 Thread Kristian Høgsberg
On Wed, Apr 03, 2013 at 05:29:16PM +0200, Giulio Camuffo wrote: > --- > src/wayland-util.c | 4 ++-- > src/wayland-util.h | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) Sure, let's do that. Kristian > diff --git a/src/wayland-util.c b/src/wayland-util.c > index 4ab1f5a..598ab42 10

Re: protocol questions

2013-04-03 Thread Kristian Høgsberg
On Wed, Apr 03, 2013 at 12:04:46PM -0400, Yichao Yu wrote: > On Wed, Apr 3, 2013 at 11:16 AM, Kristian Høgsberg wrote: > > > On Wed, Apr 3, 2013 at 10:59 AM, Yichao Yu wrote: > > > > > > > > > > > > On Wed, Apr 3, 2013 at 12:00 AM, Daniel Stone > > wrote: > > >> > > >> Hi, > > >> > > >> On 3 Apr

Re: [PATCH wayland] wayland-server: Listen for pointer current surface destruction

2013-04-03 Thread Kristian Høgsberg
On Wed, Apr 03, 2013 at 03:20:49PM +0100, Rob Bradford wrote: > From: Rob Bradford > > Add a destroy listener so that when the current surface associated with the > pointer is destroyed we can reset the pointer to the current surface. In order > to achieve this add a wl_pointer_set_current() whic

Re: protocol questions

2013-04-03 Thread Yichao Yu
On Wed, Apr 3, 2013 at 11:16 AM, Kristian Høgsberg wrote: > On Wed, Apr 3, 2013 at 10:59 AM, Yichao Yu wrote: > > > > > > > > On Wed, Apr 3, 2013 at 12:00 AM, Daniel Stone > wrote: > >> > >> Hi, > >> > >> On 3 April 2013 03:09, Kristian Høgsberg wrote: > >> > On Sat, Mar 30, 2013 at 01:31:34AM

[PATCH wayland] utils: const-ify some function arguments

2013-04-03 Thread Giulio Camuffo
--- src/wayland-util.c | 4 ++-- src/wayland-util.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/wayland-util.c b/src/wayland-util.c index 4ab1f5a..598ab42 100644 --- a/src/wayland-util.c +++ b/src/wayland-util.c @@ -55,7 +55,7 @@ wl_list_remove(struct wl_list *elm)

Re: [PATCH wayland] wayland-server: Listen for pointer current surface destruction

2013-04-03 Thread Giulio Camuffo
Looks good to me. 2013/4/3 Rob Bradford > From: Rob Bradford > > Add a destroy listener so that when the current surface associated with the > pointer is destroyed we can reset the pointer to the current surface. In > order > to achieve this add a wl_pointer_set_current() which handles assigni

[PATCH weston] shell: the move, resize, rotate bindings work on the parent of popups

2013-04-03 Thread Giulio Camuffo
this makes the move, resize and rotate bindings check whenever the focus surface is a popup, and if it is it will walk the surface hierarchy unitil it finds a non-popup one, and will apply the effect on that --- src/shell.c | 27 +++ 1 file changed, 27 insertions(+) diff -

Re: protocol questions

2013-04-03 Thread Kristian Høgsberg
On Wed, Apr 3, 2013 at 10:59 AM, Yichao Yu wrote: > > > > On Wed, Apr 3, 2013 at 12:00 AM, Daniel Stone wrote: >> >> Hi, >> >> On 3 April 2013 03:09, Kristian Høgsberg wrote: >> > On Sat, Mar 30, 2013 at 01:31:34AM -0400, Matthias Clasen wrote: >> >> - It looks like I can't trigger a popup from

Re: protocol questions

2013-04-03 Thread Yichao Yu
On Wed, Apr 3, 2013 at 12:00 AM, Daniel Stone wrote: > Hi, > > On 3 April 2013 03:09, Kristian Høgsberg wrote: > > On Sat, Mar 30, 2013 at 01:31:34AM -0400, Matthias Clasen wrote: > >> - It looks like I can't trigger a popup from a key or touch event, > >> because set_popup requires a serial tha

[PATCH weston] compositor: Use wl_pointer_set_current to cleanup after surface destruction

2013-04-03 Thread Rob Bradford
From: Rob Bradford This API call handles setting the current surface on the wl_pointer and also maintaining a destroy notification to monitor that surface for destruction. This is part of the fix for: https://bugzilla.gnome.org/show_bug.cgi?id=696946 --- src/compositor.c | 2 +- 1 file changed,

[PATCH wayland] wayland-server: Listen for pointer current surface destruction

2013-04-03 Thread Rob Bradford
From: Rob Bradford Add a destroy listener so that when the current surface associated with the pointer is destroyed we can reset the pointer to the current surface. In order to achieve this add a wl_pointer_set_current() which handles assigning the surface and creating the listener. This resolve

Re: Setting the display calibration ramps using weston

2013-04-03 Thread Richard Hughes
On 3 April 2013 13:56, Graeme Gill wrote: > A callback makes sense if this is essentially event driven. How is the > responder (ie. CMM) registered ? At the moment I've just got a: [core] cms=colord.so in weston.ini with the .so object setting vfuncs of a weston_color_manager struct. It's all v

Re: Setting the display calibration ramps using weston

2013-04-03 Thread Graeme Gill
Richard Hughes wrote: Hmm, we need to be able to change this on the fly, for instance the user changing the profile or clearing the curves to linear for profiling. The "user" meaning "an application working on behalf of the user to calibrate or profile the display". 1. Read the hardcoded .ic

[PATCH weston] window: don't execute the selected menu item when getting popup_done

2013-04-03 Thread Giulio Camuffo
--- clients/window.c | 1 - 1 file changed, 1 deletion(-) diff --git a/clients/window.c b/clients/window.c index 170a6c8..073ce53 100644 --- a/clients/window.c +++ b/clients/window.c @@ -3312,7 +3312,6 @@ handle_popup_done(void *data, struct wl_shell_surface *shell_surface) * be a windo