Re: [PATCH weston v3 07/13] window: implement shm triple-buffering

On Thu, 25 Apr 2013 12:34:13 -0700 Bill Spitzak wrote: > Pekka Paalanen wrote: > > > Triple-buffering is especially for sub-surfaces, where the > > compositor may have one wl_buffer busy on screen, and another > > wl_buffer busy in the sub-surface cached state due to the > > synchronized commit

Re: [PATCH weston v3 01/13] protocol: add sub-surfaces

On Thu, 25 Apr 2013 16:47:15 +0200 David Herrmann wrote: > Hi Pekka > > On Thu, Apr 25, 2013 at 12:57 PM, Pekka Paalanen wrote: > > Add protocol for sub-surfaces, wl_subcompositor as the global interface, > > and wl_subsurface as the per-surface interface extension. > > > > This patch is meant

Re: [PATCH weston 2/6] weston: Allow relative paths for modules

On Tue, 23 Apr 2013 17:16:48 +0200 John Kåre Alsaker wrote: > You should drop the code changes since they already allow relative paths. > You just changed it to only allow base filenames. Paths relative to what? Looks like there is a difference. > On Tue, Apr 23, 2013 at 2:54 PM, Quentin Glidic

Re: [PATCH weston 3/6] weston-test: Get the test client path from args

On Tue, 23 Apr 2013 14:54:47 +0200 Quentin Glidic wrote: > From: Quentin Glidic > > Signed-off-by: Quentin Glidic > --- > tests/weston-test.c| 18 -- > tests/weston-tests-env | 3 ++- > 2 files changed, 14 insertions(+), 7 deletions(-) > > diff --git a/tests/weston-test.

Re: [PATCH weston 4/6] shared/option-parser: Add string list options

On Tue, 23 Apr 2013 14:54:48 +0200 Quentin Glidic wrote: > From: Quentin Glidic > > Signed-off-by: Quentin Glidic > --- > man/weston.man | 6 +++--- > shared/config-parser.h | 1 + > shared/option-parser.c | 13 + > src/compositor.c | 27 ---

Re: [PATCH weston 5/6] tests: Drop weston-tests-env

On Tue, 23 Apr 2013 14:54:49 +0200 Quentin Glidic wrote: > From: Quentin Glidic > > Signed-off-by: Quentin Glidic Any explanation why doing this? > --- > tests/.gitignore | 10 +++-- > tests/Makefile.am | 56 > -- > tests/westo

Re: [PATCH weston 1/6] shared/option-parser: Allow spaced options

On 23/04/2013 17:05, Bill Spitzak wrote: On 04/23/2013 05:54 AM, Quentin Glidic wrote: +You can specify short options having an argument with a following space. Long +options with argument can be specified either with or without an equal sign. -static void +static bool handle_option(const

Re: [PATCH weston 2/6] weston: Allow relative paths for modules

On 26/04/2013 11:21, Pekka Paalanen wrote: Any specific use case, like tests? I guess I should read the following patches to find out, but that would be nice to tell in the commit message. Mostly tests and in-tree launch, to test a WIP module. -- Quentin “Sardem FF7” Glidic __

Re: [PATCH weston 2/6] weston: Allow relative paths for modules

On 23/04/2013 17:10, Bill Spitzak wrote: This disallows any subdirectories in MODULEDIR. Is this ok? Good question. An alternative would be to use the name unchanged if it starts with either '/' or '.' so the user can type "./foo" to get a file in the current directory. I’ll go this way, i

Re: [PATCH weston 3/6] weston-test: Get the test client path from args

On 26/04/2013 11:28, Pekka Paalanen wrote: Hi Quentin, it seems quite fragile to use an anonymous argument. What if something else used an anonymous argument, too? Who gets what will start to depend on the module loading order. Why not use the command line parser with a real long option? I ha

Re: [PATCH weston 4/6] shared/option-parser: Add string list options

On 26/04/2013 11:37, Pekka Paalanen wrote: There's a free(option_modules) further down below, right? What about freeing all the individual strings stored in it? No. But no option (string) is freed while all are strdup()-ed. Otherwise seems ok, though this does change the format of the --mo

Re: [PATCH weston 5/6] tests: Drop weston-tests-env

On 26/04/2013 11:44, Pekka Paalanen wrote: Any explanation why doing this? [snip] Dropping automake 1.11 support should be a separate patch. It is an important change that deserves special attention. Or if this patch does not drop 1.11 support, you should state that in the commit message. The

Re: [PATCH weston 5/6] tests: Drop weston-tests-env

On Fri, 26 Apr 2013 12:29:52 +0200 Quentin Glidic wrote: > On 26/04/2013 11:44, Pekka Paalanen wrote: > > Any explanation why doing this? > [snip] > > Dropping automake 1.11 support should be a separate patch. It is an > > important change that deserves special attention. > > > > Or if this patch

Re: Midori browser should now work on Wayland

For testing Midori against Wayland, I use "./configure --enable-gtk3 --disable-unique". But at present there hasn't been a WebkitGTK+ release that has proper wayland support. I've been using GTK3 master and the webkit patch from , rebased against W

Re: [PATCH weston v3 01/13] protocol: add sub-surfaces

On Fri, 26 Apr 2013 12:02:52 +0300 Pekka Paalanen wrote: > On Thu, 25 Apr 2013 16:47:15 +0200 > David Herrmann wrote: > > > Hi Pekka > > > > On Thu, Apr 25, 2013 at 12:57 PM, Pekka Paalanen > > wrote: > > > Add protocol for sub-surfaces, wl_subcompositor as the global interface, > > > and wl

Re: [PATCH weston v3 01/13] protocol: add sub-surfaces

Hi Pekka On Fri, Apr 26, 2013 at 1:12 PM, Pekka Paalanen wrote: >> > > diff --git a/protocol/subsurface.xml b/protocol/subsurface.xml >> > > new file mode 100644 >> > > index 000..60b4002 >> > > --- /dev/null >> > > +++ b/protocol/subsurface.xml >> > > @@ -0,0 +1,236 @@ >> > > + >> > > + >> >

Re: Midori browser should now work on Wayland

Can you write that up as directions to add to http://wayland.freedesktop.org/extras.html ? Also, for interested folks, there is a #midori channel on irc.freenode.net. On 04/26, MoD wrote: > For testing Midori against Wayland, I use "./configure --enable-gtk3 > --disable-unique". But at present t

[PATCH weston v2 1/7] tests: Add .weston extension to clients tests

From: Quentin Glidic Signed-off-by: Quentin Glidic --- tests/.gitignore | 6 +- tests/Makefile.am | 34 ++ 2 files changed, 19 insertions(+), 21 deletions(-) diff --git a/tests/.gitignore b/tests/.gitignore index 05bc024..a48ed40 100644 --- a/tests/.gitign

[PATCH weston v2 2/7] shared/option-parser: Rework option parsing

From: Quentin Glidic Long options with argument support two formats: equal ("--long=arg") and space ("--long arg") Short options now support three formats: short ("-sarg"), equal ("-s=arg") and space ("-s value") Provide a test program Signed-off-by: Quentin Glidic --- man/weston.man

[PATCH weston v2 3/7] shared/option-parser: Add string list options

From: Quentin Glidic Signed-off-by: Quentin Glidic --- man/weston.man | 6 +++--- shared/config-parser.h | 1 + shared/option-parser.c | 15 +++ src/compositor.c | 27 --- tests/weston-tests-env | 6 -- 5 files changed, 47 insertions(+),

[PATCH weston v2 4/7] weston: Allow relative paths for modules

From: Quentin Glidic This is to be used by tests or when developping to load modules directly from the build tree Signed-off-by: Quentin Glidic --- man/weston.man | 5 +++-- src/compositor.c | 9 ++--- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/man/weston.man b/man/we

[PATCH weston v2 5/7] weston-test: Get the test client path from args

From: Quentin Glidic Signed-off-by: Quentin Glidic --- tests/weston-test.c| 16 ++-- tests/weston-tests-env | 3 ++- 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/tests/weston-test.c b/tests/weston-test.c index 55c5da4..cf74e96 100644 --- a/tests/weston-test.c

[PATCH weston v2 7/7] headless-backend: Init fake pointer and keyboard

From: "U. Artie Eoff" Signed-off-by: Quentin Glidic --- src/compositor-headless.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/compositor-headless.c b/src/compositor-headless.c index 4720329..507d4bf 100644 --- a/src/compositor-headless.c +++ b/src/compositor-headless.c @@ -173,6 +

[PATCH weston v2 6/7] tests: Drop weston-tests-env

From: Quentin Glidic This file is no longer needed using the parallel-tests feature of automake This also allows users to pass additional arguments to weston and to force a backend This change is still compatible with automake 1.11 without needing the export hack any more Signed-off-by: Quentin

Additional pixel formats for wl_shm

Hi Kristian, I'm working on Raspberry Pi, where the VideoCore can deal directly with a large number of pixel formats. However, wl_shm only exposes ARGB and XRGB 32-bit per pixel formats, which on such tiny devices are very wasteful. Would it be acceptable to add more formats to the wl_shm formats

Re: Additional pixel formats for wl_shm

pq, On Fri, Apr 26, 2013 at 8:13 AM, Pekka Paalanen wrote: > Hi Kristian, > > I'm working on Raspberry Pi, where the VideoCore can deal directly with > a large number of pixel formats. However, wl_shm only exposes ARGB and > XRGB 32-bit per pixel formats, which on such tiny devices are very > was

Re: [PATCH weston v3 01/13] protocol: add sub-surfaces

pq, On Fri, Apr 26, 2013 at 7:09 AM, David Herrmann wrote: > Hi Pekka > > On Fri, Apr 26, 2013 at 1:12 PM, Pekka Paalanen > wrote: > >> > > diff --git a/protocol/subsurface.xml b/protocol/subsurface.xml > >> > > new file mode 100644 > >> > > index 000..60b4002 > >> > > --- /dev/null > >> > >

Touch screen not working under weston drm

Hey pq, When I start weston-launch (or weston directly), it does recognize that I have a touch screen device, but does not seem to make it available later for use. My findings when debugging: - touch_set_focus() fails at this point: resource = find_resource_for_client(&seat

Buffer Filters

Wayland Devs, What follows is an idea that's been kicking around my head for a little while now due to a discussion on the list a month or so ago. The basic idea is to add an interface that provides some additional buffer types that don't have any back-end data of their own, but act as filters fo

Re: Additional pixel formats for wl_shm

On Fri, 26 Apr 2013 09:09:28 -0500 Jason Ekstrand wrote: > pq, > On Fri, Apr 26, 2013 at 8:13 AM, Pekka Paalanen wrote: > > > Hi Kristian, > > > > I'm working on Raspberry Pi, where the VideoCore can deal directly with > > a large number of pixel formats. However, wl_shm only exposes ARGB and >

Re: Input and games.

On Thu, Apr 25, 2013 at 8:50 AM, Pekka Paalanen wrote: > Todd has already listed what features a standard gamepad or controller > has. Now someone should start designing the protocol. :-) Based on the wl_pointer docs, I should think it would look something like this: ---

Re: [PATCH weston v3 07/13] window: implement shm triple-buffering

Pekka Paalanen wrote: This is all *inside* the client. This is a toolkit patch. You are right, the patch is in clients/window.c, I confused it with an adjacent patch. I agree the client has to throttle resizes but I think this can avoid the triple buffer and removes the difference between

Re: [PATCH weston v2 2/7] shared/option-parser: Rework option parsing

This looks good to me, especially with all the automatic tests added. Quentin Glidic wrote: -static void -handle_option(const struct weston_option *option, char *value) +enum state { + OK, + EATEN, + ERROR +}; + +static enum state +handle_option(const struct weston_option *opt

Re: Additional pixel formats for wl_shm

I would reuse PIXMAN_FORMAT for these values. No reason to come up with yet another enumeration. Though it means the current wl_shm values have to change, except it looks like 0 and 1 (and in fact any number less than 0x100) don't make any logical PIXMAN_FORMAT values so maybe they can be s

Re: Input and games.

Hi Todd, Thanks for putting this together. I have a few general comments here and more below. My first general comment is about floating point. I'm not 100% sure what all went into the design decision to make wl_fixed have 8 bits of fractional precision vs. 12 or 16. I'm guessing that they want

Re: Input and games.

Todd, I think you forgot reply-all. I add wayland-devel again. On Fri, Apr 26, 2013 at 5:50 PM, Todd Showalter wrote: > On Fri, Apr 26, 2013 at 5:46 PM, Jason Ekstrand > wrote: > > > My first general comment is about floating point. I'm not 100% sure what > > all went into the design decision

Re: Input and games.

On Fri, Apr 26, 2013 at 8:40 PM, Jason Ekstrand wrote: > I think you forgot reply-all. I add wayland-devel again. Blast. Sorry about that. Thanks! >> There is, actually: >> >> expanded = (base << 7) | (base >> 1); >> >> ie: repeat the bit pattern down into the lower bits. Exampl

Fwd: Input and games.

I failed to reply-all before, so I'm forwarding this back to the list. On Fri, Apr 26, 2013 at 5:46 PM, Jason Ekstrand wrote: > My first general comment is about floating point. I'm not 100% sure what > all went into the design decision to make wl_fixed have 8 bits of fractional > precision vs.