Re: [PATCH weston 5/6] compositor: forbid sub-surface nesting loops

2013-05-17 Thread Daniel Stone
On 17 May 2013 21:09, Bill Spitzak wrote: > Is it impossible to change the parent of an existing subsurface? Yes. > If this is not possible it seems pretty limiting as clients have to destroy > and recreate surfaces to make some rearrangements. No, they only have to destroy and recreate the sub

Re: [PATCH weston 5/8] headless-backend: Init fake pointer and keyboard

2013-05-17 Thread Hardening
Le 17/05/2013 16:20, Quentin Glidic a écrit : From: "U. Artie Eoff" Signed-off-by: Quentin Glidic --- src/compositor-headless.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/compositor-headless.c b/src/compositor-headless.c index 0df0f7d..3776031 100644 --- a/src/compositor-head

Re: [PATCH] Fix surface_pong when a seat doesn't have a pointer

2013-05-17 Thread Kristian Høgsberg
On Fri, May 17, 2013 at 06:07:41PM +0200, Hardening wrote: > This patch fixes a crash with the surface_pong when one of the > seats doesn't have a pointer. This was the case with the RDP compositor > that use a fake seat with no mouse or keyboard. > --- > src/shell.c | 6 -- > 1 file changed,

Re: [PATCH weston 1/8] weston-launch: Run weston in the user login shell

2013-05-17 Thread Kristian Høgsberg
On Fri, May 17, 2013 at 04:20:37PM +0200, Quentin Glidic wrote: > From: Quentin Glidic > > This patch brings back the user environment from the shell. > In the future, weston-launch could create the Wayland socket earlier, in > which case the user's shell could be used to run Wayland-specific too

Re: [PATCH weston 6/6] protocol: remove an unused sub-surface error code

2013-05-17 Thread Kristian Høgsberg
On Fri, May 17, 2013 at 04:46:08PM +0300, ppaala...@gmail.com wrote: > From: Pekka Paalanen > > This was left over from allowing nesting. Thanks, all patches in this series applied. Kristian > Signed-off-by: Pekka Paalanen > --- > protocol/subsurface.xml | 2 -- > 1 file changed, 2 deletions

Re: [PATCH weston 1/6] protocol: improve sub-surface spec wording

2013-05-17 Thread Kristian Høgsberg
On Fri, May 17, 2013 at 04:46:03PM +0300, ppaala...@gmail.com wrote: > From: Pekka Paalanen > > Mention, that sub-surfaces are not clipped to the parent. > Be more accurate on surface commit vs. apply state. > Mention the initial stacking order. That looks good, applied. I can't help thinking t

Re: [PATCH weston] fix module_init signature in module tests

2013-05-17 Thread Kristian Høgsberg
On Fri, May 17, 2013 at 06:12:50AM -0700, U. Artie Eoff wrote: > From: "U. Artie Eoff" > > surface-global-test and surface-test did not get updated to > the new module_init(...) signature when it changed in > a50e6e4c500e3080b8df7ec14c7e42741477a423. Thus, they > failed to compile. Simply runni

Re: [PATCH weston 5/6] compositor: forbid sub-surface nesting loops

2013-05-17 Thread Bill Spitzak
Is it impossible to change the parent of an existing subsurface? If it is possible then Awill produce a loop and not get detected by this test since get_main_surface(C) is A which is not equal to B. If this is not possible it seems pretty limiting as clients have to destroy and recreate surfa

Re: [PATCH] client: Add wl_display_prepare_read() API to thread model assumptions

2013-05-17 Thread Kristian Høgsberg
On Wed, May 01, 2013 at 06:24:23PM +0200, Uli Schlachter wrote: > On 01.05.2013 17:52, Kristian Høgsberg wrote: > > On Tue, Apr 30, 2013 at 11:45:15PM +0200, Uli Schlachter wrote: > >> On 30.04.2013 22:06, Kristian Høgsberg wrote: > >> [...] > >>> diff --git a/src/connection.c b/src/connection.c >

Re: [PATCH 2/2] protocol: Support scaled outputs and surfaces

2013-05-17 Thread Bill Spitzak
Alexander Larsson wrote: You can make a surface of any integer size (and it has to be integer due to existing APIs on surface coordinates/sizes), however the *buffer* has to be an integer multiple of the surface size. In other words, surface sizes and positions are described in the global compos

Re: [PATCH 2/2] Move the EDID parsing to its own file

2013-05-17 Thread Bill Spitzak
Graeme Gill wrote: Bill Spitzak wrote: The Y of the primaries can be used as alternative method of specifying the whitepoint. (convert the 3 Yxy colors to XYZ, add them, then convert back to Yxy and the xy is the whitepoint, I think). Correct, but this assumes the display is perfectly addi

[PATCH] Fix surface_pong when a seat doesn't have a pointer

2013-05-17 Thread Hardening
This patch fixes a crash with the surface_pong when one of the seats doesn't have a pointer. This was the case with the RDP compositor that use a fake seat with no mouse or keyboard. --- src/shell.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/shell.c b/src/shell.c

Re: [PATCH weston] fix module_init signature in module tests

2013-05-17 Thread Othman, Ossama
Hi Artie, Sorry about that. I didn't realize some Weston binaries were only built under the "check" target. I'll run "make distcheck" the next time around. Thanks for the fix! -Ossama On Fri, May 17, 2013 at 6:12 AM, U. Artie Eoff wrote: > From: "U. Artie Eoff" > > surface-global-test and

[PATCH weston 8/8] tests: Update for API break (module_init)

2013-05-17 Thread Quentin Glidic
From: Quentin Glidic Signed-off-by: Quentin Glidic --- tests/surface-global-test.c | 2 +- tests/surface-test.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/surface-global-test.c b/tests/surface-global-test.c index 5bafa08..2da4dd1 100644 --- a/tests/surfa

[PATCH weston 7/8] weston.pc: Provide moduledir

2013-05-17 Thread Quentin Glidic
From: Quentin Glidic Signed-off-by: Quentin Glidic --- configure.ac | 4 src/Makefile.am | 1 - src/weston.pc.in | 2 ++ src/xwayland/Makefile.am | 1 - 4 files changed, 6 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index fd85b2c..79

[PATCH weston 6/8] weston.pc: Add dependencies for pixman-1 and xkbcommon

2013-05-17 Thread Quentin Glidic
From: Quentin Glidic Signed-off-by: Quentin Glidic --- src/weston.pc.in | 1 + 1 file changed, 1 insertion(+) diff --git a/src/weston.pc.in b/src/weston.pc.in index 537cc89..8d5ebde 100644 --- a/src/weston.pc.in +++ b/src/weston.pc.in @@ -6,4 +6,5 @@ includedir=@includedir@ Name: Weston Plugi

[PATCH weston 5/8] headless-backend: Init fake pointer and keyboard

2013-05-17 Thread Quentin Glidic
From: "U. Artie Eoff" Signed-off-by: Quentin Glidic --- src/compositor-headless.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/compositor-headless.c b/src/compositor-headless.c index 0df0f7d..3776031 100644 --- a/src/compositor-headless.c +++ b/src/compositor-headless.c @@ -173,6 +

[PATCH weston 4/8] shell: Use relative layers for lock/unlock

2013-05-17 Thread Quentin Glidic
From: Quentin Glidic This way, other modules can safely add layers before or after the shell layers without breaking the list on lock/unlock Signed-off-by: Quentin Glidic --- src/shell.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/src/shell.c b/src/sh

[PATCH weston 3/8] weston: Allow relative paths for modules

2013-05-17 Thread Quentin Glidic
From: Quentin Glidic This is to be used by tests or when developping to load modules directly from the build tree Signed-off-by: Quentin Glidic --- man/weston.man | 5 +++-- src/compositor.c | 9 ++--- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/man/weston.man b/man/we

[PATCH weston 2/8] tests: Add .weston extension to clients tests

2013-05-17 Thread Quentin Glidic
From: Quentin Glidic We can then add tests which do not use Weston in the test suite. Signed-off-by: Quentin Glidic --- tests/.gitignore | 7 +-- tests/Makefile.am | 41 ++--- 2 files changed, 23 insertions(+), 25 deletions(-) diff --git a/tests/.giti

[PATCH weston 1/8] weston-launch: Run weston in the user login shell

2013-05-17 Thread Quentin Glidic
From: Quentin Glidic This patch brings back the user environment from the shell. In the future, weston-launch could create the Wayland socket earlier, in which case the user's shell could be used to run Wayland-specific tools in the new Weston session. Signed-off-by: Quentin Glidic --- src/wes

[PATCH weston 0/8] Small series (again, sorry)

2013-05-17 Thread Quentin Glidic
From: Quentin Glidic These patches are all independant changes to weston: — weston.pc and layers patches are needed for external notification support plugin. — tests, module path and headless-backend patches are needed for subsequent options and tests-related patches — weston-launch patch is fu

[PATCH weston 6/6] protocol: remove an unused sub-surface error code

2013-05-17 Thread ppaalanen
From: Pekka Paalanen This was left over from allowing nesting. Signed-off-by: Pekka Paalanen --- protocol/subsurface.xml | 2 -- 1 file changed, 2 deletions(-) diff --git a/protocol/subsurface.xml b/protocol/subsurface.xml index 9c04a30..9e4a658 100644 --- a/protocol/subsurface.xml +++ b/prot

[PATCH weston 5/6] compositor: forbid sub-surface nesting loops

2013-05-17 Thread ppaalanen
From: Pekka Paalanen The only way to create a sub-surface loop by recursive nesting is to make the main surface (which does not have a role) a sub-surface of any of its sub-surfaces. All other cases should already be cought. This change checks for that exact case, and sends a protocol error. Si

[PATCH weston 4/6] tests: add a sub-surface nesting loop test

2013-05-17 Thread ppaalanen
From: Pekka Paalanen It should not be possible to create a loop by nesting sub-surfaces. Currently Weston fails this test. Signed-off-by: Pekka Paalanen --- tests/subsurface-test.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/tests/subsurface-test.c b/tests/subsu

[PATCH weston 3/6] protocol: set_desync should flush

2013-05-17 Thread ppaalanen
From: Pekka Paalanen wl_subsurface.set_desync should apply the cached wl_surface state. Otherwise, the sub-surface may be stuck: a commit on the parent surface, if desynchronized, will not commit the sub-surface because it is desynchronized, too. A commit on the sub-surface may not happen, if it

[PATCH weston 2/6] tests: add sub-surface tree destruction permutations

2013-05-17 Thread ppaalanen
From: Pekka Paalanen Add a test for varying the object destruction order in a complex sub-surface tree. This test attemps to fuzz the destruction of a sub-surface tree to make sure the server does not crash on any wl_surface or wl_subsurface destruction sequence. Signed-off-by: Pekka Paalanen

[PATCH weston 1/6] protocol: improve sub-surface spec wording

2013-05-17 Thread ppaalanen
From: Pekka Paalanen Mention, that sub-surfaces are not clipped to the parent. Be more accurate on surface commit vs. apply state. Mention the initial stacking order. Signed-off-by: Pekka Paalanen --- protocol/subsurface.xml | 27 +-- 1 file changed, 17 insertions(+), 1

[PATCH weston] fix module_init signature in module tests

2013-05-17 Thread U. Artie Eoff
From: "U. Artie Eoff" surface-global-test and surface-test did not get updated to the new module_init(...) signature when it changed in a50e6e4c500e3080b8df7ec14c7e42741477a423. Thus, they failed to compile. Simply running 'make check' shows the problem. This patch fixes it. fixes https://bugs

Re: [PATCH 2/2] protocol: Support scaled outputs and surfaces

2013-05-17 Thread Alexander Larsson
On tor, 2013-05-16 at 10:05 -0500, Jason Ekstrand wrote: > I still think we can solve this problem better if the clients, instead > of providing some sort of pre-scaled buffer that matches the output's > arbitrary scale factor, simply told the compositor which output they > rendered for. Then ever

Re: [PATCH 2/2] protocol: Support scaled outputs and surfaces

2013-05-17 Thread Alexander Larsson
On tor, 2013-05-16 at 10:57 -0700, Bill Spitzak wrote: > al...@redhat.com wrote: > > > Coordinates > > in other parts of the protocol, like input events, relative window > > positioning and output positioning are still in the compositor space > > rather than the scaled space. However, input has su

Re: Is light-weight window manager possible with Wayland?

2013-05-17 Thread Pekka Paalanen
On Fri, 17 May 2013 12:08:23 +0700 Michael Pozhidaev wrote: > Hello! > > Maybe the things I am asking now are well-known but although I have tried to > read various materials about Wayland and Weston some details remain > unclear for me. I would like to clarify them and would be very grateful >