[PATCH weston 1/2] tty: fix typo in error message

2013-08-08 Thread Peter Hutterer
--- src/tty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tty.c b/src/tty.c index 07a9405..212deb0 100644 --- a/src/tty.c +++ b/src/tty.c @@ -174,7 +174,7 @@ tty_create(struct weston_compositor *compositor, tty_vt_func_t vt_func, if (tty-starting_vt != tty-vt)

[PATCH weston 2/2] clients: fix an error message

2013-08-08 Thread Peter Hutterer
_GNU_SOURCE is always true as of c228e23b055f54d29f2df, so program_invocation_short_name is available. --- clients/window.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/window.c b/clients/window.c index 9ec9786..cbf8bf5 100644 --- a/clients/window.c +++

[PATCH] server: Release additional_shm_formats array at display destruction

2013-08-08 Thread Tomeu Vizoso
--- src/wayland-server.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/wayland-server.c b/src/wayland-server.c index 1498d51..771309f 100644 --- a/src/wayland-server.c +++ b/src/wayland-server.c @@ -746,6 +746,8 @@ wl_display_destroy(struct wl_display *display)

Re: Support for remote desktop systems

2013-08-08 Thread Andrew Wedgbury
Hi Daniel, - Original Message - From: Daniel Stone dan...@fooishbar.org To: Andrew Wedgbury andrew.wedgb...@realvnc.com Cc: wayland-devel@lists.freedesktop.org Sent: Tuesday, 6 August, 2013 5:46:44 PM Subject: Re: Support for remote desktop systems Hi Andrew, Nice to hear from

Re: [PATCH weston v2] evdev: check for ABS_MT_POSITION_X/Y to determine mt devices

2013-08-08 Thread Kristian Høgsberg
On Thu, Aug 08, 2013 at 12:03:08PM +1000, Peter Hutterer wrote: mtdev as currently used in weston is a noop. mtdev's purpose is to convert Protocol A devices (without ABS_MT_SLOT) to Protocol B devices (slots). For Protocol B devices mtdev merely routes the events, so checking for slots and

Re: [PATCH weston 1/2] Add zalloc(size_t) allocator function

2013-08-08 Thread Kristian Høgsberg
On Thu, Aug 08, 2013 at 11:57:04AM +1000, Peter Hutterer wrote: Same as calloc(1, len). --- Feel free to squash this with the follow-up, I just kept it separately to make changes easier, the second one is just search/replace. shared/zalloc.h | 40

Re: [PATCH] server: Release additional_shm_formats array at display destruction

2013-08-08 Thread Kristian Høgsberg
On Thu, Aug 08, 2013 at 10:31:56AM +0200, Tomeu Vizoso wrote: --- src/wayland-server.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/wayland-server.c b/src/wayland-server.c index 1498d51..771309f 100644 --- a/src/wayland-server.c +++ b/src/wayland-server.c @@ -746,6 +746,8 @@

Re: [PATCH wayland 3/3] scanner: check for wayland-scanner.pc before using variables

2013-08-08 Thread Kristian Høgsberg
On Wed, Aug 07, 2013 at 04:33:20PM +1000, Peter Hutterer wrote: On Wed, Aug 07, 2013 at 07:46:43AM +0200, Daiki Ueno wrote: Hi, Peter Hutterer peter.hutte...@who-t.net writes: AC_DEFUN([WAYLAND_SCANNER_RULES], [ PKG_PROG_PKG_CONFIG +

Re: [PATCH weston 10/10] evdev: log when a device is used as touchpad

2013-08-08 Thread Kristian Høgsberg
On Wed, Aug 07, 2013 at 11:04:49AM +1000, Peter Hutterer wrote: --- src/evdev.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) I picked up the remaining patches from this series, thanks. Kristian diff --git a/src/evdev.c b/src/evdev.c index 7bacbd9..ab35582 100644 ---

Re: [PATCH] weston-launch: always drop privileges before execve

2013-08-08 Thread Kristian Høgsberg
On Tue, Aug 06, 2013 at 12:10:09PM +1000, Peter Hutterer wrote: The current code works if pw-pw_shell is bash because: If the shell is started with the effective user (group) id not equal to the real user (group) id, and the -p option is not supplied, these actions are taken and the

Re: [PATCH] weston-launch: only drop privileges when uid/gid != euid/egid

2013-08-08 Thread Kristian Høgsberg
On Tue, Aug 06, 2013 at 03:09:10PM +1000, Peter Hutterer wrote: initgroups requires CAP_SETGID and may fail. If we're not actually changing anything anyway we can just skip this and (most likely) fail later when we don't have the required permissions to open something. --- Should arguably be

[PATCH weston v2] terminal.c: Check if fdopen() fails

2013-08-08 Thread Brian Lovin
If fdopen() fails we just close the fd and return, failing the copy-and-paste. Signed-off-by: Brian Lovin brian.j.lo...@intel.com --- clients/terminal.c | 4 1 file changed, 4 insertions(+) diff --git a/clients/terminal.c b/clients/terminal.c index 1cc26d0..acf7b85 100644 ---

Re: [PATCH weston v2] terminal.c: Check if fdopen() fails

2013-08-08 Thread Kristian Høgsberg
On Thu, Aug 08, 2013 at 04:12:55PM -0700, Brian Lovin wrote: If fdopen() fails we just close the fd and return, failing the copy-and-paste. That's nice, thanks. Kristian Signed-off-by: Brian Lovin brian.j.lo...@intel.com --- clients/terminal.c | 4 1 file changed, 4 insertions(+)

Re: [PATCH] weston-launch: only drop privileges when uid/gid != euid/egid

2013-08-08 Thread Peter Hutterer
On Thu, Aug 08, 2013 at 02:17:45PM -0700, Kristian Høgsberg wrote: On Tue, Aug 06, 2013 at 03:09:10PM +1000, Peter Hutterer wrote: initgroups requires CAP_SETGID and may fail. If we're not actually changing anything anyway we can just skip this and (most likely) fail later when we don't

[PATCH weston] configure.ac: check for wayland scanner macro

2013-08-08 Thread Peter Hutterer
--- That's a slightly nicer error message than breaking during configure. configure.ac | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure.ac b/configure.ac index f9f1c53..3ad1995 100644 --- a/configure.ac +++ b/configure.ac @@ -396,6 +396,8 @@ if test x$have_lcms = xyes; then fi

[PATCH 1/2] Building: Fix prefix for libunwind

2013-08-08 Thread Bryce W. Harrington
Signed-off-by: Bryce Harrington b.harring...@samsung.com --- building.html |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/building.html b/building.html index 1eed935..b56d4dd 100644 --- a/building.html +++ b/building.html @@ -153,7 +153,7 @@ pixman./p pre$ git clone

[PATCH 0/9] Spelling/grammar fixes for publican documentation

2013-08-08 Thread Bryce W. Harrington
Noticed a few minor errors while going through the online wayland documentation. None of these changes should affect any code. I've avoided rewrapping paragraphs for ease of review; it doesn't affect display at all. The protocol changes only affect the textual descriptions, no api changes; I've

[PATCH 1/9] publican: Cleanup Preface's grammar.

2013-08-08 Thread Bryce W. Harrington
Signed-off-by: Bryce Harrington b.harring...@samsung.com --- doc/publican/sources/Foreword.xml | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/doc/publican/sources/Foreword.xml b/doc/publican/sources/Foreword.xml index eeb16cc..e6875a3 100644 ---

[PATCH 4/9] client: Improve spelling and grammar in comments

2013-08-08 Thread Bryce W. Harrington
Signed-off-by: Bryce Harrington b.harring...@samsung.com --- src/wayland-client.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/wayland-client.c b/src/wayland-client.c index 532d379..b5d9030 100644 --- a/src/wayland-client.c +++ b/src/wayland-client.c @@

[PATCH 3/9] publican: Fix grammar several places in Protocol docs

2013-08-08 Thread Bryce W. Harrington
Signed-off-by: Bryce Harrington b.harring...@samsung.com --- doc/publican/sources/Protocol.xml | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/doc/publican/sources/Protocol.xml b/doc/publican/sources/Protocol.xml index 1a7a7da..33df6a9 100644 ---

[PATCH] screenshot: Drop extraneous 'is' to improve warning msg grammar

2013-08-08 Thread Bryce W. Harrington
Signed-off-by: Bryce Harrington b.harring...@samsung.com --- clients/screenshot.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/screenshot.c b/clients/screenshot.c index 1f73df6..7511ef7 100644 --- a/clients/screenshot.c +++ b/clients/screenshot.c @@ -249,7 +249,7

[PATCH 2/9] publican: Drop unneeded 'of'

2013-08-08 Thread Bryce W. Harrington
Signed-off-by: Bryce Harrington b.harring...@samsung.com --- doc/publican/sources/Introduction.xml |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/publican/sources/Introduction.xml b/doc/publican/sources/Introduction.xml index b3b89e7..7516c33 100644 ---

[PATCH 8/9] protocol: Fix pluralization of user in popup_done description

2013-08-08 Thread Bryce W. Harrington
Signed-off-by: Bryce Harrington b.harring...@samsung.com --- protocol/wayland.xml |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/protocol/wayland.xml b/protocol/wayland.xml index 10367dc..8619e91 100644 --- a/protocol/wayland.xml +++ b/protocol/wayland.xml @@ -953,7 +953,7

[PATCH 7/9] protocol: Improve grammar for set class description

2013-08-08 Thread Bryce W. Harrington
Signed-off-by: Bryce Harrington b.harring...@samsung.com --- protocol/wayland.xml |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/protocol/wayland.xml b/protocol/wayland.xml index 575db27..10367dc 100644 --- a/protocol/wayland.xml +++ b/protocol/wayland.xml @@ -909,9

[PATCH 5/9] protocol: Fix typo by removing a redundant 'a'

2013-08-08 Thread Bryce W. Harrington
Signed-off-by: Bryce Harrington b.harring...@samsung.com --- protocol/wayland.xml |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/protocol/wayland.xml b/protocol/wayland.xml index 3cfa953..99df9f9 100644 --- a/protocol/wayland.xml +++ b/protocol/wayland.xml @@ -640,7 +640,7

[PATCH 9/9] protocol: Improve a bit of grammar for wl_surface::attach description

2013-08-08 Thread Bryce W. Harrington
Signed-off-by: Bryce Harrington b.harring...@samsung.com --- protocol/wayland.xml |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/protocol/wayland.xml b/protocol/wayland.xml index 8619e91..89edd83 100644 --- a/protocol/wayland.xml +++ b/protocol/wayland.xml @@