RE: Should I always add wl_display_sync() before wl_display_dispatch_queue()?

2013-10-29 Thread Zhao, Halley
For the wl_display_sync, is there possible scenario that: 1. Frame callback doesn't come yet when it is checked 2. Frame callback comes immediately after the check 3. wl_display_dispatch_queue is called and is blocked since there is no event to dispatch on the queue. Then appl

Re: [PATCH weston 11/11] cairo-util: Rework frame button handling

2013-10-29 Thread Jason Ekstrand
In retrospect, this should probably go earlier in the series, before the second compositor-wayland patch. It doesn't actually matter, but it makes more sense there. --Jason Ekstrand On Sun, Oct 27, 2013 at 10:25 PM, Jason Ekstrand wrote: > This makes button handling more correct concerning drag

[PATCH weston 10/11] compositor-wayland: Parse [output] config sections and more options

2013-10-29 Thread Jason Ekstrand
This commit makes the wayland backend search through the config for [output] sections with names starting with "WL" and create outputs accordingly. Outputs created due to the config file support mode, scale, and transform parameters. It also listens for the --output-count command-line option. Th

[PATCH weston] tests: Test whether a simple EGL main loop uses too many buffers

2013-10-29 Thread Neil Roberts
Here is a test case which demonstrates the 3 buffers problem. It is fixed by the eglSwapInterval patch because that installs a sync event, but note the problem isn't really related to eglSwapInterval and is something we should probably fix anyway. Regards, - Neil --- >8 --- (use g

Re: Should I always add wl_display_sync() before wl_display_dispatch_queue()?

2013-10-29 Thread Rafael Antognolli
On Mon, Oct 28, 2013 at 10:06:47PM -0500, Jason Ekstrand wrote: > On Mon, Oct 28, 2013 at 9:39 PM, Zhao, Halley wrote: > > > Video player use frame callback on an event queue, sometimes there is > > synchronization issue. > > > > After looked at other usage of event queue, I found: > > >

Re: [PATCH mesa v4] wayland: Add support for eglSwapInterval

2013-10-29 Thread Neil Roberts
Jason Ekstrand writes: > You don't have to continuously sync, just sync after every > attach/commit. While it may be somewhat non-obvious, I don't see how > calling sync once per frame is any worse than setting some flag > somewhere. Hrmm thinking about it, I suppose sending the sync request isn