Re: [PATCH] logind: Use dbus_bool_t for bool types in dbus calls

2013-11-20 Thread David Herrmann
Hi On Thu, Nov 21, 2013 at 1:39 AM, Kristian Høgsberg wrote: > The gcc built-in 'bool' type is not the same size as dbus_bool_t, which is > an uint32_t. Passing a pointer to bool where dbus expects a uint32_t * > doesn't work. Nice catch! I hate dbus for that type.. happens to me all the time.

Re: [PATCH weston v3] pixman: Destroy pixman images when underlying buffer is destroyed

2013-11-20 Thread Pekka Paalanen
On Tue, 19 Nov 2013 15:44:44 +0100 Lubomir Rintel wrote: > While the pixman image might be attached, the underlying buffer might be > already gone under certain circumstances. This is easily reproduced by > attempting to resize gnome-terminal on a fbdev backend. > > $ WAYLAND_DEBUG=1 strace -emu

[PATCH] logind: Use dbus_bool_t for bool types in dbus calls

2013-11-20 Thread Kristian Høgsberg
The gcc built-in 'bool' type is not the same size as dbus_bool_t, which is an uint32_t. Passing a pointer to bool where dbus expects a uint32_t * doesn't work. --- src/logind-util.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) David, This fixes a crash that Artie hit when testing

Re: [PATCH] tests: fix compiler warnings and remove trailing whitespace

2013-11-20 Thread Bryce W. Harrington
On Wed, Nov 20, 2013 at 04:25:39PM +0100, Marek Ch wrote: > Fix 'unused variable' and 'missing initializer' warnings and > remove trailing whitespaces in connection-test > @@ -517,6 +523,7 @@ suu_handler(void *data, struct wl_object *object, > { > int *done = data; > > + assert(object

[PATCH weston v3 1/2] input: set the focus to NULL when the focus's resource is destroyed

2013-11-20 Thread Giulio Camuffo
with the surface ref-count feature a surface may live on after its resource was destroyed. so listen for the resource destroy signal and set the focus to NULL. Reviewed-by: Jason Ekstrand --- v3: added a view listener to weston_touch src/compositor.h | 6 +++- src/input.c | 108

Re: [RFC] Object's pre-actions

2013-11-20 Thread Marek Ch
On 20 November 2013 16:40, Pekka Paalanen wrote: > On Wed, 20 Nov 2013 15:40:50 +0100 > Marek Ch wrote: > > > That is true, the race is there and I keep it in mind. But I'm talking > > about the case, when the global_remove event has been already > > dispatched (so the client should know that th

[PATCH weston v2 1/2] input: set the focus to NULL when the focus's resource is destroyed

2013-11-20 Thread Giulio Camuffo
with the surface ref-count feature a surface may live on after its resource was destroyed. so listen for the resource destroy signal and set the focus to NULL. --- v2: rebased on top of master src/compositor.h | 5 +++- src/input.c | 75 -

Re: [RFC] Object's pre-actions

2013-11-20 Thread Pekka Paalanen
On Wed, 20 Nov 2013 15:40:50 +0100 Marek Ch wrote: > That is true, the race is there and I keep it in mind. But I'm talking > about the case, when the global_remove event has been already > dispatched (so the client should know that the global 'should' be > gone). In this case the object should r

[PATCH 1/2] fixed-benchmark: remove warning

2013-11-20 Thread Marek Ch
Compiler warned about unused arguments --- tests/fixed-benchmark.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fixed-benchmark.c b/tests/fixed-benchmark.c index 0719063..d4de363 100644 --- a/tests/fixed-benchmark.c +++ b/tests/fixed-benchmark.c @@ -93,7 +93,7 @@ bench

[PATCH] tests: fix bad arguments when posting event

2013-11-20 Thread Marek Ch
I was getting SIGSEGV in resources-test (arch linux, gcc 4.8.2) due to bad (no) arguments passed to wl_resource_post_event(). Although the event is not invoked it crashed in serialize_closure when handling arguments --- tests/resources-test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[PATCH] tests: fix compiler warnings and remove trailing whitespace

2013-11-20 Thread Marek Ch
Fix 'unused variable' and 'missing initializer' warnings and remove trailing whitespaces in connection-test --- tests/connection-test.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/tests/connection-test.c b/tests/connection-test.c index e284ea0..066b5b5 10

Re: [RFC] Object's pre-actions

2013-11-20 Thread Marek Ch
That is true, the race is there and I keep it in mind. But I'm talking about the case, when the global_remove event has been already dispatched (so the client should know that the global 'should' be gone). In this case the object should remain valid but all requests to it should be ignored (accordi

[PATCH 1/2] shell: add a client config entry

2013-11-20 Thread pochu27
From: Emilio Pozuelo Monfort --- man/weston.ini.man | 4 src/shell.c| 15 ++- 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/man/weston.ini.man b/man/weston.ini.man index 4ff313d..bbb1d15 100644 --- a/man/weston.ini.man +++ b/man/weston.ini.man @@ -139,

[PATCH 2/2] man: document new focus-animation config entry

2013-11-20 Thread pochu27
From: Emilio Pozuelo Monfort --- man/weston.ini.man | 6 ++ 1 file changed, 6 insertions(+) diff --git a/man/weston.ini.man b/man/weston.ini.man index bbb1d15..cc88ca8 100644 --- a/man/weston.ini.man +++ b/man/weston.ini.man @@ -188,6 +188,12 @@ sets the effect used for opening new windows