Re: [PATCH] shell: run surface bindings only when focus surface is not NULL

2014-01-08 Thread Kristian Høgsberg
On Sun, Jan 05, 2014 at 08:04:59PM +0100, Rafal Mielniczuk wrote: > This fixes the crash when move, rotate or resize binding is activated > while exposay effect is active. > > Steps to reproduce: > - activate exposay > - try to rotate the surface with mod + right mouse button > - crash Thank you,

Re: [PATCH] compositor-drm: consider the best mode of the mode_list as an option

2014-01-08 Thread Kristian Høgsberg
On Thu, Dec 12, 2013 at 05:13:56PM +0100, Fabien DESSENNE wrote: > This patch fixes an issue where Weston using the DRM backend, cannot start > the display. This happens in the following context: > - no video mode is set before weston starts (eg no "/dev/fb" set up) > - weston is not configured wit

Re: XWayland security, equals to X11 or Wayland?

2014-01-08 Thread Kristian Høgsberg
On Mon, Jan 6, 2014 at 2:40 AM, Rui Tiago Cação Matos wrote: > On 3 January 2014 20:59, Tobias Sarnowski wrote: >> does XWayland operate? From the highlevel documentation at >> http://wayland.freedesktop.org/xserver.html I conclude, that the X11 support >> is done via having a single Wayland clie

Re: [PATCH] input: Don't leak the initial keymap

2014-01-08 Thread Kristian Høgsberg
On Thu, Oct 24, 2013 at 07:28:41PM +0200, Rui Matos wrote: > weston_xkb_info_create() takes ownership of the xkb_keymap instance so > we should drop our reference or we would leak it later if the keymap > was changed. Thanks again for the reminder, applied. Kristian > --- > src/input.c | 1 + >

Re: [PATCH weston] protocol: rename wl_surface_scaler to wl_viewport

2014-01-08 Thread Kristian Høgsberg
On Wed, Jan 08, 2014 at 03:39:17PM +0200, ppaala...@gmail.com wrote: > From: Pekka Paalanen > > This seems like a better name, and will not conflict if someone later > extends wl_surface with a request scaler_set (yeah, unlikely). > > This code was written by Jonny Lamb, I just diffed his branch

Re: [PATCH weston] tests: fix build on rpi with EGL

2014-01-08 Thread Kristian Høgsberg
On Wed, Jan 08, 2014 at 03:39:19PM +0200, ppaala...@gmail.com wrote: > From: Pekka Paalanen > > This patch fixes the compiler errors: > > CC weston_test_la-weston-test.lo > weston-test.c:34:21: fatal error: EGL/egl.h: No such file or directory > > CC buffer-count-test.o > buffer-cou

Re: [PATCH weston] screenshooter: silence a warning

2014-01-08 Thread Kristian Høgsberg
On Wed, Jan 08, 2014 at 03:39:18PM +0200, ppaala...@gmail.com wrote: > From: Pekka Paalanen > > screenshooter.c: In function ‘recorder_binding’: > screenshooter.c:509:5: warning: ‘listener’ may be used uninitialized in > this function [-Wuninitialized] > > This was not really a problem so far, b

Re: [PATCH] xwayland: Handle the wl_keyboard modifiers event

2014-01-08 Thread Kristian Høgsberg
On Tue, Oct 22, 2013 at 04:52:06PM +0200, Rui Matos wrote: > This allows us to keep track of latched and locked modifiers as well > as the XKB group while the keyboard focus is on another wayland > client. Note that we don't need to track depressed modifiers since > wayland guarantees that we'll ge

Re: [PATCH weston] tests: Only run buffer-count test on Mesa >= 10.1

2014-01-08 Thread Kristian Høgsberg
On Wed, Jan 08, 2014 at 04:05:34PM +0200, ppaala...@gmail.com wrote: > From: Pekka Paalanen > > Comment #2 in the bug report says Mesa 10.0 branch does not have the > fix, and indeed buffer-count test fails on Mesa 10.0.1. Fix the test to > require Mesa 10.1 or later. > > Now I correctly get: >

[PATCH] Add a FreeRds backend, take 4

2014-01-08 Thread Hardening
FreeRDS is a FreeRDP based RDP server, the server handles incoming connections and talks RDP with the peers. FreeRds cooperates with an "out-service": the out-service creates the content to display, and FreeRds will take care of encoding the content in the appropriate format (bitmapUpdate, remot

Re: Authorized clients

2014-01-08 Thread Maarten Baert
On 08/01/14 13:52, Martin Peres wrote: > I think the screenshot API and the video recording one should be > separate. Ideally that's true, but it creates extra work for the compositor developers. And I don't see a huge benefit, actually. On X11 I can simply take 30 screenshots per second and this

Re: Authorized clients

2014-01-08 Thread Sebastian Wick
Am 2014-01-08 19:53, schrieb Martin Peres: Le 08/01/2014 17:20, Sebastian Wick a écrit : Am 2014-01-07 15:07, schrieb Martin Peres: Those are extremely rare cases. Users wanting to do that should agree they give up confidentiality and should thus be administrators in order to tell the composi

Re: Authorized clients

2014-01-08 Thread Martin Peres
Le 08/01/2014 20:20, Jasper St. Pierre a écrit : If the user installed an app that takes screenshots of the screen periodically and dumps them to a disk, I'd imagine that's functionality he wanted. Why would we prompt him? What if it is installed by default? And just because I sometimes want t

Re: Authorized clients

2014-01-08 Thread Jasper St. Pierre
If the user installed an app that takes screenshots of the screen periodically and dumps them to a disk, I'd imagine that's functionality he wanted. Why would we prompt him? On Wed, Jan 8, 2014 at 2:17 PM, Martin Peres wrote: > Le 08/01/2014 19:47, Jasper St. Pierre a écrit : > > Prompting the

Re: Authorized clients

2014-01-08 Thread Martin Peres
Le 08/01/2014 19:47, Jasper St. Pierre a écrit : Prompting the user "are you *sure* you really meant to take a screenshot? Yes/No" when he presses Print Screen is just a way to piss her off. Please don't mix everything and read carefully what I said. Pressing "Print screen" IS the event that p

Re: Authorized clients

2014-01-08 Thread Martin Peres
Le 08/01/2014 17:20, Sebastian Wick a écrit : Am 2014-01-07 15:07, schrieb Martin Peres: Those are extremely rare cases. Users wanting to do that should agree they give up confidentiality and should thus be administrators in order to tell the compositor that. Why should those people have worse

Re: Authorized clients

2014-01-08 Thread Jasper St. Pierre
Yes, the user has to trust that a screenshot app won't start uploading his porn to the web, just like she also has to trust that it won't give him a virus. The new sandboxing technology is a way of making sure the user knows what the app has access to, and to prevent access to things the user didn

Re: Authorized clients

2014-01-08 Thread Martin Peres
Le 08/01/2014 15:04, Sebastian Wick a écrit : Am 2014-01-08 13:02, schrieb Martin Peres: On 07/01/2014 20:26, Jasper St. Pierre wrote: Would it be ok for you if the compositor asked the user to agree for the program to do the operation? If so, we can guarantee that this is really t

RE: [PATCH weston] tests: Only run buffer-count test on Mesa >= 10.1

2014-01-08 Thread Eoff, Ullysses A
Indeed, this looks better to me... I've confirmed with my testing, too, that we need Mesa >= 10.1 > -Original Message- > From: wayland-devel-boun...@lists.freedesktop.org > [mailto:wayland-devel-boun...@lists.freedesktop.org] On Behalf Of > ppaala...@gmail.com > Sent: Wednesday, January

Re: [PATCH] input: Don't leak the initial keymap

2014-01-08 Thread Rui Tiago Cação Matos
Review ping. On 24 October 2013 19:28, Rui Matos wrote: > weston_xkb_info_create() takes ownership of the xkb_keymap instance so > we should drop our reference or we would leak it later if the keymap > was changed. ___ wayland-devel mailing list wayland

Re: [PATCH] xwayland: Handle the wl_keyboard modifiers event

2014-01-08 Thread Rui Tiago Cação Matos
Hi, this patch still applies after the xwayland branch rebase. Pinging for review. Thanks, Rui On 22 October 2013 16:52, Rui Matos wrote: > This allows us to keep track of latched and locked modifiers as well > as the XKB group while the keyboard focus is on another wayland > client. Note that

Re: Authorized clients

2014-01-08 Thread Sebastian Wick
Am 2014-01-07 15:07, schrieb Martin Peres: Those are extremely rare cases. Users wanting to do that should agree they give up confidentiality and should thus be administrators in order to tell the compositor that. Why should those people have worse security then others only because they want a

Re: Authorized clients

2014-01-08 Thread Sebastian Wick
Am 2014-01-08 13:02, schrieb Martin Peres: On 07/01/2014 20:26, Jasper St. Pierre wrote: Would it be ok for you if the compositor asked the user to agree for the program to do the operation? If so, we can guarantee that this is really the user's intent and allow the applicat

[PATCH weston] tests: Only run buffer-count test on Mesa >= 10.1

2014-01-08 Thread ppaalanen
From: Pekka Paalanen Comment #2 in the bug report says Mesa 10.0 branch does not have the fix, and indeed buffer-count test fails on Mesa 10.0.1. Fix the test to require Mesa 10.1 or later. Now I correctly get: mesa version too old (OpenGL ES 3.0 Mesa 10.0.1 (git-12484d2)) https://bugs.

[PATCH weston] tests: fix build on rpi with EGL

2014-01-08 Thread ppaalanen
From: Pekka Paalanen This patch fixes the compiler errors: CC weston_test_la-weston-test.lo weston-test.c:34:21: fatal error: EGL/egl.h: No such file or directory CC buffer-count-test.o buffer-count-test.c:30:21: fatal error: EGL/egl.h: No such file or directory On rpi, the EGL hea

[PATCH weston] protocol: rename wl_surface_scaler to wl_viewport

2014-01-08 Thread ppaalanen
From: Pekka Paalanen This seems like a better name, and will not conflict if someone later extends wl_surface with a request scaler_set (yeah, unlikely). This code was written by Jonny Lamb, I just diffed his branches and made a patch for Weston. Cc: Jonny Lamb Signed-off-by: Pekka Paalanen -

[PATCH weston] screenshooter: silence a warning

2014-01-08 Thread ppaalanen
From: Pekka Paalanen screenshooter.c: In function ‘recorder_binding’: screenshooter.c:509:5: warning: ‘listener’ may be used uninitialized in this function [-Wuninitialized] This was not really a problem so far, because the variable was uninitialized only in the case where Weston had no outputs.

[PATCH 3/3] alt-tab: switch binding to mod+tab

2014-01-08 Thread pochu27
From: Emilio Pozuelo Monfort So it uses the same modifier than the rest of the bindings, for consistency's sake. --- desktop-shell/shell.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index cc7d8dc..13a42e1 100644 --- a/de

[PATCH 0/3] alt-tab redux

2014-01-08 Thread pochu27
From: Emilio Pozuelo Monfort Hi Kristian, I know you said in your alt-tab removal commit that we would reintroduce it again in 1.5. I'm just sending this here now to have it on list, but waiting for 1.4 to be released is fine with me. In this series I'm not removing the old switcher. I don't th

[PATCH 2/3] switcher: change keybinding to mod+esc

2014-01-08 Thread pochu27
From: Emilio Pozuelo Monfort To avoid conflicts with the new alt+tab. --- desktop-shell/shell.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index 3d0836d..cc7d8dc 100644 --- a/desktop-shell/shell.c +++ b/desktop-shell/shel

[PATCH 1/3] Bring alt-tab back to life

2014-01-08 Thread pochu27
From: Emilio Pozuelo Monfort --- desktop-shell/shell.c | 251 ++ 1 file changed, 251 insertions(+) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index 96e31a1..3d0836d 100644 --- a/desktop-shell/shell.c +++ b/desktop-shell/shell.c @@

Re: Authorized clients

2014-01-08 Thread Martin Peres
On 07/01/2014 20:43, Pekka Paalanen wrote: On Tue, 7 Jan 2014 14:26:36 -0500 "Jasper St. Pierre" wrote: On Tue, Jan 7, 2014 at 9:07 AM, Martin Peres wrote: Would it be ok for you if the compositor asked the user to agree for the program to do the operation? If so, we can guarantee that this

Re: Authorized clients

2014-01-08 Thread Martin Peres
On 07/01/2014 20:26, Jasper St. Pierre wrote: Would it be ok for you if the compositor asked the user to agree for the program to do the operation? If so, we can guarantee that this is really the user's intent and allow the application. We can also add a security warning with

Re: Authorized clients

2014-01-08 Thread Martin Peres
On 07/01/2014 20:53, Daniel Stone wrote: Hi, On 7 January 2014 19:22, Maarten Baert wrote: @Martin Peres: Your ideas are nice in theory, but as Sebastian Wick already said, it is just not practical. If you want a specific example, I have one: https://github.com/MaartenBaert/ssr The sole purpo

Re: [PATCH v4 3/3] compositor-drm: allow to be a wl_dmabuf server

2014-01-08 Thread Daniel Vetter
On Tue, Jan 07, 2014 at 07:37:11PM +0100, Thomas Hellstrom wrote: > > I think dma-buf mmap() used without care like this should be avoided at > all cost, > because it will make people happily start using it without thinking > about non-coherent > architectures where mmap would be painfully ineffic

Re: [PATCH v4 1/3] Add wl_dmabuf protocol

2014-01-08 Thread Daniel Vetter
On Tue, Jan 07, 2014 at 06:41:42PM +0100, benjamin.gaign...@linaro.org wrote: > From: Benjamin Gaignard > > It allow to use a dmabuf file descriptor in a wayland protocol. > To make as generic as possible it is up to the server to call > wl_dmabuf_send_format() and/or wl_dmabuf_send_device() to s