Re: Inter-client surface embedding

2014-02-18 Thread Jonas Ådahl
On Mon, Feb 17, 2014 at 10:59:11PM +, Mark Thomas wrote: > On Mon, 17 Feb 2014, Pekka Paalanen wrote: > > >On Mon, 17 Feb 2014 00:04:19 + (GMT) > >Mark Thomas wrote: > > > >> - The subsurface has separate focus from the main window surface. For > >>the usual use cases of embedding like

Re: Core protocol change; [RFC v2] Wayland presentation extension

2014-02-18 Thread Pekka Paalanen
Hi Jason, thanks for the reply. I think I wrote more like a flamebait than a solution there. After sleeping over it and discussing with Axel, I think changing the existing core protocol behaviour is not appropriate, and we need to find another way around this. More below. On Mon, 17 Feb 2014 10:

Re: [PATCH libinput 1/2] Hook up libevdev as backend

2014-02-18 Thread Rui Tiago Cação Matos
On 18 February 2014 07:09, Peter Hutterer wrote: > libevdev wraps the various peculiarities of the evdev kernel API into a > type-safe API. It also buffers the device so checking for specific features at > a later time is easier than re-issuing the ioctls. Plus, it gives us almost > free support f

Re: Inter-client surface embedding

2014-02-18 Thread Matthias Clasen
On Mon, Feb 17, 2014 at 6:41 PM, Jasper St. Pierre wrote: > GtkPlug and GtkSocket are really implemented in terms of XEmbed. As we've > found, XEmbed has a surprising number of problems in real-world use cases, > so it's considered deprecated. > > Building something special-case for panels seems m

[PATCH wayland] protocol: strike the note of frame callback triggering time

2014-02-18 Thread Pekka Paalanen
From: Pekka Paalanen "the callback event will arrive after the next output refresh" is wrong, if you interpret "output refresh" as framebuffer flip or the moment when the new pixels turn into light the first time. Weston has probably never worked this way. Weston triggers the frame callbacks whe

Re: [RFC] libinput configuration interface

2014-02-18 Thread Dominic Jänichen
On Mon, 03 Feb 2014 11:02:42 +1000, Peter Hutterer wrote: > > tbh, I'm not planning to support every potential option under the sun. > There's a fine and rather blurry line between what is a preference and > what is merely configuration because we can't commit to a single > default. I'd rather hav

Re: Core protocol change; [RFC v2] Wayland presentation extension

2014-02-18 Thread Axel Davy
Hi, If you read the above paragraph carefully, you see that the last sentence CHANGES EXISTING WAYLAND CORE PROTOCOL BEHAVIOUR. The change is very subtle. It means, that without a wl_surface.attach, the buffer state is no longer applied on commit at all! To recap, the buffer state is: - frame ca

Re: [PATCH libinput] evdev: fix device_transform_ functions

2014-02-18 Thread Jonas Ådahl
On Tue, Feb 18, 2014 at 02:28:53PM +1000, Peter Hutterer wrote: > On Mon, Feb 17, 2014 at 01:42:52PM -0500, Benjamin Tissoires wrote: > > X and Y are li_fixed_t, which is 24.8 fixed point real number. > > li_fixed_t max is thus ~8388607. > > > > On a touchscreen with a range of 32767 values (like

Re: Inter-client surface embedding

2014-02-18 Thread Mark Thomas
On Mon, 17 Feb 2014, Bill Spitzak wrote: Mark Thomas wrote: I've pushed some doc updates to the protocol.xml file my git repo. But in terms of Jonas Ådahl's proposal, my protocol works the other way round: A creates a main surface A creates a "hole" on that surface and sets its position

Re: Help compiling mesa/gallium from git!

2014-02-18 Thread Bill Spitzak
On 02/08/2014 01:30 AM, Pekka Paalanen wrote: *sigh*... I wrote a long nice reply and then my laptop crashed. Ok, here's the summary anyway. Well I am wishing here I could see the longer reply but I am stuck. Weston did not compile with an error similar to this until I added "--disable-egl"

[PATCH libinput 2/2] test: Add scale li_fixed overflow test

2014-02-18 Thread Jonas Ådahl
Add a test case and test device that checks if the scale transform can handle high resolution devices and output monitor resolutions. The test case is created in a way that it will fail if the coordinate transform expression will overflow if only 32 bit integer data containers are used. Signed-of

[PATCH libinput 1/2] test: Fix touch_down in wacom touch test device

2014-02-18 Thread Jonas Ådahl
Signed-off-by: Jonas Ådahl --- test/litest-wacom-touch.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/litest-wacom-touch.c b/test/litest-wacom-touch.c index a33e085..464d541 100644 --- a/test/litest-wacom-touch.c +++ b/test/litest-wacom-touch.c @@ -54,8 +54,8 @@ li

Re: Inter-client surface embedding

2014-02-18 Thread Bill Spitzak
On 02/18/2014 11:09 AM, Mark Thomas wrote: I think the above description can be greatly simplified by removing the "hole" and "plug" objects and just using a subsurface: A creates a main surface A creates a subsurface for the "hole" A gets the uid of the subsurface from the compositor A pas

Re: [PATCH weston v2 6/6] tests: Properly report skipped tests

2014-02-18 Thread Kristian Høgsberg
On Fri, Feb 07, 2014 at 09:34:48AM +0100, Emilio Pozuelo Monfort wrote: > From: Emilio Pozuelo Monfort > > We were calling exit(0) when tests were skipped, which counted > them as passed instead of skipped. Fix this by properly exiting > with 77 (which is what automake expects for skipped tests)

Re: [PATCH weston.ini.man] Improvement of weston.ini.man. Add key:shell and remove tablet-shell.

2014-02-18 Thread Kristian Høgsberg
On Sat, Feb 08, 2014 at 04:44:14PM +0900, Nobuhiko Tanibata wrote: > Add key:shell to CORE SECTION and move a example of desktop-shell from > key:modules to key:shell. > Add cms-colord.so to key:modules of CORE SECTION. > > Signed-off-by: Nobuhiko Tanibata Thank you, patch applied. I amended t

Re: [PATCH weston.ini.man v3] Improvement of weston.ini.man. Add key:shell and remove tablet-shell

2014-02-18 Thread Kristian Høgsberg
On Mon, Feb 10, 2014 at 12:15:11PM +0900, Nobuhiko Tanibata wrote: > Add description of key:shell to CORE SECTION and move a example of > desktop-shell from key:modules to key:shell. > Add cms-colord.so to key:modules of CORE SECTION. > > Signed-off-by: Nobuhiko Tanibata I backed out the v1 of

Re: [PATCH libinput] Add a customizable log handler

2014-02-18 Thread Jonas Ådahl
On Fri, Feb 14, 2014 at 10:16:02AM +1000, Peter Hutterer wrote: > The previous log handler wasn't actually hooked up to anything. Add a public > API for the log handler with priority filtering, defaulting to priority > 'error' and stderr as output stream. > > And to keep the diff down and convenie

Re: [PATCH weston] exposay: arrange views per-output

2014-02-18 Thread Kristian Høgsberg
On Mon, Feb 10, 2014 at 01:22:32PM +0100, Emilio Pozuelo Monfort wrote: > From: Emilio Pozuelo Monfort > > https://bugs.freedesktop.org/show_bug.cgi?id=73173 Thanks for fixing this, patch applied and bug closed. Kristian > --- > desktop-shell/exposay.c | 108 > ---

Re: [PATCH weston] exposay: don't crash if a view goes away

2014-02-18 Thread Kristian Høgsberg
On Mon, Feb 10, 2014 at 02:23:04PM +0100, Emilio Pozuelo Monfort wrote: > From: Emilio Pozuelo Monfort > > When a view was destroyed while we were on exposay, we didn't > remove it from the list of views, and so when leaving exposay > we were trying to animate (and sometimes activate) a > non-exi

Re: [PATCH weston 2/2] exposay: avoid needlessly activating the active view

2014-02-18 Thread Kristian Høgsberg
On Mon, Feb 10, 2014 at 04:52:33PM +0100, Emilio Pozuelo Monfort wrote: > From: Emilio Pozuelo Monfort > > Signed-off-by: Emilio Pozuelo Monfort These two applied, thanks. Kristian > --- > desktop-shell/exposay.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/desktop-shell/expo

Re: [PATCH] Prevent zero sized wl_egl_window

2014-02-18 Thread Kristian Høgsberg
On Fri, Feb 14, 2014 at 09:31:45AM +0200, Pekka Paalanen wrote: > On Thu, 13 Feb 2014 18:18:23 + > "Yeh, Sinclair" wrote: > > > > The below seems fine, but I wonder if we could make this one cause an > > > error to be returned later where we can, rather than silently ignoring. > > > I'm not s

Re: Inter-client surface embedding

2014-02-18 Thread Mark Thomas
On Tue, 18 Feb 2014, Bill Spitzak wrote: On 02/18/2014 11:09 AM, Mark Thomas wrote: The "hole" and "plug" are meaningful objects and are needed, at least server-side, for some associated state. They're also helpful for limiting the amount of uid-dipping a client can do, as only holes and plug

Re: [PATCH] scanner: Add GCC pragmas to disable -Wredundant-decls

2014-02-18 Thread Kristian Høgsberg
On Sat, Feb 15, 2014 at 01:29:16PM -0500, Jasper St. Pierre wrote: > The code very intentionally emits a lot of redundant declarations > to simplify the scanner code. Somebody building with -Wredundant-decls > would have compile errors, so emit special pragmas to turn those > warnings off. > > The

[PATCH libinput] evdev: set CLOCK_MONOTONIC as the time source

2014-02-18 Thread Peter Hutterer
Avoids erroneous timestamps when the system time is reset. This used to a be a problem with the X.Org synaptics driver where taps, scrolling and a couple of other things would potentially lock up. Signed-off-by: Peter Hutterer --- src/evdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [PATCH] connection: Use wl_log to report errors

2014-02-18 Thread Kristian Høgsberg
On Mon, Feb 17, 2014 at 07:04:28PM -0500, Jasper St. Pierre wrote: > In some cases, like Xwayland, stdout and stderr are redirected to > /dev/null, losing us valuable information, while wl_log can be > overridden, allowing us to send it to a log file instead. This > can help debugging immensely. >

Re: [RFC] libinput configuration interface

2014-02-18 Thread Peter Hutterer
On Tue, Feb 18, 2014 at 04:33:53PM +, Dominic Jänichen wrote: > On Mon, 03 Feb 2014 11:02:42 +1000, Peter Hutterer wrote: > > > > tbh, I'm not planning to support every potential option under the sun. > > There's a fine and rather blurry line between what is a preference and > > what is merely

Re: [PATCH libinput 2/2] test: Add scale li_fixed overflow test

2014-02-18 Thread Peter Hutterer
On Tue, Feb 18, 2014 at 08:13:58PM +0100, Jonas Ådahl wrote: > Add a test case and test device that checks if the scale transform can > handle high resolution devices and output monitor resolutions. > > The test case is created in a way that it will fail if the coordinate > transform expression wi

Re: Inter-client surface embedding

2014-02-18 Thread Jasper St. Pierre
On Tue, Feb 18, 2014 at 2:22 PM, Bill Spitzak wrote: > On 02/18/2014 11:09 AM, Mark Thomas wrote: > > I think the above description can be greatly simplified by removing >>> the "hole" and "plug" objects and just using a subsurface: >>> >>> A creates a main surface >>> A creates a subsurface f

Re: [PATCH libinput] evdev: set CLOCK_MONOTONIC as the time source

2014-02-18 Thread Thiago Macieira
Em qua 19 fev 2014, às 08:47:32, Peter Hutterer escreveu: > + libevdev_set_clock_id(device->evdev, CLOCK_MONOTONIC); What happens if the monotonic clock isn't supported? Shouldn't you check that sysconf(_SC_MONOTONIC_CLOCK) > 0 ? -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT)

Re: [PATCH libinput] evdev: set CLOCK_MONOTONIC as the time source

2014-02-18 Thread Jasper St. Pierre
... and what if it fails? I'd say that requiring CLOCK_MONOTONIC is fine. Are there any popular Linux setups that don't have CLOCK_MONOTONIC? On Tue, Feb 18, 2014 at 10:13 PM, Thiago Macieira wrote: > Em qua 19 fev 2014, às 08:47:32, Peter Hutterer escreveu: > > + libevdev_set_clock_id(d

Re: [PATCH libinput] evdev: set CLOCK_MONOTONIC as the time source

2014-02-18 Thread Thiago Macieira
Em ter 18 fev 2014, às 22:33:26, Jasper St. Pierre escreveu: > ... and what if it fails? I'd say that requiring CLOCK_MONOTONIC is fine. > > Are there any popular Linux setups that don't have CLOCK_MONOTONIC? I'm guessing that some weird and niche embedded boards might not support it. Which is a

Re: Inter-client surface embedding

2014-02-18 Thread Bill Spitzak
Mark Thomas wrote: I suggest you read up on the subsurface protocol. A "subsurface" object takes two "surface" arguments, one is the parent to attach to, and the other is the child surface that becomes the subsurface. You are right, the actual object I wanted to send from A to B is a surf

[PATCH 1/5] shell: add taskbar and taskbar_handler widgets

2014-02-18 Thread Manuel Bachmann
We draw a taskbar surface in desktop-shell, extend the desktop-shell protocol to send it to the compositor, and the compositor will draw it in a new taskbar layer at the bottom. Signed-off-by: Manuel Bachmann --- clients/desktop-shell.c| 144 des

[PATCH 3/5] shell: add managed_surface interface, request and events

2014-02-18 Thread Manuel Bachmann
We create a new "managed_surface" object which will track a surface compositor-side, and receive events shell-side to handle 3 cases : - a toplevel surface has been created ; - a toplevel surface has been destroyed ; - a toplevel surface has a new title ; Signed-off-by: Manuel Bachmann --- clien

[PATCH 2/5] compositor: consider taskbar height on surfaces maximizing

2014-02-18 Thread Manuel Bachmann
As we have a new taskbar layer at the bottom, substract its height from the desired size of maximized surfaces, so they never get hovered by it. Signed-off-by: Manuel Bachmann --- desktop-shell/shell.c | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) diff --gi

[PATCH 4/5] shell: do the actual taskbar_handler visual actions

2014-02-18 Thread Manuel Bachmann
We now really draw the handler widgets. They will be added, destroyed and renamed when receiving events. Signed-off-by: Manuel Bachmann --- clients/desktop-shell.c | 123 ++- desktop-shell/shell.c |3 +- 2 files changed, 123 insertions(+), 3 del

[PATCH 5/5] compositor: effectively minimize and unminimize.

2014-02-18 Thread Manuel Bachmann
When receiving a managed_surface_set_state request from desktop-shell, compositor will know eventually hide the target surface by sending it to an dedicated layer. Signed-off-by: Manuel Bachmann --- desktop-shell/shell.c | 48 ++-- desktop-shell/shel

[PATCH 6/6] compositor: bind xdg_shell_set_minimized to the new logic

2014-02-18 Thread Manuel Bachmann
We bind the xdg call to the same logic used by taskbar. Signed-off-by: Manuel Bachmann --- desktop-shell/shell.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index 8f50046..8ac9d6d 100644 --- a/desktop-

Re: [RFC] libinput configuration interface

2014-02-18 Thread Alexander E. Patrakov
19.02.2014 04:52, Peter Hutterer wrote: The set of touchpad patches I sent out recently already handle this by default. When the physical clickpad button is depressed, the driver picks the finger that is pressing the button (sometimes guessing, but hey...). That finger cannot control the pointer

Re: Help compiling mesa/gallium from git!

2014-02-18 Thread Bill Spitzak
Okay, a bit more luck, in that I can compile weston. I mostly discovered that there are parts of mesa you just cannot turn off, no matter how much you are certain they are not used. Mesa internally has calls into various functions in these modules from others so they cannot be removed. My cu