Re: [PATCH libinput 7/9] Introduce seat wide button and key count API

2014-04-10 Thread Peter Hutterer
On Wed, Apr 09, 2014 at 09:02:14PM +0200, Jonas Ådahl wrote: Compositors will need to keep provide virtual devices of supported generic device types (pointer, keyboard, touch etc). Events from each device capable of a certain device type abstraction should be combined as if it was only one

Re: [PATCH] tests: fix bad-buffer-test

2014-04-10 Thread Pekka Paalanen
On Wed, 9 Apr 2014 16:44:53 +0200 Marek Chalupa mchqwe...@gmail.com wrote: bad-buffer-test is FAIL_TEST and every assert() (or even SIGSEGV signal) make it pass. It shouldn't be so for example when assert() is invoked when a client couldn't connect to display. Make sure that only relevant

Re: [PATCH libinput 1/9] evdev: Dynamically allocate slot array

2014-04-10 Thread Jonas Ådahl
On Thu, Apr 10, 2014 at 03:43:25PM +1000, Peter Hutterer wrote: On Wed, Apr 09, 2014 at 09:02:08PM +0200, Jonas Ådahl wrote: Don't have a hard coded (previously 16) slot array size; instead allocate dynamically depending what slots are assigned. There is still a hard coded max though, to

Re: [PATCH libinput 3/9] test: Add seat slot tests

2014-04-10 Thread Jonas Ådahl
On Thu, Apr 10, 2014 at 03:48:40PM +1000, Peter Hutterer wrote: On Wed, Apr 09, 2014 at 09:02:10PM +0200, Jonas Ådahl wrote: Add one test that checks uniqueness of seat slots when having multiple devices with active touch points. Add one test that checks that libinput drops touch points

Re: [PATCH libinput 4/9] test: Test handling of many touch points

2014-04-10 Thread Jonas Ådahl
On Thu, Apr 10, 2014 at 03:51:23PM +1000, Peter Hutterer wrote: On Wed, Apr 09, 2014 at 09:02:11PM +0200, Jonas Ådahl wrote: libinput currently handles 16 per device touch points. Test that we behave as expected when a device has an even higher number of active touch points.

Re: [PATCH libinput 9/9] touchpad: Always assign iterator in tp_for_each_touch macro

2014-04-10 Thread Jonas Ådahl
On Thu, Apr 10, 2014 at 03:55:29PM +1000, Peter Hutterer wrote: On Wed, Apr 09, 2014 at 09:02:16PM +0200, Jonas Ådahl wrote: Rewrite the tp_for_each_touch macro to always assign the iterator. Practically it was already always assigning as ntouches is always more than 0, but this way we

Re: [PATCH libinput 7/9] Introduce seat wide button and key count API

2014-04-10 Thread Jonas Ådahl
On Thu, Apr 10, 2014 at 04:07:34PM +1000, Peter Hutterer wrote: On Wed, Apr 09, 2014 at 09:02:14PM +0200, Jonas Ådahl wrote: Compositors will need to keep provide virtual devices of supported generic device types (pointer, keyboard, touch etc). Events from each device capable of a certain

Re: [PATCH libinput 1/9] evdev: Dynamically allocate slot array

2014-04-10 Thread Peter Hutterer
On Thu, Apr 10, 2014 at 08:17:37AM +0200, Jonas Ådahl wrote: On Thu, Apr 10, 2014 at 03:43:25PM +1000, Peter Hutterer wrote: On Wed, Apr 09, 2014 at 09:02:08PM +0200, Jonas Ådahl wrote: Don't have a hard coded (previously 16) slot array size; instead allocate dynamically depending what

Re: [PATCH libinput 7/9] Introduce seat wide button and key count API

2014-04-10 Thread Peter Hutterer
On Thu, Apr 10, 2014 at 08:35:00AM +0200, Jonas Ådahl wrote: On Thu, Apr 10, 2014 at 04:07:34PM +1000, Peter Hutterer wrote: On Wed, Apr 09, 2014 at 09:02:14PM +0200, Jonas Ådahl wrote: Compositors will need to keep provide virtual devices of supported generic device types (pointer,

Re: [PATCH libinput 7/9] Introduce seat wide button and key count API

2014-04-10 Thread Jonas Ådahl
On Thu, Apr 10, 2014 at 04:48:52PM +1000, Peter Hutterer wrote: On Thu, Apr 10, 2014 at 08:35:00AM +0200, Jonas Ådahl wrote: On Thu, Apr 10, 2014 at 04:07:34PM +1000, Peter Hutterer wrote: On Wed, Apr 09, 2014 at 09:02:14PM +0200, Jonas Ådahl wrote: Compositors will need to keep provide

Re: [PATCH libinput 7/9] Introduce seat wide button and key count API

2014-04-10 Thread Peter Hutterer
On Thu, Apr 10, 2014 at 08:53:45AM +0200, Jonas Ådahl wrote: On Thu, Apr 10, 2014 at 04:48:52PM +1000, Peter Hutterer wrote: On Thu, Apr 10, 2014 at 08:35:00AM +0200, Jonas Ådahl wrote: On Thu, Apr 10, 2014 at 04:07:34PM +1000, Peter Hutterer wrote: On Wed, Apr 09, 2014 at 09:02:14PM

Re: Wayland API Changed?

2014-04-10 Thread Jonas Ådahl
On Thu, Apr 10, 2014 at 05:08:45PM +0800, Leslie Zhai wrote: Hi João and Wayland developers, I am a newbie of Wayland, so I just wanna write a HelloWorld at first :) I read the client demo source code just like ./weston/clients/simple-touch.c it shown a transparent frameless window, and

Re: [PATCH weston 2/2] Reset the keyboard focus on all seats when the compositor is locked

2014-04-10 Thread Pekka Paalanen
On Wed, 09 Apr 2014 17:08:23 +0100 Neil Roberts n...@linux.intel.com wrote: Jasper St. Pierre jstpie...@mecheye.net writes: Why is this necessary? Won't events never be delivered while locked anyway? Events do seem to get delivered, you can try it if you run weston -i5 and then open a

Re: [PATCH] gl-renderer: Remove gl_renderer_interface from gl-renderer.h

2014-04-10 Thread Pekka Paalanen
On Tue, 8 Apr 2014 20:51:45 +0200 John Kåre Alsaker john.kare.alsa...@gmail.com wrote: John, you forgot the commit message. --- src/gl-renderer.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gl-renderer.h b/src/gl-renderer.h index db42f6c..6cd5f54 100644 ---

Re: [RFC libwayland] Track protocol object versions inside wl_proxy.

2014-04-10 Thread Pekka Paalanen
Hi Jason, thanks for working on this, it does seem very useful, practically a mandatory feature to support. Thinking out loud We already had the versioning rules documented, right? Whenever bumping an interface version, also the parent interface (factory) version must be bumped. That makes the

[PATCH weston] shell: Disarm the screensaver timeout timer on terminate_screensaver()

2014-04-10 Thread Ander Conselvan de Oliveira
The timer was left running after the screensaver was terminated. When it triggered, a fade out that would in turn cause the screen to be locked was started. Since that could happen without the compositor emitting the idle signal, there would be no wake signal to make the shell show the lock

[PATCH] shell: Damage below child surfaces on move to different workspace

2014-04-10 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com When moving from a surface from visible workspace to an invisible one via a popup menu, the area below the menu wouldn't be repainted. https://bugs.freedesktop.org/show_bug.cgi?id=76973 --- desktop-shell/shell.c | 1 + 1

[PATCH weston] shell: Keep shsurf-fullscreen_output set after unset_fullscreen()

2014-04-10 Thread Ander Conselvan de Oliveira
When a fullscreen surface gets the maximized state, the function reset_surface_type() is called and that causes unset_fullscreen() to be called. That function would set the value of shsurf-fullscreen_output to NULL. However, since the surface still has the fullscreen state, it will be configured

Re: Wayland API Changed?

2014-04-10 Thread Leslie Zhai
Hi JJ, Thanks for your reply :) Of course, welcome to contribute to the tinywm (the tiniest window manager is trying to support x11, wayland and directfb backends currently in the world and even in the universe) open source project https://github.com/AOSC-Dev/TinyWM tinywm is very young,

Re: [RFC libwayland] Track protocol object versions inside wl_proxy.

2014-04-10 Thread Jason Ekstrand
On Thu, Apr 10, 2014 at 6:37 AM, Pekka Paalanen ppaala...@gmail.com wrote: Hi Jason, thanks for working on this, it does seem very useful, practically a mandatory feature to support. Hi Pekka, Yeah, I've been itching to knock this out for a while. Just finally got around to it. Comments

Re: [PATCH weston 1/2] Reset focus on unknown seats when restoring focus state

2014-04-10 Thread Kristian Høgsberg
On Wed, Apr 09, 2014 at 04:33:31PM +0100, Neil Roberts wrote: The focus_state list on a workspace only contains entries for seats which have a keyboard focus on that workspace. For workspaces that have no surfaces the list will be empty. That means that when a workspace with no surfaces is

Re: [PATCH weston 2/2] Reset the keyboard focus on all seats when the compositor is locked

2014-04-10 Thread Kristian Høgsberg
On Wed, Apr 09, 2014 at 04:33:32PM +0100, Neil Roberts wrote: Before commit 2f5faff7f9142 when the compositor is locked it would reset the keyboard focus on all of the seats as part of pushing the focus_state. This was removed because it now always keeps track of the focus_state in the

Re: [PATCH weston] shell: Disarm the screensaver timeout timer on terminate_screensaver()

2014-04-10 Thread Kristian Høgsberg
On Thu, Apr 10, 2014 at 02:49:35PM +0300, Ander Conselvan de Oliveira wrote: The timer was left running after the screensaver was terminated. When it triggered, a fade out that would in turn cause the screen to be locked was started. Since that could happen without the compositor emitting the

Re: [PATCH] shell: Damage below child surfaces on move to different workspace

2014-04-10 Thread Kristian Høgsberg
On Thu, Apr 10, 2014 at 03:35:58PM +0300, Ander Conselvan de Oliveira wrote: From: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com When moving from a surface from visible workspace to an invisible one via a popup menu, the area below the menu wouldn't be repainted.

Re: [PATCH weston] shell: Keep shsurf-fullscreen_output set after unset_fullscreen()

2014-04-10 Thread Kristian Høgsberg
On Thu, Apr 10, 2014 at 04:36:57PM +0300, Ander Conselvan de Oliveira wrote: When a fullscreen surface gets the maximized state, the function reset_surface_type() is called and that causes unset_fullscreen() to be called. That function would set the value of shsurf-fullscreen_output to NULL.

[PATCHv2 weston] gl-renderer: Remove gl_renderer_interface from gl-renderer.h

2014-04-10 Thread John Kåre Alsaker
The rationale here is, that this line would create an instance of gl_renderer_interface in every compilation unit that included gl-renderer.h. This is not necessary, and it can actually be harmful by masking the real exported gl_renderer_interface symbol, if you added another compilation unit to

Re: Wayland API Changed?

2014-04-10 Thread Pekka Paalanen
On Thu, 10 Apr 2014 21:46:41 +0800 Leslie Zhai xiangzha...@gmail.com wrote: That is a good news to me, and I am learning Wayland and relative components, so I wanna develop recordmydesktop-wayland to be familiar with it :) Screenshooting particularly is very special. Unless your program is

Re: [PATCH] gl-renderer: Remove gl_renderer_interface from gl-renderer.h

2014-04-10 Thread Kristian Høgsberg
On Thu, Apr 10, 2014 at 3:41 AM, Pekka Paalanen ppaala...@gmail.com wrote: On Tue, 8 Apr 2014 20:51:45 +0200 John Kåre Alsaker john.kare.alsa...@gmail.com wrote: John, you forgot the commit message. --- src/gl-renderer.h | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [PATCH] protocol: Correct typo 'suppot'

2014-04-10 Thread Kristian Høgsberg
On Tue, Apr 08, 2014 at 09:04:57PM +, Bryce W. Harrington wrote: Thanks, committed. Kristian Signed-off-by: Bryce Harrington b.harring...@samsung.com --- protocol/fullscreen-shell.xml |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/protocol/fullscreen-shell.xml

Re: Wayland API Changed?

2014-04-10 Thread Leslie Zhai
Hi pq, Thanks for your reply :) I love hear the interestring story, so I will click the every thread link to follow your guys` story :) I might follow the existing recordmydesktop-wayland project if existed, also welcome to tinywm (wayland backend) open source project goes here