Re: [PATCH 6/6] window: Add a simple getenv to force SHM rendering

2014-04-30 Thread Kristian Høgsberg
On Mon, Apr 28, 2014 at 11:19:32AM -0400, Jasper St. Pierre wrote: Yeah, that's useful, applied. Kristian > --- > clients/window.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/clients/window.c b/clients/window.c > index d822af7..3897440 100644 > --- a/clients/wi

Re: [PATCH 4/6] cairo-util: Don't show a resize cursor on edges when we're maximized

2014-04-30 Thread Kristian Høgsberg
On Mon, Apr 28, 2014 at 11:19:30AM -0400, Jasper St. Pierre wrote: > This is substantially confusing to users, namely me. That is indeed confusing. However, I edited the patch to just set grip_size to 0 if we're maximized. Kristian > --- > shared/cairo-util.c | 13 - > 1 file chang

Re: [PATCH 1/6] compositor: Fix the documentation for surface->configure

2014-04-30 Thread Kristian Høgsberg
On Mon, Apr 28, 2014 at 11:19:27AM -0400, Jasper St. Pierre wrote: > It's called on commit, not on attach. Additionally, correct the > interface name to be wl_surface, not surface. > --- > src/compositor.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/compositor

Re: [PATCH weston v2] screen-share: Don't unset server environment variables

2014-04-30 Thread Kristian Høgsberg
On Wed, Apr 30, 2014 at 10:53:30AM -0500, Jason Ekstrand wrote: > Looks good to me. > > Reviewed-by: Jason Ekstrand Thanks, committed. Kristian > On Apr 30, 2014 3:52 AM, "Andrew Wedgbury" > wrote: > > > There is no need to unset WAYLAND_DISPLAY and WAYLAND_SOCKET when > > screen-share > > l

Re: [PATCH weston v2] screen-share: Don't unset server environment variables

2014-04-30 Thread Jason Ekstrand
Looks good to me. Reviewed-by: Jason Ekstrand On Apr 30, 2014 3:52 AM, "Andrew Wedgbury" wrote: > There is no need to unset WAYLAND_DISPLAY and WAYLAND_SOCKET when > screen-share > launches the fullscreen shell server. This was done originally in case the > launched server decided to use the wa

[PATCH weston 3/3] weston-info: Display the name from the new wl_output.name event

2014-04-30 Thread Neil Roberts
If the compositor supports version 3 of the wl_output interface and sends a name event then this will now be displayed in the info. --- clients/weston-info.c | 39 ++- 1 file changed, 38 insertions(+), 1 deletion(-) diff --git a/clients/weston-info.c b/clients/

[PATCH weston 2/3] Send the new wl_output.name event when binding an output

2014-04-30 Thread Neil Roberts
This version for the wl_output interface has been changed to 3 and it now sends out the name event when a client binds an output. --- src/compositor.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/compositor.c b/src/compositor.c index ee8dc24..6a333df 100644 --- a/src

[PATCH 1/3] protocol: Add an event to specify the name of an output

2014-04-30 Thread Neil Roberts
This bumps the version of the wl_output interface to 3 and adds a separate event to report the output's name. --- protocol/wayland.xml | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/protocol/wayland.xml b/protocol/wayland.xml index 330f8ab..60fa81e 100644 --- a/p

[PATCH weston] shell: Don't map surfaces of type SHELL_SURFACE_NONE

2014-04-30 Thread Ander Conselvan de Oliveira
When commit 07926d90 factored out the code that chooses in which layer a surface is added to, it changed the behavior for surfaces with no type. Instead of not adding it to any layer, the surface is added to the current workspace. This patch restores the old behavior. https://bugs.freedesktop.org

[PATCH] xwayland: free xcb reply value when malloc returns null

2014-04-30 Thread vivek
Signed-off-by: vivek --- xwayland/selection.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/xwayland/selection.c b/xwayland/selection.c index b694477..d1f6361 100644 --- a/xwayland/selection.c +++ b/xwayland/selection.c @@ -186,8 +186,10 @@ weston_wm_get_selection_targ

[PATCH weston v2] screen-share: Don't unset server environment variables

2014-04-30 Thread Andrew Wedgbury
There is no need to unset WAYLAND_DISPLAY and WAYLAND_SOCKET when screen-share launches the fullscreen shell server. This was done originally in case the launched server decided to use the wayland backend based on the presence of these. However, we pass a command line argument telling it to use th

Re: [PATCH] client: extend error handling

2014-04-30 Thread Pekka Paalanen
On Wed, 30 Apr 2014 09:40:19 +0200 Marek Chalupa wrote: > On 24 April 2014 14:45, Pekka Paalanen wrote: > > > On Wed, 23 Apr 2014 14:39:48 +0200 > > Marek Chalupa wrote: > > > > > +/** > > > + * This function is called for error events > > > + * and idicates that in some object occured an erro

[PATCH v3] client: extend error handling

2014-04-30 Thread Marek Chalupa
When an error occurs, wl_display_get_error() does not provide any way of getting know if it was a local error or if it was an error event, respectively what object caused the error and what the error was. This patch introduces a new function wl_display_get_protocol_error() which will return error

Re: [PATCH] client: extend error handling

2014-04-30 Thread Marek Chalupa
On 24 April 2014 14:45, Pekka Paalanen wrote: > On Wed, 23 Apr 2014 14:39:48 +0200 > Marek Chalupa wrote: > > > When an error occurres, than wl_display_get_error() do not > > ... occurs, [then] ... does not > > > provide any way of getting know if it was a local error or if it was > > an error e

Re: [PATCH 6/6] window: Add a simple getenv to force SHM rendering

2014-04-30 Thread Pekka Paalanen
On Tue, 29 Apr 2014 16:18:33 -0400 "Jasper St. Pierre" wrote: > Can we at least do this work independently of this patch? I was debugging > EGL stack issues, so I figured I might as well give my envvar hack to debug > SHM issues. Of course, I never intended to block this patch. I just wanted to