Re: [PATCH wayland-web] Added depencies and bug fixes to build instructions

2014-05-19 Thread Pekka Paalanen
On Fri, 16 May 2014 13:43:50 -0700 spit...@gmail.com wrote: From: spitzak spit...@gmail.com This is based on several experimental runs on two different Ubuntu 12.04 machines. Latest version includes instructions for a recent update of Mesa (which requires llvm-3.1) and that you must

Re: [PATCH wayland-web] Added depencies and bug fixes to build instructions

2014-05-19 Thread Pekka Paalanen
On Mon, 19 May 2014 10:39:54 +0300 Pekka Paalanen ppaala...@gmail.com wrote: On Fri, 16 May 2014 13:43:50 -0700 spit...@gmail.com wrote: From: spitzak spit...@gmail.com This is based on several experimental runs on two different Ubuntu 12.04 machines. Latest version includes

Re: [PATCH v3] configure.ac: Change in build system to use the path from pkg-config for wayland-scanner.

2014-05-19 Thread Pekka Paalanen
On Sun, 18 May 2014 00:39:16 +0200 Thierry Reding thierry.red...@gmail.com wrote: On Fri, May 16, 2014 at 03:43:47PM +0530, Srivardhan Hebbar wrote: This is a fix to the bug https://bugs.freedesktop.org/show_bug.cgi?id=78688. Signed-off-by: Srivardhan Hebbar sri.heb...@samsung.com ---

RE: [PATCH v3] configure.ac: Change in build system to use the path from pkg-config for wayland-scanner.

2014-05-19 Thread Srivardhan
-Original Message- From: Pekka Paalanen [mailto:ppaala...@gmail.com] Sent: Monday, May 19, 2014 2:30 PM To: Thierry Reding Cc: Srivardhan Hebbar; wayland-devel@lists.freedesktop.org Subject: Re: [PATCH v3] configure.ac: Change in build system to use the path from pkg-config for

[PATCH v4] configure.ac: Change in build system to use the path from pkg-config for wayland-scanner.

2014-05-19 Thread Srivardhan Hebbar
This is a fix to the bug https://bugs.freedesktop.org/show_bug.cgi?id=78688. Signed-off-by: Srivardhan Hebbar sri.heb...@samsung.com --- Makefile.am |6 +++--- configure.ac | 13 - 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/Makefile.am b/Makefile.am index

Re: [PATCH v3] configure.ac: Change in build system to use the path from pkg-config for wayland-scanner.

2014-05-19 Thread Thierry Reding
On Mon, May 19, 2014 at 11:59:51AM +0300, Pekka Paalanen wrote: On Sun, 18 May 2014 00:39:16 +0200 Thierry Reding thierry.red...@gmail.com wrote: [...] One issue here is that if --disable-scanner is specified, then the wayland-scanner binary is neither built nor installed. That

Re: [PATCH v3] configure.ac: Change in build system to use the path from pkg-config for wayland-scanner.

2014-05-19 Thread Pekka Paalanen
On Mon, 19 May 2014 11:56:39 +0200 Thierry Reding thierry.red...@gmail.com wrote: On Mon, May 19, 2014 at 11:59:51AM +0300, Pekka Paalanen wrote: On Sun, 18 May 2014 00:39:16 +0200 Thierry Reding thierry.red...@gmail.com wrote: [...] be made to behave the same way. I think a more

Re: [PATCH v3] configure.ac: Change in build system to use the path from pkg-config for wayland-scanner.

2014-05-19 Thread Thierry Reding
On Mon, May 19, 2014 at 01:39:24PM +0300, Pekka Paalanen wrote: On Mon, 19 May 2014 11:56:39 +0200 Thierry Reding thierry.red...@gmail.com wrote: On Mon, May 19, 2014 at 11:59:51AM +0300, Pekka Paalanen wrote: On Sun, 18 May 2014 00:39:16 +0200 Thierry Reding thierry.red...@gmail.com

Re: [PATCH v3] configure.ac: Change in build system to use the path from pkg-config for wayland-scanner.

2014-05-19 Thread Pekka Paalanen
On Mon, 19 May 2014 15:11:01 +0200 Thierry Reding thierry.red...@gmail.com wrote: On Mon, May 19, 2014 at 01:39:24PM +0300, Pekka Paalanen wrote: On Mon, 19 May 2014 11:56:39 +0200 Thierry Reding thierry.red...@gmail.com wrote: On Mon, May 19, 2014 at 11:59:51AM +0300, Pekka Paalanen

[PATCH 5/5] Make wayland-scanner.pc sysroot aware

2014-05-19 Thread Thierry Reding
From: Thierry Reding tred...@nvidia.com The pkgdatadir variable is used to find data files installed by wayland. If wayland is installed in a sysroot, the path to this directory needs to be prefixed with the sysroot to make sure the proper files are found. ${pc_sysrootdir} is expanded to the

[PATCH 2/5] Remove wayland_protocoldir definition

2014-05-19 Thread Thierry Reding
From: Thierry Reding tred...@nvidia.com This is mostly useless and can be confusing in makefiles. The pattern rules defined in the makefile snippet are generic enough to allow the protocol sources to reside in subdirectories. Signed-off-by: Thierry Reding tred...@nvidia.com ---

[PATCH 1/5] Always build wayland-scanner

2014-05-19 Thread Thierry Reding
From: Thierry Reding tred...@nvidia.com When cross-compiling, wayland-scanner cannot be used to generate files because it is built for the host architecture. To overcome this, users currently need to instruct the build not to create wayland-scanner and provide a native variant in the PATH. This

[PATCH 3/5] Improve wayland-scanner m4 rules

2014-05-19 Thread Thierry Reding
From: Thierry Reding tred...@nvidia.com When cross-compiling always look up the wayland-scanner binary in the PATH. Using the value from the wayland-scanner.pc file will not work because it will point to a binary built for the host. While trying to find the path of the wayland-scanner makefile

[PATCH 4/5] Dogfood wayland-scanner makefile snippet

2014-05-19 Thread Thierry Reding
From: Thierry Reding tred...@nvidia.com To reduce code duplication and make sure it receives at minimum amount of testing, use the wayland-scanner makefile snippet in this package. Signed-off-by: Thierry Reding tred...@nvidia.com --- Makefile.am | 9 + 1 file changed, 1 insertion(+), 8

[PATCH weston 1/4] Handle requests using outputs that have been unplugged

2014-05-19 Thread Neil Roberts
Previously when an output was unplugged the clients' resources for it were left around and if they were used in a request it could cause Weston to access invalid memory. Now when an output is unplugged the resources for it are marked as zombies. This is done by setting a dummy dispatcher and

[PATCH 2/4] Add a release request to wl_output

2014-05-19 Thread Neil Roberts
Outputs can come and go within the compositor. If we don't have a way for the client to destroy the resource then the resources within the compositor will effectively leak until the client disconnects. This is similar to the release event for wl_pointer. --- protocol/wayland.xml | 8 +++- 1

[PATCH weston 4/4] Handle wl_output.release

2014-05-19 Thread Neil Roberts
The wl_output.release request is now handled. It just causes the resource to be destroyed. This is also set as the destructor when zombifying the resource. --- src/compositor.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/src/compositor.c

[PATCH 3/4] Add a macro to get the opcode number of a request given the interface

2014-05-19 Thread Neil Roberts
This adds a macro called WL_REQUEST_OPCODE which takes the name of the struct for the interface and the name of one of its members. It then calculates the opcode number by dividing the offsetof the member by the size of a function pointer. This assumes the interface struct only contains function

Re: [PATCH weston 1/4] Handle requests using outputs that have been unplugged

2014-05-19 Thread Jason Ekstrand
Neil, Looks good except for the two comments below --Jason On Mon, May 19, 2014 at 12:23 PM, Neil Roberts n...@linux.intel.com wrote: Previously when an output was unplugged the clients' resources for it were left around and if they were used in a request it could cause Weston to access

Re: [PATCH weston 1/4] Handle requests using outputs that have been unplugged

2014-05-19 Thread Jason Ekstrand
One more comment On Mon, May 19, 2014 at 3:04 PM, Jason Ekstrand ja...@jlekstrand.netwrote: Neil, Looks good except for the two comments below --Jason On Mon, May 19, 2014 at 12:23 PM, Neil Roberts n...@linux.intel.comwrote: Previously when an output was unplugged the clients' resources

Re: [PATCH 2/4] Add a release request to wl_output

2014-05-19 Thread Jason Ekstrand
Yup, we need this. Reviewed-By: Jason Ekstrand ja...@jlekstrand.net On Mon, May 19, 2014 at 12:26 PM, Neil Roberts n...@linux.intel.com wrote: Outputs can come and go within the compositor. If we don't have a way for the client to destroy the resource then the resources within the

Re: [PATCH 3/4] Add a macro to get the opcode number of a request given the interface

2014-05-19 Thread Jason Ekstrand
Ooh, I like this. I thought about having wayland-scanner emit more #defines, but this works rather nicely. One question: do we want it in wayland-util or wayland-server? Putting it in wayland-util exposes it client-side as well. --Jason On Mon, May 19, 2014 at 12:26 PM, Neil Roberts

Re: [PATCH weston 4/4] Handle wl_output.release

2014-05-19 Thread Jason Ekstrand
Looks good to me. Reviewed-By: Jason Ekstrand ja...@jlekstrand.net On Mon, May 19, 2014 at 12:27 PM, Neil Roberts n...@linux.intel.com wrote: The wl_output.release request is now handled. It just causes the resource to be destroyed. This is also set as the destructor when zombifying the

Re: [PATCH wayland-web] Added depencies and bug fixes to build instructions

2014-05-19 Thread Bill Spitzak
On 05/19/2014 12:43 AM, Pekka Paalanen wrote: Oh, in fact there would be room for quite much of splitting here, like the pre-boxing and adding $ to commands could be a separate patch, and therefore much easier to get in while the rest may still be discussed. Changes are to be split into

Re: [PATCH wayland-web] Added depencies and bug fixes to build instructions

2014-05-19 Thread Bill Spitzak
On 05/19/2014 12:39 AM, Pekka Paalanen wrote: On Fri, 16 May 2014 13:43:50 -0700 spit...@gmail.com wrote: From: spitzak spit...@gmail.com This is based on several experimental runs on two different Ubuntu 12.04 machines. Latest version includes instructions for a recent update of Mesa

[PATCH weston-ivi-shell v5 0/9] a reference shell for In-Vehicle Infotainment system

2014-05-19 Thread Nobuhiko Tanibata
2014-04-26 01:05 に Pekka Paalanen さんは書きました: On Fri, 25 Apr 2014 22:34:27 +0900 Nobuhiko Tanibata nobuhiko_tanib...@xddp.denso.co.jp wrote: 2014-04-23 19:40 に Pekka Paalanen さんは書きました: This is looking good, mostly just some details in the wording to be tuned. :-) I will see if I can review

[PATCH weston-ivi-shell v5 1/9] protocol: add interface ivi_application extension

2014-05-19 Thread Nobuhiko Tanibata
ivi_applicatoin extension creates ivi_surface objects tied to a given wl_surface with a given id. The given id can be used in a shell to identify which application is assigned to a wl_surface and layout the surface wherever the shell wants. ivi_surface objects can be used to receive status of

[PATCH weston-ivi-shell v5 2/9] ivi-shell: add the shell plugin for In-Vehicle Infotainment system

2014-05-19 Thread Nobuhiko Tanibata
In-Vehicle Infotainment system traditionally manages surfaces with global identification. A protocol, ivi_application, supports such a feature by implementing a request, ivi_application::surface_creation defined in ivi_application.xml. The ivi-shell explicitly loads ivi-layout.so and a module to

[PATCH weston-ivi-shell v5 4/9] protocol: ivi hmi controller protocol to set up IVI style UI

2014-05-19 Thread Nobuhiko Tanibata
This protocol realizes following features, - UI ready - changing modes; tiling, side by side, full_screen, and random - Give control a surface; workspace to be controlled by using ivi layout APIs - Display/undisplay a surface; home contains sevaral workspaces to launch application

[PATCH weston-ivi-shell v5 6/9] clients: a reference implementation of UI client how to use ivi-hmi-controller.

2014-05-19 Thread Nobuhiko Tanibata
This is launched from hmi-controller by launch_hmi_client_process and invoke a client process. The basic flow is as followed, 1/ process invoked 2/ read configuration from weston.ini. 3/ draw png file to surface according to configuration of weston.ini 4/ all parts of UI are ready. request

[PATCH weston-ivi-shell v5 7/9] data: add reference image files for weston-ivi-shell-user-interface

2014-05-19 Thread Nobuhiko Tanibata
Signed-off-by: Nobuhiko Tanibata nobuhiko_tanib...@xddp.denso.co.jp --- Changes for v2: - squash Makefile to this patch Changes for v3, v4, and v5: - nothing. Version number aligned to the first patch data/Makefile.am | 14 +- data/background.png | Bin 0 -

[PATCH weston-ivi-shell v5 8/9] ivi-shell: a reference of weston.ini for ivi-shell and ivi-hmi-controller.

2014-05-19 Thread Nobuhiko Tanibata
Signed-off-by: Nobuhiko Tanibata nobuhiko_tanib...@xddp.denso.co.jp --- Changes for v2: - squash Makefile to this patch Changes for v3 and v4: - nothing. Version number aligned to the first patch Changes for v5: - rebase weston v1.5 branch Makefile.am | 13 +--

[PATCH weston-ivi-shell v5 9/9] clients: modify example clients to support ivi-application.xml

2014-05-19 Thread Nobuhiko Tanibata
Signed-off-by: Nobuhiko Tanibata nobuhiko_tanib...@xddp.denso.co.jp --- Changes for v2, v3 and v4: - nothing. Version number aligned to the first patch Changes for v5: - rebase weston v1.5 branch - remove Macros to enable ivi-application Makefile.am | 12 ++--

Re: [PATCH weston-ivi-shell v5 7/9] data: add reference image files for weston-ivi-shell-user-interface

2014-05-19 Thread Nobuhiko Tanibata
Hi, I removed binary from patch as review comment. Image files can be downloaded from, https://github.com/ntanibata/weston-ivi-shell/tree/weston-ivi-shell-1.4.93-v3/data BR, Nobuhiko 2014-05-20 13:30 に Nobuhiko Tanibata さんは書きました: Signed-off-by: Nobuhiko Tanibata

Re: [PATCH weston-ivi-shell v4 1/9] ivi application protocol:

2014-05-19 Thread Nobuhiko Tanibata
2014-04-23 19:40 に Pekka Paalanen さんは書きました: Hi, it's been a long while since I have looked at this, but I got a bit of time to come back. I hope you haven't abandoned this effort yet. :-) I looked at the PDF from your post on March 6th, 2014, and some of my own comments I gave at that time to

Re: [PATCH weston-ivi-shell v5 2/9] The weston-layout library supports

2014-05-19 Thread Nobuhiko Tanibata
Hi, I apply review comments as v5 except following comments. + +struct link_layerPropertyNotification { +layerPropertyNotificationFunc callback; +void *userdata; +struct wl_list link; +}; + +struct link_surfacePropertyNotification { +surfacePropertyNotificationFunc callback; +

Re: [PATCH weston-ivi-shell v4 3/9] ivi-shell supports a type of shell for In-Vehicle Infotainment system.

2014-05-19 Thread Nobuhiko Tanibata
Hi pq, I applied your comments except for several ones, +struct ivi_shell *shell = wl_resource_get_user_data(resource); +struct ivi_shell_surface *ivisurf = NULL; +struct weston_layout_surface *layout_surface = NULL; +struct weston_surface *es =

Re: [PATCH weston-ivi-shell v4 4/9] A reference protocol of ivi hmi controller to set up IVI style UI.

2014-05-19 Thread Nobuhiko Tanibata
Hi pq, I apply your comment in v5. I remove several request because it can be handled without request by identifying it by ivi_id. I add description more as well. BR, Nobuhiko 2014-04-25 18:46 に Pekka Paalanen さんは書きました: On Mon, 17 Mar 2014 15:27:46 +0900 Nobuhiko Tanibata