[PATCH libinput] touchpad: Drop the scroll direction lock, increase threshold instead

2014-06-03 Thread Peter Hutterer
The direction lock was intended to avoid erroneous horizontal scroll events when scrolling vertically (and vice versa). Some testing on my touchpad here shows that it is too easy to accidentally lock the direction when no lock is intended (e.g. moving around an image). And quite hard to figure out

[PATCH] connection: remove unreached code

2014-06-03 Thread Boyan Ding
--- src/connection.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/connection.c b/src/connection.c index 47ee556..f292853 100644 --- a/src/connection.c +++ b/src/connection.c @@ -379,8 +379,6 @@ wl_connection_queue(struct wl_connection *connection, } return wl_buffer_p

Re: [PATCH] s/libinput_pointer_button_state/libinput_button_state/

2014-06-03 Thread Peter Hutterer
On Tue, Jun 03, 2014 at 08:08:02PM -0400, Stephen Chandler Paul wrote: > Button states are applicable to more then just the pointer, so having a > non-generic name name for a generic enumerator value like > libinput_pointer_button_state doesn't make sense. Changing it to something > generic like li

Re: [PATCH libinput 02/10] Add an interface to enable/disable tapping

2014-06-03 Thread Peter Hutterer
On Tue, Jun 03, 2014 at 10:41:16PM +0200, Jonas Ådahl wrote: > On Tue, Jun 03, 2014 at 03:34:55PM +1000, Peter Hutterer wrote: > > Provide an interface to enable/disable tapping, with a default mapping of > > 1/2/3 fingers mapping to L/R/M button events, respectively. > > > > Signed-off-by: Peter

[PATCH] s/libinput_pointer_button_state/libinput_button_state/

2014-06-03 Thread Stephen Chandler Paul
Button states are applicable to more then just the pointer, so having a non-generic name name for a generic enumerator value like libinput_pointer_button_state doesn't make sense. Changing it to something generic like libinput_button_state allows it to be reused by other devices that may potentiall

Re: Weston multitouch support?

2014-06-03 Thread Peter Hutterer
On Tue, Jun 03, 2014 at 02:13:47PM +0200, Shawn Rutledge wrote: > On 3 June 2014 13:16, Peter Hutterer wrote: > > On 3/06/2014 20:25 , Shawn Rutledge wrote: > ... > > the synaptics driver does support multitouch and gives you the same type of > > events as any MT device will (if you disable the in

Re: [PATCH libinput] Add our own version of linux/input.h

2014-06-03 Thread Peter Hutterer
On Tue, Jun 03, 2014 at 11:23:07AM -0400, Jasper St. Pierre wrote: > Just have people shoot an email saying "hey, we'd like to add a constant > for this". Talking to each other is really all we need to do, no need to > make it any more formal. indeed. and there's a high chance that if another OS n

Re: [PATCH libinput] Add our own version of linux/input.h

2014-06-03 Thread Peter Hutterer
On Tue, Jun 03, 2014 at 08:54:38AM -0400, Jasper St. Pierre wrote: > I think it should be #include "linux/input.h" at the very least. > has always meant "system library" to me. amended locally, thanks. Cheers, Peter > On Tue, Jun 3, 2014 at 5:34 AM, Peter Hutterer > wrote: > > > On 3/06/20

Re: [PATCH libinput 03/10] touchpad: hook up to the tapping configuration

2014-06-03 Thread Peter Hutterer
On Tue, Jun 03, 2014 at 10:42:50PM +0200, Jonas Ådahl wrote: > On Tue, Jun 03, 2014 at 03:34:56PM +1000, Peter Hutterer wrote: > > Now that we have run-time changes of the tap.enabled state move the check > > to the IDLE state only. Otherwise the tap machine may hang if tapping is > > disabled whil

Re: [PATCH libinput 03/10] touchpad: hook up to the tapping configuration

2014-06-03 Thread Jasper St. Pierre
On Tue, Jun 3, 2014 at 4:42 PM, Jonas Ådahl wrote: > On Tue, Jun 03, 2014 at 03:34:56PM +1000, Peter Hutterer wrote: > > Now that we have run-time changes of the tap.enabled state move the check > > to the IDLE state only. Otherwise the tap machine may hang if tapping is > > disabled while a gest

Re: [PATCH libinput 03/10] touchpad: hook up to the tapping configuration

2014-06-03 Thread Jonas Ådahl
On Tue, Jun 03, 2014 at 03:34:56PM +1000, Peter Hutterer wrote: > Now that we have run-time changes of the tap.enabled state move the check > to the IDLE state only. Otherwise the tap machine may hang if tapping is > disabled while a gesture is in progress. > > Two basic tests are added to check f

Re: [PATCH libinput 01/10] Add an enum for configuration return codes

2014-06-03 Thread Jonas Ådahl
On Tue, Jun 03, 2014 at 03:34:54PM +1000, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- > src/libinput.h | 32 > 1 file changed, 32 insertions(+) > > diff --git a/src/libinput.h b/src/libinput.h > index d771e21..c9ec71a 100644 > --- a/src/libinput.h

Re: [PATCH libinput 02/10] Add an interface to enable/disable tapping

2014-06-03 Thread Jonas Ådahl
On Tue, Jun 03, 2014 at 03:34:55PM +1000, Peter Hutterer wrote: > Provide an interface to enable/disable tapping, with a default mapping of > 1/2/3 fingers mapping to L/R/M button events, respectively. > > Signed-off-by: Peter Hutterer > --- > src/libinput-private.h | 13 + > src/libinpu

Re: [PATCH libinput] Add our own version of linux/input.h

2014-06-03 Thread Jonas Ådahl
On Tue, Jun 03, 2014 at 08:08:15AM +1000, Peter Hutterer wrote: > Avoids having to #define any values we're trying to use. > > Header file is from Linux 3.15-rc8. Changing to "linux/input.h" or not, the patch looks correct to me, so Reviewed-by: Jonas Ådahl > > Signed-off-by: Peter Hutterer

[PATCH wayland-web 5/7] Added a 'running weston' chapter

2014-06-03 Thread Bill Spitzak
From: Bill Spitzak Moved $XDG_RUNTIME_DIR into it. --- building.html | 105 +++-- 1 file changed, 57 insertions(+), 48 deletions(-) diff --git a/building.html b/building.html index d0ddccf..6870a8b 100644 --- a/building.html +++ b/building.ht

[PATCH wayland-web 4/7] Added page of Ubuntu12.04 specific directions

2014-06-03 Thread Bill Spitzak
From: Bill Spitzak --- building.html| 19 +++- ubuntu12.04.html | 291 ++ 2 files changed, 307 insertions(+), 3 deletions(-) create mode 100644 ubuntu12.04.html diff --git a/building.html b/building.html index 57ee2fb..d0ddccf 100644 -

[PATCH wayland-web 7/7] Added links to the online versions of git repositories

2014-06-03 Thread Bill Spitzak
Also fixed drm git repository to what I think is the correct one, as it has one later commit than the one given in the old instructions. --- building.html | 26 ++ xserver.html | 14 -- 2 files changed, 22 insertions(+), 18 deletions(-) diff --git a/buildi

[PATCH wayland-web 6/7] Added comments about dependencies after each build instruction

2014-06-03 Thread Bill Spitzak
From: Bill Spitzak Added many links to various project home pages when I could find them. --- building.html| 93 +++--- ubuntu12.04.html |2 +- xserver.html | 27 3 files changed, 83 insertions(+), 39 deletions(-)

[PATCH wayland-web 2/7] Simple updates to Weston build instructions

2014-06-03 Thread Bill Spitzak
From: Bill Spitzak - $WLD/bin must be on the path - Put info about system-wide install in one place - Removed drm, libxkbcommon, pixman, cairo as distributed versions are usable nowadays. - Added libinput --- building.html | 167 +++-- 1

[PATCH wayland-web 3/7] Fixed xserver build instructions

2014-06-03 Thread Bill Spitzak
From: Bill Spitzak - Removed xtrans as it is no different than other dependencies - Added comment from commit message about new configure line - Fix for bug in libepoxy configure --- building.html |2 +- xserver.html | 53 + 2 files ch

[PATCH wayland-web 0/7] Version 6 of build instructions patch

2014-06-03 Thread Bill Spitzak
Only difference from last patch is to fix a typo where "/font" was mistakenly replaced with "/span" outside an html command. Changes the on-line build instructions to fix errors, enable libinput, and remove compilation of stuff that is available from repositories on modern systems, and to add a

[PATCH wayland-web 1/7] Put a box around all code samples

2014-06-03 Thread Bill Spitzak
From: Bill Spitzak Added "comment" css class to colorize comments --- wayland.css |2 ++ 1 file changed, 2 insertions(+) diff --git a/wayland.css b/wayland.css index 7f058ba..d7ef79f 100644 --- a/wayland.css +++ b/wayland.css @@ -8,3 +8,5 @@ a { color: #444; } a:hover { color: #888; } a:v

Re: [PATCH wayland-web 4/7] Added page of Ubuntu12.04 specific directions

2014-06-03 Thread Bill Spitzak
Thanks! Yes that was a bad global search and replace when I tried to insert the "span" html command in place of "font". On 06/02/2014 11:42 PM, Bryce W. Harrington wrote: On Fri, May 30, 2014 at 02:12:32PM -0700, Bill Spitzak wrote: From: Bill Spitzak --- building.html| 19 +++- ubu

Re: [PATCH libinput] Add our own version of linux/input.h

2014-06-03 Thread Jasper St. Pierre
Just have people shoot an email saying "hey, we'd like to add a constant for this". Talking to each other is really all we need to do, no need to make it any more formal. On Tue, Jun 3, 2014 at 11:17 AM, Thiago Macieira wrote: > Em ter 03 jun 2014, às 19:32:06, Peter Hutterer escreveu: > > > Th

Re: [PATCH libinput] Add our own version of linux/input.h

2014-06-03 Thread Thiago Macieira
Em ter 03 jun 2014, às 19:32:06, Peter Hutterer escreveu: > > The current situation is vague, and this patch probably is not intended > > to fix that at all, but is there a plan? Or is it expected that other > > OSs implement their own libinput or something? > > No, other OS can use libinput, they

Re: [PATCH libinput] Add our own version of linux/input.h

2014-06-03 Thread Thiago Macieira
Em ter 03 jun 2014, às 08:54:38, Jasper St. Pierre escreveu: > I think it should be #include "linux/input.h" at the very least. > has always meant "system library" to me. That distinction is blurred when you have third-party libraries. "" is actually meant for "headers in my project" because it

Re: [PATCH libinput] Add our own version of linux/input.h

2014-06-03 Thread Jasper St. Pierre
I think it should be #include "linux/input.h" at the very least. has always meant "system library" to me. On Tue, Jun 3, 2014 at 5:34 AM, Peter Hutterer wrote: > On 3/06/2014 17:06 , Thiago Macieira wrote: > >> Em ter 03 jun 2014, às 16:56:35, Peter Hutterer escreveu: >> >>> On Mon, Jun 02, 20

Re: [PATCH] weston: Fix memleak issue in compositor.c

2014-06-03 Thread Hardening
Le 27/05/2014 11:00, Srivardhan Hebbar a écrit : > This fix is upon "Hardening " patch. [PATCH 2/2] Handle > OOM with signal events. > LGTM Reviewed-by: Hardening > Signed-off-by: Srivardhan Hebbar > --- > src/compositor.c | 23 +-- > 1 file changed, 17 insertions(+), 6

Re: Weston multitouch support?

2014-06-03 Thread Peter Hutterer
On 3/06/2014 20:25 , Shawn Rutledge wrote: On 3 June 2014 01:25, Peter Hutterer wrote: On Mon, Jun 02, 2014 at 12:45:51PM +0100, José Expósito wrote: Hi Peter, I have checked the libinput implementation and, correct me if I'm wrong, I have seen that 2 fingers click is interpreted as right cli

Re: Weston multitouch support?

2014-06-03 Thread Peter Hutterer
On 3/06/2014 19:43 , José Expósito wrote: Hi Peter, Thank you very much for your answers > there are some special rules for clickpads, specifically a click with a > finger resting on one of the software-button areas will produce a right > or middle click. > [...] > eventually yes, but not

Re: Weston multitouch support?

2014-06-03 Thread José Expósito
Hi Peter, Thank you very much for your answers > there are some special rules for clickpads, specifically a click with a > finger resting on one of the software-button areas will produce a right > or middle click. > [...] > eventually yes, but not at this point. as I said in the previous email yo

Re: [PATCH libinput] Add our own version of linux/input.h

2014-06-03 Thread Peter Hutterer
On 3/06/2014 17:06 , Thiago Macieira wrote: Em ter 03 jun 2014, às 16:56:35, Peter Hutterer escreveu: On Mon, Jun 02, 2014 at 10:01:20PM -0700, Thiago Macieira wrote: Em ter 03 jun 2014, às 08:08:15, Peter Hutterer escreveu: Avoids having to #define any values we're trying to use. Header file

Re: [PATCH libinput] Add our own version of linux/input.h

2014-06-03 Thread Peter Hutterer
On 3/06/2014 17:21 , Pekka Paalanen wrote: On Tue, 03 Jun 2014 00:06:40 -0700 Thiago Macieira wrote: Em ter 03 jun 2014, às 16:56:35, Peter Hutterer escreveu: On Mon, Jun 02, 2014 at 10:01:20PM -0700, Thiago Macieira wrote: Em ter 03 jun 2014, às 08:08:15, Peter Hutterer escreveu: Avoids ha

Re: [PATCH libinput] Add our own version of linux/input.h

2014-06-03 Thread Jonas Ådahl
On Tue, Jun 03, 2014 at 10:21:07AM +0300, Pekka Paalanen wrote: > On Tue, 03 Jun 2014 00:06:40 -0700 > Thiago Macieira wrote: > > > Em ter 03 jun 2014, às 16:56:35, Peter Hutterer escreveu: > > > On Mon, Jun 02, 2014 at 10:01:20PM -0700, Thiago Macieira wrote: > > > > Em ter 03 jun 2014, às 08:08

Re: [PATCH wayland-web 0/7] Version 5 of build instructions patch

2014-06-03 Thread Bryce W. Harrington
On Fri, May 30, 2014 at 02:12:28PM -0700, Bill Spitzak wrote: > This is a duplicate posting but I removed the in-reply-to because that seems > to have hidden it, as there have been no comments. > > Changes are to incorporate the patches from Pekka Paalanen, removing > incorrect changes I made, a

Re: [PATCH libinput] Add our own version of linux/input.h

2014-06-03 Thread Pekka Paalanen
On Tue, 03 Jun 2014 00:06:40 -0700 Thiago Macieira wrote: > Em ter 03 jun 2014, às 16:56:35, Peter Hutterer escreveu: > > On Mon, Jun 02, 2014 at 10:01:20PM -0700, Thiago Macieira wrote: > > > Em ter 03 jun 2014, às 08:08:15, Peter Hutterer escreveu: > > > > Avoids having to #define any values we

Re: [PATCH weston] compositor: raise errors when bad scale or transform values are used

2014-06-03 Thread Pekka Paalanen
On Fri, 30 May 2014 12:07:15 +0200 Jonny Lamb wrote: > --- > src/compositor.c | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/src/compositor.c b/src/compositor.c > index 574db2d..3c5c8e3 100644 > --- a/src/compositor.c > +++ b/src/compositor.c > @@ -2138,6 +2138,16

Re: [PATCH libinput] Add our own version of linux/input.h

2014-06-03 Thread Thiago Macieira
Em ter 03 jun 2014, às 16:56:35, Peter Hutterer escreveu: > On Mon, Jun 02, 2014 at 10:01:20PM -0700, Thiago Macieira wrote: > > Em ter 03 jun 2014, às 08:08:15, Peter Hutterer escreveu: > > > Avoids having to #define any values we're trying to use. > > > > > > Header file is from Linux 3.15-rc8.

Re: [PATCH wayland 2/2] protocol: add wl_surface errors enum for bad scale and transform values

2014-06-03 Thread Pekka Paalanen
On Fri, 30 May 2014 12:08:16 +0200 Jonny Lamb wrote: > --- > protocol/wayland.xml | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/protocol/wayland.xml b/protocol/wayland.xml > index 3091d83..951aafc 100644 > --- a/protocol/wayland.xml > +++ b/protocol/wayland.xml > @@