Re: [PATCH wayland] client: add a public function to make a roundtrip on a custom queue

2014-07-16 Thread Giulio Camuffo
2014-07-15 20:39 GMT+03:00 Daniel Stone : > Hi, > > > On Tuesday, July 15, 2014, Giulio Camuffo wrote: >> >> 2014-07-14 22:31 GMT+03:00 Jason Ekstrand : >> > Guilio, >> > Would it be better to name it wl_event_queue_roundtrip and just have it >> > take >> > the wl_event_queue? I guess it is sort-

Re: [PATCH 1/3] tests: add expect_protocol_error function

2014-07-16 Thread Marek Chalupa
Hi, I fixed the comment as Bryce wrote (s/came/come) and fixed a white-space error. The logic of this version of the patch is equivalent to the old one. Thanks, Marek On 7 July 2014 20:41, Bryce W. Harrington wrote: > On Mon, Jul 07, 2014 at 05:47:41PM +0300, Pekka Paalanen wrote: > > On Thu,

[PATCH 1/3] tests: add expect_protocol_error function

2014-07-16 Thread Marek Chalupa
This function checks if a particular protocol error came in wire. It's usefull in the cases where we hitherto used FAIL_TEST. The problem with FAIL_TEST is that *any* assert will pass the test, but we want only some asserts to pass the test (i. e. we don't want the test to pass when it, for example

[PATCH v2 2/3] tests: add frame_callback_wait_nofail

2014-07-16 Thread Marek Chalupa
With expect_protocol_error, we need a possibility to wait for a frame without aborting the test when wl_display_dispatch returns -1; This patch adds function frame_callback_wait_nofail that only returns 1 or 0 (instead of aborting on error). --- tests/weston-test-client-helper.c | 9 ++--- tes

[PATCH v2 3/3] tests: use expect_protocol_error in tests

2014-07-16 Thread Marek Chalupa
Turn FAIL_TESTs to TESTs. FAIL_TESTs are bad... --- tests/bad-buffer-test.c | 35 +-- tests/subsurface-test.c | 40 2 files changed, 29 insertions(+), 46 deletions(-) diff --git a/tests/bad-buffer-test.c b/tests/bad-buffer-t

Re: New guy

2014-07-16 Thread Magnus Hoff
Hi Jasper :) Thanks for your response! :) On Tue, Jul 15, 2014 at 1:59 PM, Jasper St. Pierre wrote: > On Tue, Jul 15, 2014 at 7:48 AM, Magnus Hoff > wrote: >> * Support for (sub-)pixel resolution of two-finger scroll. In X.org, >> two-finger scroll is mapped to button-events, which means that t

Re: New guy

2014-07-16 Thread Stefanos A.
2014-07-16 14:14 GMT+02:00 Magnus Hoff : > Hi Jasper :) Thanks for your response! :) > > On Tue, Jul 15, 2014 at 1:59 PM, Jasper St. Pierre > wrote: > > On Tue, Jul 15, 2014 at 7:48 AM, Magnus Hoff > > wrote: > >> * Support for (sub-)pixel resolution of two-finger scroll. In X.org, > >> two-fin

[PATCH 3/4] add get_geometry & geometry request/event

2014-07-16 Thread Marek Chalupa
--- protocol/wayland-test.xml | 11 +++ tests/weston-test-client-helper.c | 18 ++ tests/weston-test-client-helper.h | 6 ++ tests/weston-test.c | 23 +++ 4 files changed, 58 insertions(+) diff --git a/protocol/wayland-test.xm

Use xdg-shell in tests

2014-07-16 Thread Marek Chalupa
Hi, in this series of patches I added support for xdg-shell/surface to the test-suite. The thing that led me to this is captured in the last patch, that is that maximizing and fullscreening didn't work as expected for really simple client (just bare xdg-surface and nothing more). However, I'm not

[PATCH 1/4] tests: simplify move_client and make it more generic

2014-07-16 Thread Marek Chalupa
Move client right in the move_client funciton. This allows the surface use its own configure function, so from now the client can be any weston surface (xdg, wl_shell, ..) --- tests/weston-test.c | 62 + 1 file changed, 24 insertions(+), 38 delet

[PATCH 2/4] tests: handle xdg events in client

2014-07-16 Thread Marek Chalupa
Bind to xdg-shell, create xdg-surface and handle event comming from it. --- Makefile.am | 4 +- tests/weston-test-client-helper.c | 133 -- tests/weston-test-client-helper.h | 9 +++ 3 files changed, 140 insertions(+), 6 deletions(-) d

[PATCH 4/4] tests: add client test

2014-07-16 Thread Marek Chalupa
Test xdg-shell features. Add tests for maximizing and fullscreening the client. --- Makefile.am | 7 +++- tests/client-test.c | 114 2 files changed, 120 insertions(+), 1 deletion(-) create mode 100644 tests/client-test.c diff --git

Re: [PATCH 10/11] weston-image --help works. Also help if no filename is given

2014-07-16 Thread Bill Spitzak
On 07/09/2014 06:32 PM, Jason Ekstrand wrote: > One little nitpick: Should we really be returning 1 if --help is given? That's not an error. On second thought, I ran a bunch of little utilities and things and some of them always given an error with the usage and others don't. However, if we'

[PATCH libinput 3/8] test: Remove test device from context when deleting

2014-07-16 Thread Jonas Ådahl
Signed-off-by: Jonas Ådahl --- test/litest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/test/litest.c b/test/litest.c index b64c7e3..961b917 100644 --- a/test/litest.c +++ b/test/litest.c @@ -605,6 +605,7 @@ litest_delete_device(struct litest_device *d) return;

[PATCH libinput 5/8] evdev: Early out during configure if not using fallback dispatch

2014-07-16 Thread Jonas Ådahl
The feature set configured otherwise would not work anyway as it would need using the fallback dispatch to function. Signed-off-by: Jonas Ådahl --- src/evdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/evdev.c b/src/evdev.c index f980812..fec24f5 100644 --- a/src/evdev.c +++ b/sr

[PATCH libinput 4/8] test: Don't fail when events are enabled multiple times

2014-07-16 Thread Jonas Ådahl
When overriding events of a test device, if one would enable an event that was already enabled by default for the overridden device, an assert checking if the event was already enabled would fail and cause the test to fail. Since the merging of the default and overriding event lists is implemented

[PATCH libinput 6/8] evdev: Use helper for separating buttons from keys

2014-07-16 Thread Jonas Ådahl
Signed-off-by: Jonas Ådahl --- src/evdev.c | 83 ++--- 1 file changed, 47 insertions(+), 36 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index fec24f5..c031258 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -41,6 +41,12 @@ #define

[PATCH libinput 1/8] test/path: Avoid creating ignored test devices

2014-07-16 Thread Jonas Ådahl
Some tests doesn't use or doesn't need to use the test device automatically created when adding a test case for certain types of devices. For these tests, to shorten test run time, don't create the test devices that would be ignored. Signed-off-by: Jonas Ådahl --- test/path.c | 30 ++

[PATCH libinput 7/8] evdev: Release still pressed keys/buttons when removing device

2014-07-16 Thread Jonas Ådahl
Keep track of pressed keys and buttons in a bitmask array and iterate through it on device removal releasing every still pressed key. This commit enables _GNU_SOURCE features in evdev.c, more specifically static_assert(). This is supported by gcc 4.6 and above, but is not part of the C standard un

[PATCH libinput 8/8] touchpad: Use evdev_pointer_notify_button()

2014-07-16 Thread Jonas Ådahl
Make use of the key mask in struct evdev_device to keep track of pressed buttons. Signed-off-by: Jonas Ådahl --- src/evdev-mt-touchpad-buttons.c | 24 src/evdev-mt-touchpad-tap.c | 8 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/src/evde

[PATCH libinput 2/8] test: Use only one test device for some udev and path tests

2014-07-16 Thread Jonas Ådahl
Some tests in test/path.c and test/udev.c are not dependent on device behaviour but rather managing of device lifetime etc. Run those tests only once with only one device, resulting more or less the same code coverage but shorter run time. Signed-off-by: Jonas Ådahl --- test/litest.c | 65 ++

Re: [PATCH wayland] protocol: add repeat_info event to wl_keyboard

2014-07-16 Thread Jonny Lamb
(finally got around to looking at this again) On Mon, 2 Jun 2014 10:22:40 +0300 Pekka Paalanen wrote: > this looks good to me, but I'd like to see text about when this event > is sent. I assume it is sent once as soon as a wl_keyboard object has > been created, and this is also required/guaranteed

[PATCH wayland] protocol: add repeat_info event to wl_keyboard

2014-07-16 Thread Jonny Lamb
In the process wl_keyboard's version has been incremented. Given clients get the wl_keyboard from wl_seat without a version, wl_seat's version has also been incremented (wl_seat version 4 implies wl_keyboard version 4). --- protocol/wayland.xml | 28 ++-- 1 file changed, 26

Re: [PATCH weston] input: send wl_keyboard.repeat_info with rate and delay info

2014-07-16 Thread Jonny Lamb
On lun, 2014-06-02 at 10:43 +0300, Pekka Paalanen wrote: > Looks good, only few comments there. They should all be fixed now. -- Jonny Lamb ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

[PATCH weston] input: send wl_keyboard.repeat_info with rate and delay info

2014-07-16 Thread Jonny Lamb
The compositor reads the values out from weston.ini, the weston compositor passes on the values, the weston-info client prints out the values, and the values are respected in toytoolkit. --- clients/weston-info.c| 89 +++- clients/window.c |

[PATCH weston 3/3] shell: constrain resize grabs so windows don't go under the panel

2014-07-16 Thread Jonny Lamb
https://bugs.freedesktop.org/show_bug.cgi?id=80228 --- desktop-shell/shell.c | 28 1 file changed, 28 insertions(+) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index e51c299..e0f001d 100644 --- a/desktop-shell/shell.c +++ b/desktop-shell/shell.c @@ -175

[PATCH weston 2/3] desktop-shell: use panel location to calculate correct sizes and ranges

2014-07-16 Thread Jonny Lamb
Now the client can let us know where the panel is using desktop_shell.set_panel_position, we can correctly calculate where to put new views and how big maximized views should be. --- desktop-shell/shell.c | 175 ++ 1 file changed, 120 insertions(+),

[PATCH weston 1/3] desktop-shell: add set_panel_position to help place views onscreen

2014-07-16 Thread Jonny Lamb
Panels are always assumed to be on the top edge of the output. If this is not the case views will be placed under the panel, wherever it is, and maximize doesn't use the correct space allocated for views. By telling the server on which edge the panel is located, it can correctly calculate where to

Re: wl_tablet draft v2

2014-07-16 Thread Lyude
On Mon, 2014-07-14 at 13:25 -0700, Jason Gerecke wrote: > On Sun, Jul 13, 2014 at 12:17 PM, Lyude wrote: > >wl_tablet specifications > > Version 2 > > > > General notes: > > - Many of the axis values in this are normalized to either 0-6

Re: [PATCH libinput 1/2] tablet: Don't swap X and Y in evcode_to_axis()

2014-07-16 Thread Peter Hutterer
On Sun, Jul 13, 2014 at 07:19:28PM -0400, Stephen Chandler Paul wrote: > Signed-off-by: Stephen Chandler Paul pushed, thanks Cheers, Peter > --- > src/evdev-tablet.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/evdev-tablet.h b/src/evdev-tablet.h > index

Re: wl_tablet draft v2

2014-07-16 Thread Peter Hutterer
On Wed, Jul 16, 2014 at 08:08:29PM -0400, Lyude wrote: > On Mon, 2014-07-14 at 13:25 -0700, Jason Gerecke wrote: > > On Sun, Jul 13, 2014 at 12:17 PM, Lyude wrote: > > >wl_tablet specifications > > > Version 2 > > > > > > General notes:

Re: [PATCH libinput 1/8] test/path: Avoid creating ignored test devices

2014-07-16 Thread Peter Hutterer
On Wed, Jul 16, 2014 at 10:39:06PM +0200, Jonas Ådahl wrote: > Some tests doesn't use or doesn't need to use the test device > automatically created when adding a test case for certain types of > devices. For these tests, to shorten test run time, don't create the > test devices that would be ignor

Re: [PATCH libinput 7/8] evdev: Release still pressed keys/buttons when removing device

2014-07-16 Thread Peter Hutterer
On Wed, Jul 16, 2014 at 10:39:12PM +0200, Jonas Ådahl wrote: > Keep track of pressed keys and buttons in a bitmask array and iterate > through it on device removal releasing every still pressed key. fwiw, the kernel should release all keys on disconnect these days, but for the manual removal it's

Re: [PATCH libinput 5/8] evdev: Early out during configure if not using fallback dispatch

2014-07-16 Thread Peter Hutterer
On Wed, Jul 16, 2014 at 10:39:10PM +0200, Jonas Ådahl wrote: > The feature set configured otherwise would not work anyway as it > would need using the fallback dispatch to function. > > Signed-off-by: Jonas Ådahl > --- > src/evdev.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src

Re: [PATCH libinput 2/8] test: Use only one test device for some udev and path tests

2014-07-16 Thread Peter Hutterer
On Wed, Jul 16, 2014 at 10:39:07PM +0200, Jonas Ådahl wrote: > Some tests in test/path.c and test/udev.c are not dependent on > device behaviour but rather managing of device lifetime etc. Run those > tests only once with only one device, resulting more or less the same > code coverage but shorter