Re: [PATCH wayland] Portability: Simple stability improvements and cleanups

2014-09-10 Thread Pekka Paalanen
On Thu, 11 Sep 2014 00:02:48 +0200 Karsten Otto wrote: > A selection of simple patches to improve general stability of wayland. > They are harmless enough to be included anytime, maybe even for 1.6, but no > rush. > Tested on ubuntu 14.04 LTS with wayland/weston (>1.5.92) > > The patches were o

Re: [PATCH] gl-renderer: Add flexible shader generation.

2014-09-10 Thread Gwenole Beauchesne
Hi, 2014-04-08 22:18 GMT+02:00 John Kåre Alsaker : > I need to add lots of shader variants to do color conversions. This is a very valid reason. The original code for YUV to RGB conversion implemented a BT.601 limited color range conversion. It is desired to handle more combinations of (BT.601, B

Re: [PATCH libinput 1/2] Document LIBINPUT_CALIBRATION_MATRIX properly

2014-09-10 Thread Peter Hutterer
On Wed, Sep 10, 2014 at 08:34:17AM +0200, Jonas Ådahl wrote: > On Wed, Sep 10, 2014 at 09:40:57AM +1000, Peter Hutterer wrote: > > Make this part of our API proper and outline the 4 most common examples. > > > > Signed-off-by: Peter Hutterer > > --- > > src/libinput.h | 18 +- > >

[PATCH wayland] Portability: Simple stability improvements and cleanups

2014-09-10 Thread Karsten Otto
A selection of simple patches to improve general stability of wayland. They are harmless enough to be included anytime, maybe even for 1.6, but no rush. Tested on ubuntu 14.04 LTS with wayland/weston (>1.5.92) The patches were originally posted by Philip Withnall in his series of FreeBSD portabi

[PATCH] cosmetic: update comments that refer to weston_surface_update_transform()

2014-09-10 Thread Derek Foreman
weston_surface_update_transform() no longer exists, except in comments. Fix that. --- desktop-shell/shell.c | 2 +- src/compositor-drm.c | 3 +-- src/compositor.c | 4 ++-- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index 3cc

[PATCH] shm: fix error in comment

2014-09-10 Thread Derek Foreman
--- src/wayland-shm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wayland-shm.c b/src/wayland-shm.c index 3fce678..04ba4f2 100644 --- a/src/wayland-shm.c +++ b/src/wayland-shm.c @@ -372,7 +372,7 @@ wl_shm_buffer_get_stride(struct wl_shm_buffer *buffer) * Returns a poi

Re: [PATCH] build: use symbol versioning

2014-09-10 Thread Ran Benita
On Tue, Sep 09, 2014 at 07:08:46PM +0200, Jan Engelhardt wrote: > Symbol versions provide a means by which ELF utilities can determine > whether a program is incompatible with a too-old library version so > that package management tools can autodetect version-based > dependencies and suggest upgrad

Re: [PATCH v2 2/2] xdg-shell: fix maximizing in multi-head setup

2014-09-10 Thread Pekka Paalanen
On Mon, 1 Sep 2014 17:20:33 +0200 Marek Chalupa wrote: > Set the right position of maximized window. Up until now we ignored > output's "position" and were using only the working area > of output which is in output-relative coordinates. This led to > showing the maximized window always on the fi

Re: [PATCH] xdg-shell: update shsurf->output when maximizing

2014-09-10 Thread Pekka Paalanen
On Mon, 8 Sep 2014 12:34:20 +0200 Marek Chalupa wrote: > shsurf->output is the output that user expects the shell surface > is on. When maximizing, we don't have any explicit setting of the output > like in the case of fullscreening, so set the output to the one that > the surface is currently o

[PATCH weston] Partially revert "xdg-shell: Add show_window_menu request"

2014-09-10 Thread Pekka Paalanen
From: Pekka Paalanen This reverts the parts of commit 81ff075bf48c55cd07e37784e20c310fa52ed926 that touch window.c. This brings the toytoolkit window context menus back, until someone implements the xdg-shell equivalent in the compositor. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=82972

Re: [PATCH weston] input: Schedule pointer sprite repaint when cursor is set

2014-09-10 Thread Pekka Paalanen
On Mon, 8 Sep 2014 19:33:41 +0200 Jonas Ådahl wrote: > If a cursor was set with wl_pointer.set_cursor but not in combination > with an action that has the side effect of damaging the region where > the cursor is positioned, it would not be drawn. This patch explicitly > schedules a repaint of th

[PATCH 3/3] client: cancel read in wl_display_read_events() when last_error is set

2014-09-10 Thread Marek Chalupa
Calling wl_display_read_events() after an error should be equivalent to wl_display_cancel_read(), so that display state is consistent. Thanks to Pekka Paalanen for pointing that out. Signed-off-by: Marek Chalupa --- src/wayland-client.c | 13 ++--- 1 file changed, 10 insertions(+), 3 d

[PATCH 1/3] display-test: test if threads are woken up on EAGAIN

2014-09-10 Thread Marek Chalupa
When wl_connection_read() in wl_display_read_events() returns with EAGAIN, we want the sleeping threads to be woken up. Test it! Signed-off-by: Marek Chalupa --- tests/display-test.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/tests/display-test.c

[PATCH 2/3] client: wake-up threads on all return paths from read_events

2014-09-10 Thread Marek Chalupa
If wl_connection_read returned EAGAIN, we must wake up sleeping threads. If we don't do this and the thread calling wl_connection_read won't call wl_display_read_events again, the sleeping threads will sleep indefinitely. Signed-off-by: Marek Chalupa --- src/wayland-client.c | 7 ++- 1 file

Re: [PATCH 3/4] tests: add display test that highlights another bug in read_events

2014-09-10 Thread Marek Chalupa
On 10 September 2014 11:17, Pekka Paalanen wrote: > On Tue, 9 Sep 2014 13:10:48 +0200 > Marek Chalupa wrote: > > > On 4 September 2014 15:17, Pekka Paalanen wrote: > > > > > On Fri, 29 Aug 2014 11:21:30 +0200 > > > Marek Chalupa wrote: > > > > > > > When wl_display_read_events() returns with e

Re: [PATCH 3/4] tests: add display test that highlights another bug in read_events

2014-09-10 Thread Pekka Paalanen
On Tue, 9 Sep 2014 13:10:48 +0200 Marek Chalupa wrote: > On 4 September 2014 15:17, Pekka Paalanen wrote: > > > On Fri, 29 Aug 2014 11:21:30 +0200 > > Marek Chalupa wrote: > > > > > When wl_display_read_events() returns with errno == EAGAIN, we > > > naturally try to call it again. But this ne

Re: [PATCH 3/4] tests: add display test that highlights another bug in read_events

2014-09-10 Thread Marek Chalupa
On 10 September 2014 10:53, Pekka Paalanen wrote: > On Tue, 9 Sep 2014 15:39:35 +0200 > Marek Chalupa wrote: > > > On 9 September 2014 13:10, Marek Chalupa wrote: > > > > > > > > > > > On 4 September 2014 15:17, Pekka Paalanen > > > wrote: > > > > > >> On Fri, 29 Aug 2014 11:21:30 +0200 > > >>

Re: [PATCH 3/4] tests: add display test that highlights another bug in read_events

2014-09-10 Thread Pekka Paalanen
On Tue, 9 Sep 2014 15:39:35 +0200 Marek Chalupa wrote: > On 9 September 2014 13:10, Marek Chalupa wrote: > > > > > > > On 4 September 2014 15:17, Pekka Paalanen > > wrote: > > > >> On Fri, 29 Aug 2014 11:21:30 +0200 > >> Marek Chalupa wrote: > >> > >> > When wl_display_read_events() returns w

Re: [PATCH v2 weston] libinput: normalize WL_CALIBRATION before passing it to libinput

2014-09-10 Thread Pekka Paalanen
On Wed, 10 Sep 2014 08:25:13 +0200 Jonas Ådahl wrote: > On Wed, Sep 10, 2014 at 09:34:52AM +1000, Peter Hutterer wrote: > > On Tue, Sep 09, 2014 at 10:42:26PM +0200, Jonas Ådahl wrote: > > > On a side note, there is still a problem with the current format > > > of WL_CALIBRATION and that is that

Re: [PATCH weston 2/2] main: don't leak option strings

2014-09-10 Thread Pekka Paalanen
On Tue, 09 Sep 2014 12:18:24 -0700 Bill Spitzak wrote: > On 09/08/2014 11:49 PM, Pekka Paalanen wrote: > > > parse_options() already strdups() all strings it returns, which is > > one reason why I would not go removing the strdups. > > You are right it already does that. Did not realize it even

Re: [PATCH libinput 2/2] Document the static udev configuration options we support

2014-09-10 Thread Jonas Ådahl
On Wed, Sep 10, 2014 at 09:40:58AM +1000, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- > src/libinput.h | 32 > 1 file changed, 32 insertions(+) > > diff --git a/src/libinput.h b/src/libinput.h > index 7fde65f..a0e5d4c 100644 > --- a/src/libinput.h