Re: [PATCH V2] wayland.xml: add "enum", "bitfield" and "is_bitfield" attributes

2014-09-22 Thread Pekka Paalanen
On Tue, 23 Sep 2014 13:59:39 +0800 Boyan Ding wrote: > On Mon, 2014-09-22 at 11:27 -0700, Jason Ekstrand wrote: > > > I'm a little unsure. I think trying to completely solve this problem > > in a way that will truly make strongly typed languages happy is > > insanity. That said, I'm cautiously

Re: [PATCH libinput 3/3] touchpad: Disable touchpads on trackpoint activity

2014-09-22 Thread Peter Hutterer
On Mon, Sep 22, 2014 at 09:22:02AM +0200, Hans de Goede wrote: > Hi, > > On 09/22/2014 07:18 AM, Peter Hutterer wrote: > > On Thu, Sep 18, 2014 at 01:11:05PM +0200, Hans de Goede wrote: > >> Some laptops with both a clickpad and a trackpoint have such a large > >> touchpad, > >> that parts of the

[PATCH libinput 4/4] test: add some left-handed tests

2014-09-22 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- test/pointer.c | 128 test/touch.c| 23 + test/touchpad.c | 306 3 files changed, 457 insertions(+) diff --git a/test/pointer.c b/test/pointer.c index f704372..56b6709 10

[PATCH libinput 3/4] touchpad: hook up left-handed configuration

2014-09-22 Thread Peter Hutterer
Tapping and clickfinger is unaffected, physical and software buttons are swapped. The main area of a clickpad remains as left button though. Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad-buttons.c | 17 - src/evdev-mt-touchpad.c | 19 +++ 2 files

[PATCH libinput 1/4] Add configuration option for left-handed behavior

2014-09-22 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/libinput-private.h | 8 ++ src/libinput.c | 37 src/libinput.h | 78 ++ 3 files changed, 123 insertions(+) diff --git a/src/libinput-private.h b/src/libinput-privat

[PATCH libinput 2/4] evdev: hook up left-handed configuration option

2014-09-22 Thread Peter Hutterer
Two separate flags needed, want_left_handed and left_handed to avoid switching to left_handed while a button is still down. Since each backend has a different way of determining whether buttons are down, let them set a function to do exactly that. Then call that function whenever a button release e

Re: [PATCH V2] wayland.xml: add "enum", "bitfield" and "is_bitfield" attributes

2014-09-22 Thread Boyan Ding
On Mon, 2014-09-22 at 11:27 -0700, Jason Ekstrand wrote: > I'm a little unsure. I think trying to completely solve this problem > in a way that will truly make strongly typed languages happy is > insanity. That said, I'm cautiously ok with defining bitfields and > enums as long as we are very ca

[PATCH weston v4] Implement data_device interface destructor

2014-09-22 Thread kabeer khan
window : compare version and call appropriate destructor data-device : change version of creation of data_device_manager and data_device interfaces Signed-off-by: kabeer khan --- clients/window.c | 15 ++- src/data-device.c | 15 ++- 2 files changed, 20 insertions(+), 1

[PATCH] compositor: Refactor weston_output_mode_switch()

2014-09-22 Thread Derek Foreman
This breaks weston_output_mode_switch() into 3 functions: weston_output_mode_set_native() weston_output_mode_switch_to_temporary() weston_output_mode_switch_to_native() Differences from previous behaviour: SET_NATIVE didn't set current_scale (now it does) SET_TEMPORARY could set mode and scale ind

Re: [PATCH weston 1/3] Introduce pointer lock interface

2014-09-22 Thread Jason Ekstrand
On Mon, Sep 22, 2014 at 12:52 PM, Jonas Ådahl wrote: > On Mon, Sep 22, 2014 at 11:31:27AM -0700, Jason Ekstrand wrote: > > On Sun, Sep 21, 2014 at 11:43 PM, Pekka Paalanen > > wrote: > > > > > On Sat, 20 Sep 2014 11:43:22 -0700 > > > Jason Ekstrand wrote: > > > > > > > On Sat, Sep 20, 2014 at 1

Re: [PATCH V2] wayland.xml: add "enum", "bitfield" and "is_bitfield" attributes

2014-09-22 Thread Jason Ekstrand
On Mon, Sep 22, 2014 at 12:48 PM, Jasper St. Pierre wrote: > > > On Mon, Sep 22, 2014 at 12:27 PM, Jason Ekstrand > wrote: > >> >> >> On Mon, Sep 22, 2014 at 9:30 AM, Nils Chr. Brause < >> nilschrbra...@gmail.com> wrote: >> >>> On Mon, Sep 22, 2014 at 11:21 AM, Pekka Paalanen >>> wrote: >>> > >

[PATCH wayland 2/2] scanner: Remove stray newline

2014-09-22 Thread Jonas Ådahl
Signed-off-by: Jonas Ådahl --- src/scanner.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/scanner.c b/src/scanner.c index 6be1d7a..809130b 100644 --- a/src/scanner.c +++ b/src/scanner.c @@ -884,7 +884,6 @@ emit_structs(struct wl_list *message_list, struct interface *interface, enum sid

[PATCH wayland 1/2] scanner: Improve XML parse error reporting

2014-09-22 Thread Jonas Ådahl
Print the parse error and exit with a failure if expat can't parse the XML. Signed-off-by: Jonas Ådahl --- src/scanner.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/scanner.c b/src/scanner.c index 72fd3e8..6be1d7a 100644 --- a/src/scanner.c +++ b/src/scanne

Re: [PATCH V2] wayland.xml: add "enum", "bitfield" and "is_bitfield" attributes

2014-09-22 Thread Bill Spitzak
On 09/22/2014 12:48 PM, Jasper St. Pierre wrote: xdg_shell.resize_edges. It is both a bitfield (top / left / right / bottom edges are powers of two) and an enum (top right / bottom left corner convenience values, with top / bottom being left out as it is undefined). That actually is a better e

Re: Compose and dead-keys support in libxkbcommon

2014-09-22 Thread Bill Spitzak
Yes I understand that an input method process would call this. But it could be code in that input method rather than in a library normal clients have to link with. I'm asking whether it is a good idea to give applications such an easy way to ignore the input method by calling this directly. O

Re: [PATCH weston 1/3] Introduce pointer lock interface

2014-09-22 Thread Jonas Ådahl
On Mon, Sep 22, 2014 at 11:31:27AM -0700, Jason Ekstrand wrote: > On Sun, Sep 21, 2014 at 11:43 PM, Pekka Paalanen > wrote: > > > On Sat, 20 Sep 2014 11:43:22 -0700 > > Jason Ekstrand wrote: > > > > > On Sat, Sep 20, 2014 at 1:29 AM, Pekka Paalanen > > wrote: > > > > > > > On Fri, 19 Sep 2014 2

Re: [PATCH V2] wayland.xml: add "enum", "bitfield" and "is_bitfield" attributes

2014-09-22 Thread Jasper St. Pierre
On Mon, Sep 22, 2014 at 12:27 PM, Jason Ekstrand wrote: > > > On Mon, Sep 22, 2014 at 9:30 AM, Nils Chr. Brause > wrote: > >> On Mon, Sep 22, 2014 at 11:21 AM, Pekka Paalanen >> wrote: >> > >> > On Wed, 3 Sep 2014 19:44:04 +0200 >> > "Nils Chr. Brause" wrote: >> > >> > > This replaces "[PATCH

Re: Compose and dead-keys support in libxkbcommon

2014-09-22 Thread Jasper St. Pierre
libxkbcommon forms part of the input method. On Mon, Sep 22, 2014 at 11:36 AM, Bill Spitzak wrote: > I'm sure this was discussed, but wouldn't it be better to encourage use of > the input method rather than giving programmers who only want latin an easy > way to ignore it? > > > On 09/14/2014 02

Re: [PATCH weston 1/3] Introduce pointer lock interface

2014-09-22 Thread Jason Ekstrand
On Sun, Sep 21, 2014 at 11:43 PM, Pekka Paalanen wrote: > On Sat, 20 Sep 2014 11:43:22 -0700 > Jason Ekstrand wrote: > > > On Sat, Sep 20, 2014 at 1:29 AM, Pekka Paalanen > wrote: > > > > > On Fri, 19 Sep 2014 20:20:53 +0200 > > > Jonas Ådahl wrote: > > > > > > > On Fri, Sep 19, 2014 at 11:00:

Re: [PATCH V2] wayland.xml: add "enum", "bitfield" and "is_bitfield" attributes

2014-09-22 Thread Jason Ekstrand
On Mon, Sep 22, 2014 at 9:30 AM, Nils Chr. Brause wrote: > On Mon, Sep 22, 2014 at 11:21 AM, Pekka Paalanen > wrote: > > > > On Wed, 3 Sep 2014 19:44:04 +0200 > > "Nils Chr. Brause" wrote: > > > > > This replaces "[PATCH wayland] Add "enum" attribute to "arg" elements". > > > Previous concers h

Re: [PATCH weston 0/3] Pointer locking revisited

2014-09-22 Thread Bill Spitzak
On 09/17/2014 01:20 PM, Jonas Ådahl wrote: Could you clarify where the cursor should be during the lock, and what should be the cursor position when a lock is ended ? Sure. Can add a clause saying that the the position of the actual pointer will stay where it was before the lock was initiated

Re: Compose and dead-keys support in libxkbcommon

2014-09-22 Thread Bill Spitzak
I'm sure this was discussed, but wouldn't it be better to encourage use of the input method rather than giving programmers who only want latin an easy way to ignore it? On 09/14/2014 02:05 PM, Ran Benita wrote: These patches add support for compose sequences/dead keys to libxkbcommon, in a sm

Re: [PATCH libxkbcommon 2/4] compose: add xkbcommon-compose - implementation

2014-09-22 Thread Bill Spitzak
On 09/15/2014 04:58 AM, Ran Benita wrote: On Mon, Sep 15, 2014 at 08:21:34AM +0200, David Herrmann wrote: Why don't we require a keymap in xkb_compose_state_new()? Should be easy to do and we can then track modifiers reliably. Ok, a keysym which is a modifier in one keymap should never be a

Re: [PATCH V2] wayland.xml: add "enum", "bitfield" and "is_bitfield" attributes

2014-09-22 Thread Nils Chr. Brause
On Mon, Sep 22, 2014 at 11:21 AM, Pekka Paalanen wrote: > > On Wed, 3 Sep 2014 19:44:04 +0200 > "Nils Chr. Brause" wrote: > > > This replaces "[PATCH wayland] Add "enum" attribute to "arg" elements". > > Previous concers have be incorporated and it is meant for 1.7. > > > > From 733fb18b163de9327

Re: [PATCH] shell: fix weston_output_mode_switch() usage

2014-09-22 Thread Derek Foreman
On 22/09/14 06:41 AM, Pekka Paalanen wrote: > On Fri, 19 Sep 2014 14:43:23 -0500 > Derek Foreman wrote: > >> Calling weston_output_mode_switch() with WESTON_MODE_SWITCH_RESTORE_NATIVE >> will result in the mode being set "back" to the passed in mode - so the >> passed mode should be the native mo

Re: [PATCH wayland] protocol: Add a surface_has_existing_role error

2014-09-22 Thread Jasper St. Pierre
I think it would be a pain to do that, and might not be clear for wl_seat and wl_data_device. If you believe in it, all power to you. On 22 Sep 2014 02:10, "Pekka Paalanen" wrote: > On Mon, 25 Aug 2014 08:59:51 +0300 > Pekka Paalanen wrote: > > > On Fri, 22 Aug 2014 10:48:02 -0700 > > Jason Ekst

Re: [PATCH] shell: fix weston_output_mode_switch() usage

2014-09-22 Thread Pekka Paalanen
On Fri, 19 Sep 2014 14:43:23 -0500 Derek Foreman wrote: > Calling weston_output_mode_switch() with WESTON_MODE_SWITCH_RESTORE_NATIVE > will result in the mode being set "back" to the passed in mode - so the > passed mode should be the native mode. That's kind of silly, don't you think? :-) If it

Re: [PATCH weston v3 2/2] Implement data_device interface destructor

2014-09-22 Thread Pekka Paalanen
On Wed, 27 Aug 2014 16:34:25 +0530 kabeer.k...@samsung.com wrote: > From: kabeer > > window: use data_device interface destructor > data-device: implement data_device_release destructor > Should mention the bug link here: https://bugs.freedesktop.org/show_bug.cgi?id=81745 > Signed-off-by: kab

Re: [PATCH v3 1/2] Protocol: Add destructor to wl_data_device interface Fix for Bug# 81745

2014-09-22 Thread Pekka Paalanen
On Wed, 27 Aug 2014 16:33:25 +0530 kabeer.k...@samsung.com wrote: > From: kabeer > > Signed-off-by: kabeer > --- > protocol/wayland.xml | 11 +-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/protocol/wayland.xml b/protocol/wayland.xml > index bb457bc..f0248f5 1

Re: [PATCH V2] wayland.xml: add "enum", "bitfield" and "is_bitfield" attributes

2014-09-22 Thread Pekka Paalanen
On Wed, 3 Sep 2014 19:44:04 +0200 "Nils Chr. Brause" wrote: > This replaces "[PATCH wayland] Add "enum" attribute to "arg" elements". > Previous concers have be incorporated and it is meant for 1.7. > > From 733fb18b163de93276f092a4be100c7e0c0c723f Mon Sep 17 00:00:00 2001 > From: "Nils Chr. Bra

Re: [PATCH 4/4] queue-test: Add another assertion

2014-09-22 Thread Pekka Paalanen
On Thu, 11 Sep 2014 21:43:49 +0200 Karsten Otto wrote: > From: Philip Withnall > Date: Fri, 15 Feb 2013 12:57:23 + > > Ensure that the round trip succeeds. > > [kao: adjusted patch to current test framework style] > > Signed-off-by: Philip Withnall > Signed-off-by: Karsten Otto > --- >

Re: [PATCH 3/4] wayland-server: Abort if a read from a client gives 0 length

2014-09-22 Thread Pekka Paalanen
On Thu, 11 Sep 2014 21:42:26 +0200 Karsten Otto wrote: > From: Philip Withnall > Date: Fri, 15 Feb 2013 12:57:05 + > > This happens if the socket has been gracefully closed. > > Signed-off-by: Philip Withnall > Signed-off-by: Karsten Otto > --- > src/wayland-server.c | 2 +- > 1 file chan

Re: [PATCH wayland] protocol: Add a surface_has_existing_role error

2014-09-22 Thread Pekka Paalanen
On Mon, 25 Aug 2014 08:59:51 +0300 Pekka Paalanen wrote: > On Fri, 22 Aug 2014 10:48:02 -0700 > Jason Ekstrand wrote: > > > As I mentioned on IRC, I don't really like adding and using an enum value > > without bumping protocol version. However, the only time we ever use it is > > to kill the c

Re: [PATCH wayland] doc: replace publican with xmlto

2014-09-22 Thread Pekka Paalanen
On Thu, 4 Sep 2014 17:32:10 +1000 Peter Hutterer wrote: > Publican isn't packaged for some distros, xmlto is a lot more common. Most of > what publican provides for us is the stylesheet anyway, so we can just use > xmlto and the publican stylesheet to get roughly the same look. > > PDF and XML g

Re: [PATCH v2 libinput 05/10] filter: adjust acceleration curve depending on speed

2014-09-22 Thread Hans de Goede
Hi, On 09/22/2014 02:57 AM, Peter Hutterer wrote: > The acceleration curve consists of four parts, in ascii-art like this: > _ >/ > / > / > / > > where the x axis is the speed, y is the acceleration factor. > The first plateau is at the acceleration factor 1 (i.

Re: [PATCH v2 libinput 08/10] touchpad: hook up pointer acceleration configuration

2014-09-22 Thread Hans de Goede
Hi, On 09/22/2014 02:02 AM, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- > Changes to v1: > - don't duplicate the accel config code, just re-use it for touchpad Looks good: Reviewed-by: Hans de Goede Regards, Hans > > > src/evdev-mt-touchpad.c | 7 +-- > src/evdev.c

Re: [PATCH v2 libinput 05.5/10] touchpad: use the evdev device's filter struct

2014-09-22 Thread Hans de Goede
Hi, On 09/22/2014 02:01 AM, Peter Hutterer wrote: > We don't need a separate filter struct, we can use the parent evdev device. > > Signed-off-by: Peter Hutterer Looks good: Reviewed-by: Hans de Goede Regards, Hans > --- > Changes to v1: > - didn't exist in the first set of patches, slots

Re: [PATCH libinput 3/3] touchpad: Disable touchpads on trackpoint activity

2014-09-22 Thread Hans de Goede
Hi, On 09/22/2014 07:18 AM, Peter Hutterer wrote: > On Thu, Sep 18, 2014 at 01:11:05PM +0200, Hans de Goede wrote: >> Some laptops with both a clickpad and a trackpoint have such a large >> touchpad, >> that parts of the users hands will touch the pad when using the trackpoint. >> Examples of thi

Re: [PATCH 2/2] clients: Maximize window when double touch on title bar

2014-09-22 Thread Pekka Paalanen
On Thu, 12 Jun 2014 11:06:26 +0800 Xiong Zhang wrote: > Signed-off-by: Xiong Zhang > --- > clients/window.c| 26 -- > shared/cairo-util.h | 7 +++ > shared/frame.c | 49 + > 3 files changed, 80 insertions(+),

Re: [PATCH 2/2] cosmetic: Move WL_EXPORT out of header files

2014-09-22 Thread Pekka Paalanen
On Thu, 18 Sep 2014 16:46:49 -0500 Derek Foreman wrote: > Most of the code only puts WL_EXPORT in .c files. Remove the few > instances in header files. > > If it's missing form the associated .c, put it there instead. > --- > src/compositor.h | 6 +++--- > src/filter.c | 4 ++-- > src/filt