Re: [PATCH V2] doc: Added API documentation for wl_display_destroy and wl_display_add_socket functions.

2014-10-15 Thread Bryce Harrington
Reviewed-by: Bryce Harrington br...@osg.samsung.com On Tue, Oct 14, 2014 at 12:31:37PM +0530, Srivardhan Hebbar wrote: Signed-off-by: Srivardhan Hebbar sri.heb...@samsung.com --- src/wayland-server.c | 33 + 1 file changed, 33 insertions(+) diff --git

Re: [PATCH weston] input: fix access to invalid resource

2014-10-15 Thread Marek Chalupa
Look OK, it can not hurt to add this check in any case. On 10 October 2014 22:46, Giulio Camuffo giuliocamu...@gmail.com wrote: the keyboard focus surface may not have a valid resource (server side surface or a surface surviving its client), so check if it is valid before using it. ---

Re: [RFC weston 12/16] matrix: Add functions to decompose a transformation matrix into basic operations

2014-10-15 Thread Bryce Harrington
On Fri, Sep 26, 2014 at 04:10:23PM -0500, Derek Foreman wrote: Adds an internal weston_matrix_decompose() which takes a matrix and decomposes translation, rotation, shear and scale parameters to re-create it. This information is cached the first time any helper functions are used to extract

[PATCH V3] doc: Added API documentation for wl_display_destroy and wl_display_add_socket functions.

2014-10-15 Thread Srivardhan Hebbar
Signed-off-by: Srivardhan Hebbar sri.heb...@samsung.com --- src/wayland-server.c | 33 + 1 file changed, 33 insertions(+) diff --git a/src/wayland-server.c b/src/wayland-server.c index 674aeca..469127f 100644 --- a/src/wayland-server.c +++ b/src/wayland-server.c

[PATCH V4] doc: Added API documentation for wl_display_destroy and wl_display_add_socket functions.

2014-10-15 Thread Srivardhan Hebbar
Signed-off-by: Srivardhan Hebbar sri.heb...@samsung.com --- src/wayland-server.c | 33 + 1 file changed, 33 insertions(+) diff --git a/src/wayland-server.c b/src/wayland-server.c index 674aeca..0fc2088 100644 --- a/src/wayland-server.c +++ b/src/wayland-server.c

[PATCH wayland] wl_strtol and wl_strtoul utility functions are added

2014-10-15 Thread Imran Zaman
Hi The patch is used to replace strtol and strtoul with wl_strtol and wl_strtoul with inputs and result checks. The utility functions are used extensively in wayland and weston so added appropriate input and output checks; test cases are also updated; will push the patch for weston as well. BR

[PATCH wayland] wl_strtol and wl_strtoul utility functions are added (inlined patch)

2014-10-15 Thread Imran Zaman
Hi The patch is used to replace strtol and strtoul with wl_strtol and wl_strtoul with inputs and result checks. The utility functions are used extensively in wayland and weston so added appropriate input and output checks; test cases are also updated; will push the patch for weston as well.

[PATCH wayland 1/2] support specifying custom directories for the client and server

2014-10-15 Thread Imran Zaman
Hi support specifying custom directories for the client and server sockets through environment variables. This is in order to support nested compositor architectures where system compositor using drm-backend is shared among multiple child compositors using wayland-backend. --- diff

[PATCH wayland 2/2] support specifying custom directories for the client and server

2014-10-15 Thread Imran Zaman
Hi support for adjusting socket access rights to allow group of users to connect to the socket. This is used for nested compositor architectures. - diff --git a/src/wayland-server.c b/src/wayland-server.c index ce1eca8..b1ca5e6 100644 --- a/src/wayland-server.c +++ b/src/wayland-server.c @@

Re: [PATCH wayland] wl_strtol and wl_strtoul utility functions are added (inlined patch)

2014-10-15 Thread Jasper St. Pierre
Why? What's the rationale for this? On Wed, Oct 15, 2014 at 6:18 AM, Imran Zaman imran.za...@gmail.com wrote: Hi The patch is used to replace strtol and strtoul with wl_strtol and wl_strtoul with inputs and result checks. The utility functions are used extensively in wayland and weston so

Re: [PATCH wayland] wl_strtol and wl_strtoul utility functions are added

2014-10-15 Thread Jason Ekstrand
I don't see how this belongs in libwayland. Sure, we use strtol twice, but I don't think that warrants adding 100 lines of wrapper functions and test cases. --Jason Ekstrand On Wed, Oct 15, 2014 at 6:16 AM, Rémi Denis-Courmont r...@remlab.net wrote: Le 2014-10-15 16:14, Imran Zaman a écrit :

Re: [PATCH wayland] wl_strtol and wl_strtoul utility functions are added (inlined patch)

2014-10-15 Thread Imran Zaman
The reason is that strtol is used at many places in weston/wayland.. and its not covering all the error cases everywhere.. so its better to encapsulate it in a function which i did.. On Wed, Oct 15, 2014 at 9:31 PM, Jasper St. Pierre jstpie...@mecheye.net wrote: Why? What's the rationale for

Re: [PATCH wayland] wl_strtol and wl_strtoul utility functions are added

2014-10-15 Thread Imran Zaman
The reason is that strtol is used at many places in weston/wayland.. and its not covering all the error cases everywhere (i.e. its buggy).. so its better to encapsulate it in a function with all the input and output checks... it can be moved to weston if its sound such a big deal... On Wed, Oct

Re: [PATCH wayland] wl_strtol and wl_strtoul utility functions are added (inlined patch)

2014-10-15 Thread Bill Spitzak
You might be able to remove the base argument, is anybody using that? That would remove confusion over which is the base and return argument Also it seems like calling code would be easier to read with a version that returns the value but puts the error into errno. Something like this:

Re: [PATCH wayland] wl_strtol and wl_strtoul utility functions are added (inlined patch)

2014-10-15 Thread Giulio Camuffo
2014-10-15 22:01 GMT+03:00 Imran Zaman imran.za...@gmail.com: The reason is that strtol is used at many places in weston/wayland.. and its not covering all the error cases everywhere.. so its better to encapsulate it in a function which i did.. You may have a point here, but imho it must not

Re: [PATCH wayland] wl_strtol and wl_strtoul utility functions are added

2014-10-15 Thread Bill Spitzak
According the the Linux man page you have to set errno to zero to use strtol correctly anyway. Quick test shows this is the only way to detect out-of-range errors. The glib strtol consumes all digits no matter how many you type in (rather than possibly quitting on the first digit that makes

Re: [PATCH wayland] wl_strtol and wl_strtoul utility functions are added

2014-10-15 Thread Thiago Macieira
On Wednesday 15 October 2014 16:16:34 Rémi Denis-Courmont wrote: Le 2014-10-15 16:14, Imran Zaman a écrit : Hi The patch is used to replace strtol and strtoul with wl_strtol and wl_strtoul with inputs and result checks. I don't know where Wayland developers stand on this, but I would

Re: [PATCH wayland] wl_strtol and wl_strtoul utility functions are added

2014-10-15 Thread Thiago Macieira
On Wednesday 15 October 2014 16:14:17 Imran Zaman wrote: Hi The patch is used to replace strtol and strtoul with wl_strtol and wl_strtoul with inputs and result checks. The utility functions are used extensively in wayland and weston so added appropriate input and output checks; test

Re: [PATCH wayland] wl_strtol and wl_strtoul utility functions are added (inlined patch)

2014-10-15 Thread Bryce Harrington
On Wed, Oct 15, 2014 at 04:18:59PM +0300, Imran Zaman wrote: Hi The patch is used to replace strtol and strtoul with wl_strtol and wl_strtoul with inputs and result checks. The utility functions are used extensively in wayland and weston so added These utility... appropriate input and

Re: [PATCH 1/6] Add cms protocol

2014-10-15 Thread Bryce Harrington
On Mon, Oct 13, 2014 at 07:40:46PM +0200, Niels Ole Salscheider wrote: The cms protocol allows to attach an ICC profile to a surface. It also tells the client about the blending color space and the color spaces of all outputs. Signed-off-by: Niels Ole Salscheider

Re: [PATCH 2/6] Attach input profiles and build corresponding LUTs

2014-10-15 Thread Bryce Harrington
On Mon, Oct 13, 2014 at 07:40:47PM +0200, Niels Ole Salscheider wrote: This implements the functionality to attach a profile to a surface in weston. An LUT is built from the profile that can be used to transform colors from the input color space to the blending color space. An sRGB color

Re: [PATCH 3/6] Attach output profiles and build corresponding LUTs

2014-10-15 Thread Bryce Harrington
On Mon, Oct 13, 2014 at 07:40:48PM +0200, Niels Ole Salscheider wrote: This patch allows to attach an ICC profile to each output. Signed-off-by: Niels Ole Salscheider niels_...@salscheider-online.de --- src/cms-colord.c | 4 +++- src/cms-helper.c | 16 +++- src/cms-helper.h |

Re: [PATCH 6/6] image demo client: Add support for color management

2014-10-15 Thread Bryce Harrington
On Mon, Oct 13, 2014 at 07:40:51PM +0200, Niels Ole Salscheider wrote: You can now use C to switch between the following modes: - Assume sRGB input color space - Assume that the input color space is the blending color space - Attach a false-color ICC profile to the surface Signed-off-by:

Re: [PATCH wayland 2/2] support specifying custom directories for the client and server

2014-10-15 Thread Bryce Harrington
On Wed, Oct 15, 2014 at 05:36:27PM +0300, Imran Zaman wrote: Hi support for adjusting socket access rights to allow group of users to connect to the socket. This is used for nested compositor architectures. - diff --git a/src/wayland-server.c b/src/wayland-server.c index