Re: [PATCH v1 weston 07/11] tests: Add a fadein test

2014-11-26 Thread Pekka Paalanen
On Wed, 26 Nov 2014 10:49:08 -0600 Derek Foreman wrote: > On 26/11/14 02:43 AM, Pekka Paalanen wrote: > > On Tue, 25 Nov 2014 10:15:04 -0600 > > Derek Foreman wrote: > > > >> On 25/11/14 04:11 AM, Pekka Paalanen wrote: > >>> On Mon, 24 Nov 2014 18:48:51 -0800 > >>> Bryce Harrington wrote: > >>

Re: [PATCH weston v2] simple-shm: explain two initial roundtrips

2014-11-26 Thread Pekka Paalanen
On Thu, 27 Nov 2014 09:15:33 +0200 Pekka Paalanen wrote: > On Wed, 26 Nov 2014 16:12:27 +0100 > Marek Chalupa wrote: > > > Maybe it'd be worth to mention this 'general technique' on appropriate > > places in the source code, i. e. in wl_display_get_registry() documentation > > or so. > > Everyb

Re: [PATCH weston v2] simple-shm: explain two initial roundtrips

2014-11-26 Thread Pekka Paalanen
On Wed, 26 Nov 2014 16:12:27 +0100 Marek Chalupa wrote: > On 26 November 2014 at 09:04, Pekka Paalanen wrote: > > > From: Pekka Paalanen > > > > Explain carefully why we need two roundtrips, not just one, not just > > dispatch and roundtrip, but two roundtrips after creating the > > wl_registr

[PATCH weston 2/2] compositor: Implement JSON-timeline logging

2014-11-26 Thread Pekka Paalanen
From: Pekka Paalanen Logging is activated and deactivated with the debug key binding 't'. When activated, it creates a new log file, where it records the events. The log file contains events and detailed object information entries in JSON format, and is meant to be parsed in sequence from beginni

[PATCH weston 1/2] compositor: add weston_surface_set_description()

2014-11-26 Thread Pekka Paalanen
From: Pekka Paalanen When printing out logs from Weston's actions, mainly for debugging, it can be very difficult to identify the different surfaces. Inspecting the configure function pointer is not useful, as the configure functions may live in modules. Add vfunc get_description to weston_surf

Re: [PATCH weston-ivi-shell v8 00/13] a reference shell for In-Vehicle Infotainment system

2014-11-26 Thread Pekka Paalanen
On Thu, 27 Nov 2014 13:07:20 +0900 Nobuhiko Tanibata wrote: > This is version 8 of ivi_shell patches reviewed by Pekka Paalanen > . > > Vesion 7 can be found here: > > http://lists.freedesktop.org/archives/wayland-devel/2014-July/015971.html > > Version 1 can be found here and this overviews

Re: [PATCH] doc: Removed extra indentation from wl_list code sample

2014-11-26 Thread Pekka Paalanen
On Wed, 26 Nov 2014 10:44:40 -0800 Bill Spitzak wrote: > On 11/26/2014 03:37 AM, Pekka Paalanen wrote: > > > I see the asterisks at > > $WLD/share/doc/wayland/Wayland/en-US/html/ch05.html#structwl__list > > after 'make install'. Looks like the C comment asterisks we use for > > style reasons get

[PATCH weston-ivi-shell v8 13/13] ivi-shell: reference implementation of input panel for ivi-shell

2014-11-26 Thread Nobuhiko Tanibata
- introduces ivi-shell/input-panel-ivi.c which is basically copied from desktop shell. It shall be improvaded to remove duplicate implementation. Signed-off-by: Nobuhiko Tanibata Acked-by: Pekka Paalanen --- Makefile.am | 3 +- ivi-shell/input-panel-ivi.c | 391 +++

[PATCH weston-ivi-shell v8 12/13] clients: support ivi-application.xml for clients/window.c

2014-11-26 Thread Nobuhiko Tanibata
Signed-off-by: Nobuhiko Tanibata Reviewed-by: Pekka Paalanen --- clients/window.c | 67 +++- 1 file changed, 57 insertions(+), 10 deletions(-) diff --git a/clients/window.c b/clients/window.c index 5099004..f39150b 100644 --- a/clients/window.

[PATCH weston-ivi-shell v8 10/13] clients: support ivi-application.xml for clients/simple-shm.c

2014-11-26 Thread Nobuhiko Tanibata
Signed-off-by: Nobuhiko Tanibata Reviewed-by: Pekka Paalanen --- Makefile.am | 4 +++- clients/simple-shm.c | 42 ++ 2 files changed, 45 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index e91a125..e5fe359 100644 --- a/Make

[PATCH weston-ivi-shell v8 11/13] clients: support ivi-application.xml for clients/simple-egl.c

2014-11-26 Thread Nobuhiko Tanibata
Signed-off-by: Nobuhiko Tanibata Reviewed-by: Pekka Paalanen --- Makefile.am | 4 ++- clients/simple-egl.c | 95 +++- 2 files changed, 89 insertions(+), 10 deletions(-) diff --git a/Makefile.am b/Makefile.am index e5fe359..de1d768 100644

[PATCH weston-ivi-shell v8 09/13] ivi-shell: a reference of weston.ini for ivi-shell and ivi-hmi-controller.

2014-11-26 Thread Nobuhiko Tanibata
- introduces ivi-shell/weston.ini.in Signed-off-by: Nobuhiko Tanibata Reviewed-by: Pekka Paalanen --- Makefile.am | 13 +-- ivi-shell/.gitignore| 1 + ivi-shell/weston.ini.in | 93 + 3 files changed, 104 insertions(+), 3 delet

[PATCH weston-ivi-shell v8 08/13] data: add reference image files for weston-ivi-shell-user-interface

2014-11-26 Thread Nobuhiko Tanibata
- introduces reference images used by weston-ivi-shell-user-interface. Signed-off-by: Nobuhiko Tanibata Reviewed-by: Pekka Paalanen --- Makefile.am | 14 +- data/COPYING | 28 +++- data/background.png | Bin 0 -> 245

[PATCH weston-ivi-shell v8 07/13] clients: a reference implementation of UI client how to use ivi-hmi-controller.

2014-11-26 Thread Nobuhiko Tanibata
- introduces ivi-shell-user-interface.c This is launched from hmi-controller by launch_hmi_client_process and invoke a client process. The basic flow is as followed, 1/ process invoked 2/ read configuration from weston.ini. 3/ draw png file to surface according to configuration of weston.ini 4/ a

[PATCH weston-ivi-shell v8 06/13] ivi-shell: a reference implementation how to use ivi-layout internal APIs

2014-11-26 Thread Nobuhiko Tanibata
- hmi-controller.so - introduces hmi-controller.so The library is used to manage layout of surfaces/layers. Layout change is triggered by ivi-hmi-controller protocol, ivi-hmi-controller.xml. A reference how to use the protocol, see ivi-shell-user-interface.c. In-Vehicle Infotainment system usuall

[PATCH weston-ivi-shell v8 05/13] protocol: ivi hmi controller protocol to set up IVI style UI

2014-11-26 Thread Nobuhiko Tanibata
- introduces ivi-hmi-controller.xml This protocol realizes following features, - UI ready - changing modes; tiling, side by side, full_screen, and random - Give control a surface; workspace to be controlled by using ivi layout APIs - Display/undisplay a surface; home contains sevaral workspaces

[PATCH weston-ivi-shell v8 04/13] ivi-shell: add the shell plugin for In-Vehicle Infotainment system

2014-11-26 Thread Nobuhiko Tanibata
- ivi-shell.so - introduces ivi-shell/ivi-shell.[ch] In-Vehicle Infotainment system traditionally manages surfaces with global identification. A protocol, ivi_application, supports such a feature by implementing a request, ivi_application::surface_creation defined in ivi_application.xml. The ivi-

[PATCH weston-ivi-shell v8 02/13] protocol: add interface ivi_application extension

2014-11-26 Thread Nobuhiko Tanibata
- introduces ivi-application.xml Many applications in an IVI-system are special single-purpose applications that have a very specific role in the whole IVI UI, for example a rear camera, speedometer, map, etc. The IVI system vendor specifies what these are and how they integrate into the UI. They

[PATCH weston-ivi-shell v8 01/13] ivi-shell: add README for ivi-shell

2014-11-26 Thread Nobuhiko Tanibata
Signed-off-by: Nobuhiko Tanibata Reviewed-by: Pekka Paalanen --- ivi-shell/README | 79 1 file changed, 79 insertions(+) create mode 100644 ivi-shell/README diff --git a/ivi-shell/README b/ivi-shell/README new file mode 100644 index

[PATCH weston-ivi-shell v8 00/13] a reference shell for In-Vehicle Infotainment system

2014-11-26 Thread Nobuhiko Tanibata
This is version 8 of ivi_shell patches reviewed by Pekka Paalanen . Vesion 7 can be found here: http://lists.freedesktop.org/archives/wayland-devel/2014-July/015971.html Version 1 can be found here and this overviews what ivi_shell is: http://lists.freedesktop.org/archives/wayland-devel/2014-

Re: [PATCH 1/3] Use zalloc rather than malloc and manually setting members to 0

2014-11-26 Thread Bryce Harrington
On Wed, Nov 26, 2014 at 03:33:16PM +0100, Marek Chalupa wrote: > On 21 November 2014 at 07:21, Bryce Harrington > wrote: > > > Signed-off-by: Bryce Harrington > > > > - if (do_yflip) > > - recorder->tmpbuf = NULL; > > - else > > + if (!do_yflip) > >

Re: [PATCH 3/9] doc: preserve links produced by Doxygen

2014-11-26 Thread Jon A. Cruz
On 11/26/2014 10:22 AM, Bill Spitzak wrote: > On 11/25/2014 11:52 PM, Pekka Paalanen wrote: > >> Or are duplicates perhaps due to us having, say, struct wl_display a >> different thing on server vs. client? > > The duplicates are due mostly to wl_list (and similar things) being > documented twi

Re: [PATCH wayland] tests: rename NO_ASSERT_LEAK_CHECK

2014-11-26 Thread Bill Spitzak
On 11/26/2014 06:25 AM, Marek Chalupa wrote: On 20 November 2014 at 23:59, Bryce Harrington mailto:br...@osg.samsung.com>> wrote: On Wed, Nov 19, 2014 at 12:00:10PM +0100, Marek Chalupa wrote: > This env variable is used for turning off the leak checks in tests. > Rename it to WA

Re: [PATCH] doc: Removed extra indentation from wl_list code sample

2014-11-26 Thread Bill Spitzak
On 11/26/2014 03:37 AM, Pekka Paalanen wrote: I see the asterisks at $WLD/share/doc/wayland/Wayland/en-US/html/ch05.html#structwl__list after 'make install'. Looks like the C comment asterisks we use for style reasons get copied to the output. They appeared when you replaced ~~~ with \code. My

Re: [PATCH 6/9] doc: Added \code tags around sample code in doxygen comments

2014-11-26 Thread Bill Spitzak
On 11/25/2014 11:51 PM, Pekka Paalanen wrote: What \comment-line command are you looking for? I see you reformatted - * wl_list_insert(&foo_list, &item1.link); \comment{Pushes item1 at the head} but I assume you mean something else? No I meant that. I thought somebody had made the comme

Re: [PATCH 3/9] doc: preserve links produced by Doxygen

2014-11-26 Thread Bill Spitzak
On 11/25/2014 11:52 PM, Pekka Paalanen wrote: I'd be interested in hearing how we end up with a) missing targets, and b) duplicate targets. Could missing targets be fixed by documenting things that are not yet documented? If yes, that would probably be nice. The missing targets are from porti

Re: [PATCH v1 weston 07/11] tests: Add a fadein test

2014-11-26 Thread Derek Foreman
On 26/11/14 02:43 AM, Pekka Paalanen wrote: > On Tue, 25 Nov 2014 10:15:04 -0600 > Derek Foreman wrote: > >> On 25/11/14 04:11 AM, Pekka Paalanen wrote: >>> On Mon, 24 Nov 2014 18:48:51 -0800 >>> Bryce Harrington wrote: >>> On Mon, Nov 24, 2014 at 01:19:46PM +0200, Pekka Paalanen wrote: >>>

Re: [PATCH weston v2] simple-shm: explain two initial roundtrips

2014-11-26 Thread Marek Chalupa
On 26 November 2014 at 09:04, Pekka Paalanen wrote: > From: Pekka Paalanen > > Explain carefully why we need two roundtrips, not just one, not just > dispatch and roundtrip, but two roundtrips after creating the > wl_registry object. > > v2: Explain what initial events are, and that this is a ge

Re: [PATCH 2/3] Setting members to 0/NULL after a zalloc or calloc is redundant

2014-11-26 Thread Marek Chalupa
Hi, this patch doesn't apply after 823ad33ef34fa32b14b300d987fb9d2e2a42e9c4 (src/evdev.c was deleted) Otherwise looks OK Reviewed-by: Marek Chalupa P. S. there is one more setting to NULL after calloc in src/compositor.c in weston_subsurface_create (sub->cached_buffer_ref.buffer = NULL) On 21

Re: [PATCH 1/3] Use zalloc rather than malloc and manually setting members to 0

2014-11-26 Thread Marek Chalupa
On 21 November 2014 at 07:21, Bryce Harrington wrote: > Signed-off-by: Bryce Harrington > --- > src/clipboard.c | 5 +++-- > src/screenshooter.c | 9 ++--- > 2 files changed, 5 insertions(+), 9 deletions(-) > > diff --git a/src/clipboard.c b/src/clipboard.c > index 5a3a02d..dbd8c9b 1006

Re: [PATCH 3/3] Use zalloc instead of calloc(1, ...)

2014-11-26 Thread Marek Chalupa
$ git grep calloc\(1, reveals that there are quite few more places where calloc(1, ...) is used. However, this patch is a good starter. Reviewed-by: Marek Chalupa On 21 November 2014 at 07:21, Bryce Harrington wrote: > Signed-off-by: Bryce Harrington > --- > src/cms-helper.c | 2 +- >

Re: [PATCH wayland] tests: rename NO_ASSERT_LEAK_CHECK

2014-11-26 Thread Marek Chalupa
On 20 November 2014 at 23:59, Bryce Harrington wrote: > On Wed, Nov 19, 2014 at 12:00:10PM +0100, Marek Chalupa wrote: > > This env variable is used for turning off the leak checks in tests. > > Rename it to WAYLAND_TESTS_NO_LEAK_CHECK, so that it is consistent > > with WAYLAND_TESTS_NO_TIMEOUTS.

Re: [PATCH wayland] client: update documentation about threading

2014-11-26 Thread Pekka Paalanen
On Fri, 21 Nov 2014 11:12:35 +0100 Marek Chalupa wrote: > Remove out-dated documentation and add few more words > about this topic. > > Signed-off-by: Marek Chalupa > --- > src/wayland-client.c | 106 > ++- > 1 file changed, 87 insertions(+), 19

Re: [PATCH wayland] client: remove old comment

2014-11-26 Thread Pekka Paalanen
On Wed, 12 Nov 2014 13:28:43 +0100 Marek Chalupa wrote: > There is nothing like main thread since > 3c7e8bfbb4745315b7bcbf69fa746c3d6718c305 anymore. > > Signed-off-by: Marek Chalupa > --- > src/wayland-client.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/src/wayland-client.c b/

Re: [PATCH weston] Drop legacy backends in favor of libinput

2014-11-26 Thread Pekka Paalanen
On Wed, 26 Nov 2014 07:06:31 +1000 Peter Hutterer wrote: > --- > Makefile.am| 15 +- > configure.ac | 10 +- > src/compositor-drm.c | 2 +- > src/compositor-fbdev.c | 2 +- > src/compositor-rpi.c | 2 +- > src/evdev-touchpad.c | 800 >

Re: [PATCH] doc: Removed extra indentation from wl_list code sample

2014-11-26 Thread Pekka Paalanen
On Tue, 25 Nov 2014 17:41:03 -0800 Bill Spitzak wrote: > This is a minor documentation fix. I did not see any asterisks in the > output as reported by Pekka Paalanen. Using doxygen 1.7.6.1. > --- > src/wayland-util.h |8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --

Re: [PATCH 3/9] doc: preserve links produced by Doxygen

2014-11-26 Thread Pekka Paalanen
On Wed, 26 Nov 2014 00:38:20 -0800 "Jon A. Cruz" wrote: > On 11/25/2014 11:52 PM, Pekka Paalanen wrote: > > I'd be interested in hearing how we end up with > > a) missing targets, and b) duplicate targets. > > > > Could missing targets be fixed by documenting things that are not yet > > document

Re: [PATCH v1 weston 06/11] tests: Add screenshot recording to weston-test

2014-11-26 Thread Pekka Paalanen
On Tue, 25 Nov 2014 09:11:39 -0600 Derek Foreman wrote: > On 25/11/14 03:53 AM, Pekka Paalanen wrote: > > On Mon, 24 Nov 2014 15:20:35 -0800 > > Bryce Harrington wrote: > > > >> On Mon, Nov 24, 2014 at 04:31:01PM -0600, Derek Foreman wrote: > >>> On 24/11/14 05:01 AM, Pekka Paalanen wrote: > >>

Re: [PATCH v3 libinput] evdev: Query mouse DPI from udev

2014-11-26 Thread Hans de Goede
Hi, On 11/25/2014 11:41 PM, Peter Hutterer wrote: From: Derek Foreman Instead of using a hard coded mouse DPI value, we query it from udev. If it's not present or the property is obviously broken we fall back to default. Signed-off-by: Derek Foreman Signed-off-by: Peter Hutterer Looks goo

Re: [PATCH v1 weston 07/11] tests: Add a fadein test

2014-11-26 Thread Pekka Paalanen
On Tue, 25 Nov 2014 10:15:04 -0600 Derek Foreman wrote: > On 25/11/14 04:11 AM, Pekka Paalanen wrote: > > On Mon, 24 Nov 2014 18:48:51 -0800 > > Bryce Harrington wrote: > > > >> On Mon, Nov 24, 2014 at 01:19:46PM +0200, Pekka Paalanen wrote: > >>> On Wed, 19 Nov 2014 15:06:22 -0800 > >>> Bryce

Re: [PATCH 3/9] doc: preserve links produced by Doxygen

2014-11-26 Thread Jon A. Cruz
On 11/25/2014 11:52 PM, Pekka Paalanen wrote: > I'd be interested in hearing how we end up with > a) missing targets, and b) duplicate targets. > > Could missing targets be fixed by documenting things that are not yet > documented? If yes, that would probably be nice. > > If we ever get duplicate

[PATCH weston v2] simple-shm: explain two initial roundtrips

2014-11-26 Thread Pekka Paalanen
From: Pekka Paalanen Explain carefully why we need two roundtrips, not just one, not just dispatch and roundtrip, but two roundtrips after creating the wl_registry object. v2: Explain what initial events are, and that this is a general technique. Signed-off-by: Pekka Paalanen --- clients/simp