Re: [PATCH libinput v2 1/2] Introduce unaccelerated motion event vectors

2014-12-03 Thread Peter Hutterer
On Thu, Dec 04, 2014 at 11:44:09AM +0800, Jonas Ådahl wrote: > For certain applications (such as FPS games) it is necessary to use > unaccelerated motion events (the motion vector that is passed to the > acceleration filter) to get a more natural feeling. Supply this > information by passing both a

[PATCH libinput] Always check for INVALID configs first

2014-12-03 Thread Peter Hutterer
Always check for invalid input first, then check if the input is supported by the actual device. Signed-off-by: Peter Hutterer --- src/libinput.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/libinput.c b/src/libinput.c index 0d380fa..60505f6 1006

[PATCH libinput 2/2] test: Don't send two motion events when button scrolling

2014-12-03 Thread Jonas Ådahl
Button scrolling motion events don't pass through the acceleration filter so no need to assume the initial event will be absorbed. Signed-off-by: Jonas Ådahl --- test/litest.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/test/litest.c b/test/litest.c index e2ec90d..2ab802b 100644 ---

[PATCH libinput v2 1/2] Introduce unaccelerated motion event vectors

2014-12-03 Thread Jonas Ådahl
For certain applications (such as FPS games) it is necessary to use unaccelerated motion events (the motion vector that is passed to the acceleration filter) to get a more natural feeling. Supply this information by passing both accelerated and unaccelerated motion vectors to the existing motion ev

Re: [PATCH 1/4] doc: use markdown tildes for code blocks

2014-12-03 Thread Bill Spitzak
On 12/03/2014 02:37 PM, Peter Hutterer wrote: I did some web searches, and the consensus is that Doxygen has done a great job of making it impossible to put a C-style comment into a code sample. doxygen is designed for source file commenting. you couldn't compile a nested C-style comment, doxy

[PATCH v2] doc: Add config check for doxygen 1.6.0+.

2014-12-03 Thread Jon A. Cruz
Add a config time check for a new enough (1.6.0+) version of doxygen. v2. require 1.6.0+ instead of 1.8.0+ Signed-off-by: Jon A. Cruz --- configure.ac | 8 1 file changed, 8 insertions(+) diff --git a/configure.ac b/configure.ac index 6f8220b..12dd94c 100644 --- a/configure.ac +++ b/c

Re: [PATCH 1/4] doc: use markdown tildes for code blocks

2014-12-03 Thread Peter Hutterer
On Wed, Dec 03, 2014 at 02:20:50PM -0800, Bill Spitzak wrote: > On 12/03/2014 01:49 PM, Peter Hutterer wrote: > > >what is \comment? I can't find it in the doxygen tag list. > > That stumped me for a while, too. It's an "alias" defined in the > wayland.doxygen file. As far as I can tell aliases a

Re: [PATCH 2/4] doc: Shut off second set of warnings from generating the man pages

2014-12-03 Thread Bill Spitzak
Yea, ignore this patch. I think I can get Doxygen to produce both outputs in one pass, which will be faster and only produce one set of warnings. On 12/03/2014 01:42 PM, Peter Hutterer wrote: On Wed, Dec 03, 2014 at 12:27:54PM -0800, Bill Spitzak wrote: On 12/02/2014 07:47 PM, Peter Huttere

Re: [PATCH 1/4] doc: use markdown tildes for code blocks

2014-12-03 Thread Bill Spitzak
On 12/03/2014 01:49 PM, Peter Hutterer wrote: what is \comment? I can't find it in the doxygen tag list. That stumped me for a while, too. It's an "alias" defined in the wayland.doxygen file. As far as I can tell aliases are not really commands, they are instead more like macros. This explai

Re: [PATCH 1/4] doc: use markdown tildes for code blocks

2014-12-03 Thread Peter Hutterer
On Wed, Dec 03, 2014 at 12:37:40PM -0800, Bill Spitzak wrote: > > > On 12/02/2014 07:45 PM, Peter Hutterer wrote: > >On Tue, Dec 02, 2014 at 06:29:33PM -0800, Bill Spitzak wrote: > >>This requires doxygen 1.8 or newer. > >>I could not figure out how to make configure.ac test the doxygen > >>versi

Re: [PATCH 2/4] doc: Shut off second set of warnings from generating the man pages

2014-12-03 Thread Peter Hutterer
On Wed, Dec 03, 2014 at 12:27:54PM -0800, Bill Spitzak wrote: > > > On 12/02/2014 07:47 PM, Peter Hutterer wrote: > >On Tue, Dec 02, 2014 at 06:29:34PM -0800, Bill Spitzak wrote: > >>These warnings are a duplicate of the first set > >>--- > >> doc/doxygen/Makefile.am |1 + > >> 1 file change

Re: [PATCH] doc: Add config check for doxygen 1.8.0+.

2014-12-03 Thread Jon A. Cruz
I'd be fine with this being held off on. In general the next older version support to hold the line at would be 1.6.1 as that's what is in RHEL/CentOS/Scientific 6. That makes me think perhaps I should first submit this updated to start with a check for 1.6.0 and then leave bumping up to 1.8+ as a

Re: [PATCH] doc: Add config check for doxygen 1.8.0+.

2014-12-03 Thread Bill Spitzak
Thanks! You know I tried searching for "version" in the autotools documents, but did not find this. That documentation is pretty incomplete. Note that as far as I can tell the only feature we are using is the tildes for code markup, and that is being questioned right now. On 12/02/2014 09:48

Re: [PATCH 1/4] doc: use markdown tildes for code blocks

2014-12-03 Thread Bill Spitzak
On 12/02/2014 07:45 PM, Peter Hutterer wrote: On Tue, Dec 02, 2014 at 06:29:33PM -0800, Bill Spitzak wrote: This requires doxygen 1.8 or newer. I could not figure out how to make configure.ac test the doxygen version number. It appears to be really complex. So it will run with any version of d

Re: [PATCH 2/4] doc: Shut off second set of warnings from generating the man pages

2014-12-03 Thread Bill Spitzak
On 12/02/2014 07:47 PM, Peter Hutterer wrote: On Tue, Dec 02, 2014 at 06:29:34PM -0800, Bill Spitzak wrote: These warnings are a duplicate of the first set --- doc/doxygen/Makefile.am |1 + 1 file changed, 1 insertion(+) diff --git a/doc/doxygen/Makefile.am b/doc/doxygen/Makefile.am in

Re: [PATCH wayland v3 2/2] client: update documentation about threading

2014-12-03 Thread Daniel Stone
Hi, On 3 December 2014 at 14:53, Marek Chalupa wrote: > + * fds[0].fd = wl_display_get_fd(display); > + * fds[0].event = POLLIN | POLLHUP | POLLERR; > POLLHUP and POLLERR are not valid for fds[0].events (note spelling); they can be returned in revents if these events happened, but you don't

Re: [PATCH] Weston: fbdev: Remove uneeded semicolon

2014-12-03 Thread Daniel Stone
Hi, On 3 December 2014 at 03:07, nerdopolis wrote: > --- > 0001-weston-fbdev-remove-uneeded-semicolon.patch | 33 +++ > fd | 116 > +++ > We probably don't need these, either. ;) Instead of using git send-email directly, yo

[PATCH wayland v3 1/2] client: update obsolete comments

2014-12-03 Thread Marek Chalupa
1) there is nothing like main thread since 3c7e8bfbb4745315b7bcbf69fa746c3d6718c305 anymore, so remove it from documentation and update the doc accordingly. 2) use calling 'default queue' instead of 'main queue'. In the code we use display->default_queue, so it'll be easier the understand

[PATCH wayland v3 2/2] client: update documentation about threading

2014-12-03 Thread Marek Chalupa
Remove out-dated documentation and add few more words about this topic. v2. replace a paragraph by better explanation from Pekka Paalanen fix other notes from reviewing v3. fix typo Signed-off-by: Marek Chalupa --- src/wayland-client.c | 104

[PATCH] Remove explicit dependency on $(WAYLAND_LIBS)

2014-12-03 Thread Olivier Fourdan
Hi I was trying to build XWayland as per the recipe from http://wayland.freedesktop.org/xserver.html and ran into an issue because I have the Wayland libs installed in a non-standard location (from http://wayland.freedesktop.org/building.html) Basically, xserver/hw/xwayland/Makefile.am speci

Re: [PATCH wayland v2 1/2] client: update obsolete comments

2014-12-03 Thread Marek Chalupa
On 28 November 2014 at 14:30, Pekka Paalanen wrote: > On Fri, 28 Nov 2014 12:18:55 +0100 > Marek Chalupa wrote: > > > 1) there is nothing like main thread since > >3c7e8bfbb4745315b7bcbf69fa746c3d6718c305 anymore, so remove > >it from documentation and update the doc accordingly. > > > >

Re: [PATCH wayland] tests: fix memory leak

2014-12-03 Thread Marek Chalupa
On 1 December 2014 at 11:42, Pekka Paalanen wrote: > On Fri, 21 Nov 2014 11:18:33 +0100 > Marek Chalupa wrote: > > > We didn't free the struct client that we got from client_connect() > > > > Signed-off-by: Marek Chalupa > > --- > > tests/display-test.c| 23 +-- > > tes