[PATCH 1/4] doc: don't duplicate files for doxygen->man input

I was not sure if this is a problem but it seems wrong to have the same .c file listed twice as doxygen input. --- doc/doxygen/Makefile.am | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/doc/doxygen/Makefile.am b/doc/doxygen/Makefile.am index f8d636e..6c87743 1

[PATCH 3/4] doc: put doxygen output into $publican_sources

This removes the need to name them multiple times --- doc/publican/Makefile.am | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/doc/publican/Makefile.am b/doc/publican/Makefile.am index c9a6274..d4514cc 100644 --- a/doc/publican/Makefile.am +++ b/doc/publican/Ma

[PATCH 4/4] doc: Make it easier to add a new doxygen page

If you have a library called Foo, you only have to add en-US/FooAPI.xml to $publican_sources in publican/Makefile.am, and a list of C source files to doxygen/Makefile.am. --- doc/doxygen/Makefile.am | 29 + doc/publican/Makefile.am | 26

[PATCH] doc: changes so each libaray is an appendix

This splits the libwayland-client and -server into different html pages, as they have different objects such as wl_display with the same name. Also changes so it is easier to add doxygen output for a new library such as libinput or libweston. This is far from perfect. In particular the intro text

[PATCH 2/4] doc: Split libwayland-client and -server into different pages

This was suggested before to make it clearer that things like wl_display are different objects in each of them. I made these into two appendixes because the protocol spec was already an appendix. --- doc/publican/Makefile.am |1 - doc/publican/doxygen-to-publican.xsl | 28 +++

[PATCH v2 1/2] compositor: Propagate errors from module_init

load_modules currently ignores errors signalled by both weston_load_module and module_init, and instead always returns 0. Its return value appears to be checked in callers, so we most likely want to propagate any errors. Signed-off-by: Ondřej Majerech --- src/compositor.c | 6 -- 1 file chan

[PATCH v2 2/2] ivi-shell: Say something when configuration is missing

When ivi-module is not set in weston.conf, we probably want to tell the user about their error instead of just dying. Signed-off-by: Ondřej Majerech --- ivi-shell/ivi-shell.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ivi-shell/ivi-shell.c b/ivi-shell/ivi-shell.c index a14010e..02fbafb

[PATCH v2 0/2] Let's propagate even more errors

Derp. After sending this out, I noticed there's yet another low-hanging fruit to be picked. Ondřej Majerech (2): compositor: Propagate errors from module_init ivi-shell: Say something when configuration is missing ivi-shell/ivi-shell.c | 1 + src/compositor.c | 6 -- 2 files changed

[PATCH 1/2] compositor: Propagate error from module_init

load_modules currently calls module_init, but completely ignores its return value and instead always returns 0. Its return value appears to be checked in callers, so we most likely want to propagate any error signalled by module_init. Signed-off-by: Ondřej Majerech --- src/compositor.c | 3 ++-

[PATCH 2/2] ivi-shell: Say something when configuration is missing

When ivi-module is not set in weston.conf, we probably want to tell the user about their error instead of just dying. Signed-off-by: Ondřej Majerech --- ivi-shell/ivi-shell.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ivi-shell/ivi-shell.c b/ivi-shell/ivi-shell.c index a14010e..02fbafb

[PATCH] Remove spurious addition from range normalization calculation

The presence of a "+1" in the range calculation prevents the normalization functions from returning a value of "1.0" when absinfo->value has reached its maximum. Signed-off-by: Jason Gerecke --- src/evdev-tablet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/evdev-

[PATCH weston 5/7] text: Use bool for input_panel_visible

Signed-off-by: Derek Foreman --- src/text-backend.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/text-backend.c b/src/text-backend.c index e274f0b..e50569a 100644 --- a/src/text-backend.c +++ b/src/text-backend.c @@ -23,6 +23,7 @@ #include "config.h" +#inclu

[PATCH weston 1/7] editor: Make editor multi-seat aware

With multi-seat, multiple entries can occur on the text inputs in the editor. Also, the panel shouldn't be hidden by the editor if either text entry is still active. Signed-off-by: Derek Foreman --- clients/editor.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git

[PATCH weston 0/7] text-input fix-ups

Currently running weston-editor on a multi-seat configuration crashes weston. This is an attempt to clean up the crashes and fix up the input panel handling a little for multi-seat, with a few minor clean-ups along the way. Derek Foreman (7): editor: Make editor multi-seat aware text: Fix some

[PATCH weston 7/7] text: Fix text-input for multi-seat

Multi-seat configurations currently break the text-backend, crashing weston. This is an attempt to clean up any crashes and have somewhat sensible input panel behavior with multi-seat. Signed-off-by: Derek Foreman --- src/text-backend.c | 76 ++---

[PATCH weston 3/7] text: Fix coding style

Put the return type on a separate line in function declarations. Signed-off-by: Derek Foreman --- src/text-backend.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/text-backend.c b/src/text-backend.c index 6246b30..092321a 100644 --- a/src/text-backend.c +++

[PATCH weston 4/7] text: Remove unused linked list from input_method_context

Signed-off-by: Derek Foreman --- src/text-backend.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/text-backend.c b/src/text-backend.c index 092321a..e274f0b 100644 --- a/src/text-backend.c +++ b/src/text-backend.c @@ -82,8 +82,6 @@ struct input_method_context { struct text_inpu

[PATCH weston 6/7] text: Don't crash if a seat has no keyboard

A keyboard might not be present in a seat, so check that before dereferencing keyboard related pointers. Also, use the keyboard pointer we set to shorten the code a little bit. Signed-off-by: Derek Foreman --- src/text-backend.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletio

[PATCH weston 2/7] text: Fix some typos

Signed-off-by: Derek Foreman --- protocol/input-method.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/protocol/input-method.xml b/protocol/input-method.xml index 5fbc6a0..6961c5a 100644 --- a/protocol/input-method.xml +++ b/protocol/input-method.xml @@ -29,7 +29,7 @@

Re: [PATCH 1/4] doc: use markdown tildes for code blocks

On 12/05/2014 06:44 AM, Pekka Paalanen wrote: do you have any suggestions on how to get rid of the asterisks in front of code examples? All I can say is that this appears to be a Doxygen bug, and it depends both on the version of Doxygen and on what commands have been processed by Doxygen be

Re: [PATCH 1/2] evdev: Add a remove callback to the evdev_dispatch_interface

Hi, On 12/05/2014 12:59 PM, Hans de Goede wrote: Some dispatchers may want to do some cleanup at remove time, rather then at destroy time. Signed-off-by: Hans de Goede Self-nak, this patch misses the bits actually calling the remove callback. Regards, Hans --- src/evdev-mt-touchpad.c |

[PATCH weston] input: swallow the key press event when running a compositor key binding

--- src/bindings.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/bindings.c b/src/bindings.c index 5cb031a..8d4c133 100644 --- a/src/bindings.c +++ b/src/bindings.c @@ -202,6 +202,9 @@ binding_key(struct weston_keyboard_grab *grab, if (keyboard

Re: [PATCH v2] doc: Add config check for doxygen 1.6.0+.

On 12/05/2014 07:09 AM, Pekka Paalanen wrote: > > Hi, > > looking at doc/doxygen/wayland.doxygen.in it says > # Doxyfile 1.7.6.1 > > Do we know this works with Doxygen 1.6 or should we require 1.7? > > Not that it matters too much, since right now we don't have any checks, > but I'd prefer so

Re: [PATCH v2] doc: Add config check for doxygen 1.6.0+.

On Wed, 3 Dec 2014 18:26:26 -0800 "Jon A. Cruz" wrote: > Add a config time check for a new enough (1.6.0+) version of doxygen. > > v2. require 1.6.0+ instead of 1.8.0+ > > Signed-off-by: Jon A. Cruz > --- > configure.ac | 8 > 1 file changed, 8 insertions(+) > > diff --git a/config

Re: [PATCH 4/4] doc: Remove duplicated descriptions of wayland objects

On Wed, 3 Dec 2014 13:51:44 +1000 Peter Hutterer wrote: > On Tue, Dec 02, 2014 at 06:29:36PM -0800, Bill Spitzak wrote: > > This text is a duplicate of the text in the protocol documentation, but > > the converter mangled it by removing the paragraph breaks and some other > > errors. Instead repl

Re: [PATCH 1/4] doc: use markdown tildes for code blocks

On Thu, 4 Dec 2014 07:49:59 +1000 Peter Hutterer wrote: > On Wed, Dec 03, 2014 at 12:37:40PM -0800, Bill Spitzak wrote: > > > > > > On 12/02/2014 07:45 PM, Peter Hutterer wrote: > > >On Tue, Dec 02, 2014 at 06:29:33PM -0800, Bill Spitzak wrote: > > >>This requires doxygen 1.8 or newer. > > >>I

Re: [PATCH 1/4] doc: use markdown tildes for code blocks

On Tue, 02 Dec 2014 19:02:12 -0800 "Jon A. Cruz" wrote: > On 12/02/2014 06:29 PM, Bill Spitzak wrote: > > This requires doxygen 1.8 or newer. > > FYI this will cut off support for RHEL6 and corresponding distros such > as CentOS and Scientific Linux (I had to track this for my prior day job). >

Re: [PATCH] doc: Invoke doxygen via the defined make variable.

On Wed, 3 Dec 2014 13:44:56 +1000 Peter Hutterer wrote: > On Tue, Dec 02, 2014 at 05:54:07PM -0800, Jon A. Cruz wrote: > > Invoke doxygen via the autoconf-defined make variable instead of directly. > > This brings it in line with standard makefile practices. > > > > Signed-off-by: Jon A. Cruz >

[PATCH weston v1 16/17] test-helpers: add functions that simulate pointer actions

Add functions that simulate pointer movement, draging and clicking. These functions will be handy in more tests, so add them to helpers. Signed-off-by: Marek Chalupa --- tests/weston-test-client-helper.c | 57 +++ tests/weston-test-client-helper.h | 9 +++

[PATCH weston v1 15/17] tests: add test-suite tests

Tests for test-suite itself Signed-off-by: Marek Chalupa --- Makefile.am | 7 +++- tests/test-suite-test.c | 92 + 2 files changed, 98 insertions(+), 1 deletion(-) create mode 100644 tests/test-suite-test.c diff --git a/Makefile.am b

[PATCH weston v1 13/17] tests: make frame_callback_wait universal

frame_callback_wait uses wl_display_dispatch. Use display_dispatch for toytoolkit clients. Signed-off-by: Marek Chalupa --- tests/weston-test-client-helper.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/tests/weston-test-client-helper.c b/tests/weston-test-cli

[PATCH weston v1 17/17] tests: add interactive tests

These tests are using pointer and keyboard simulated events to interact with client. Signed-off-by: Marek Chalupa --- Makefile.am | 7 ++- tests/interactive-test.c | 135 +++ 2 files changed, 141 insertions(+), 1 deletion(-) create mode

[PATCH weston v1 02/17] tests: link tests against libtoytoolkit

We want to use toytoolkit in tests. This patch also removes collisions of symbols defined in libtoytoolkit with symbols defined in tests (i. e. shm_listener) Signed-off-by: Marek Chalupa --- Makefile.am | 26 +++--- tests/weston-test-client-helper.c | 5

[PATCH weston v1 11/17] add get_geometry & geometry request/event

--- protocol/wayland-test.xml | 11 +++ tests/weston-test-client-helper.c | 18 ++ tests/weston-test-client-helper.h | 6 ++ tests/weston-test.c | 23 +++ 4 files changed, 58 insertions(+) diff --git a/protocol/wayland-test.xm

[PATCH weston v1 06/17] clients: add window_get_decoration_size

In tests we need to know about the decoration size. Moreover it's a small clean-up. Signed-off-by: Marek Chalupa --- clients/window.c | 37 ++--- clients/window.h | 2 ++ 2 files changed, 24 insertions(+), 15 deletions(-) diff --git a/clients/window.c b/clients/

[PATCH weston v1 12/17] tests: make client_roundtrip universal

Make client_roundtrip a function instead of macro and make it work with both - normal clients and toytoolkit clients. Signed-off-by: Marek Chalupa --- tests/weston-test-client-helper.c | 17 + tests/weston-test-client-helper.h | 5 ++--- 2 files changed, 19 insertions(+), 3 dele

[PATCH weston v1 10/17] window: add display_dispatch

Split display_run into two functions - display_run and display_dispatch. display_dispatch is the part that actually does something and display_run just calls it in a loop. Now we can dispatch toytoolkit events in tests (display_run is blocking, so we couldn't use that) Signed-off-by: Marek Chalupa

[PATCH weston v1 14/17] weston-test: use real time instead of magic number

Pass time from weston_compositor_get_time() into notify_{motion, button} etc. Until now the time was hardcoded to 100 and with toytoolkit clients it causes problems, because toytoolkit checks the time. Signed-off-by: Marek Chalupa --- tests/weston-test.c | 7 --- 1 file changed, 4 insertions

[PATCH weston v1 05/17] clients: add missing getters for input objects

We need get wayland objects from toytoolkit display (there already are display_get_output, input_get_seat, ...), so that we can use them in the tests. This patch adds: display_get_input() input_get_wl_pointer() input_get_wl_keyboard() input_get_wl_touch() Signed-off-by: Marek Chalupa ---

[PATCH weston v1 09/17] tests: do attach only with normal surfaces

When we call move_client on toytoolkit client when intializing, then the wl_buffer is NULL and we don't want that. Actually, toytoolkit clients don't need attaching and commiting the surface at all, because it has been already done. Signed-off-by: Marek Chalupa --- tests/weston-test-client-helpe

[PATCH weston v1 08/17] add toytoolkit_client_create

--- tests/weston-test-client-helper.c | 345 -- tests/weston-test-client-helper.h | 3 + 2 files changed, 333 insertions(+), 15 deletions(-) diff --git a/tests/weston-test-client-helper.c b/tests/weston-test-client-helper.c index f4c04eb..ea54c9e 100644 ---

[PATCH weston v1 07/17] tests-helper: distil the functionality from handlers

Split out the real code from event handlers (like pointer_handle_motion, etc.) and put it into standalone function. We'll use it in follow-up patch where we will register handlers for toytoolkit clients and we'll use the new functions so that the code won't be duplicated. Signed-off-by: Marek Chal

[PATCH weston v1 03/17] tests: add toytoolkit into struct client

Allow store information about toytoolkit widget in client. Now we'll be able to get client behave as a toytoolkit client. Signed-off-by: Marek Chalupa --- tests/weston-test-client-helper.h | 9 + 1 file changed, 9 insertions(+) diff --git a/tests/weston-test-client-helper.h b/tests/wes

[PATCH weston v1 04/17] tests: use wl_* objects instead of test structs

When storing client state i. e. focus, we use our structs. For example when we got pointer focus, we store into pointer->focus the type 'struct surface'. We did it via user data in wl_* object, but toytoolkit has its own data in the objects and storing and reading them as our structures results in

Toytoolkit interactive tests

Hi, This series of patches adds possibility to create a test client that uses toytoolkit and to easily interact with it. If accepted, this solves the bug: https://bugs.freedesktop.org/show_bug.cgi?id=83990 Makefile.am | 38 +- clients/window.c | 137 -

[PATCH weston v1 01/17] tests: simplify move_client and make it more generic

Move client right in the move_client funciton. This allows the surface use its own configure function, so from now the client can be any weston surface (xdg, wl_shell, ..) Signed-off-by: Marek Chalupa --- tests/weston-test.c | 62 + 1 file chan

Re: [PATCH wayland] tests: fix memory leak

On 4 December 2014 at 12:12, Pekka Paalanen wrote: > On Wed, 3 Dec 2014 11:44:47 +0100 > Marek Chalupa wrote: > > > On 1 December 2014 at 11:42, Pekka Paalanen wrote: > > > > > On Fri, 21 Nov 2014 11:18:33 +0100 > > > Marek Chalupa wrote: > > > > > > > We didn't free the struct client that we

Re: [PATCH wayland v3 2/2] client: update documentation about threading

On 3 December 2014 at 17:04, Daniel Stone wrote: > Hi, > > On 3 December 2014 at 14:53, Marek Chalupa wrote: > >> + * fds[0].fd = wl_display_get_fd(display); >> + * fds[0].event = POLLIN | POLLHUP | POLLERR; >> > > POLLHUP and POLLERR are not valid for fds[0].events (note spelling); they > c

[PATCH wayland v4] client: update documentation about threading

Remove out-dated documentation and add few more words about this topic. v2. replace a paragraph by better explanation from Pekka Paalanen fix other notes from reviewing v3. fix typo v4. fix flags for poll in an example add wl_display_cancel_read() to another example (so that user se

Re: [PATCH 1/3] Use zalloc rather than malloc and manually setting members to 0

Hi, On 26 November 2014 at 22:49, Bryce Harrington wrote: > On Wed, Nov 26, 2014 at 03:33:16PM +0100, Marek Chalupa wrote: > > On 21 November 2014 at 07:21, Bryce Harrington > > wrote: > > > > > Signed-off-by: Bryce Harrington > > > > > > - if (do_yflip) > > > - recorder->t

[PATCH weston 2/3] screenshooter: fix various memory handling

There were unchecked malloc and free of conditionally allocated memory without checking if the memory was really allocated. Also simplify error handling in one function. Signed-off-by: Marek Chalupa --- src/screenshooter.c | 27 +++ 1 file changed, 19 insertions(+), 8 del

[PATCH weston 3/3] clipboard: set fd member of clipboard_source

The fd member of clipboard_source structure was not set but was used in close(). Signed-off-by: Marek Chalupa --- src/clipboard.c | 4 1 file changed, 4 insertions(+) diff --git a/src/clipboard.c b/src/clipboard.c index dbd8c9b..a9747b9 100644 --- a/src/clipboard.c +++ b/src/clipboard.c @@

[PATCH weston 1/3] window: use roundtrip instead of dispatch after get_registry

wl_display_dispatch() just dispatches events that are in default and display queues and if there are no events, then it will wait for them. But only dispatching the events doesn't guarantee that we got all the global announcements, we need to do sync too. Therefore use wl_display_roundtrip() instea

[PATCH] touchpad: Allow the center of pinned fingers to drift over time

Allow the center of pinned fingers to drift over time, to avoid accidentally unpinning fingers. BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=86807 Signed-off-by: Hans de Goede --- src/evdev-mt-touchpad.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/evdev-mt-touchpad.c b/

[PATCH 1/2] evdev: Add a remove callback to the evdev_dispatch_interface

Some dispatchers may want to do some cleanup at remove time, rather then at destroy time. Signed-off-by: Hans de Goede --- src/evdev-mt-touchpad.c | 1 + src/evdev.c | 1 + src/evdev.h | 3 +++ 3 files changed, 5 insertions(+) diff --git a/src/evdev-mt-touchpad.c b/src/e

[PATCH 2/2] touchpad: Use remove callback to unlink event listener and stop timers

We use 2 mechanisms to unregister the trackpoint event listener depending on device removal order. 1) We have a device_removed callback, if the trackpoint gets removed before the touchpad, this gets called, sees the device being removed is the trackpoint and unregisters the listener 2) If the tou

Re: Prerequisites to build wayland / weston without x?

On 05/12/14 03:06, scsijon wrote: > I have just spent an hour or so trying to find it, and although your > documentation etc is good, this doesn't seem to be in it, or give me a hint > where to find it! > > What I am after is a list of prerequisites to build wayland / weston from > scratch with th

Re: [PATCH weston v2 2/2] compositor: Implement JSON-timeline logging

On Thu, 04 Dec 2014 12:46:33 +0100 sardemff7+wayl...@sardemff7.net wrote: > On 2014-12-04 12:23, Pekka Paalanen wrote: > > On Tue, 02 Dec 2014 12:12:28 -0800 > > Bill Spitzak wrote: > >> I think you should make an emit(FILE*, const char*) function that prints > >> a quoted string or null, instead