Re: [PATCH libinput 1/2] Change the scroll step distance to 15 and document it as degrees

I really find it doubtful that users are thinking about how many times the scroll wheel has revolved about it's axis! Much more likely is the tangent distance that the edge of the scroll wheel has moved. On a really typical mouse that I have it seems to be about 2.5mm per click. Looking at it

[PATCH libinput] tablet: Add a left handed mode and tests

On the majority of Wacom tablets, the buttons are on the left side, opposite of the side where the palm is meant to rest. Because of this, it's impossible to use the tablet with your left hand (comfortably, anyway) unless you flip it over, in which case the coordinates need to be inverted for it

Re: [PATCH libinput 1/2] Change the scroll step distance to 15 and document it as degrees

On Mon, Jan 19, 2015 at 05:49:36PM -0800, Bill Spitzak wrote: I really find it doubtful that users are thinking about how many times the scroll wheel has revolved about it's axis! Much more likely is the tangent distance that the edge of the scroll wheel has moved. On a really typical mouse

[PATCH libinput] Rename a tablet function to ...has_axis to match the pointer axis function

Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- For the tablet-support branch, provides some consistency. src/libinput.c | 2 +- src/libinput.h | 4 ++-- src/libinput.sym| 2 +- test/tablet.c | 20 ++-- tools/event-debug.c | 2 +- 5 files

Re: [PATCH libinput] evdev.c: Return from evdev_configure_device() after configuring a device as a tablet

On Mon, Jan 19, 2015 at 08:54:45PM -0500, Stephen Chandler Paul wrote: As it turns out upon detecting a tablet in evdev_configure_device(), there isn't any call to return to escape the function once we've finished configuring the tablet. As a result, the code continues running and ends up

Re: [PATCH libinput] Add libinput_event_pointer_get_axis_click_count() to count wheel clicks

This is great and addresses my problem with the Windows API mentioned in a previous email. Guess I should have looked at all the posts before responding. On 01/13/2015 12:01 AM, Peter Hutterer wrote: On Tue, Jan 13, 2015 at 03:12:24PM +0800, Jonas Ådahl wrote: On Tue, Jan 13, 2015 at

[PATCH libinput] evdev.c: Return from evdev_configure_device() after configuring a device as a tablet

As it turns out upon detecting a tablet in evdev_configure_device(), there isn't any call to return to escape the function once we've finished configuring the tablet. As a result, the code continues running and ends up reconfiguring the device as a pointer, resulting in strange behavior such as

Re: [PATCH] libinput-seat: Don't regard no input devices as failure

On 01/14/2015 06:33 AM, Pekka Paalanen wrote: Btw. showing that message on screen instead of hiding it in the log would be quite a lot of effort: add an event to desktop-shell.xml, let Weston emit the event, and make weston-desktop-shell create a new window with the message. That window might

Re: [PATCH weston v2 08/20] compositor: add weston_matrix_transform_rect() and use it where appropriate

On 01/09/2015 01:42 PM, Giulio Camuffo wrote: Just a nitpick below: +WL_EXPORT pixman_box32_t +weston_matrix_transform_rect(struct weston_matrix *matrix, +pixman_box32_t rect) The function name doesn't imply it returns an axis aligned bounding box. Maybe

Re: [PATCH weston] xwm: don't set inactive surfaces as top level

On 01/12/2015 09:14 AM, Giulio Camuffo wrote: +static bool +weston_wm_window_inactive(struct weston_wm_window *window) +{ + struct weston_wm *wm = window-wm; + + return window-type == wm-atom.net_wm_window_type_tooltip || + window-type ==

Re: [PATCH libinput] tablet: Add a left handed mode and tests

On Mon, Jan 19, 2015 at 09:44:08PM -0500, Stephen Chandler Paul wrote: On the majority of Wacom tablets, the buttons are on the left side, opposite of the side where the palm is meant to rest. Because of this, it's impossible to use the tablet with your left hand (comfortably, anyway) unless

Re: [PATCH weston 6/6] zoom: Change how we select a zoom location

This seems excessively complicated compared to a version that just figures out an x/y pair to use instead of seat-pointer-x/y and leaves the rest of the code alone. On 01/09/2015 10:45 AM, Derek Foreman wrote: Any time the zoom is updated the best zoom target will be calculated with the

Re: [PATCH 1/7] protocol: add linux_dmabuf extension RFCv1

On Thu, Jan 08, 2015 at 02:26:00PM +0200, Pekka Paalanen wrote: On Mon, 5 Jan 2015 11:44:49 +0100 Daniel Vetter dan...@ffwll.ch wrote: On Thu, Dec 18, 2014 at 01:45:22PM +0200, Pekka Paalanen wrote: On Thu, 18 Dec 2014 10:25:09 +0100 Daniel Vetter dan...@ffwll.ch wrote: On Fri,

Re: [PATCH weston] ivi-shell-transition: check create_layout_transition() return value.

Hi, 2015-01-19 3:04 GMT+01:00, Tanibata, Nobuhiko (ADITJ/SWG) ntanib...@jp.adit-jv.com: Hi, I basically agree this solution. When I observe other code in Weston. There are two patterns when error happens in Weston. - just output error by Weston_log. And then return from the method. Please,

Re: [PATCH] Fix mutex hang in colord on output removal

On 15 January 2015 at 14:40, Olivier Fourdan ofour...@redhat.com wrote: ocms is taken from the container now (that was the casting error), so no need for the lookup from cms as we already have it. Ohh of course, makes sense. Signed-off-by: Richard Hughes rich...@hughsie.com Pekka, can you