Re: [PATCH libinput 1/2] test: switch event conversion tests to use litest devices

Hi, On 03-02-15 08:53, Hans de Goede wrote: Hi, On 03-02-15 05:50, Peter Hutterer wrote: Makes the code use more commonly used paths, no real functional changes at this point. This was using hand-crafted devices as it predates the litest_add_for_device() helper. For an upcoming patch to use t

Re: [PATCH libinput 1/2] test: switch event conversion tests to use litest devices

Hi, On 03-02-15 05:50, Peter Hutterer wrote: Makes the code use more commonly used paths, no real functional changes at this point. This was using hand-crafted devices as it predates the litest_add_for_device() helper. For an upcoming patch to use the udev ID_INPUT_. tags the event_conversion_k

Re: [PATCH V2] configure.ac: Fallback to older detection code if pkg-config can't find expat

On Mon, Feb 02, 2015 at 06:33:49PM -0800, Bill Spitzak wrote: > > > On 02/02/2015 03:12 PM, sardemff7+wayl...@sardemff7.net wrote: > >On 2015-02-02 22:29, Bill Spitzak wrote: > >>This paritally reverts commit a4afd90f9f0c27ed5f3f313b915c260673f8be34. > >> > >>On older expat versions (ie the one o

Re: [PATCH libinput] Add a libinput_device_get_udev_devices() call for merged devices

On Tue, Feb 03, 2015 at 09:36:14AM +0800, Jonas Ådahl wrote: > On Fri, Jan 30, 2015 at 03:48:15PM +1000, Peter Hutterer wrote: > > Merged devices may comprise of multiple event nodes. To get those we need to > > return all udev devices we have. > > > > This patch still leaves the backend where it

Re: [PATCH libinput] evdev: retrieve udev tags

On Mon, Feb 02, 2015 at 01:43:48PM -0500, Benjamin Tissoires wrote: > Udev already tags the devices by opening each of them and analyzing their > features. We are basically re-doing this in libinput. > > The advantage of udev tags over the plain heuristic from libinput is that > users (or driver w

[PATCH libinput 2/2] path: make sure udev devices are initialized before usage

When creating uinput devices, we get the devnode from the kernel directly rather than through udev. When we add this to the path backend too quickly the udev_device we get may not be fully initialized and properties may be missing. This causes false test results. Avoid this by making sure the hand

[PATCH libinput 1/2] test: switch event conversion tests to use litest devices

Makes the code use more commonly used paths, no real functional changes at this point. This was using hand-crafted devices as it predates the litest_add_for_device() helper. For an upcoming patch to use the udev ID_INPUT_. tags the event_conversion_key test requires this change: without it the dev

Re: [PATCH V2] configure.ac: Fallback to older detection code if pkg-config can't find expat

On 02/02/2015 03:12 PM, sardemff7+wayl...@sardemff7.net wrote: On 2015-02-02 22:29, Bill Spitzak wrote: This paritally reverts commit a4afd90f9f0c27ed5f3f313b915c260673f8be34. On older expat versions (ie the one on Ubuntu 12.04) there is no pkg-config file, so fall back to the previous test f

Re: [PATCH libinput 5/5] zalloc the libinput_source, don't malloc it

On Tue, Feb 03, 2015 at 11:07:06AM +1000, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer Reviewed-by: Jonas Ådahl on the whole series. > --- > src/libinput.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libinput.c b/src/libinput.c > index 951698a..7456b9

Re: [PATCH libinput] Add a libinput_device_get_udev_devices() call for merged devices

On Fri, Jan 30, 2015 at 03:48:15PM +1000, Peter Hutterer wrote: > Merged devices may comprise of multiple event nodes. To get those we need to > return all udev devices we have. > > This patch still leaves the backend where it is (one evdev device per libinput > device) and merely introduces the n

[PATCH libinput 3/5] test: add pointer acceleration defaults test

Signed-off-by: Peter Hutterer --- test/pointer.c | 40 1 file changed, 40 insertions(+) diff --git a/test/pointer.c b/test/pointer.c index 45e0d57..9a91231 100644 --- a/test/pointer.c +++ b/test/pointer.c @@ -732,6 +732,44 @@ START_TEST(pointer_scroll_but

[PATCH libinput 4/5] Don't init pointer acceleration on absolute devices

Note: touchpads have a different backend, we never get here in that case. This only applies to true absolute pointer devices. Signed-off-by: Peter Hutterer --- src/evdev.c| 3 ++- test/pointer.c | 26 ++ 2 files changed, 28 insertions(+), 1 deletion(-) diff --git a/

[PATCH libinput 5/5] zalloc the libinput_source, don't malloc it

Signed-off-by: Peter Hutterer --- src/libinput.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libinput.c b/src/libinput.c index 951698a..7456b90 100644 --- a/src/libinput.c +++ b/src/libinput.c @@ -510,7 +510,7 @@ libinput_add_fd(struct libinput *libinput, struc

[PATCH libinput 2/5] evdev: set the default speed after initializing ptraccel

https://bugs.freedesktop.org/show_bug.cgi?id=88899 Signed-off-by: Peter Hutterer --- src/evdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/evdev.c b/src/evdev.c index 1b3bb90..b2b8cbf 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -1229,6 +1229,9 @@ evdev_device_init_pointer_acce

[PATCH libinput 1/5] filter: zalloc the struct to make sure the speed is initialized

Signed-off-by: Peter Hutterer --- src/filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/filter.c b/src/filter.c index 89390d1..72ef760 100644 --- a/src/filter.c +++ b/src/filter.c @@ -286,7 +286,7 @@ create_pointer_accelerator_filter(accel_profile_func_t profile)

Re: [PATCH wayland] test-runner: wait for concrete pid

Hi Marek, That change looks good (I'll assume you've observed it improve behavior in your use scenarios). I seem to recall some ugliness in this general area when correcting tests for some other project under Google test (daemon development, signal masking and other such), but those should be sep

Re: [PATCH weston v4] xwm: support maximizing xwayland windows

On Thu, Jan 29, 2015 at 07:06:49PM +0200, Giulio Camuffo wrote: > This patch adds the maximize button to the window frame for the windows > which set the MWM_DECOR_MAXIMIZE hint, and it wires it with the shell > via a new method in weston_shell_interface. > Additionally, it also listens for the wm

Re: [PATCH V2] configure.ac: Fallback to older detection code if pkg-config can't find expat

On 2015-02-02 22:29, Bill Spitzak wrote: This paritally reverts commit a4afd90f9f0c27ed5f3f313b915c260673f8be34. On older expat versions (ie the one on Ubuntu 12.04) there is no pkg-config file, so fall back to the previous test for the header file when it fails. Test is slightly cleaned up from

Re: [PATCH weston] desktop-shell: Remove unnecessary type casts

On Fri, Jan 30, 2015 at 11:30:42AM -0800, Jon A. Cruz wrote: > Looks good. > > Reviewed-by: Jon A. Cruz Thanks, applied: aff7c33..8aeeac8 master -> master > On 01/30/2015 11:24 AM, Derek Foreman wrote: > > Remove a few instances of casting weston_seat to weston_seat. > > > > Signed-off-b

Re: [PATCH weston] screenshooter: remove useless cast

On Mon, Feb 02, 2015 at 01:03:23PM -0600, Derek Foreman wrote: > Signed-off-by: Derek Foreman Reviewed-by: Bryce Harrington Thanks, applied: 7424c81..aff7c33 master -> master > --- > src/screenshooter.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/screens

[PATCH v3 weston] input: Don't test keyboard/pointer/touch pointers

Keyboards and pointers aren't freed when devices are removed, so we should really be testing keyboard_device_count and pointer_device_count in most cases, not the actual pointers. Otherwise we end up with different behaviour after removing a device than we had before it was inserted. This commit r

Re: [PATCH v2 libinput] add simple symbols leak checker

On Mon, Feb 02, 2015 at 01:16:23PM +0100, Marek Chalupa wrote: > This patch adds simple script that compares libinput.sym file to the > functions that are marked by LIBINPUT_EXPORT. This script is added > to make check target. > > v2. use noinst_SCRIPTS instead of dummy target > drop .sh suffi

Re: [PATCH v2 weston] input: Don't test keyboard/pointer/touch pointers

On 02/02/15 04:26 PM, Hardening wrote: > Le 02/02/2015 22:24, Derek Foreman a écrit : >> Thanks for looking at this rather cumbersome patch! :) >> >> On 02/02/15 01:40 PM, Bill Spitzak wrote: >>> Is there a reason it does not just clear the pointer when >>> keyboard_device_count is changed to zero?

[ANNOUNCE] weston 1.6.92

This is the first release candidate for Weston 1.7. See the end of this email for download links. The main new feature added since rc1 is adding the missing feedback flags, including ZERO_COPY, to the Presentation extension protocol specification. Compositors can use these flags to help clients

Re: [PATCH v2 weston] input: Don't test keyboard/pointer/touch pointers

Le 02/02/2015 22:24, Derek Foreman a écrit : > Thanks for looking at this rather cumbersome patch! :) > > On 02/02/15 01:40 PM, Bill Spitzak wrote: >> Is there a reason it does not just clear the pointer when >> keyboard_device_count is changed to zero? That would seem like a smaller >> patch. >

Re: [PATCH v2 weston] input: Don't test keyboard/pointer/touch pointers

On 02/02/15 03:40 PM, Bill Spitzak wrote: > On 02/02/2015 01:24 PM, Derek Foreman wrote: > >>> force_kill_binding() appears to have deleted the setting of the >>> focus_surface variable. >> >> I don't see it... I think I just moved it to the top of the function? > > I think you are right. > > I

Re: [PATCH v2 weston] input: Don't test keyboard/pointer/touch pointers

On 02/02/2015 01:24 PM, Derek Foreman wrote: force_kill_binding() appears to have deleted the setting of the focus_surface variable. I don't see it... I think I just moved it to the top of the function? I think you are right. It is assuming keyboard is not null however. ___

[PATCH V2] configure.ac: Fallback to older detection code if pkg-config can't find expat

This paritally reverts commit a4afd90f9f0c27ed5f3f313b915c260673f8be34. On older expat versions (ie the one on Ubuntu 12.04) there is no pkg-config file, so fall back to the previous test for the header file when it fails. Test is slightly cleaned up from previous one. I could not use AC_SEARCH_L

Re: [PATCH v2 weston] input: Don't test keyboard/pointer/touch pointers

Thanks for looking at this rather cumbersome patch! :) On 02/02/15 01:40 PM, Bill Spitzak wrote: > Is there a reason it does not just clear the pointer when > keyboard_device_count is changed to zero? That would seem like a smaller > patch. Pulled Jonas Ådahl in on the CC for that question... I

[ANNOUNCE] wayland 1.6.92

This is the first release candidate for Wayland 1.7. See the end of this email for download links. Quite a number of patches landed this past week since the alpha, largely cleanup/enhancements to documentation and tests. Architectural diagrams in the developer documentation is now mechanically g

Re: [PATCH] RDP compositor: fixes for multiple connections and mstsc

Hello, I had a bit problem to apply the patch. I tried both 1.6.0 and weston git. Finally I went to patch the 1.6.0 version I have in Fedora 21. I needed to comment out the cmd->skipCompression = FALSE; freerdp-devel-1.2.0-0.2.beta.1.fc21.x86_64 #define FREERDP_VERSION_MAJOR 1 #define FREERDP_VE

Re: [PATCH v2 weston] input: Don't test keyboard/pointer/touch pointers

Is there a reason it does not just clear the pointer when keyboard_device_count is changed to zero? That would seem like a smaller patch. Assuming there is a good reason there seem to be some errors. At first I thought there were just redundant checks for seat being null, which I think should

[PATCH v2 weston] input: Don't test keyboard/pointer/touch pointers

Keyboards and pointers aren't freed when devices are removed, so we should really be testing keyboard_device_count and pointer_device_count in most cases, not the actual pointers. Otherwise we end up with different behaviour after removing a device than we had before it was inserted. This commit r

[PATCH weston] screenshooter: remove useless cast

Signed-off-by: Derek Foreman --- src/screenshooter.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/screenshooter.c b/src/screenshooter.c index c98e2f9..4e32db5 100644 --- a/src/screenshooter.c +++ b/src/screenshooter.c @@ -558,8 +558,7 @@ weston_recorder_destroy(struct

[PATCH libinput] evdev: retrieve udev tags

Udev already tags the devices by opening each of them and analyzing their features. We are basically re-doing this in libinput. The advantage of udev tags over the plain heuristic from libinput is that users (or driver writers) can force some tags that are not detected by common rules. For instanc

[PATCH v2 libinput] add simple symbols leak checker

This patch adds simple script that compares libinput.sym file to the functions that are marked by LIBINPUT_EXPORT. This script is added to make check target. v2. use noinst_SCRIPTS instead of dummy target drop .sh suffix generate the script from .in file use -u swich when running diff

Re: wayland 1.6.91 testsuite failure [Re: [ANNOUNCE] wayland 1.6.91]

On Monday 2015-02-02 11:17, Marek Chalupa wrote: >Sent a patch that fixed it for me. I meant to send it as a reply to this, >but something went wrong. >Here it is: [PATCH wayland] test-runner: wait for concrete pid  > >Does it fix it on your side? Nope, the patch does not address my issue. Howeve

Re: wayland 1.6.91 testsuite failure [Re: [ANNOUNCE] wayland 1.6.91]

Sent a patch that fixed it for me. I meant to send it as a reply to this, but something went wrong. Here it is: [PATCH wayland] test-runner: wait for concrete pid Does it fix it on your side? Cheers, Marek On Mon, F

Re: [PATCH libinput] test: add per-device udev rule support

Hi, On 02-02-15 04:55, Peter Hutterer wrote: Don't rely on a magic version tag, instead let a device define a udev rule and drop that into the udev runtime directory before the device is created. There are a couple of caveats with this approach: first, since this changes system-wide state it ma

[PATCH wayland] test-runner: wait for concrete pid

After running a test in fork, we were waiting for any child to terminate. It is OK unless the child forks again. If the child calls fork, the waitid can catch the child's child termination, stop block and run another test while the former test is still running. This is racy i. e. when adding socket