[PATCH weston] xwm: Fix a weston crash when a window surface is created after unmap

2015-04-09 Thread Derek Foreman
If windows are created and quickly destroyed it's possible that they'll be on the unpaired window list at the time of surface creation. The surface destroy listener for that surface isn't properly freed and a crash happens some time later. This patch removes the window from the unpaired list duri

Re: [PATCH libinput 0/3] Fix Lenovo X230 series touchpad

2015-04-09 Thread Vasily Khoruzhick
Hi Benjamin, On Thu, Apr 9, 2015 at 8:30 PM, Benjamin Tissoires wrote: > > Hi, > > Here is a series to try making the touchpad found on the Lenovo > X230 working. This touchpad has a very bad hardware resolution and by > default, libinput jumps the cursor for 10 pixels at least whenever the > use

Re: [PATCH libinput 0/3] Fix Lenovo X230 series touchpad

2015-04-09 Thread Giulio Camuffo
2015-04-09 21:23 GMT+03:00 Benjamin Tissoires : > On Thu, Apr 9, 2015 at 2:17 PM, Giulio Camuffo > wrote: >> 2015-04-09 20:30 GMT+03:00 Benjamin Tissoires : >>> Hi, >>> >>> Here is a series to try making the touchpad found on the Lenovo >>> X230 working. This touchpad has a very bad hardware reso

Re: [PATCH libinput 0/3] Fix Lenovo X230 series touchpad

2015-04-09 Thread Benjamin Tissoires
On Thu, Apr 9, 2015 at 2:17 PM, Giulio Camuffo wrote: > 2015-04-09 20:30 GMT+03:00 Benjamin Tissoires : >> Hi, >> >> Here is a series to try making the touchpad found on the Lenovo >> X230 working. This touchpad has a very bad hardware resolution and by >> default, libinput jumps the cursor for 10

Re: [PATCH libinput 0/3] Fix Lenovo X230 series touchpad

2015-04-09 Thread Giulio Camuffo
2015-04-09 20:30 GMT+03:00 Benjamin Tissoires : > Hi, > > Here is a series to try making the touchpad found on the Lenovo > X230 working. This touchpad has a very bad hardware resolution and by > default, libinput jumps the cursor for 10 pixels at least whenever the > user moves the finger. > > Thi

[PATCH libinput 1/3] filter: break out accel_profile_linear from pointer_accel_profile_linear

2015-04-09 Thread Benjamin Tissoires
No functional change. Allows to reuse the linear filtering in other acceleration profiles. Signed-off-by: Benjamin Tissoires --- src/filter.c | 20 +++- 1 files changed, 15 insertions(+), 5 deletions(-) diff --git a/src/filter.c b/src/filter.c index 033201f..92e6802 100644 ---

[PATCH libinput 3/3] udev: add a custom udev rule for X230 touchpads

2015-04-09 Thread Benjamin Tissoires
X230 touchpads should be tagged as LIBINPUT_MODEL_LENOVO_X230 by udev to apply a different acceleration profile. Signed-off-by: Benjamin Tissoires --- udev/99-x230.rules | 14 ++ udev/Makefile.am |4 +++- 2 files changed, 17 insertions(+), 1 deletions(-) create mode 100644 u

[PATCH libinput 4/3] evdev: Fix reported resolution of Lenovo X230 touchpads

2015-04-09 Thread Benjamin Tissoires
The Lenovo X230 advertise a vertical resolution of 136, which gives a size of 31 mm. The actual size of the touchpad is 40mm, so override the resolution to 100. /!\ This is a temporary fix. The proper fix should go in hwdb. /!\ Signed-off-by: Benjamin Tissoires --- src/evdev.c | 13 ++

[PATCH libinput 0/3] Fix Lenovo X230 series touchpad

2015-04-09 Thread Benjamin Tissoires
Hi, Here is a series to try making the touchpad found on the Lenovo X230 working. This touchpad has a very bad hardware resolution and by default, libinput jumps the cursor for 10 pixels at least whenever the user moves the finger. This series adds a special tag for such hardware and provides a s

[PATCH libinput 2/3] evdev: use a different filter for low resolution touchpad on the Lenovo X230

2015-04-09 Thread Benjamin Tissoires
Those touchpads presents an actual lower resolution that what is advertised. We see some jumps from the cursor due to the big steps in X and Y when we are receiving data. For instance, we receive: E: 13.471932 0003 16366# EV_ABS / ABS_X16366 E: 13.471932 0003 0001 9591

Re: [PATCH weston 6/6] stacking: manage stacking lists, implement present()

2015-04-09 Thread Manuel Bachmann
For reference, here is a video of the "weston-stacking" client with vanilla Weston, latest master branch, and this series of patches applied : https://www.youtube.com/watch?v=IZj72kWLY2w (if a parent window creates a new child window, and we use the "n" button from the parent again, then xdg_sur

[PATCH weston 6/6] stacking: manage stacking lists, implement present()

2015-04-09 Thread Manuel Bachmann
Due to the absence of a clever close handler, closing one window among multiple ones used to quit the application. We now keep track of our children windows, and close only these ones. If the user tries to create a new window and we already have a child, present() the child instead. The user will

[PATCH weston 5/6] toytoolkit: implement a window_present() helper function

2015-04-09 Thread Manuel Bachmann
"window_present()" is a little helper function calling "xdg_surface_present()" on a toytoolkit shell surface. Signed-off-by: Manuel Bachmann --- clients/window.c | 9 + clients/window.h | 3 +++ 2 files changed, 12 insertions(+) diff --git a/clients/window.c b/clients/window.c index 81e

[PATCH weston 4/6] desktop-shell: implement the presented() GUI notifier

2015-04-09 Thread Manuel Bachmann
Each time a managed_surface receives a "presented" event, a red tooltip will be created on the panel and stacked on the right side (near the clock). The user can click on the tooltip to make the shell send an "activate" request, and raise the surface to the foreground of its current workspace. Th

[PATCH weston 3/6] xdg-shell: implement the present() basic logic

2015-04-09 Thread Manuel Bachmann
Whenever a shell surface is created, a corresponding managed_surface object will be created and tracked down down at the shell client level. Every valid call to xdg_surface_set_title(), xdg_surface_present() or xdg_surface_present_from_event() will now fire the corresponding events ; managed_surfa

[PATCH weston 2/6] desktop-shell: define a "managed_surface" interface

2015-04-09 Thread Manuel Bachmann
The new xdg-shell present/present_from_event() requests specify that the compositor may notify the user. Thus, we need a way to pass requests and events between the compositor-side shell plugin and the shell client (which does the drawing). Define a "managed_surface" interface, which will keep tra

[PATCH weston 1/6] xdg-shell: define the present/present_from_event() requests

2015-04-09 Thread Manuel Bachmann
xdg_surface_present() and xdg_surface_present_from_event() are new requests supposed to be called on an existing xdg_surface. They tell the compositor that the surface has new content which may be of interest to the user. The compositor may then choose to notify the user. xdg_surface_present_from_

Re: [RFC : xdg_surface_present() - take 2

2015-04-09 Thread Manuel Bachmann
Hi everybody again, As there does not seem to be a great motivation to annotate the protocol, I suppose the right way to go is to have the 2 requests. I prepared the patches in this sense, and am going to push them for review right now. Regards, Manuel 2015-03-27 6:54 GMT+01:00 Manuel Bachmann

[PATCH weston v2] xwm: Add and use helper function for looking up windows in the hash table

2015-04-09 Thread Derek Foreman
This lets us verify that all callers are actually testing for a successful hash lookup at compile time. All current users of hash_table_lookup are converted to the new wm_lookup_window() and the appropriate success check is added. This fixes any call sites that used to assume a successful return a

[PATCH v2] weston-launch: Fixed TTY switching

2015-04-09 Thread mateuszx . potrola
From: Mateusz Polrola After weston-launch is executing weston it cannot close TTY file, because it is still required to properly handle SIGUSR1 and SIGUSR2 signals that are used for switching TTY. Additionally after opening TTY it has to be activated, so that user don't have to manually switch t

[PATCH] libinput_device_config_accel_set_speed: Make acceleration range wider

2015-04-09 Thread Hans de Goede
The main purpose of this patch is to allow the user to actually slow down pointer movement using libinput_device_config_accel_set_speed, this is achieved by changing the max-accel setting from "2.0 - speed" to "2.0 - speed * 1.5", resulting in a max-accel of 0.5 when the user configures speed at -1

Re: [PATCH libinput] evdev: reject devices with only one of x/y resolution

2015-04-09 Thread Hans de Goede
Hi, On 08-04-15 23:51, Peter Hutterer wrote: This is a kernel bug, reject such devices outright. This saves us from a bunch of extra double checks to make sure that the resolutions are always set up. Signed-off-by: Peter Hutterer Looks good, I've added my Rev-by and pushed this one. Regards

Re: [PATCH libinput 1/2] touchpad: a touch in TOUCH_NONE doesn't need to be ended

2015-04-09 Thread Hans de Goede
Hi, On 09-04-15 07:27, Peter Hutterer wrote: Signed-off-by: Peter Hutterer Both patches look good, I've added my Rev-by and pushed them. Regards, Hans --- src/evdev-mt-touchpad.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-

Re: [PATCH libinput] touchpad: detect fake finger overflow after BTN_TOOL_QUINTTAB

2015-04-09 Thread Hans de Goede
Hi, On 09-04-15 06:23, Peter Hutterer wrote: Up to QUINTTAP, we count fake fingers through the BTN_TOOL_*TAP kernel defines. Once we exceed QUINTTAP, the nfake_finger count returns to 0 and tp_unhover_touches terminates all touch sequences. The most visible effect of this was stopped in 591a41f

Re: Migrated randr protocol patch to weston git upstream

2015-04-09 Thread Pekka Paalanen
On Thu, 09 Apr 2015 17:07:42 +0800 Leslie Zhai wrote: > Hi Pekka, > > Thanks for your reply! > > Then how to set mirror (clone) mode for multi-monitors via > ~/.config/weston.ini [OUTPUT SECTION] by mode, transform or seat? > It is often extend mode by default when plugin new monitor, so I >

Re: [PATCH] weston-launch: Fixed TTY switching

2015-04-09 Thread Daniel Stone
Hi, On 8 April 2015 at 23:24, Bill Spitzak wrote: > On 04/08/2015 02:35 PM, Daniel Stone wrote: >> The best solution is to use strlcpy. >> >> If politics make that impossible, use snprintf(dest, len, "%s", src) >> which is exactly the same as strlcpy, including the return value! >>

Re: [PATCH] protocol: Add DnD actions

2015-04-09 Thread Carlos Garnacho
Hey Bill, On miƩ, 2015-04-08 at 14:18 -0700, Bill Spitzak wrote: > > >* Additionally to modifier state, there's other > > keyboard/accessibility features as DnD is done in > > GNOME/GTK+ > > (eg. DnD driven by cursor keys), these must be > > implemented on > >

Re: Migrated randr protocol patch to weston git upstream

2015-04-09 Thread Leslie Zhai
Hi Pekka, Thanks for your reply! Then how to set mirror (clone) mode for multi-monitors via ~/.config/weston.ini [OUTPUT SECTION] by mode, transform or seat? It is often extend mode by default when plugin new monitor, so I consider about XRandR naturally, the xrandr utility can set mirror mode

Re: Migrated randr protocol patch to weston git upstream

2015-04-09 Thread Pekka Paalanen
On Thu, 09 Apr 2015 14:42:33 +0800 Leslie Zhai wrote: > Hi wayland developers, > > I found that Quanxian Wang had implemented randr protocol in 2014 > http://lists.freedesktop.org/archives/wayland-devel/2014-April/014091.html > > But I could not find randr relative branch in weston official gi

Re: [PATCH weston 9/9] tests: add ivi_layout stand-alone test module

2015-04-09 Thread Pekka Paalanen
On Thu, 2 Apr 2015 01:05:09 + "Tanibata, Nobuhiko (ADITJ/SWG)" wrote: > > > > -Original Message- > > From: wayland-devel > > [mailto:wayland-devel-boun...@lists.freedesktop.org] On Behalf Of Pekka > > Paalanen > > Sent: Monday, March 30, 2015 6:21 PM > > To: wayland-devel@lists.free