Re: [PATCH v3 0/4] Fix Lenovo X230 series touchpad

2015-04-16 Thread Vasily Khoruzhick
Hi Benjamin, On Thu, Apr 16, 2015 at 9:41 PM, Benjamin Tissoires wrote: > So here is a v2 (well v3 to keep things incrementing) of the x230 touchpad > series. > > The touchpad seems almost as fast as any other by multiplying again the > incline parameter by TP_MAGIC_LOW_RES_FACTOR. I am sure ther

Re: [PATCH v3 3/4] udev: add a custom udev rule for X230 touchpads

2015-04-16 Thread Peter Hutterer
On Thu, Apr 16, 2015 at 02:41:35PM -0400, Benjamin Tissoires wrote: > X230 touchpads should be tagged as LIBINPUT_MODEL_LENOVO_X230 by udev to > apply a different acceleration profile. > > Signed-off-by: Benjamin Tissoires one minor change: rename it to 90-... so that local overrides are easier

Re: [PATCH v3 1/4] filter: break out accel_profile_linear from pointer_accel_profile_linear

2015-04-16 Thread Peter Hutterer
On Thu, Apr 16, 2015 at 02:41:33PM -0400, Benjamin Tissoires wrote: > No functional code. Allows to reuse the linear filtering in other > acceleration profiles. > > Signed-off-by: Benjamin Tissoires > --- > no changes since v1 > > src/filter.c | 20 +++- > 1 files changed, 15

Re: [PATCH v3 4/4] evdev: Fix reported resolution of Lenovo X230 touchpads

2015-04-16 Thread Peter Hutterer
On Thu, Apr 16, 2015 at 02:41:36PM -0400, Benjamin Tissoires wrote: > The Lenovo X230 advertise a vertical resolution of 136, which gives a size > of 31 mm. The actual size of the touchpad is 40mm, so override the > resolution to 100. > > /!\ This is a temporary fix. The proper fix should go in hw

Re: Wayland Relative Pointer API Progress

2015-04-16 Thread x414e54
If you add in something like get a wl_input from a wl_seat which can be used as a generic interface to access the libinput directly in a safe way but still controlled the compositor if the window loses focus or there needs to be some translation done. This would be much more generic than my wl_jost

Re: Wayland Relative Pointer API Progress

2015-04-16 Thread x414e54
Actually sorry I was wrong. UE4 uses HID raw input but there are some older game engines that used to use directinput. On Fri, Apr 17, 2015 at 1:43 PM, x414e54 wrote: > Thank you for the comments. > I do have a few counterpoints but I will leave after that. > >> >> Not sure an IR/laser/wii mote p

Re: Wayland Relative Pointer API Progress

2015-04-16 Thread x414e54
Thank you for the comments. I do have a few counterpoints but I will leave after that. > > Not sure an IR/laser/wii mote pointer should even be considered a > "relative" pointer since they operate in absolute coordinates. Given > this, there is no "set position" hint to consider. Transmitting > ac

Re: Wayland Relative Pointer API Progress

2015-04-16 Thread Jonas Ådahl
On Fri, Apr 17, 2015 at 11:51:41AM +0900, x414e54 wrote: > Hi, > > I am wondering if there has been any recent progress on the stability of > the Wayland relative pointer API? AFAIK it is being / to be reviewed a bit more. I have some kind of plan to submit a version with the previous issues addr

Re: [PATCH libinput 2/2] touchpad: introduce MULTITAP for multi-tap-and-drag

2015-04-16 Thread Peter Hutterer
On Thu, Apr 16, 2015 at 10:00:45AM +0200, Hans de Goede wrote: > Hi, > > On 16-04-15 07:04, Peter Hutterer wrote: > >Once we have a doubletap, enter a loop in the state machine where we can tap > >multiple times and either get a multi-click or a multi-click drag-and-drop. > > > >The sequence down/

Wayland Relative Pointer API Progress

2015-04-16 Thread x414e54
Hi, I am wondering if there has been any recent progress on the stability of the Wayland relative pointer API? I had a few ideas on the original December implementation: Whilst we definitely need the relative event support, I feel that the client should never be allowed to warp or confine the gl

Re: EFL/Wayland and xdg-shell

2015-04-16 Thread The Rasterman
On Thu, 16 Apr 2015 15:32:31 +0100 Daniel Stone said: > Hi, > > On 15 April 2015 at 23:51, Carsten Haitzler wrote: > > On Wed, 15 Apr 2015 20:29:32 +0100 Daniel Stone said: > >> On 15 April 2015 at 02:39, Carsten Haitzler wrote: > >> > not esoteric - an actual request from people making produ

[PATCH weston] input: add a weston_pointer_clear_focus() helper function

2015-04-16 Thread Derek Foreman
This adds a function to clear pointer focus and also set the sx,sy co-ordinates to an arbitrary value we shouldn't compute with. Assertions are added to make sure any time pointer focus is set to NULL these values are used. weston_compositor_pick_view() now returns these values too. Signed-off-b

Re: [PATCH weston] input: Don't use uninitialized variables in default_grab_pointer_focus()

2015-04-16 Thread Daniel Stone
Hi, On 16 April 2015 at 21:02, Derek Foreman wrote: > exposay is the only caller that tries to use non 0 with a NULL view, and > I haven't been able to figure out a reason why that's useful - we've > just declared that case to be invalid. I'm planning to just make that 0 > too. From taking a lo

Re: [PATCH] protocol: Add DnD actions

2015-04-16 Thread Bill Spitzak
On 04/16/2015 03:55 AM, Carlos Garnacho wrote: In gtk+/gnome we currently have the following keybindings active during DnD: - Cursor keys move the drag point, modifiers affect speed - Esc key cancels drag - Modifiers alone pick an action from the offered list The user has to hold the mouse

Re: [PATCH weston] input: Don't use uninitialized variables in default_grab_pointer_focus()

2015-04-16 Thread Derek Foreman
On 13/04/15 01:51 AM, Pekka Paalanen wrote: > On Fri, 10 Apr 2015 11:13:22 -0500 > Derek Foreman wrote: > >> On 10/04/15 09:41 AM, Derek Foreman wrote: >>> On 10/04/15 02:16 AM, Pekka Paalanen wrote: On Wed, 8 Apr 2015 15:18:41 -0500 Derek Foreman wrote: > If we have no point

Re: [PATCH v3 2/4] evdev: use a different filter for low resolution touchpad on the Lenovo X230

2015-04-16 Thread Vasily Khoruzhick
On Thu, Apr 16, 2015 at 9:41 PM, Benjamin Tissoires wrote: > Those touchpads presents an actual lower resolution that what is > advertised. > > We see some jumps from the cursor due to the big steps in X and Y > when we are receiving data. > > For instance, we receive: > > E: 13.471932 0003 1

[PATCH v3 3/4] udev: add a custom udev rule for X230 touchpads

2015-04-16 Thread Benjamin Tissoires
X230 touchpads should be tagged as LIBINPUT_MODEL_LENOVO_X230 by udev to apply a different acceleration profile. Signed-off-by: Benjamin Tissoires --- Changes to v1: - more generic rule (in the file name and the way it is handled) No changes to v2. udev/99-libinput-model-quirks.rules | 14 ++

Re: [PATCH v3 0/4] Fix Lenovo X230 series touchpad

2015-04-16 Thread Benjamin Tissoires
Grmbl... this series is for libinput, sorry for the missing subject prefix Benjamin On Thu, Apr 16, 2015 at 2:41 PM, Benjamin Tissoires wrote: > So here is a v2 (well v3 to keep things incrementing) of the x230 touchpad > series. > > The touchpad seems almost as fast as any other by multiplying

[PATCH v3 0/4] Fix Lenovo X230 series touchpad

2015-04-16 Thread Benjamin Tissoires
So here is a v2 (well v3 to keep things incrementing) of the x230 touchpad series. The touchpad seems almost as fast as any other by multiplying again the incline parameter by TP_MAGIC_LOW_RES_FACTOR. I am sure there is an explanation here, but I won't give it. I also did not felt now that the sc

[PATCH v3 2/4] evdev: use a different filter for low resolution touchpad on the Lenovo X230

2015-04-16 Thread Benjamin Tissoires
Those touchpads presents an actual lower resolution that what is advertised. We see some jumps from the cursor due to the big steps in X and Y when we are receiving data. For instance, we receive: E: 13.471932 0003 16366# EV_ABS / ABS_X16366 E: 13.471932 0003 0001 9591

[PATCH v3 1/4] filter: break out accel_profile_linear from pointer_accel_profile_linear

2015-04-16 Thread Benjamin Tissoires
No functional code. Allows to reuse the linear filtering in other acceleration profiles. Signed-off-by: Benjamin Tissoires --- no changes since v1 src/filter.c | 20 +++- 1 files changed, 15 insertions(+), 5 deletions(-) diff --git a/src/filter.c b/src/filter.c index 962d74d.

[PATCH v3 4/4] evdev: Fix reported resolution of Lenovo X230 touchpads

2015-04-16 Thread Benjamin Tissoires
The Lenovo X230 advertise a vertical resolution of 136, which gives a size of 31 mm. The actual size of the touchpad is 40mm, so override the resolution to 100. /!\ This is a temporary fix. The proper fix should go in hwdb. /!\ Signed-off-by: Benjamin Tissoires --- changes to v1: - updated with

Re: [PATCH 5/6] compositor-drm: Fix refresh rate selection in drm_output_switch_mode

2015-04-16 Thread Derek Foreman
On 02/04/15 12:10 AM, Mario Kleiner wrote: > The matching logic in choose_mode() compared refresh rate > of a drm_mode candidate mode expressed in Hz against the > requested refresh rate of the target weston_mode expressed > in milliHz, so the match always failed and the logic always > ended up the

Re: [PATCH 3/6] desktop-shell: Allow multiple active fullscreen windows on multi-display setup.

2015-04-16 Thread Derek Foreman
On 02/04/15 12:10 AM, Mario Kleiner wrote: > Desktop shell demoted all fullscreen shell surfaces on all active > outputs of a multi-display setup whenever any shell surface was > activated anywhere. This made it impossible to have multiple > fullscreen windows on separate outputs active at the same

Re: [PATCH 4/6] compositor-drm/shell: Allow restore_output_mode() to work properly.

2015-04-16 Thread Derek Foreman
On 02/04/15 12:10 AM, Mario Kleiner wrote: > Initialize output->native_mode with the initially chosen > mode for an output, so restore_output_mode() has something > to work with and can switch back from temporary selected modes > to the outputs native mode. Before, this was a no-op. > > This allow

Re: EFL/Wayland and xdg-shell

2015-04-16 Thread Daniel Stone
Hi, On 15 April 2015 at 23:51, Carsten Haitzler wrote: > On Wed, 15 Apr 2015 20:29:32 +0100 Daniel Stone said: >> On 15 April 2015 at 02:39, Carsten Haitzler wrote: >> > not esoteric - an actual request from people making products. >> >> The reason I took that as 'esoteric' was that I assumed i

Re: [PATCH libinput v2 4/4] touchpad: Implement pinch gesture support

2015-04-16 Thread Hans de Goede
Hi, On 09-04-15 07:25, Peter Hutterer wrote: On Thu, Mar 26, 2015 at 10:04:40AM +0100, Hans de Goede wrote: Implement touchpad pinch (and rotate) gesture support. Note that two two-finger scrolling tests are slightly tweaked to assure that there is enough touch movement to allow the scroll-or-

Re: EFL/Wayland and xdg-shell

2015-04-16 Thread Jan Arne Petersen
Hi, On 16.04.2015 00:51, Carsten Haitzler (The Rasterman) wrote: actually the other way around... clients know where the vkbd region(s) are so client can shuffle content to be visible. :) In a VKB (rather than overlay-helper, as used for complex composition) scenario, I would expect xdg-shell

Re: [PATCH] protocol: Add DnD actions

2015-04-16 Thread Carlos Garnacho
Hey Jonas, On Thu, Apr 16, 2015 at 10:15 AM, Jonas Ådahl wrote: > > I'd have to agree on that it doesn't seem like the best thing to let the > compositor choose the preferred action. Having it apply compositor > specific policy given what the keyboard state or similar will probably > never wor

Re: [RFC PATCH v2 wayland] protocol: add wl_pointer.axis_source, axis_stop and axis_discrete events

2015-04-16 Thread Jonas Ådahl
On Tue, Apr 07, 2015 at 01:19:24PM +1000, Peter Hutterer wrote: > On Fri, Mar 27, 2015 at 10:23:43AM +0800, Jonas Ådahl wrote: > > > > Follow up questions: > > > > Do we expect to get axis_stop on both the horizontal and vertical axes, > > and is the client supposed to trigger its kinetic scro

Re: [PATCH] protocol: Add DnD actions

2015-04-16 Thread Jonas Ådahl
Hi, Disclaimer: I don't know much how XDND works, but have some comments anyway. See below: On Sat, Apr 11, 2015 at 12:59:48PM +0200, Carlos Garnacho wrote: > On vie, 2015-04-10 at 12:44 -0700, Bill Spitzak wrote: > > On 04/10/2015 02:29 AM, Carlos Garnacho wrote: > > > > > > However the > > > >

Re: [PATCH libinput 1/1] touchpad: reduce palm detection threshold to 70mm

2015-04-16 Thread Hans de Goede
Hi, On 16-04-15 08:18, Peter Hutterer wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1209753 lists a touchpad 76mm wide that suffers from palm touches Signed-off-by: Peter Hutterer Looks good: Reviewed-by: Hans de Goede Regards, Hans --- src/evdev-mt-touchpad.c | 2 +- test/touc

Re: [PATCH v2 libinput 4/6] evdev: enable middle button configuration on some devices

2015-04-16 Thread Hans de Goede
Hi, On 16-04-15 07:39, Peter Hutterer wrote: Devices that have left and right buttons but no middle button get middle button emulation (without config). Devices that have a middle button too get a config option but default to off. Most mice have LMR set as buttons, regardless whether they have a

Re: [PATCH libinput 1/2] test: add litest_is_button_event

2015-04-16 Thread Hans de Goede
Hi, On 16-04-15 07:04, Peter Hutterer wrote: Makes it easier from a caller to check for common things without all the other boilerplate code. Signed-off-by: Peter Hutterer Looks good: Reviewed-by: Hans de Goede Regards, Hans --- test/litest.c | 26 +++--- test/li