Re: [PATCH wayland] Add "enum" attribute to "arg" elements

2015-04-27 Thread Pekka Paalanen
On Sat, 25 Apr 2015 14:11:32 + Jeroen Bollen wrote: > > I think that totally depends on how the interface is specified. This > > applies only to one of the two ways an can grow. > > What other way can it grow? It can only grow bigger. If the application > isn't aware of new values added, it

[PATCH] ivi-shell: remove unnecesary code in ivi_layout_surface_configure

2015-04-27 Thread Nobuhiko Tanibata
ivi_layout_surface_configure is called from ivi-shell when configure listener of weston surface is triggered. This function shall do, - emit signal to hmi-controller to notify the configuration change Other unnecesary logics are cleaned up. Signed-off-by: Nobuhiko Tanibata Acked-by: Pekka Paalan

[PATCH] ivi-shell: remove unnecesary assignment of fail safe value.

2015-04-27 Thread Nobuhiko Tanibata
Scale is calculated as float and to be inf. It shall be avoided by, ivi_layout_surface_set_source/destination_rectangle. So output log and then return this method to use prevous scale for fail safe. Signed-off-by: Nobuhiko Tanibata Acked-by: Pekka Paalanen --- ivi-shell/ivi-layout.c | 11 ++

[PATCH] ivi-shell: fit source rectangle of ivi-surface to the size of application content.

2015-04-27 Thread Nobuhiko Tanibata
When application changes the size of its content, UI shall fit the source rectangle, view area, to the size of its content to show whole content. Signed-off-by: Nobuhiko Tanibata Acked-by: Pekka Paalanen --- ivi-shell/hmi-controller.c | 39 +++ 1 file changed

[PATCH] ivi-shell: remove unnecesary code in ivi_shell_surface_configure

2015-04-27 Thread Nobuhiko Tanibata
This method should not update weston_view directly. This shall be done by controller via ivi_layout_*. Signed-off-by: Nobuhiko Tanibata Acked-by: Pekka Paalanen --- ivi-shell/ivi-shell.c | 18 -- 1 file changed, 18 deletions(-) diff --git a/ivi-shell/ivi-shell.c b/ivi-shell/ivi

[PATCH] ivi-shell: set an initial value for ivi-surface.

2015-04-27 Thread Nobuhiko Tanibata
Especially, the size of destination rectagle is set to (1,1). This is because the size will be used for caluculating scale and not to be 0 to avoid 0 dividing. I also remark this as FIXME. This shall be fixed at ivi-layout-tansition.c. In new invoded application, its property is initilized by (0,0

Re: [PATCH] touchpad: Only use slot 0 deltas for 2fg scrolling on semi-mt touchpads

2015-04-27 Thread Hans de Goede
Hi, On 27-04-15 03:21, Peter Hutterer wrote: On Fri, Apr 24, 2015 at 04:49:36PM +0200, Hans de Goede wrote: Some semi-mt model touchpads have a better accuracy for slot 0 then for slot 1 (they only have 2), so on semi-mt models only use the movement of the touch in slot 0 for 2fg scrolling, rat

Re: [PATCH wayland] Add "enum" attribute to "arg" elements

2015-04-27 Thread Jeroen Bollen
About the 2 ways of adding an enum: The user can always specify an error handler to handle unknown values. The error handle can then handle the error value, or unknown value. On Mon, 27 Apr 2015 09:05 Pekka Paalanen wrote: > On Sat, 25 Apr 2015 14:11:32 + > Jeroen Bollen wrote: > > > > I t

Re: Patch: some refactoring in evdev-mt-touchpad-tap.c

2015-04-27 Thread Lucas Baudin
Hi, Well, I was not aware of Hans de Goede's patchset, so I am not sure this is still relevant, see in text replies. On 27/04/2015 03:35, Peter Hutterer wrote: Hi Lucas, On Fri, Apr 24, 2015 at 11:50:58PM +0200, Lucas Baudin wrote: Here is a patch that factorizes some code from edev-mt-touch

Re: [PATCH wayland] Add "enum" attribute to "arg" elements

2015-04-27 Thread Auke Booij
Apologies for my lack of responses, I have been abroad for a few days. On 23 April 2015 at 10:38, Pekka Paalanen wrote: >> This is a sort of sanity condition on being a bitfield: it does not >> require all combinations are valid, but it also distinguishes it from >> a regular enum. > > Is that an

Re: [PATCH wayland] Add "enum" attribute to "arg" elements

2015-04-27 Thread Auke Booij
On 21 Apr 2015 09:18, "Pekka Paalanen" wrote: > Two things I came up with in the IRC discussion was that only > types of int an uint are eligible for enums, and only uint for > bitfields. I think wayland-scanner should enforce that. I just realised another aspect of this. Can a (non-bitfield) en

Re: [PATCH wayland] Add "enum" attribute to "arg" elements

2015-04-27 Thread Pekka Paalanen
On Mon, 27 Apr 2015 13:26:39 +0200 Auke Booij wrote: > Apologies for my lack of responses, I have been abroad for a few days. > > On 23 April 2015 at 10:38, Pekka Paalanen wrote: > >> This is a sort of sanity condition on being a bitfield: it does not > >> require all combinations are valid, bu

Re: [PATCH wayland] Add "enum" attribute to "arg" elements

2015-04-27 Thread Pekka Paalanen
On Mon, 27 Apr 2015 14:20:09 +0200 Auke Booij wrote: > On 21 Apr 2015 09:18, "Pekka Paalanen" wrote: > > Two things I came up with in the IRC discussion was that only > > types of int an uint are eligible for enums, and only uint for > > bitfields. I think wayland-scanner should enforce that. >

Re: [PATCH wayland] Add "enum" attribute to "arg" elements

2015-04-27 Thread Pekka Paalanen
On Mon, 27 Apr 2015 15:49:27 +0300 Pekka Paalanen wrote: > In the end, all I care is about the definition of the new attributes > related to enum. If you really want to write a generator that can break > the build of other people, you can. > > I would just want the definition of the attribute be

Re: [PATCH wayland] Add "enum" attribute to "arg" elements

2015-04-27 Thread Auke Booij
On 27 April 2015 at 14:49, Pekka Paalanen wrote: > On Mon, 27 Apr 2015 13:26:39 +0200 > Auke Booij wrote: > >> Apologies for my lack of responses, I have been abroad for a few days. >> >> On 23 April 2015 at 10:38, Pekka Paalanen wrote: >> >> This is a sort of sanity condition on being a bitfiel

Re: [PATCH libinput v2 0/4] touchpad gestures support

2015-04-27 Thread Carlos Garnacho
Hey Peter :), On Mon, Apr 27, 2015 at 6:01 AM, Peter Hutterer wrote: > On Fri, Apr 24, 2015 at 02:39:07PM +0200, Carlos Garnacho wrote: >> On Fri, Apr 24, 2015 at 1:49 PM, Hans de Goede wrote: >> > Hi, >> > >> > On 24-04-15 13:39, Carlos Garnacho wrote: >> >> >> >> Hey Hans :), >> >> >> >> On ju

Re: [PATCH libinput 7/8] evdev: init pointer accel filters when we have rel x/y axes

2015-04-27 Thread Derek Foreman
On 27/04/15 12:52 AM, Peter Hutterer wrote: > Some devices provide abs x/y and rel x/y. We can't know which event the device > will send. The Microsoft Surface Type Cover sends relative devices, which It probably sends events, not devices. :) This whole series looks correct to me (though the use

Re: [PATCH wayland] Add "enum" attribute to "arg" elements

2015-04-27 Thread Jeroen Bollen
> In fact, I am still > a bit confused why an API breakage in these early years of wayland is > considered such a big deal, compared with a daily struggle of not > having sufficient typing information. Same here To pq: If an request specifies how unknown enum values should be handled, it just sp

Re: Wayland Relative Pointer API Progress

2015-04-27 Thread Bill Spitzak
On 04/24/2015 08:51 PM, x414e54 wrote: On Fri, Apr 24, 2015 at 6:22 PM, Pekka Paalanen wrote: Then apps would need to know what the accel paramaters mean, which requires us to lock down the acceleration logic and mathematical functions in the protocol specification. I don't think that is some

Re: [PATCH wayland] introduce new headers wayland-client/server-core.h

2015-04-27 Thread Bill Spitzak
On 04/26/2015 11:48 PM, Marek Chalupa wrote: Is the --include-core-headers option necessary? Until now the scanner included wayland-client/server.h which included the %-protocol.h, but since there are inclusion guards, the protocol header was not included again - so including wayland-client/ser

Re: [PATCH libinput v2 0/4] touchpad gestures support

2015-04-27 Thread Bill Spitzak
On 04/26/2015 09:01 PM, Peter Hutterer wrote: I've been ping-ponging between giving deltas or an absolute distance in mm. I can change the patch-set to report a distance in mm instead of delta from the previous distance, with the caveat that on some touchpads we do not know the resolution so the

Re: [PATCH wayland] Add "enum" attribute to "arg" elements

2015-04-27 Thread Bill Spitzak
On 04/27/2015 12:05 AM, Pekka Paalanen wrote: - From the first definition of an interface, specify how unknown values should be handled. Otherwise users do not expect unknown values to appear. The latter case is where you do not want an automatic always-on warning or error. This is no

Re: [PATCH wayland] introduce new headers wayland-client/server-core.h

2015-04-27 Thread Giulio Camuffo
2015-04-27 21:53 GMT+03:00 Bill Spitzak : > On 04/26/2015 11:48 PM, Marek Chalupa wrote: > >> >> Is the --include-core-headers option necessary? Until now the scanner >> included wayland-client/server.h >> which included the %-protocol.h, but since there are inclusion guards, >> the protocol header

Re: [PATCH libinput 7/8] evdev: init pointer accel filters when we have rel x/y axes

2015-04-27 Thread Peter Hutterer
On Mon, Apr 27, 2015 at 10:01:18AM -0500, Derek Foreman wrote: > On 27/04/15 12:52 AM, Peter Hutterer wrote: > > Some devices provide abs x/y and rel x/y. We can't know which event the > > device > > will send. The Microsoft Surface Type Cover sends relative devices, which > > It probably sends e

Re: Patch: some refactoring in evdev-mt-touchpad-tap.c

2015-04-27 Thread Peter Hutterer
On Mon, Apr 27, 2015 at 12:36:20PM +0200, Lucas Baudin wrote: > Hi, > > Well, I was not aware of Hans de Goede's patchset, so I am not sure this is > still relevant, see in text replies. ah, fair enough, that makes sense then. > On 27/04/2015 03:35, Peter Hutterer wrote: > >Hi Lucas, > > > >On F

Re: [PATCH wayland] introduce new headers wayland-client/server-core.h

2015-04-27 Thread Bill Spitzak
On 04/27/2015 01:06 PM, Giulio Camuffo wrote: 2015-04-27 21:53 GMT+03:00 Bill Spitzak : On 04/26/2015 11:48 PM, Marek Chalupa wrote: Is the --include-core-headers option necessary? Until now the scanner included wayland-client/server.h which included the %-protocol.h, but since there are in

Re: [PATCH wayland] introduce new headers wayland-client/server-core.h

2015-04-27 Thread Giulio Camuffo
2015-04-28 3:34 GMT+03:00 Bill Spitzak : > > > On 04/27/2015 01:06 PM, Giulio Camuffo wrote: >> >> 2015-04-27 21:53 GMT+03:00 Bill Spitzak : >>> >>> On 04/26/2015 11:48 PM, Marek Chalupa wrote: >>> Is the --include-core-headers option necessary? Until now the scanner included wayland

Re: [PATCH wayland] introduce new headers wayland-client/server-core.h

2015-04-27 Thread Marek Chalupa
On Mon, Apr 27, 2015 at 4:06 PM, Giulio Camuffo wrote: > 2015-04-27 21:53 GMT+03:00 Bill Spitzak : > > On 04/26/2015 11:48 PM, Marek Chalupa wrote: > > > >> > >> Is the --include-core-headers option necessary? Until now the scanner > >> included wayland-client/server.h > >> which included the %-p

Re: [PATCH wayland] introduce new headers wayland-client/server-core.h

2015-04-27 Thread Giulio Camuffo
2015-04-28 9:29 GMT+03:00 Marek Chalupa : > > > On Mon, Apr 27, 2015 at 4:06 PM, Giulio Camuffo > wrote: >> >> 2015-04-27 21:53 GMT+03:00 Bill Spitzak : >> > On 04/26/2015 11:48 PM, Marek Chalupa wrote: >> > >> >> >> >> Is the --include-core-headers option necessary? Until now the scanner >> >> in