Re: [PATCH weston v5] input: Don't test keyboard/pointer/touch pointers

2015-05-20 Thread Jonas Ådahl
On Mon, May 04, 2015 at 10:59:10AM -0500, Derek Foreman wrote: > Keyboards and pointers aren't freed when devices are removed, > so we should really be testing keyboard_device_count and > pointer_device_count in most cases, not the actual pointers. > Otherwise we end up with different behaviour aft

Re: [PATCH weston 4/4] input: Detect keyboard capabilities

2015-05-20 Thread Jonas Ådahl
On Wed, May 20, 2015 at 12:32:46PM -0500, Derek Foreman wrote: > Thanks for taking a look! > > On 20/05/15 05:04 AM, Jonas Ådahl wrote: > > On Tue, May 05, 2015 at 03:01:54PM -0500, Derek Foreman wrote: > >> Some devices (power buttons, acpi video bus driver) are considered > >> keyboards but you

[PATCH] desktop-shell: support an option to use 16 bit color or not, instead of using it by default

2015-05-20 Thread nerdopolis
--- clients/desktop-shell.c | 13 +++-- man/weston.ini.man | 4 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/clients/desktop-shell.c b/clients/desktop-shell.c index e2f9f80..d4ba127 100644 --- a/clients/desktop-shell.c +++ b/clients/desktop-shell.c @@ -94,6 +9

Re: [PATCH wayland] tests: add an headers test

2015-05-20 Thread Bill Spitzak
Please don't duplicate the functions in multiple headers! You could achieve the same result this way so that there is only one copy of each function in the headers: wayland-client-protocol-core.h = (the same as you have it, generated by wayland-scanner -c) wayland-client-protocol.h = #inc

Re: [PATCH] desktop-shell: support an option to use 16 bit color or not, instead of using it by default

2015-05-20 Thread nerdopolis
On Wednesday, May 20, 2015 12:17:42 PM Bill Spitzak wrote: > That name is pretty confusing and not what anybody would guess. It > certainly should start with "background-" so that it matches all the > other switches that control the desktop image. > > The fact that it does not always work does N

Re: [PATCH libinput 7/7] touchpad: sync the initial touch state

2015-05-20 Thread Benjamin Tissoires
On Tue, May 19, 2015 at 6:52 PM, Peter Hutterer wrote: > Unlikely, but there's the odd chance of the first touch coming in with the > same X or Y coordinate the kernel already has internally. This would > generate a bogus delta on the second event when the touch coordinate jumps > from 0/y or x/0

[PATCH weston] gl-renderer: Make the error logging a little nicer

2015-05-20 Thread Derek Foreman
Signed-off-by: Derek Foreman --- src/gl-renderer.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/src/gl-renderer.c b/src/gl-renderer.c index 772c6a8..d18e124 100644 --- a/src/gl-renderer.c +++ b/src/gl-renderer.c @@ -1925,7 +1925,6 @@ match_config_to_visua

[PATCH wayland] tests: add an headers test

2015-05-20 Thread Giulio Camuffo
This test checks that the protocol and library headers include only what they are supposed to include. That is, that the core headers do not include the protocol headers and that the core protocol headers do not include the non core library headers. The build process now generates core protocol hea

Re: [PATCH] desktop-shell: support an option to use 16 bit color or not, instead of using it by default

2015-05-20 Thread Bill Spitzak
That name is pretty confusing and not what anybody would guess. It certainly should start with "background-" so that it matches all the other switches that control the desktop image. The fact that it does not always work does NOT have to be part of the name. Some ideas I prefer: background-de

Re: [PATCH weston 4/4] input: Detect keyboard capabilities

2015-05-20 Thread Derek Foreman
Thanks for taking a look! On 20/05/15 05:04 AM, Jonas Ådahl wrote: > On Tue, May 05, 2015 at 03:01:54PM -0500, Derek Foreman wrote: >> Some devices (power buttons, acpi video bus driver) are considered >> keyboards but you can't type with them. >> >> As of libinput 0.15 we can query a keyboard to

Re: [PATCH] desktop-shell: support an option to use 16 bit color or not, instead of using it by default

2015-05-20 Thread Pekka Paalanen
On Wed, 20 May 2015 07:55:17 -0400 nerdopolis wrote: > --- > clients/desktop-shell.c | 13 +++-- > man/weston.ini.man | 4 > 2 files changed, 15 insertions(+), 2 deletions(-) > > diff --git a/clients/desktop-shell.c b/clients/desktop-shell.c > index e2f9f80..970b9f0 100644 >

[PATCH] desktop-shell: support an option to use 16 bit color or not, instead of using it by default

2015-05-20 Thread nerdopolis
--- clients/desktop-shell.c | 13 +++-- man/weston.ini.man | 4 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/clients/desktop-shell.c b/clients/desktop-shell.c index e2f9f80..970b9f0 100644 --- a/clients/desktop-shell.c +++ b/clients/desktop-shell.c @@ -94,6 +9

Re: [PATCH weston 4/4] input: Detect keyboard capabilities

2015-05-20 Thread Jonas Ådahl
On Tue, May 05, 2015 at 03:01:54PM -0500, Derek Foreman wrote: > Some devices (power buttons, acpi video bus driver) are considered > keyboards but you can't type with them. > > As of libinput 0.15 we can query a keyboard to see which key events it > can generate. We use this to detect if a keybo

Re: [PATCH] drm/plane-helper: Adapt cursor hack to transitional helpers

2015-05-20 Thread Pekka Paalanen
On Wed, 20 May 2015 10:36:32 +0200 Daniel Vetter wrote: > In > > commit f02ad907cd9e7fe3a6405d2d005840912f1ed258 > Author: Daniel Vetter > Date: Thu Jan 22 16:36:23 2015 +0100 > > drm/atomic-helpers: Recover full cursor plane behaviour > > we've added a hack to atomic helpers to never t

[PATCH] drm/plane-helper: Adapt cursor hack to transitional helpers

2015-05-20 Thread Daniel Vetter
In commit f02ad907cd9e7fe3a6405d2d005840912f1ed258 Author: Daniel Vetter Date: Thu Jan 22 16:36:23 2015 +0100 drm/atomic-helpers: Recover full cursor plane behaviour we've added a hack to atomic helpers to never to vblank waits for cursor updates through the legacy apis since that's what

Re: [PATCH weston] compositor-wayland: Code cleanup

2015-05-20 Thread Pekka Paalanen
On Wed, 20 May 2015 01:03:53 -0700 Dima Ryazanov wrote: > Don't do multi-assignments. > > Signed-off-by: Dima Ryazanov > --- > src/compositor-wayland.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c > index aaf205

[PATCH weston] compositor-wayland: Code cleanup

2015-05-20 Thread Dima Ryazanov
Don't do multi-assignments. Signed-off-by: Dima Ryazanov --- src/compositor-wayland.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index aaf205b..935701a 100644 --- a/src/compositor-wayland.c +++ b/src/compositor-waylan

Re: [PATCH] drm-backend: for now, on the egl backend, force gl cursors to be used instead of hardware cursors

2015-05-20 Thread Daniel Vetter
On Wed, May 20, 2015 at 10:23:19AM +0300, Pekka Paalanen wrote: > On Wed, 20 May 2015 09:04:52 +0200 > Daniel Vetter wrote: > > > On Mon, May 18, 2015 at 10:10:27PM -0400, nerdopolis wrote: > > > Hardware cursors have been causing some problems with some drivers, > > > mostly i915 > > > > What

Re: [PATCH weston] compositor-wayland: Handle window close events more gracefully

2015-05-20 Thread Dima Ryazanov
On Tue, May 19, 2015 at 11:35 PM, Pekka Paalanen wrote: > On Tue, 19 May 2015 16:41:19 -0700 > Bryce Harrington wrote: > > > On Mon, May 18, 2015 at 11:14:16PM -0700, Dima Ryazanov wrote: > > > When a compositor window is closed, remove the output instead of just > exiting. > > > > > > (The "if

Re: [PATCH weston] compositor-wayland: Handle window close events more gracefully

2015-05-20 Thread Dima Ryazanov
On Wed, May 20, 2015 at 12:00 AM, Bryce Harrington wrote: > On Wed, May 20, 2015 at 09:39:54AM +0300, Pekka Paalanen wrote: > > On Wed, 20 May 2015 08:34:32 +0200 > > Hardening wrote: > > > > > Le 20/05/2015 01:41, Bryce Harrington a écrit : > > > > On Mon, May 18, 2015 at 11:14:16PM -0700, Dima

Re: Landing priorities for 1.8

2015-05-20 Thread Bryce Harrington
With just a few days left until RC2, we're shifting review focus to bugfixes, tests, documentation, and low-risk changes. After RC2, we'll be limiting changes to just release critical fixes. Bryce On Wed, May 13, 2015 at 02:53:58PM -0700, Bryce Harrington wrote: > In patchwork, ideally I'd like

Re: [PATCH] drm-backend: for now, on the egl backend, force gl cursors to be used instead of hardware cursors

2015-05-20 Thread Pekka Paalanen
On Wed, 20 May 2015 09:04:52 +0200 Daniel Vetter wrote: > On Mon, May 18, 2015 at 10:10:27PM -0400, nerdopolis wrote: > > Hardware cursors have been causing some problems with some drivers, mostly > > i915 > > What exactly goes wrong with cursor on i915? Working around kernel bugs in > userspac

Re: [PATCH] drm-backend: for now, on the egl backend, force gl cursors to be used instead of hardware cursors

2015-05-20 Thread Daniel Vetter
On Mon, May 18, 2015 at 10:10:27PM -0400, nerdopolis wrote: > Hardware cursors have been causing some problems with some drivers, mostly > i915 What exactly goes wrong with cursor on i915? Working around kernel bugs in userspace is imo bad since it'll perpetuate the bug ... -Daniel > > This wil

Re: [PATCH weston] compositor-wayland: Handle window close events more gracefully

2015-05-20 Thread Bryce Harrington
On Wed, May 20, 2015 at 09:39:54AM +0300, Pekka Paalanen wrote: > On Wed, 20 May 2015 08:34:32 +0200 > Hardening wrote: > > > Le 20/05/2015 01:41, Bryce Harrington a écrit : > > > On Mon, May 18, 2015 at 11:14:16PM -0700, Dima Ryazanov wrote: > > >> When a compositor window is closed, remove the