Re: [libinput][PATCH] test: Move litest_log and litest_vlog outside ifdef LIBUBWIND block

2015-05-25 Thread Khem Raj
On Mon, May 25, 2015 at 4:08 PM, Peter Hutterer wrote: > On Thu, May 21, 2015 at 12:12:15PM -0700, Khem Raj wrote: >> litest_log is used in the else block as well, and we get errors like >> test/litest.c:240: error: undefined reference to 'litest_log' >> >> Signed-off-by: Khem Raj > > thanks. unf

[PATCH libinput] test: add an extra loop for slow udev initialization

2015-05-25 Thread Peter Hutterer
On slower machines, e.g. VMs, udev isn't fast enough to get the properties set up by the time we're trying to get the device going. This fails when we try to add the device with libinput_path_add_device(). We know that all litest devices will have ID_INPUT set, so check for that before we continue

Re: [libinput][PATCH] test: Move litest_log and litest_vlog outside ifdef LIBUBWIND block

2015-05-25 Thread Peter Hutterer
On Thu, May 21, 2015 at 12:12:15PM -0700, Khem Raj wrote: > litest_log is used in the else block as well, and we get errors like > test/litest.c:240: error: undefined reference to 'litest_log' > > Signed-off-by: Khem Raj thanks. unfortunately I missed your patch, I just pushed the pach sequence

[PATCH libinput 00/11] disable-while-typing refinement

2015-05-25 Thread Peter Hutterer
A couple of patches to refine disable-while-typing which in its current incarnation works but its slightly annoying. The biggest change is 11/11 which adds a new approach: if a touch started after the last key press we release it once the timeout is over. So in the normal use-case where a user typ

[PATCH libinput 11/11] touchpad: touches after the last key press can be released

2015-05-25 Thread Peter Hutterer
The current code labels a touch as palm if it started within the typing timeouts. To move the pointer even after the timeout expires, a user has to lift the finger which is quite annoying and different to the old synaptics driver behaviour (which had a simple on/off toggle on whether to let events

[PATCH libinput 02/11] touchpad: extend the key blacklist for disable-while-typing

2015-05-25 Thread Peter Hutterer
Alt-tab should not trigger the disable-while-typing timeout, likewise with the F-keys, multimedia keys, the windows and menu key, etc. https://bugs.freedesktop.org/show_bug.cgi?id=90613 Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c | 45 +

[PATCH libinput 01/11] touchpad: move disable-while-typing into its own struct

2015-05-25 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c | 34 +- src/evdev-mt-touchpad.h | 4 +++- 2 files changed, 20 insertions(+), 18 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index 409d81e..2ae6f60 100644 --- a/src/evdev-mt

[PATCH libinput 06/11] test: add disable-while-typing tests

2015-05-25 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- test/litest.c | 12 +++ test/litest.h | 2 + test/touchpad.c | 302 3 files changed, 316 insertions(+) diff --git a/test/litest.c b/test/litest.c index 267487a..318b6ce 100644 --- a/test/litest.c ++

[PATCH libinput 04/11] touchpad: only check keyboards for disable-while-typing

2015-05-25 Thread Peter Hutterer
The keyboard test is a simple one, if we have the first row of alphabetic keys, we assume it's a full keyboard. Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c | 22 -- src/evdev.c | 20 src/evdev.h | 1 + 3 files change

[PATCH libinput 08/11] touchpad: add palm state debugging

2015-05-25 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index 0b644d9..994effe 100644 --- a/src/evdev-mt-touchpad.c +++ b/src/evdev-mt-touchpad.c @@ -475

[PATCH libinput 05/11] touchpad: be finer-grained about when to pair touchpads/keyboard for DWT

2015-05-25 Thread Peter Hutterer
Check a couple of easy yes/no definitives that cover most Lenovo laptops, and avoid false positives on Wacoms. Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c | 54 +++-- src/evdev-mt-touchpad.h | 2 -- src/libinput-util.h | 3 +++ test

[PATCH libinput 03/11] touchpad: add helper function to get from tp to the libinput context

2015-05-25 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad-buttons.c | 8 src/evdev-mt-touchpad-edge-scroll.c | 12 ++-- src/evdev-mt-touchpad-tap.c | 10 +- src/evdev-mt-touchpad.c | 8 src/evdev-mt-touchpad.h | 6 ++ 5 fi

[PATCH libinput 07/11] touchpad: split disable-while-typing handling into a helper function

2015-05-25 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index c908ead..0b644d9 100644 --- a/src/evdev-mt-touchpad.c +++ b/src/evdev-mt-touchpad.c @@ -

[PATCH libinput 10/11] touchpad: don't enable edge palm detection on Wacom touchpads

2015-05-25 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c | 10 -- test/touchpad.c | 6 +- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index 994effe..db330ec 100644 --- a/src/evdev-mt-touchpad.c +++ b/src/e

[PATCH libinput 09/11] touchpad: reset the touch state when edge scrolling is stopped

2015-05-25 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad-edge-scroll.c | 4 1 file changed, 4 insertions(+) diff --git a/src/evdev-mt-touchpad-edge-scroll.c b/src/evdev-mt-touchpad-edge-scroll.c index 9bf3f0c..f7eae9e 100644 --- a/src/evdev-mt-touchpad-edge-scroll.c +++ b/src/evdev-mt-touch

[PATCH weston 0/2] Fix up internal screenshot test

2015-05-25 Thread Derek Foreman
Currently the screenshot test has a race condition - sometimes it's all good, sometimes it just gets a black screen. Until desktop-shell is finished starting, there's a black "fade surface" over everything. Currently this is removed after a 15 second timeout even if the shell fails to start in th

[PATCH weston 1/2] desktop-shell: Add an option for shell startup timeout

2015-05-25 Thread Derek Foreman
Make the time to wait for shell startup before removing the fade surface configurable. Use this in internal-screenshot so we can screenshot without waiting for the shell to start. Signed-off-by: Derek Foreman --- desktop-shell/shell.c | 18 +++--- man/weston.ini.man

[PATCH weston 2/2] internal-screenshot-test: Fix test so it doesn't expect shell surfaces

2015-05-25 Thread Derek Foreman
We no longer have a race with shell startup because we create our own colored surface and check that it's properly drawn. Signed-off-by: Derek Foreman --- tests/internal-screenshot-test.c| 63 ++-- tests/reference/internal-screenshot-00.png | Bin 5149 ->

Re: [PATCH xwayland] xwayland: Throttle our cursor surface updates with a frame callback

2015-05-25 Thread Daniel Stone
Hi, On 25 May 2015 at 20:15, Rui Matos wrote: > In some extreme cases with animated cursors at a high frame rate we > could end up filling the wl_display outgoing buffer and end up with > wl_display_flush() failing. > > In any case, using the frame callback to throttle ourselves is the > right th

Re: [PATCH xwayland] xwayland: Throttle our cursor surface updates with a frame callback

2015-05-25 Thread Jasper St. Pierre
This makes sense to me. Reviewed-by: Jasper St. Pierre On Mon, May 25, 2015 at 12:15 PM, Rui Matos wrote: > In some extreme cases with animated cursors at a high frame rate we > could end up filling the wl_display outgoing buffer and end up with > wl_display_flush() failing. > > In any case, us

Re: [PATCH] desktop-shell: provide an option, background-bpp , for specifing the bit depth of the wallpaper

2015-05-25 Thread Bill Spitzak
On 05/25/2015 06:19 AM, nerdopolis wrote: &background->bpp, 16); + /* TODO After Weston 1.8, change default to 32 bit bpp on the wallpaper*/ + if (background->low_bpp != 32) { + window_set_preferred_format(background->window, +

Re: [PATCH wayland] RFC: Require WAYLAND_DISPLAY to be set instead of using wayland-0 as the default

2015-05-25 Thread Bill Spitzak
It can use wayland-0 if $DISPLAY is not set. So the rules programs that can use both Wayland and X11 but prefer Wayland could be: Use $WAYLAND_DISPLAY if set Use $DISPLAY if set Use wayland-0 On 05/25/2015 01:12 AM, Dima Ryazanov wrote: Although defaulting to wayland-0 seems convenient, it

[PATCH xwayland] xwayland: Throttle our cursor surface updates with a frame callback

2015-05-25 Thread Rui Matos
In some extreme cases with animated cursors at a high frame rate we could end up filling the wl_display outgoing buffer and end up with wl_display_flush() failing. In any case, using the frame callback to throttle ourselves is the right thing to do. Signed-off-by: Rui Matos --- hw/xwayland/xway

[PATCH] desktop-shell: provide an option, background-bpp , for specifing the bit depth of the wallpaper

2015-05-25 Thread nerdopolis
--- clients/desktop-shell.c | 13 +++-- man/weston.ini.man| 5 + tests/internal-screenshot.ini | 1 + 3 files changed, 17 insertions(+), 2 deletions(-) diff --git a/clients/desktop-shell.c b/clients/desktop-shell.c index 777a50a..d620daf 100644 --- a/clients/deskto

Patch for Weston Running on a Secondary X Screen

2015-05-25 Thread Marko
Hello! I had a problem with Weston failing to run when launched in a secondary screen (such as DISPLAY=:1.1) on a multi X screen configuration. Attached is the patch that should fix the issue. I reported this as a bug in https://bugs.freedesktop.org/show_bug.cgi?id=90532 and Derek suggested

[libinput][PATCH] test: Move litest_log and litest_vlog outside ifdef LIBUBWIND block

2015-05-25 Thread Khem Raj
litest_log is used in the else block as well, and we get errors like test/litest.c:240: error: undefined reference to 'litest_log' Signed-off-by: Khem Raj --- test/litest.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/test/litest.c b/test/litest.c index 5a

Re: [Intel-gfx] [PATCH] drm/plane-helper: Adapt cursor hack to transitional helpers

2015-05-25 Thread Jani Nikula
On Thu, 21 May 2015, Mario Kleiner wrote: > On 05/20/2015 10:36 AM, Daniel Vetter wrote: >> In >> >> commit f02ad907cd9e7fe3a6405d2d005840912f1ed258 >> Author: Daniel Vetter >> Date: Thu Jan 22 16:36:23 2015 +0100 >> >> drm/atomic-helpers: Recover full cursor plane behaviour >> >> we've ad

Re: [RFC weston 00/14] Atomic modesetting support

2015-05-25 Thread Daniel Vetter
On Fri, May 22, 2015 at 1:51 PM, Pekka Paalanen wrote: > I just remembered, that this patch series does not excercise > DRM_MODE_ATOMIC_TEST_ONLY. Using it would be quite some more > refactoring. > > In Weston's assign_planes(), we would need to start with a > drmModeAtomicReq that sets only the p

Re: Serial touchscreen device in Weston

2015-05-25 Thread Peter Hutterer
On Mon, May 25, 2015 at 11:07:17AM +, Keskinarkaus, Teemu wrote: > Hi, > > For reasons beyond me I'm forced to use serial port as a mean to connect > touchscreen to my device. I've already verified that I get serial data out > from it when touching the screen so that part is working. > > Now

Serial touchscreen device in Weston

2015-05-25 Thread Keskinarkaus, Teemu
Hi, For reasons beyond me I'm forced to use serial port as a mean to connect touchscreen to my device. I've already verified that I get serial data out from it when touching the screen so that part is working. Now next part is to get it working with the Weston. The I'm running Weston in iMX6 w

[PATCH wayland] RFC: Require WAYLAND_DISPLAY to be set instead of using wayland-0 as the default

2015-05-25 Thread Dima Ryazanov
Although defaulting to wayland-0 seems convenient, it has an undesirable side effect: clients may unintentionally connect to the wrong compositor. Generally, it's safer to fail instead. Here's a real example: In Fedora 22, Gtk+ prefers Wayland over X11, though the default session is still a normal

Re: [PATCH] desktop-shell: support an option to use 16 bit color or not, instead of using it by default

2015-05-25 Thread Pekka Paalanen
On Sat, 23 May 2015 13:10:20 -0400 nerdopolis wrote: > On Friday, May 22, 2015 01:19:58 AM you wrote: > > On Thu, May 21, 2015 at 11:15:54PM -0400, nerdopolis wrote: > > > It would be harder to write a whole new test for this... > > > Weston setting the wallpaper to 16 bit only when compiled wit