Re: [PATCH weston] compositor: Separate hardcoded backend related code from compositor

2015-06-23 Thread Pekka Paalanen
On Tue, 23 Jun 2015 11:22:18 -0700 Bill Spitzak wrote: > On Tue, Jun 23, 2015 at 10:49 AM, Giulio Camuffo > wrote: > > > Well, but you are adding weston specific stuff into the backends code, > > that is the options handling. In libweston the backends do not parse > > the command line or the co

Re: [PATCH v4 1/6] Added simple unit/integration test framework and corresponding test program.

2015-06-23 Thread Jon A. Cruz
On 06/22/2015 07:19 AM, Pekka Paalanen wrote: > Hi Jon, > > this is just a quick casual look, so I'm only mentioning what cought my > eye but mostly ignoring minor issues like style. > > I know you sent a v5 series, but it sounded like my comments here are > still applicable. > > I do get kind

Re: [PATCH weston 06/11] build a libweston.so used by the weston binary

2015-06-23 Thread Jon A. Cruz
On 06/22/2015 01:02 PM, Giulio Camuffo wrote: > The library is versioned, so a -N is appended to its name, e.g. > libweston-1.so. > The same is done for the pc file, the include and lib/weston dirs. > This allows multiple libweston versions to be installed together. Ooooh! ABI-versions. Nice. I'v

Re: [PATCH weston 04/11] make the backends compositor-neutral

2015-06-23 Thread Jon A. Cruz
On 06/22/2015 10:51 PM, Giulio Camuffo wrote: > 2015-06-23 3:52 GMT+03:00 Bill Spitzak : >> It seems like prev >> >> On Mon, Jun 22, 2015 at 1:02 PM, Giulio Camuffo >> wrote: >>> >>> The backends used to have lots of code dealing with weston specific >>> configs. >>> To allow them to be used by ot

Re: [PATCH v2] xwayland: keep temp files out of the client mask

2015-06-23 Thread Michel Dänzer
On 23.06.2015 23:28, Olivier Fourdan wrote: > From: Chris Wilson > > Xwayland opens anonymous files for its sharing buffers, move these > file descriptors out of the of irange of the the client select mask Spelling: "out of the range of the client select mask"? > to avoid reaching the maximum

Re: [PATCH weston 02/11] compositor: add API to manage compositor instances

2015-06-23 Thread Jon A. Cruz
Oh I forgot an item on the placement of comments. On 06/23/2015 04:31 PM, Jon A. Cruz wrote: > > Minor doxygen note: the explicit "\brief" is not needed, and the brief > description should end with a '.' to allow the auto-brief to pick it up. > > Overall looks good, but missing a few extra man

Re: [PATCH weston 04/11] make the backends compositor-neutral

2015-06-23 Thread Jon A. Cruz
Just a few minor low-level items in this feedback... On 06/22/2015 01:02 PM, Giulio Camuffo wrote: > The backends used to have lots of code dealing with weston specific configs. > To allow them to be used by other compositors with their own configurations > remove all the usage of weston_config fr

Re: [PATCH libinput 2/5] Add configuration interface for tap drag-lock

2015-06-23 Thread Peter Hutterer
On Tue, Jun 23, 2015 at 05:59:54PM -0700, Bill Spitzak wrote: > On Tue, Jun 23, 2015 at 4:17 PM, Peter Hutterer > wrote: > > > > > > Perhaps you are already doing this, but can't you require the mouse to be > > > held down and/or moved more than some threshold on the first drag to turn > > > on d

Re: [PATCH libinput 2/5] Add configuration interface for tap drag-lock

2015-06-23 Thread Bill Spitzak
On Tue, Jun 23, 2015 at 4:17 PM, Peter Hutterer wrote: > > > Perhaps you are already doing this, but can't you require the mouse to be > > held down and/or moved more than some threshold on the first drag to turn > > on drag-lock mode? > > interesting idea, but I don't think it'll work. too much

Re: [PATCH weston 02/11] compositor: add API to manage compositor instances

2015-06-23 Thread Jon A. Cruz
Minor doxygen note: the explicit "\brief" is not needed, and the brief description should end with a '.' to allow the auto-brief to pick it up. Overall looks good, but missing a few extra management calls. However those seem applicable to patch 4/11. On 06/22/2015 01:02 PM, Giulio Camuffo wrote

Re: [PATCH libinput 2/5] Add configuration interface for tap drag-lock

2015-06-23 Thread Peter Hutterer
On Tue, Jun 23, 2015 at 12:14:21PM -0700, Bill Spitzak wrote: > On Sun, Jun 21, 2015 at 9:54 PM, Peter Hutterer > wrote: > > > In some applications, notably Inkscape, where it is common to frequently > > drag > > objects a short distance the default to drag-lock always-on is frustrating > > for >

Re: [PATCH weston] compositor: Separate hardcoded backend related code from compositor

2015-06-23 Thread Bryce Harrington
On Tue, Jun 23, 2015 at 07:29:17PM +0900, JoonCheol Park wrote: > Instead of adding available backends and usage outputs at build time, > this patch finds all available backend plugins in MODULEDIR and prints > them. It also prints usage output for selected backend by calling > "backend_usage()" in

Re: [PATCH weston] compositor: Separate hardcoded backend related code from compositor

2015-06-23 Thread Bryce Harrington
On Tue, Jun 23, 2015 at 12:48:13PM -0700, Jon A. Cruz wrote: > Actually... yesterday I was just bouncing off of Bryce some ideas in > regards to tuning up the options parser to clean up a bit of the current > mess in regards to params, help messages, keeping multiple areas in > sync, etc. Yeah at

Re: [PATCH weston 03/11] compositor: move the main() to a new weston.c file

2015-06-23 Thread Bryce Harrington
On Mon, Jun 22, 2015 at 11:02:50PM +0300, Giulio Camuffo wrote: > This commits starts to separate the libweston code from the weston > specific code. As such, the main() is moved, together with signals > handling and configuration handling. > --- > Makefile.am | 1 + > src/compositor.c | 80

Re: [PATCH weston] compositor: Separate hardcoded backend related code from compositor

2015-06-23 Thread Jon A. Cruz
Actually... yesterday I was just bouncing off of Bryce some ideas in regards to tuning up the options parser to clean up a bit of the current mess in regards to params, help messages, keeping multiple areas in sync, etc. I *think* I've been starting to see some of the same issues that JoonCheol is

Re: [PATCH weston] compositor: Separate hardcoded backend related code from compositor

2015-06-23 Thread Giulio Camuffo
2015-06-23 21:22 GMT+03:00 Bill Spitzak : > On Tue, Jun 23, 2015 at 10:49 AM, Giulio Camuffo > wrote: >> >> Well, but you are adding weston specific stuff into the backends code, >> that is the options handling. In libweston the backends do not parse >> the command line or the config file, so all

Re: [PATCH weston] compositor: Separate hardcoded backend related code from compositor

2015-06-23 Thread Giulio Camuffo
2015-06-23 21:57 GMT+03:00 JoonCheol Park : > > > 2015-06-24 2:49 GMT+09:00 Giulio Camuffo : >> >> 2015-06-23 20:40 GMT+03:00 JoonCheol Park : >> > Hi Giulio, pq! >> > >> > >> > 2015-06-23 20:57 GMT+09:00 Pekka Paalanen : >> >> >> >> On Tue, 23 Jun 2015 14:14:53 +0300 >> >> Giulio Camuffo wrote: >

Re: [PATCH libinput 2/5] Add configuration interface for tap drag-lock

2015-06-23 Thread Bill Spitzak
On Sun, Jun 21, 2015 at 9:54 PM, Peter Hutterer wrote: > In some applications, notably Inkscape, where it is common to frequently > drag > objects a short distance the default to drag-lock always-on is frustrating > for > users. > Make it configurable, with the current default to "on". > New API:

Re: Wayland Relative Pointer API Progress

2015-06-23 Thread Bill Spitzak
On Sun, Jun 21, 2015 at 11:46 PM, x414e54 wrote: > Hi I have been away for a while and quite busy so I did not get a > chance to response. > > On Tue, Apr 28, 2015 at 3:46 AM, Bill Spitzak wrote: > > No, I absolutely 100% disagree. > > > > Synchronized updating so things don't vibrate or shift i

Re: [PATCH weston] compositor: Separate hardcoded backend related code from compositor

2015-06-23 Thread JoonCheol Park
2015-06-24 2:49 GMT+09:00 Giulio Camuffo : > 2015-06-23 20:40 GMT+03:00 JoonCheol Park : > > Hi Giulio, pq! > > > > > > 2015-06-23 20:57 GMT+09:00 Pekka Paalanen : > >> > >> On Tue, 23 Jun 2015 14:14:53 +0300 > >> Giulio Camuffo wrote: > >> > >> > Hi, > >> > > >> > This kinda goes in the opposite

Re: [PATCH weston] compositor: Separate hardcoded backend related code from compositor

2015-06-23 Thread Bill Spitzak
On Tue, Jun 23, 2015 at 10:49 AM, Giulio Camuffo wrote: > Well, but you are adding weston specific stuff into the backends code, > that is the options handling. In libweston the backends do not parse > the command line or the config file, so all the backend options are > weston specific. > This

Re: [PATCH weston] compositor: Separate hardcoded backend related code from compositor

2015-06-23 Thread Giulio Camuffo
2015-06-23 20:40 GMT+03:00 JoonCheol Park : > Hi Giulio, pq! > > > 2015-06-23 20:57 GMT+09:00 Pekka Paalanen : >> >> On Tue, 23 Jun 2015 14:14:53 +0300 >> Giulio Camuffo wrote: >> >> > Hi, >> > >> > This kinda goes in the opposite direction to my libweston patches. In >> > that series i move the c

Re: [PATCH weston] compositor: Separate hardcoded backend related code from compositor

2015-06-23 Thread JoonCheol Park
Hi Giulio, pq! 2015-06-23 20:57 GMT+09:00 Pekka Paalanen : > On Tue, 23 Jun 2015 14:14:53 +0300 > Giulio Camuffo wrote: > > > Hi, > > > > This kinda goes in the opposite direction to my libweston patches. In > > that series i move the command line handling away from the backends > > code to mak

Re: [PATCH weston 11/11] configure: add an option to allow building only the libraries

2015-06-23 Thread Hardening
Le 22/06/2015 22:02, Giulio Camuffo a écrit : > the --enable/disable-weston-binaries enables or disables the creation > of 'weston', 'weston-launch' and all the binaries that are > installed in $prefix/lib/libexec. This allows, together with > --enable-clients, to only build the libraries, making p

Re: [PATCH v2 weston 00/16] Atomic modesetting support

2015-06-23 Thread Daniel Vetter
On Tue, Jun 23, 2015 at 12:48 PM, Daniel Stone wrote: >> This is assuming we cannot do without the primary plane. If it was >> possible to drive truely universal planes, we would not know if we need >> a primary plane until we know if there is anything on it. You'd have to >> first assume the prim

Re: [PATCH 13/13] ivi-shell: rename to ivi_layout_layer_destroy()

2015-06-23 Thread Pekka Paalanen
On Mon, 22 Jun 2015 15:32:23 +0900 Nobuhiko Tanibata wrote: > From: Nobuhiko Tanibata > > "remove" is not proper name beacause it destorys a layer. The name of > the api is changed from layer_remove to layer_destroy. > > Signed-off-by: Nobuhiko Tanibata > Reviewed-by: Pekka Paalanen > --- >

Re: [PATCH 01/14] tests: test set for ivi-surface normal use case with helper client

2015-06-23 Thread Pekka Paalanen
On Mon, 22 Jun 2015 17:28:23 -0700 "Jon A. Cruz" wrote: > On 06/21/2015 11:33 PM, Nobuhiko Tanibata wrote: > > From: Nobuhiko Tanibata > > > > These tests are implemented on test suite framework, which provides > > helper client. > > Following features are tested for ivi-surface > > - orientati

Re: [PATCH v2 weston 00/16] Atomic modesetting support

2015-06-23 Thread Pekka Paalanen
On Tue, 23 Jun 2015 11:48:56 +0100 Daniel Stone wrote: > Hi, > > On 23 June 2015 at 11:26, Pekka Paalanen wrote: > > you asked me to take a look at the assing_planes code wrt. TEST_ONLY > > and backtracking. > > Thanks! > > As a general comment, carried over from IRC: I think we should get >

Re: [RFC PATCH] Allow more file descriptors than clients limit

2015-06-23 Thread Olivier Fourdan
Hi I've filed bug https://bugs.freedesktop.org/show_bug.cgi?id=91072 to keep track of this issue and copying Wayland-devel ML as well since this is affecting Wayland/XWayland primarily. Cheers, Olivier - Original Message - > The X server assumes that one file descriptor is opened per c

Re: [PATCH weston] compositor: Separate hardcoded backend related code from compositor

2015-06-23 Thread Pekka Paalanen
On Tue, 23 Jun 2015 14:14:53 +0300 Giulio Camuffo wrote: > Hi, > > This kinda goes in the opposite direction to my libweston patches. In > that series i move the command line handling away from the backends > code to make them work in multiple compositors. This moves even more > compositor-speci

Weston hangs with copy&paste actions from /to gedit and firefox ??

2015-06-23 Thread Christian Hartmann
Hi list, I do not have an backtrace nor some hints, but FYI I have a problem with firefox and gedit under wayland-devel I have opened a text file (a patch in this case) and doing copy and paste into the gmail editor window of firefox. suddenly the weston desktop hangs - a remote login is possible

Re: Wayland Relative Pointer API Progress

2015-06-23 Thread Pekka Paalanen
On Mon, 22 Jun 2015 15:46:41 +0900 x414e54 wrote: > This is wrong on so many levels and probably shows you either have > never used either Weston or Gnome Shell when they had laggy slow mouse > issues. > I believe Gnome has partially fixed it but there was still massive lag > when entering/exitin

Re: [PATCH weston] compositor: Separate hardcoded backend related code from compositor

2015-06-23 Thread Giulio Camuffo
Hi, This kinda goes in the opposite direction to my libweston patches. In that series i move the command line handling away from the backends code to make them work in multiple compositors. This moves even more compositor-specific stuff in the backends so we need to decide if we want this or libwe

Re: [PATCH v2 weston 00/16] Atomic modesetting support

2015-06-23 Thread Daniel Stone
Hi, On 23 June 2015 at 11:26, Pekka Paalanen wrote: > you asked me to take a look at the assing_planes code wrt. TEST_ONLY > and backtracking. Thanks! As a general comment, carried over from IRC: I think we should get Mario's series reviewed and merged first. It looks like good work, and I don'

Re: [PATCH v2 weston 00/16] Atomic modesetting support

2015-06-23 Thread Pekka Paalanen
On Mon, 22 Jun 2015 17:25:05 +0100 Daniel Stone wrote: > Hi, > Thanks to everyone who reviewed the previous series. This new series > cleans up the previous patches, introduces a few fixes (e.g. not relying > on a repaint to pull us out of DPMS), and crucially adds support for the > libdrm TEST_O

[PATCH weston] compositor: Separate hardcoded backend related code from compositor

2015-06-23 Thread JoonCheol Park
Instead of adding available backends and usage outputs at build time, this patch finds all available backend plugins in MODULEDIR and prints them. It also prints usage output for selected backend by calling "backend_usage()" in the plugin. By this patch, we can remove all hardcode for backends fro

Re: [PATCH wayland] cosmetic: gratuitous whitespace changes in event-loop.c

2015-06-23 Thread Pekka Paalanen
On Thu, 18 Jun 2015 09:56:09 -0700 "Jon A. Cruz" wrote: > On 06/18/2015 09:48 AM, Derek Foreman wrote: > > Signed-off-by: Derek Foreman > > --- > > src/event-loop.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/event-loop.c b/src/event-loop.c > > index d1e0

Re: [PATCH weston] build: Use AM_CFLAGS instead of GCC_CFLAGS

2015-06-23 Thread Pekka Paalanen
On Thu, 18 Jun 2015 09:59:42 -0700 "Jon A. Cruz" wrote: > On 06/18/2015 09:43 AM, Derek Foreman wrote: > > AM_CFLAGS is the default for any target that doesn't specify its > > own cflags. We should use AM_CFLAGS in preference to GCC_CFLAGS > > so we can change AM_CFLAGS and get all targets. > >

Re: [PATCH wayland] build: Use AM_CFLAGS instead of GCC_CFLAGS everywhere

2015-06-23 Thread Pekka Paalanen
On Thu, 18 Jun 2015 09:59:26 -0700 "Jon A. Cruz" wrote: > On 06/18/2015 09:27 AM, Derek Foreman wrote: > > This will make it easier if we ever want to add new flags to everything > > in the future. > > > > Signed-off-by: Derek Foreman > > --- > > Makefile.am | 8 > > 1 file changed, 4

Re: [PATCH libinput 1/2] touchpad: only send most recent edge delta when triggering threshold

2015-06-23 Thread Hans de Goede
Hi, On 23-06-15 06:00, Peter Hutterer wrote: When edge scrolling is triggered by exceeding the motion threshold (5mm) we sent the whole delta as the first scroll event, causing a big jump. Instead, send only the current delta. This effectively introduces a 5mm dead zone when edge scrolling, sti