On Wed, Jul 15, 2015 at 11:55 AM, Peter Hutterer
wrote:
> On Wed, Jul 15, 2015 at 08:23:09AM +0900, x414e54 wrote:
>> Hi,
>>
>> Just a quick questions:
>>
>> 1) Is there any way to un-normalize the values?
>
> not at this point, no.
> fwiw as of libinput 0.19 the normalization only applies to the
Initialising 'wl_client *client = NULL' and checking 'resource' for NULL and
returning if found.
This patch will avoid dereferencing of 'resource' if NULL
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=91356
Signed-off-by: Ashim
---
src/wayland-server.c |7 ++-
1 file changed, 6 i
A new release of libinput, 0.20.0, is now available.
The big new addition in this release is support for touchpad gestures,
implemented by Hans de Goede. Two types of gestures are supported: swipe and
pinch. Swipe is triggered by a movement of 3+ fingers in the same
direction, pinch is triggered
On 07/07/2015 05:35 AM, Pekka Paalanen wrote:
> On Thu, 2 Jul 2015 23:36:47 -0700
> "Jon A. Cruz" wrote:
>
>> Signed-off-by: Jon A. Cruz
>> ---
>> .gitignore | 2 +
>> Makefile.am| 22 +++
>> configure.ac | 20 ++
>> do
Signed-off-by: Jon A. Cruz
---
Makefile.am| 9 +-
tests/config-parser-test.c | 371 +
2 files changed, 319 insertions(+), 61 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 0ab5b0a..118bafb 100644
--- a/Makefile.am
+++ b/Mak
Here is yet another re-worked version of the patch adding unit testing
framework and corresponding separation. This drops the higher-level waycheck
program and focuses on the first two steps of adding zunitc and converting
the config-parser test.
Changes since v6:
- Incorporated review feedback.
-
Signed-off-by: Jon A. Cruz
---
.gitignore | 2 +
Makefile.am| 22 +++
README | 6 +++
configure.ac | 20 ++
doc/doxygen/devtools.dox | 51 +
doc/doxygen/tooldev.doxyge
Adds basic support for optionally outputting in the XML format
commonly used by JUnit compatible tools.
This format is supported by default by many tools, including
the Jenkins build system. It also is more detailed and
captures more information than the more simplistic TAP
format.
Signed-off-by:
On Wed, Jul 15, 2015 at 08:02:10PM +0200, Carlos Garnacho wrote:
> The lifetime and progress of gestures is maintained by the separate
> wl_pointer_gesture_pinch and wl_pointer_gesture_swipe interfaces,
> each of these has begin/update(optional)/end phases, as transmitted
> by their events.
>
> Th
On 07/07/2015 04:49 AM, Pekka Paalanen wrote:
> On Thu, 2 Jul 2015 23:36:45 -0700
> "Jon A. Cruz" wrote:
>
>> Adds basic support for optionally outputting in the XML format
>> commonly used by JUnit compatible tools.
>>
>> This format is supported by default by many tools, including
>> the Jenki
On 07/07/2015 05:08 AM, Pekka Paalanen wrote:
> On Thu, 2 Jul 2015 23:36:46 -0700
> "Jon A. Cruz" wrote:
>
>> Signed-off-by: Jon A. Cruz
>> ---
>> Makefile.am| 10 +-
>> tests/config-parser-test.c | 371
>> +
>> 2 files changed, 320
On Wed, Jul 15, 2015 at 08:02:10PM +0200, Carlos Garnacho wrote:
> The lifetime and progress of gestures is maintained by the separate
> wl_pointer_gesture_pinch and wl_pointer_gesture_swipe interfaces,
> each of these has begin/update(optional)/end phases, as transmitted
> by their events.
>
> Th
On Wed, Jul 15, 2015 at 11:44:47AM -0400, Benjamin Tissoires wrote:
> On Mon, Jul 13, 2015 at 11:39 PM, Peter Hutterer
> wrote:
> > These touchpads have a terrible resolution when two fingers are down,
> > causing
> > scrolling to jump around a lot. That then turns into bug reports that we
> > c
On 15 July 2015 at 19:11, Bryce Harrington wrote:
> On Wed, Jul 15, 2015 at 01:09:03PM +0100, Emil Velikov wrote:
>> Hello gents,
>>
>> On 15 July 2015 at 09:51, Marek Chalupa wrote:
>> > Reviewed-by: Marek Chalupa
>> >
>> > (http://lists.freedesktop.org/archives/wayland-devel/2015-May/021952.ht
On Wed, Jul 15, 2015 at 4:32 AM, Peter Hutterer
wrote:
> Thumb detection interfered with gestures a fair bit but it shouldn't. A pinch
> gesture with a thumb is a fairly natural move so we shouldn't cancel that.
> A swipe gesture with a thumb on the touchpad - well, don't do that. No need
> for co
On Wed, Jul 15, 2015 at 03:19:35PM -0500, Derek Foreman wrote:
> Reviewed-By: Derek Foreman
Thanks, pushed:
To ssh://git.freedesktop.org/git/wayland/weston
a820b4d..8c7287f master -> master
> On 15/07/15 03:19 PM, Emmanuel Gil Peyrot wrote:
> > This reverts commit d3553c721c0fed07f85b70fea4
Reviewed-By: Derek Foreman
On 15/07/15 03:19 PM, Emmanuel Gil Peyrot wrote:
> This reverts commit d3553c721c0fed07f85b70fea418ca65ed974fbb.
>
> weston_wm_write_property() takes the ownership of the reply it gets as
> a parameter, and will eventually free it later in writable_callback.
>
> This
This reverts commit d3553c721c0fed07f85b70fea418ca65ed974fbb.
weston_wm_write_property() takes the ownership of the reply it gets as
a parameter, and will eventually free it later in writable_callback.
This change introduced a double-free when Xwayland programs triggered a
copy to the clipboard,
This reverts commit d3553c721c0fed07f85b70fea418ca65ed974fbb.
weston_wm_write_property() takes the ownership of the reply it gets as
a parameter, and will eventually free it later in writable_callback.
This change introduced a double-free when Xwayland programs triggered a
copy to the clipboard,
On 15/07/15 02:58 PM, Emmanuel Gil Peyrot wrote:
> This reverts commit d3553c721c0fed07f85b70fea418ca65ed974fbb.
>
> weston_wm_write_property() takes the ownership of the reply it gets as
> a parameter, and will eventually free it later in writable_callback.
>
> This change introduced a double-fr
This reverts commit d3553c721c0fed07f85b70fea418ca65ed974fbb.
weston_wm_write_property() takes the ownership of the reply it gets as
a parameter, and will eventually free it later in writable_callback.
This change introduced a double-free when Xwayland programs triggered a
copy to the clipboard,
On Wed, Jul 15, 2015 at 01:09:03PM +0100, Emil Velikov wrote:
> Hello gents,
>
> On 15 July 2015 at 09:51, Marek Chalupa wrote:
> > Reviewed-by: Marek Chalupa
> >
> > (http://lists.freedesktop.org/archives/wayland-devel/2015-May/021952.html)
> >
> > On 05/16/2015 07:38 AM, Dima Ryazanov wrote:
>
The translation is fairly straightforward so far, it would be convenient
if gestures went through the pointer grab interface, but this is not done
at the moment.
Signed-off-by: Carlos Garnacho
---
src/compositor.h | 7 +++
src/input.c | 92 +
src
Each of these come with a getter on wl_pointer, which takes care
of creating the resource. The focused resources list is maintained
in sync with the pointer's.
Signed-off-by: Carlos Garnacho
---
src/compositor.h | 5 +++
src/input.c | 94
This is accompanied by separate handlers for the different stages
of swipe/pinch gestures, so those can be set in demos.
Signed-off-by: Carlos Garnacho
---
clients/window.c | 196 ++-
clients/window.h | 54 +++
2 files changed, 248
Just print the output, as with the other events.
Signed-off-by: Carlos Garnacho
---
clients/eventdemo.c | 96 -
1 file changed, 95 insertions(+), 1 deletion(-)
diff --git a/clients/eventdemo.c b/clients/eventdemo.c
index dc69fd6..0bb349a 10064
The lifetime and progress of gestures is maintained by the separate
wl_pointer_gesture_pinch and wl_pointer_gesture_swipe interfaces,
each of these has begin/update(optional)/end phases, as transmitted
by their events.
The gesture interfaces can be obtained from the wl_pointer, and
must be interpr
Hey all,
Now that we have touchpad gesture support in libinput, would be great to get
some protocol so clients can take advantage of this.
Following is the protocol that Peter and I came up with after some
brainstorming, I'm also attaching weston patches which offer minimal support,
and make e
Keyboards and pointers aren't freed when devices are removed, so we should
really be testing keyboard_device_count and pointer_device_count in most
cases, not the actual pointers. Otherwise we end up with different
behaviour after removing a device than we had before it was inserted.
This commit r
"v7" of my "Don't allow direct use of seat->device pointers" stuff.
Those pointers are funny in that they only exist after a device has been
plugged in, and they don't ever go away. We're supposed to check if
the associated _device_count > 0 before using them. The final patch
in this series adds
seat->keyboard_focus_listener.link isn't a head, it's just sometimes a
member of the focus signal list. Calling wl_list_init() on it puts
a loop in the list.
Instead, we remove the item then init it. That way we can call remove on
it again later even if it hasn't been re-added to a list.
Signed
Use early return for a slight simplification.
Reviewed-by: Jonas Ådahl
Signed-off-by: Derek Foreman
---
src/compositor-drm.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/compositor-drm.c b/src/compositor-drm.c
index 85eb783..eb661b7 100644
--- a/src/compositor
We should be testing device counts, not pointers. The pointers are
persistent state that never gets freed, and are an inaccurate indicator
of device presence after a release.
Signed-off-by: Derek Foreman
---
desktop-shell/shell.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
di
It never actually needs the seat, and we always verify the touch pointer
before calling it, so let's just pass a touch pointer instead of having
an assumption that the seat's touch pointer has been verified.
Reviewed-by: Jonas Ådahl
Signed-off-by: Derek Foreman
---
desktop-shell/shell.c | 12 ++
It doesn't need the seat pointer, and the caller should already have
tested that the keyboard pointer is valid.
Reviewed-by: Jonas Ådahl
Signed-off-by: Derek Foreman
---
src/bindings.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/src/bindings.c b/src/bi
We should be testing device counts, not pointers. The pointers are
persistent state that never gets freed, and are an inaccurate indicator
of device presence after the last release.
Signed-off-by: Derek Foreman
---
fullscreen-shell/fullscreen-shell.c | 4 ++--
1 file changed, 2 insertions(+), 2
This should be identical to the pointer in shset->seat.
A later patch prevents direct access to seat->pointer, using the
known valid pointer in the grab will be nicer than using the
getter functions that patch introduces.
Reviewed-by: Jonas Ådahl
Signed-off-by: Derek Foreman
---
desktop-shell/
It doesn't actually need the seat and we have to validate that the seat
has a pointer before making the call, so it's safer just to pass
the validated pointer.
Reviewed-by: Jonas Ådahl
Signed-off-by: Derek Foreman
---
desktop-shell/shell.c | 14 +++---
1 file changed, 7 insertions(+), 7
Reviewed-by: Jonas Ådahl
Signed-off-by: Derek Foreman
---
src/text-backend.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/text-backend.c b/src/text-backend.c
index 9485f7e..76e4e15 100644
--- a/src/text-backend.c
+++ b/src/text-backend.c
@@ -79,7 +79,7 @@ struct
We shouldn't be using seat->pointer|keyboard|touch here, we should be
testing *_device_count to see if a device is currently present.
Testing the pointers directly will result in incorrectly advertising
capabilities after all devices of a type have been removed.
Signed-off-by: Derek Foreman
---
Going from seat to input device requires that we test the device
before relying on the pointer. In all of these binding functions
we can trust exactly one input device type directly. If we pass
that in instead of a seat it's more obvious that we can trust
the one pointer we have.
When a seat is
We shouldn't actually use the keyboard pointer unless we check that
a keyboard is present.
Reviewed-by: Jonas Ådahl
Signed-off-by: Derek Foreman
---
desktop-shell/exposay.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/desktop-shell/exposay.c b/desktop-shell/expos
It doesn't actually need the seat and we have to validate that the seat
has a pointer before making the call, so it's safer just to pass
the validated pointer.
Reviewed-by: Jonas Ådahl
Signed-off-by: Derek Foreman
---
desktop-shell/shell.c | 18 +-
1 file changed, 13 insertions(
It doesn't actually need the seat and we have to validate that the seat
has a pointer before making the call, so it's safer just to pass
the validated pointer.
Reviewed-by: Jonas Ådahl
Signed-off-by: Derek Foreman
---
desktop-shell/shell.c | 19 ++-
1 file changed, 10 insertions
These functions should never be called outside of the core.
Reviewed-by: Jonas Ådahl
Signed-off-by: Derek Foreman
---
src/bindings.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/bindings.c b/src/bindings.c
index e339454..ec505dc 100644
--- a/src/binding
Normally we need to check if a seat's [device_type]_count is > 0 before
we can use the associated pointer. However, in a binding you're
guaranteed that the seat has a device of that type. If we pass in
that type instead of the seat, it's obvious we don't have to test it.
The bindings can still g
Hi,
On 8 July 2015 at 09:02, Daniel Vetter wrote:
> On Wed, Jul 01, 2015 at 05:56:13PM +0300, Pekka Paalanen wrote:
>> From: Pekka Paalanen
>> + - Make platform-specific call to ensure that caches are flushed, such
>> +that access with GPU / display controller / CPU will be coherent
On Wed, Jul 15, 2015 at 01:03:24PM +0100, Daniel Stone wrote:
> Hi,
>
> On 14 July 2015 at 11:07, Pekka Paalanen wrote:
> > From: Pekka Paalanen
> >
> > What is libweston and where do we intend to go with it.
>
> Sounds good to me, although the bit about always using
> --with-cairo=image just m
On Mon, Jul 13, 2015 at 11:39 PM, Peter Hutterer
wrote:
> These touchpads have a terrible resolution when two fingers are down, causing
> scrolling to jump around a lot. That then turns into bug reports that we can't
> do much about, the data is simply garbage.
>
> For Alps:
> https://bugs.freedes
Factoring in the comments by Bryce, this looks good to me.
Acked-by: Jon A. Cruz
On 07/14/2015 03:07 AM, Pekka Paalanen wrote:
> From: Pekka Paalanen
>
> What is libweston and where do we intend to go with it.
>
> Cc: Giulio Camuffo
> Signed-off-by: Pekka Paalanen
> ---
> README | 139
> +
On 29 June 2015 at 20:22, Bill Spitzak wrote:
> On Sun, Jun 28, 2015 at 7:32 AM, x414e54 wrote:
>> Clients do not draw the mouse cursor, either the GPU (using hardware
>> overlays) or the WM does.
>
> Yes, I want to allow clients to use this CPU/WM support. Currently the
> client *has* to draw th
Hello gents,
On 15 July 2015 at 09:51, Marek Chalupa wrote:
> Reviewed-by: Marek Chalupa
>
> (http://lists.freedesktop.org/archives/wayland-devel/2015-May/021952.html)
>
> On 05/16/2015 07:38 AM, Dima Ryazanov wrote:
>>
>> snprintf does not allocate memory, so we can never get an out-of-memory
>
Hi,
On 14 July 2015 at 11:07, Pekka Paalanen wrote:
> From: Pekka Paalanen
>
> What is libweston and where do we intend to go with it.
Sounds good to me, although the bit about always using
--with-cairo=image just makes me lean even more towards removing the
other options. Bryce's changes are d
Reviewed-by: Marek Chalupa
On Sat, Jul 11, 2015 at 4:51 AM, Bryce Harrington
wrote:
> Addresses this warning found by Denis Denisov:
>
> [src/logind-util.c:702]: (warning) %d in format string (no. 1)
> requires 'int' but the argument type is 'unsigned int'.
>
> Signed-off-by: Bryce Harringt
Hmm, it looks like there's new bug with this patch. I remember it worked
pretty well before, but now it is not true anymore. Sometimes, after
destroying the output with xterm opened on the other output, the xterm
stops reacting on button press event. With xterm opened on both outputs,
this does
On 05/21/2015 03:43 PM, Marek Chalupa wrote:
output.done event can be sent even on some property change, not only
when announcing the output. Therefore we must check if we already have it
otherwise we may corrupt the list by adding it multiple times.
This fixes bug when xwayland looped indefin
2015-07-15 12:23 GMT+03:00 Pekka Paalanen :
> On Wed, 15 Jul 2015 12:03:34 +0300
> Giulio Camuffo wrote:
>
>> 2015-07-15 11:43 GMT+03:00 Pekka Paalanen :
>> > On Wed, 15 Jul 2015 10:51:34 +0300
>> > Giulio Camuffo wrote:
>> >
>> >> Hi, one comment below but it looks ok to me, also with Bryce's co
On Tue, 7 Jul 2015 10:18:47 -0700
"Jasper St. Pierre" wrote:
> Wacky. In any case, NULL is not a valid listener, which is sort of
> terrible, but it is how it is. You need to create an empty function
> that does nothing.
No, you don't.
If one needs to shut up the compiler by adding NULLs, so be
On Wed, 15 Jul 2015 12:03:34 +0300
Giulio Camuffo wrote:
> 2015-07-15 11:43 GMT+03:00 Pekka Paalanen :
> > On Wed, 15 Jul 2015 10:51:34 +0300
> > Giulio Camuffo wrote:
> >
> >> Hi, one comment below but it looks ok to me, also with Bryce's comments.
> >>
> >> 2015-07-14 13:07 GMT+03:00 Pekka Paa
On 05/16/2015 07:38 AM, Dima Ryazanov wrote:
This makes Xwayland correctly handle a monitor getting unplugged.
Signed-off-by: Dima Ryazanov
---
hw/xwayland/xwayland-output.c | 1 +
hw/xwayland/xwayland.c| 10 +-
hw/xwayland/xwayland.h| 1 +
3 files changed, 11 i
2015-07-15 11:43 GMT+03:00 Pekka Paalanen :
> On Wed, 15 Jul 2015 10:51:34 +0300
> Giulio Camuffo wrote:
>
>> Hi, one comment below but it looks ok to me, also with Bryce's comments.
>>
>> 2015-07-14 13:07 GMT+03:00 Pekka Paalanen :
>> > From: Pekka Paalanen
>> >
>> > What is libweston and where
Reviewed-by: Marek Chalupa
(http://lists.freedesktop.org/archives/wayland-devel/2015-May/021952.html)
On 05/16/2015 07:38 AM, Dima Ryazanov wrote:
snprintf does not allocate memory, so we can never get an out-of-memory error.
(Also, the error handler would free xwl_output after it was already
On Wed, 15 Jul 2015 10:51:34 +0300
Giulio Camuffo wrote:
> Hi, one comment below but it looks ok to me, also with Bryce's comments.
>
> 2015-07-14 13:07 GMT+03:00 Pekka Paalanen :
> > From: Pekka Paalanen
> >
> > What is libweston and where do we intend to go with it.
> >
> > Cc: Giulio Camuffo
Hi, one comment below but it looks ok to me, also with Bryce's comments.
2015-07-14 13:07 GMT+03:00 Pekka Paalanen :
> From: Pekka Paalanen
>
> What is libweston and where do we intend to go with it.
>
> Cc: Giulio Camuffo
> Signed-off-by: Pekka Paalanen
> ---
> README | 139
> +++
On Tue, 14 Jul 2015 13:13:26 -0700
Bryce Harrington wrote:
> On Tue, Jul 14, 2015 at 01:07:47PM +0300, Pekka Paalanen wrote:
> > From: Pekka Paalanen
> >
> > What is libweston and where do we intend to go with it.
> >
> > Cc: Giulio Camuffo
> > Signed-off-by: Pekka Paalanen
> > ---
> > READ
65 matches
Mail list logo
