[PATCH libinput 00/16] pointer acceleration cleanup

2015-08-05 Thread Peter Hutterer
Patches 01-07 are cleanup to fix the current mess of different speeds and add a bit of clarity in what we're doing here. Especially 05 and 06 should help greatly here. Patches 08-14 split the pointer acceleration parts up a bit further, even though that introduces duplication. Right now we only

[PATCH libinput 03/16] filter: rename speed to speed_ranged where it's in the [-1, 1] range

2015-08-05 Thread Peter Hutterer
To avoid confusion with the other speed in units/time Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/filter-private.h | 4 ++-- src/filter.c | 18 +- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/filter-private.h

[PATCH libinput 06/16] filter: explain the acceleration function in detail

2015-08-05 Thread Peter Hutterer
And switch to a code-flow that's a bit more self-explanatory than the current min/max combinations. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/filter.c | 83 1 file changed, 73 insertions(+), 10 deletions(-) diff

[PATCH libinput 04/16] filter: rename speed_out to factor for the touchpad profiles

2015-08-05 Thread Peter Hutterer
The return value of a profile is a unitless factor, not a speed. Same applies for s1/s2, these are factors, not speeds. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/filter.c | 46 +++--- 1 file changed, 23 insertions(+), 23 deletions(-)

[PATCH libinput 05/16] filter: add two helper functions to convert between speeds

2015-08-05 Thread Peter Hutterer
This makes it more obvious where we're using units/us and units/ms as input variable and what the output is. Clutters up the code, but still better than dealing with us/ms differently per function, and still better than carrying all the 1000.0 multiplications/divisions manually. Signed-off-by:

[PATCH libinput 01/16] Revert filter: move the pointer acceleration profiles back to units/ms

2015-08-05 Thread Peter Hutterer
This reverts commit 8a6825f1602aa9d9c4b29a83d296f55f68b316e0. Aside from introducing bugs, this doesn't really help with anything, it adds a requirement to rename everything to make clear where we're using µs and where we're using ms and that just clutters up the code. Signed-off-by: Peter

[PATCH libinput 02/16] filter: drop superfluous struct declaration

2015-08-05 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/filter.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/filter.c b/src/filter.c index b01b68a..e615deb 100644 --- a/src/filter.c +++ b/src/filter.c @@ -96,7 +96,6 @@ struct pointer_tracker { int dir; }; -struct

[PATCH libinput 11/16] filter: split out handling of the low-dpi accel method

2015-08-05 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/filter.c | 34 -- 1 file changed, 32 insertions(+), 2 deletions(-) diff --git a/src/filter.c b/src/filter.c index 68f1786..16dedb4 100644 --- a/src/filter.c +++ b/src/filter.c @@ -296,6 +296,27 @@

[PATCH libinput 09/16] filter: revamp to create device-specific filters, rather than accel functions

2015-08-05 Thread Peter Hutterer
The previous approach to pointer acceleration was to initialize the same motion filter behavior but a different acceleration profile depending on the hardware (the profile converts a speed to a multiplier for input deltas). To be more flexible for hardware-specifics, change this into a set of

[PATCH libinput 13/16] filter: split trackpoint acceleration out

2015-08-05 Thread Peter Hutterer
This is step one to fixing trackpoint acceleration, separating it from the other acceleration code. No functional changes yet, it still uses the low-dpi accel method. https://bugs.freedesktop.org/show_bug.cgi?id=91369 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev.c | 4

[PATCH libinput 07/16] filter: drop accel-last, write-only value

2015-08-05 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/filter.c | 5 - 1 file changed, 5 deletions(-) diff --git a/src/filter.c b/src/filter.c index 4f0d8d5..29bf8e5 100644 --- a/src/filter.c +++ b/src/filter.c @@ -117,7 +117,6 @@ struct pointer_accelerator { double

[PATCH libinput 10/16] filter: split calculating the accel factor into a helper function

2015-08-05 Thread Peter Hutterer
No functional changes. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/filter.c | 35 +-- 1 file changed, 25 insertions(+), 10 deletions(-) diff --git a/src/filter.c b/src/filter.c index 828d6b6..68f1786 100644 --- a/src/filter.c +++ b/src/filter.c

[PATCH libinput 08/16] filter: move create_pointer_accelerator_filter down in the file

2015-08-05 Thread Peter Hutterer
No functional changes, just moving code in preparation for filter patches Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/filter.c | 70 ++-- 1 file changed, 35 insertions(+), 35 deletions(-) diff --git a/src/filter.c

[PATCH libinput 16/16] tools: add shell script for making the pointer acceleration graphs in the docs

2015-08-05 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- tools/Makefile.am | 2 ++ tools/make-ptraccel-graphs.sh | 79 +++ 2 files changed, 81 insertions(+) create mode 100755 tools/make-ptraccel-graphs.sh diff --git a/tools/Makefile.am

[PATCH libinput 12/16] filter: duplicate the code for the Lenovo x230 accel method

2015-08-05 Thread Peter Hutterer
This is once-tested, don't touch it again code. The quirks on the touchpad means we'd have to find that specific device again and re-test everything if we change anything elsewhere in the code. So duplicate it properly, so that we don't have to touch it again. Signed-off-by: Peter Hutterer

[PATCH libinput 14/16] tools: allow filter-switching in ptraccel-debug

2015-08-05 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- tools/ptraccel-debug.c | 43 --- 1 file changed, 36 insertions(+), 7 deletions(-) diff --git a/tools/ptraccel-debug.c b/tools/ptraccel-debug.c index 077da59..aa887fe 100644 ---

[PATCH] ivi-shell: bugfix, ivi_surface is not removed from list of a layer when the ivi_surface is removed from the compositor.

2015-08-05 Thread Nobuhiko Tanibata
Set a mask value to event_mask of ivi_layout_layer, a removed ivi_surface belongs to, in order to trigger refreshing a list of surface in ivi_layout_layer. Signed-off-by: Nobuhiko Tanibata nobuhiko_tanib...@xddp.denso.co.jp --- ivi-shell/ivi-layout.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH] ivi-shell: bugfix, list of surfaces on a layer are cumulated when set render order is called several time in one commitchanges.

2015-08-05 Thread Nobuhiko Tanibata
The final list of surfaces of set render order shall be applied. So link of surfaces and list of surfaces in a layer shall be initialized. And then the order of surfaces shall be restructured. Signed-off-by: Nobuhiko Tanibata nobuhiko_tanib...@xddp.denso.co.jp --- ivi-shell/ivi-layout.c | 14

Re: [PATCH weston] build: install Weston protocol XML files #89966

2015-08-05 Thread Pekka Paalanen
On Wed, 5 Aug 2015 00:03:50 -0300 Dawid Gajownik gajow...@gmail.com wrote: Protocol XML files are required by external applications. This patch installs necessary files and makes them discoverable via pkg-config. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=89966 Signed-off-by:

Re: [PATCH weston] build: install Weston protocol XML files #89966

2015-08-05 Thread Dawid Gajownik
On Wed, Aug 5, 2015 at 6:49 AM, Pekka Paalanen ppaala...@gmail.com wrote: Hi, Hi. NAK. By policy, we do not install protocol XML files for extensions that are not stable, or are intended to be private to Weston. Weston should install only the protocol files which are both stable and

[PATCH weston v4] compositor: Implement wl_pointer_gesture_swipe/pinch interfaces

2015-08-05 Thread Carlos Garnacho
These are obtained from the _wl_pointer_gestures global resource, although each pointer will maintain the resources list and additional information for the pinch/swipe gestures. The lifetime and focus management of gesture resources is thus attached to the pointer. The translation of libinput

[PATCH weston v4] clients: Request the wl_pointer_gesture_swipe/pinch interfaces

2015-08-05 Thread Carlos Garnacho
This is accompanied by separate handlers for the different stages of swipe/pinch gestures, so those can be set in demos. v4: Indenting fix. v3: added null checks around pointer gesture interface destruction, nullify afterwards. v2: depend on standalone protocol xml. Signed-off-by: Carlos

Re: [PATCH weston] screen-share: don't test keyboard/pointer pointers

2015-08-05 Thread Derek Foreman
Oops, thanks Reviewed-by: Derek Foreman der...@osg.samsung.com On 31/07/15 09:46 PM, Dawid Gajownik wrote: Keyboards and pointers aren't freed when devices are removed, so we should really be testing keyboard_device_count and pointer_device_count in most cases, not the actual pointers.

Re: [PATCH] ivi-shell: bugfix, ivi_surface is not removed from list of a layer when the ivi_surface is removed from the compositor.

2015-08-05 Thread Derek Foreman
On 05/08/15 01:58 AM, Nobuhiko Tanibata wrote: Set a mask value to event_mask of ivi_layout_layer, a removed ivi_surface belongs to, in order to trigger refreshing a list of surface in ivi_layout_layer. Signed-off-by: Nobuhiko Tanibata nobuhiko_tanib...@xddp.denso.co.jp ---

Re: [PATCH] [RDP compositor] don't crash when the key file doesn't exist

2015-08-05 Thread Derek Foreman
On 01/08/15 05:35 PM, David FORT wrote: This allows to close the remaining issue in https://bugs.freedesktop.org/show_bug.cgi?id=91390 --- src/compositor-rdp.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/compositor-rdp.c b/src/compositor-rdp.c

Re: [PATCH weston] compositor-rdp: rdp_destroy() double free error #91457

2015-08-05 Thread Derek Foreman
This looks good to me barring two tiny style nits below. That fixed, Reviewed-by: Derek Foreman der...@osg.samsung.com CC'd David in case he has objections. On 31/07/15 06:10 PM, Dawid Gajownik wrote: When something goes wrong during weston initialization, weston_compositor_destroy() is

[PATCH weston] desktop-shell: Make resize and move functions take a pointer instead of a seat

2015-08-05 Thread Derek Foreman
An earlier patch made surface_resize() and surface_move() take pointers instead of seats, this updates the weston_shell_interface resize and move to match. Signed-off-by: Derek Foreman der...@osg.samsung.com --- desktop-shell/shell.c | 8 src/compositor.h | 5 +++--

[PATCH weston v2] compositor-rdp: rdp_destroy() double free error #91457

2015-08-05 Thread Dawid Gajownik
When something goes wrong during weston initialization, weston_compositor_destroy() is executed. It destroys the backend and then frees compositor memory. Unfortunately RDP backend is not correctly destroyed. It frees compositor instead of a backend memory. This causes later a double free error.

Re: [PATCH weston v2] compositor-rdp: rdp_destroy() double free error #91457

2015-08-05 Thread Derek Foreman
On 05/08/15 02:49 PM, Dawid Gajownik wrote: When something goes wrong during weston initialization, weston_compositor_destroy() is executed. It destroys the backend and then frees compositor memory. Unfortunately RDP backend is not correctly destroyed. It frees compositor instead of a backend

Re: [PATCH weston] compositor-rdp: rdp_destroy() double free error #91457

2015-08-05 Thread Dawid Gajownik
On Wed, Aug 5, 2015 at 4:18 PM, Derek Foreman der...@osg.samsung.com wrote: This looks good to me barring two tiny style nits below. That fixed, Reviewed-by: Derek Foreman der...@osg.samsung.com Thanks for the information. Does Weston follow the same coding style as Wayland [1]? The mistakes

[PATCH weston v3] compositor-rdp: rdp_destroy() double free error #91457

2015-08-05 Thread Dawid Gajownik
When something goes wrong during weston initialization, weston_compositor_destroy() is executed. It destroys the backend and then frees compositor memory. Unfortunately RDP backend is not correctly destroyed. It frees compositor instead of a backend memory. This causes later a double free error.

Re: [PATCH weston v3] compositor-rdp: rdp_destroy() double free error #91457

2015-08-05 Thread Derek Foreman
On 05/08/15 03:21 PM, Dawid Gajownik wrote: When something goes wrong during weston initialization, weston_compositor_destroy() is executed. It destroys the backend and then frees compositor memory. Unfortunately RDP backend is not correctly destroyed. It frees compositor instead of a backend

Re: [PATCH weston] compositor-rdp: rdp_destroy() double free error #91457

2015-08-05 Thread Derek Foreman
On 05/08/15 03:05 PM, Dawid Gajownik wrote: On Wed, Aug 5, 2015 at 4:18 PM, Derek Foreman der...@osg.samsung.com wrote: This looks good to me barring two tiny style nits below. That fixed, Reviewed-by: Derek Foreman der...@osg.samsung.com Thanks for the information. Does Weston follow the

Re: [PATCH weston v2] backends: don't destroy renderer and output twice

2015-08-05 Thread Derek Foreman
Looks good Reviewed-by: Derek Foreman der...@osg.samsung.com On 30/07/15 10:02 PM, Dawid Gajownik wrote: drm, fbdev, rpi and wayland backends are unnecessarily destroying renderer and output before executing weston_compositor_shutdown() Signed-off-by: Dawid Gajownik gajow...@gmail.com ---

Re: [PATCH weston] compositor: fix crash when destroying incompletely created output

2015-08-05 Thread Derek Foreman
On 30/07/15 08:23 PM, Dawid Gajownik wrote: When output can't be created in foo_backend_create_output(), weston_output_destroy() is called without executing weston_compositor_add_output(). In such a case output-link is not initialized and causes application crash on

Re: [PATCH] desktop-shell: fix bug referencing invalid surface list

2015-08-05 Thread Derek Foreman
On 29/07/15 01:12 PM, Ryo Munakata wrote: In shell_destroy_shell_surface, we remove the link of a shell_surface. There is a case which the link references shell_client::surface_list which is already free'd. Therefore we have to remove shell_client::surface_list when freeing a shell_client.

Re: [PATCH] desktop-shell: fix bug referencing invalid surface list

2015-08-05 Thread Ryo Munakata
Hi Derek. On 08/05, Derek Foreman wrote: On 29/07/15 01:12 PM, Ryo Munakata wrote: In shell_destroy_shell_surface, we remove the link of a shell_surface. There is a case which the link references shell_client::surface_list which is already free'd. Therefore we have to remove

Re: [PATCH] ivi-shell: bugfix, ivi_surface is not removed from list of a layer when the ivi_surface is removed from the compositor.

2015-08-05 Thread Nobuhiko Tanibata
2015-08-06 02:15 に Derek Foreman さんは書きました: On 05/08/15 01:58 AM, Nobuhiko Tanibata wrote: Set a mask value to event_mask of ivi_layout_layer, a removed ivi_surface belongs to, in order to trigger refreshing a list of surface in ivi_layout_layer. Signed-off-by: Nobuhiko Tanibata