[PATCH weston] ivi-shell: bugfix, list of layers on a screen are cumulated when set render order is called several time in one commitchanges.

2015-08-19 Thread Ucan, Emre (ADITG/SW1)
- Always clear pending list at set_render_order API. - Introduce the dirty parameter for triggering the render order change. - IVI_NOTIFICATION_REMOVE/ADD flags are set only at commit_screen_list. Signed-off-by: Emre Ucan eu...@de.adit-jv.com --- ivi-shell/ivi-layout.c | 45

[PATCH weston v3] ivi-shell: bugfix, an ivi_surface is not removed from list of ivi_layer when the ivi_surface is removed from the compositor.

2015-08-19 Thread Ucan, Emre (ADITG/SW1)
- Introduce the dirty parameter for triggering the render order change - IVI_NOTIFICATION_REMOVE/ADD flags are set only at commit_layer_list. Signed-off-by: Emre Ucan eu...@de.adit-jv.com --- ivi-shell/ivi-layout-private.h |1 + ivi-shell/ivi-layout.c | 63

Re: [PATCH libinput] Add log_*_ratelimit wrappers

2015-08-19 Thread Hans de Goede
Hi, On 19-08-15 07:26, Peter Hutterer wrote: Don't open-code the rate-limited log messages, use a simple wrapper instead. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Looks good to me: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev.c|

[PATCH weston] compositor-drm: rename outputs to follow kernel style

2015-08-19 Thread Pekka Paalanen
From: Pekka Paalanen pekka.paala...@collabora.co.uk The problem with the old table of names is that it contains duplicates. It is possible to end up with multiple outputs with the same name. In that case you cannot write individual configurations for these outputs in weston.ini, because they are

Re: [PATCH libinput] evdev: drop relative x/y motion from a device not marked as pointer

2015-08-19 Thread Hans de Goede
Hi, On 18-08-15 07:08, Peter Hutterer wrote: A device with REL_X/Y and keys gets marked only as ID_INPUT_KEY, initializes as keyboard and then segfaults when we send x/y coordinates - pointer acceleration never initializes. Ignore the events and log a bug instead. This intentionally only

Re: [PATCH weston] compositor-drm: cast surface to EGLNativeWindowType

2015-08-19 Thread Pekka Paalanen
On Mon, 17 Aug 2015 18:46:43 -0300 Dawid Gajownik gajow...@gmail.com wrote: gl_renderer_output_create expects `window_for_legacy' variable to be of type EGLNativeWindowType, not EGLNativeDisplayType. This variable is used later in eglCreateWindowSurface(). Signed-off-by: Dawid Gajownik

[PATCH weston v2] ivi-shell: bugfix, list of surfaces on a layer are cumulated when set render order is called several time in one commitchanges.

2015-08-19 Thread Ucan, Emre (ADITG/SW1)
The final list of surfaces of set render order shall be applied. So link of surfaces and list of surfaces in a layer shall be initialized. And then the order of surfaces shall be restructured. Use existing clear_surface_pending_list function to clear the list. Signed-off-by: Emre Ucan

Re: [PATCH libinput 1/6] test: use the touchpad size for the 7mm movement

2015-08-19 Thread Hans de Goede
Hi, On 18-08-15 01:20, Peter Hutterer wrote: Makes the code more straightforward, and we now require the devices to have a height/width anyway. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Series looks good: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans ---

Re: [PATCH weston] compositor-drm: rename outputs to follow kernel style

2015-08-19 Thread Derek Foreman
Excellent! Incidentally, this is also how Enlightenment names its outputs. Reviewed-by: Derek Foreman der...@osg.samsung.com On 19/08/15 07:54 AM, Pekka Paalanen wrote: From: Pekka Paalanen pekka.paala...@collabora.co.uk The problem with the old table of names is that it contains

Re: [PATCH weston 1/3] clients: Drop deadlock circumvention hack now that we don't need it

2015-08-19 Thread Derek Foreman
On 26/01/15 04:19 AM, Jonas Ã…dahl wrote: mesa supports EGLSwapInterval 0 now, so lets remove this hack. As a bonus we don't conflict with the XDG shell protocol that doesn't allow committing a null-buffer, which was a side effect of this hack. Unreviewed for far too long. :( The question I

Re: [PATCH weston] compositor-fbdev: fix VT switching crash

2015-08-19 Thread Derek Foreman
Ouch, Reviewed-by: Derek Foreman der...@osg.samsung.com On 19/08/15 06:03 AM, Pekka Paalanen wrote: From: Pekka Paalanen pekka.paala...@collabora.co.uk This bug was introduced in 954f183e2f9891b241c1efc0ea61ed56019a4326. The session_notify() data was accidentally cast to fbdev_backend

Re: Libinput: Halfkey/Mirrorboard implementation

2015-08-19 Thread Bill Spitzak
On Tue, Aug 18, 2015 at 11:20 PM, Peter Hutterer peter.hutte...@who-t.net wrote: My difficulties with xkb are in creating a mapping where by the space bar acts as both a modifier *and* a space bar. right. I don't think xkb will let you do this, at least not as a either/or case depending

[PATCH weston] compositor-fbdev: fix VT switching crash

2015-08-19 Thread Pekka Paalanen
From: Pekka Paalanen pekka.paala...@collabora.co.uk This bug was introduced in 954f183e2f9891b241c1efc0ea61ed56019a4326. The session_notify() data was accidentally cast to fbdev_backend while it is weston_compositor. This was possibly due to the code before the mentioned commit casting data

RE: [PATCH weston v3] ivi-shell: bugfix, an ivi_surface is not removed from list of ivi_layer when the ivi_surface is removed from the compositor.

2015-08-19 Thread Tanibata, Nobuhiko (ADITJ/SWG)
Hi Ucan-san, I reviewed and tested it. Additionally, we shall fix not only this one but also logic of layer list in screen similarly later. Tested-by: Nobuhiko Tanibata nobuhiko_tanib...@xddp.denso.co.jp Reviewed-by: Nobuhiko Tanibata nobuhiko_tanib...@xddp.denso.co.jp BR, Nobuhiko Tanibata

RE: [PATCH weston v2] ivi-shell: bugfix, list of surfaces on a layer are cumulated when set render order is called several time in one commitchanges.

2015-08-19 Thread Tanibata, Nobuhiko (ADITJ/SWG)
Hi Ucan-san, I reviewed and tested it. Additionally, we shall fix not only this one but also logic of layer list in screen similarly later as well. Tested-by: Nobuhiko Tanibata nobuhiko_tanib...@xddp.denso.co.jp Reviewed-by: Nobuhiko Tanibata nobuhiko_tanib...@xddp.denso.co.jp BR, Nobuhiko

Re: Libinput: Halfkey/Mirrorboard implementation

2015-08-19 Thread Peter Hutterer
On Tue, Aug 18, 2015 at 05:47:43PM +0100, Kieran Bingham wrote: Hi Peter, Sorry for the late reply here, I've moved back from South America to England and had to look in to some of my assumptions! On 27 July 2015 at 06:07, Peter Hutterer peter.hutte...@who-t.net wrote: Hi Kieran,