RE: [PATCH] libinput device capability modification regarding combo input devices

2015-09-23 Thread 박성진
Dear Andreas Pokorny, thanks for your reply. J As you mentioned, we also need to distinguish between a full keyboard and a device which has a set of few keys. Each key coming from the full keyboard will be sent to the focus surface(window). However, a key coming from the device which has a

Re: [PATCH][weston 1/3] ivi-layout-transition: Fix potential leak of memory pointed to by transition

2015-09-23 Thread Lucas Tanure
On Wed, Sep 23, 2015 at 9:06 PM, Bryce Harrington wrote: > On Wed, Sep 23, 2015 at 10:33:21AM -0300, Lucas Tanure wrote: > > Free transition in ivi_layout_transition_fade_layer if we fail to > > allocate memory for data > > > > Signed-off-by: Lucas Tanure > > Don't forget spaces after keywords.

Re: [PATCH 2/2] Ensure strncpy results are null terminated.

2015-09-23 Thread Bryce Harrington
On Wed, Sep 02, 2015 at 01:53:32PM -0500, Derek Foreman wrote: > On 28/08/15 03:04 PM, Bryce Harrington wrote: > > Signed-off-by: Bryce Harrington > > --- > > clients/window.c | 1 + > > src/compositor-fbdev.c | 1 + > > 2 files changed, 2 insertions(+) > > > > diff --git a/clients/window.

[PATCH weston, v3] weston-terminal: Add cwd and command options

2015-09-23 Thread ahmet acar
Add 'cwd' (current working directory) and 'command' (run specified command immediately after startup) switch to weston-terminal. Both switch are optional. v3: -change command execution mechanism as 'bash -c command' (Bill Spitzak) Running weston-terminal --command="nano main.c" equals below:

[PATCH weston v2] shell: Check more thoroughly for undefined surface resource

2015-09-23 Thread Bryce Harrington
The surface can have an undefined resource in certain situations (such as with xwayland). So, since NULL is a valid state for this parameter, and since the wl_resource_*, etc. calls require their parameters to be non-NULL, make a practice of always checking the surface resource before making wayla

Re: [PATCH][weston 1/3] ivi-layout-transition: Fix potential leak of memory pointed to by transition

2015-09-23 Thread Bryce Harrington
On Wed, Sep 23, 2015 at 10:33:21AM -0300, Lucas Tanure wrote: > Free transition in ivi_layout_transition_fade_layer if we fail to > allocate memory for data > > Signed-off-by: Lucas Tanure Don't forget spaces after keywords. I.e. "if (" instead of "if(" I locally fixed that code style issue, a

Re: [PATCH][weston 3/3] ivi-layout-transition: Fix potential leak of memory pointed to by transition

2015-09-23 Thread Bryce Harrington
On Wed, Sep 23, 2015 at 10:33:23AM -0300, Lucas Tanure wrote: > Destroy transition if layout_transition_register was not ok, we can't > just free transition, we need to call layout_transition_destroy in order > to free private_data from transition > > Signed-off-by: Lucas Tanure > --- > ivi-shel

Re: [PATCH 3/3] Add a release request on wl_seat

2015-09-23 Thread Jonas Ådahl
On Wed, Sep 23, 2015 at 11:17:33AM -0500, Derek Foreman wrote: > On 25/02/15 08:03 AM, David FORT wrote: > > This is required if we want to correctly remove a wl_seat server-side. > > --- > > protocol/wayland.xml | 6 ++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/protocol/waylan

Re: [PATCH][weston] ivi-shell: initialize all fields in create_layout_transition

2015-09-23 Thread John-John Tedro
I'm currently investigating. I see two easy solutions, so please advice since I'm unfamiliar with the requirements on IVI-based solutions. 1) Bail, easy and safe, but might not be desirable. 2) Immediately transition into the desired state on errors. Slightly harder, but doable. Examples for

Re: [PATCH][weston] desktop-shell: fix minimization of fullscreen surfaces

2015-09-23 Thread Derek Foreman
On 23/09/15 02:40 PM, Derek Foreman wrote: > Note: this email somehow confused patchwork and generated a new broken > patch entry. I've deleted that, but replying here won't properly end up > in the old patch's thread... sigh. > > On 20/09/15 12:10 PM, Manuel Bachmann wrote: >> Hi folks, >> >> A

[PATCH V2] weston_wm: Implement _NET_ACTIVE_WINDOW

2015-09-23 Thread Benoit Gschwind
I updated the patch taking in account remarks from Bryce. But after a quick check I found that on the top the current master the _NET_ACTIVE_WINDOW is not clear when all X11 window lost the focus. I will investigate to fix this case. Best regards --- xwayland/window-manager.c | 23 +

Re: [PATCH][weston] desktop-shell: fix minimization of fullscreen surfaces

2015-09-23 Thread Derek Foreman
Note: this email somehow confused patchwork and generated a new broken patch entry. I've deleted that, but replying here won't properly end up in the old patch's thread... sigh. On 20/09/15 12:10 PM, Manuel Bachmann wrote: > Hi folks, > > Any news on this one ? (https://patchwork.freedesktop.or

Re: [PATCH weston 2/3] launcher: Split out launcher implementations into three distinct ones

2015-09-23 Thread Derek Foreman
On 23/09/15 12:46 PM, Jasper St. Pierre wrote: > We now have a launcher interface and distinct implementations for > logind, weston-launch, and direct DRM, each in their own files. > > This helps up clean up the spaghetti code into something that's > hopefully a bit more understood. There should b

[PATCH weston, v2] weston-terminal: Add cwd and command options

2015-09-23 Thread ahmet acar
Add 'cwd' (current working directory) and 'command' (run specified command immediately after startup) to weston-terminal. v2: -improve commit title and description -remove unneeded 'Changes from' thing -use weston_config_section_get_string() instead off -follow wayland coding style guide

[PATCH weston 3/3] launcher-logind: Remove old VT switching code, move to SwitchTo/Activate

2015-09-23 Thread Jasper St. Pierre
In the time since this code was written, logind has gained new APIs to handle VT switching automatically and activate sessions. Switch to that. --- src/launcher-logind.c | 219 +- 1 file changed, 40 insertions(+), 179 deletions(-) diff --git a/src/l

[PATCH weston 1/3] launcher: Rename logind-util to launcher-logind

2015-09-23 Thread Jasper St. Pierre
We're refactoring this to have multiple launcher "implementations". --- Makefile.am | 4 +- src/launcher-logind.c | 940 ++ src/launcher-logind.h | 123 +++ src/launcher-util.c | 2 +- src/logind-util.c | 940 -

[PATCH weston 2/3] launcher: Split out launcher implementations into three distinct ones

2015-09-23 Thread Jasper St. Pierre
We now have a launcher interface and distinct implementations for logind, weston-launch, and direct DRM, each in their own files. This helps up clean up the spaghetti code into something that's hopefully a bit more understood. There should be no functional changes here. --- Makefile.am

Re: Patchwork upgrade?

2015-09-23 Thread Olivier Blin
Le 22/09/2015 19:27, Damien Lespiau a écrit : On Mon, Jul 27, 2015 at 11:01:43AM -0700, Bryce Harrington wrote: > On Mon, Jul 20, 2015 at 11:19:18AM +0100, Daniel Stone wrote: The other thing is more difficult. I don't have any archive of the cairo ml I can feed to patchwork (the mangled emails

Re: [PATCH weston v2] xwm: use always a valid 'primary view' for an X window

2015-09-23 Thread Giulio Camuffo
2015-09-23 19:46 GMT+03:00 Derek Foreman : > On 01/02/15 08:18 AM, Giulio Camuffo wrote: >> The xwm gets a primary view for a X window using the get_primary_view >> vfunc of the shell_interface struct. Storing it is dangerous though because >> it doesn't listen for its destruction so it may end up

Re: [PATCH weston v2] xwm: use always a valid 'primary view' for an X window

2015-09-23 Thread Derek Foreman
On 01/02/15 08:18 AM, Giulio Camuffo wrote: > The xwm gets a primary view for a X window using the get_primary_view > vfunc of the shell_interface struct. Storing it is dangerous though because > it doesn't listen for its destruction so it may end up using the old stored > view pointer after that v

Re: [PATCH 2/3] Modify wayland-scanner to generate inert objects

2015-09-23 Thread Derek Foreman
This one's been waiting for a long time... I'm currently pretending to make an effort to clean up patchwork a bit. ;) On 25/02/15 08:03 AM, David FORT wrote: > As stated in the very good blog post[1] of Pekka Paalanen, server-side we can > have > sometime troubles with object that the server has

Re: [PATCH 3/3] Add a release request on wl_seat

2015-09-23 Thread Derek Foreman
On 25/02/15 08:03 AM, David FORT wrote: > This is required if we want to correctly remove a wl_seat server-side. > --- > protocol/wayland.xml | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/protocol/wayland.xml b/protocol/wayland.xml > index 4fb8035..8f63ebf 100644 > --- a/protocol

[PATCH weston] compositor: remove incorrect idle timer initialization

2015-09-23 Thread Egor Starkov
Remove idle timer first update in weston_compositor_create() since idle_time variable is not set at this point. Idle timer is armed properly later in weston_compositor_wake(). Egor Starkov (1): compositor: remove incorrect idle timer initialization src/compositor.c | 1 - 1 file changed, 1 del

[PATCH weston] compositor: remove incorrect idle timer initialization

2015-09-23 Thread Egor Starkov
weston_compositor_create() should just create idle timer but not arm it, because idle-time setting is not read at this point Signed-off-by: Egor Starkov --- src/compositor.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/compositor.c b/src/compositor.c index cbef4dc..125afd5 100644 --- a

Re: [PATCH weston 2/3] text: Don't track binding in struct text_backend

2015-09-23 Thread Derek Foreman
On 17/09/15 03:45 PM, Bryce Harrington wrote: > On Thu, Jun 25, 2015 at 03:49:48PM -0500, Derek Foreman wrote: >> The binding is only used for preventing launch, and we've already got the >> pid for that. >> >> With multiple seats there are multiple bindings, so if the most recent >> binding unbind

Re: [PATCH weston 1/3] text: Launch input method in text_backend_init

2015-09-23 Thread Derek Foreman
On 17/09/15 03:38 PM, Bryce Harrington wrote: > On Thu, Jun 25, 2015 at 03:49:47PM -0500, Derek Foreman wrote: >> Previously we tried to launch the input method every time a seat was >> created, and the launch function would notice it was running and not >> bother to actually launch. > > If I unde

Re: Compile and use rpi-backend on raspberry 2 gave always black screen after weston-launch

2015-09-23 Thread Derek Foreman
On 17/09/15 09:16 AM, Fabio Fantoni wrote: > Il 17/09/2015 14:15, Pekka Paalanen ha scritto: >> On Thu, 17 Sep 2015 11:13:19 +0200 >> Fabio Fantoni wrote: >> >>> Il 16/09/2015 18:00, Pekka Paalanen ha scritto: On Tue, 15 Sep 2015 17:10:09 +0200 Fabio Fantoni wrote: > Hi, I'm tr

[PATCH] xwayland: Adjust screen size with rotation

2015-09-23 Thread Olivier Fourdan
bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92076 Signed-off-by: Olivier Fourdan --- hw/xwayland/xwayland-output.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/xwayland/xwayland-output.c b/hw/xwayland/xwayland-output.c index 7e5484c..7d7420b 100644 --

[PATCH][weston 3/3] ivi-layout-transition: Fix potential leak of memory pointed to by transition

2015-09-23 Thread Lucas Tanure
Destroy transition if layout_transition_register was not ok, we can't just free transition, we need to call layout_transition_destroy in order to free private_data from transition Signed-off-by: Lucas Tanure --- ivi-shell/ivi-layout-transition.c | 3 ++- 1 file changed, 2 insertions(+), 1 deleti

[PATCH][weston 1/3] ivi-layout-transition: Fix potential leak of memory pointed to by transition

2015-09-23 Thread Lucas Tanure
Free transition in ivi_layout_transition_fade_layer if we fail to allocate memory for data Signed-off-by: Lucas Tanure --- ivi-shell/ivi-layout-transition.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ivi-shell/ivi-layout-transition.c b/ivi-shell/ivi-layout-transition.c index 150e301..7

[PATCH][weston 2/3] ivi-layout-transition: Fix potential leak of memory pointed to by transition

2015-09-23 Thread Lucas Tanure
Check if transition is not null and if layout_transition_register was ok before return, if not, free transition Signed-off-by: Lucas Tanure --- ivi-shell/ivi-layout-transition.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ivi-shell/ivi-layout-transition.c b/ivi-shel

Re:[weston] weston-terminal: Add a few nice features

2015-09-23 Thread ahmet acar
>I'm going to apologize upfront, since what lies below is a pretty >intense review First; thank you for your intense review.i am happy with it. > I hope you'll fix up your patch and resubmit Sure. >Sounds useful! I would suggestion though to make your commit >message more >descriptive oriented

Re: Patchwork upgrade?

2015-09-23 Thread Damien Lespiau
On Tue, Sep 22, 2015 at 04:49:59PM -0700, Bryce Harrington wrote: > > You probably want to be a maintainer of cairo in patchwork to change > > patch status, ... If you have a patchwork account I can add you. > > Thanks, I do: account name 'bryce'. Done. -- Damien ___

xdg_surface initial configuration

2015-09-23 Thread Michael Forney
Hi, I know this has been discussed before, but I recently came across a situation that I think xdg_surface currently does not account for. As far as I know, the expected interaction between client and compositor is the client calls get_xdg_surface, then does a roundtrip to pick up any configure e