Re: [PATCH wayland 8/8] client: Use read preparation API in wl_display_dispatch_queue()

On Fri, Oct 02, 2015 at 01:42:03PM -0700, Bryce Harrington wrote: > On Fri, Oct 02, 2015 at 05:32:59PM +0800, Jonas Ådahl wrote: > > Instead of doing things that do the equivalent of using > > wl_display_prepare_read() and friends, just use the public API. The > > only semantical difference is that

Re: [PATCH wayland 7/8] client: Remove misplaced documentation about main loop intergration

On Fri, Oct 02, 2015 at 01:36:20PM -0700, Bryce Harrington wrote: > On Fri, Oct 02, 2015 at 05:32:58PM +0800, Jonas Ådahl wrote: > > There was documentation about how to integrate the display server file > > descriptor in the documentation about wl_display_dispatch_pending(). > > This is not the ri

Re: Enums, bitfields and wl_arrays

This email contains a clear suggestions that I'd like everyone to read, not just Nils and Erik. But Nils and Erik brought up a few points that I'd like to have settled, since they have been brought up quite frequently now. On 3 October 2015 at 11:14, Nils Chr. Brause wrote: > Pekka Paalanen wrote

Re: [PATCH wayland] shm: Add wl_shm_buffer get/put functions

I imagine it's sampling from shared memory owned by the client during its own rendering. On Sun, Oct 4, 2015 at 11:21 AM, Bill Spitzak wrote: > On 10/04/2015 08:34 AM, Giulio Camuffo wrote: >> >> 2015-07-18 0:30 GMT+03:00 Derek Foreman : >>> >>> Sometimes the compositor wants to make sure a shm p

Re: [PATCH wayland] shm: Add wl_shm_buffer get/put functions

On 10/04/2015 08:34 AM, Giulio Camuffo wrote: 2015-07-18 0:30 GMT+03:00 Derek Foreman : Sometimes the compositor wants to make sure a shm pool doesn't disappear out from under it. For example, in Enlightenment, rendering happens in a separate thread while the main thread can still dispatch even

Re: [PATCH wayland] shm: Add wl_shm_buffer get/put functions

I imagine get/put is named after the kernel style. I typically see ref/unref for userspace names (or ref/destroy, but nobody likes that). On Sun, Oct 4, 2015 at 8:34 AM, Giulio Camuffo wrote: > 2015-07-18 0:30 GMT+03:00 Derek Foreman : >> Sometimes the compositor wants to make sure a shm pool doe

Re: [PATCH][weston] animation: Fix potential leak of memory pointed to by move

2015-10-03 17:18 GMT+03:00 Lucas Tanure : > Free move before return if animation is null. > > Signed-off-by: Lucas Tanure Reviewed-by: Giulio Camuffo > --- > src/animation.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/animation.c b/src/animation.c > index cc

Re: [PATCH wayland] shm: Add wl_shm_buffer get/put functions

2015-07-18 0:30 GMT+03:00 Derek Foreman : > Sometimes the compositor wants to make sure a shm pool doesn't disappear > out from under it. > > For example, in Enlightenment, rendering happens in a separate thread > while the main thread can still dispatch events. If a client is destroyed > during r

Re: [PATCH] screenshooter: correct output ordering of screencast recording when Y-flip is off

2015-07-07 13:06 GMT+03:00 Tomohito Esaki : > The screenshooter encoder wrote the output from either top-to-bottom or > bottom-to-top, depending on the Y-flip setting, but wcap-decode only > decodes from bottom-to-top. Make the encoder always output from > bottom-to-top, to match the decoder, and f

Re: [PATCH weston] build: Add -lrt for programs that use clock_gettime()

2015-06-29 22:05 GMT+03:00 Derek Foreman : > glibc requires this prior to 2.17, and we already do it in a few other > places. > > Signed-off-by: Derek Foreman Reviewed-by: Giulio Camuffo > --- > Makefile.am | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Makefile.a

Re: [PATCH weston] compositor/clients: Protect CLOCK_BOOTTIME with ifdefs

2015-06-29 21:20 GMT+03:00 Derek Foreman : > CLOCK_BOOTTIME is a relatively new* feature that may not actually be > present everywhere (I'm looking at you wheezy). Since our use of it > is actually only cosmetic, I've just ifdef'd if. > > * No it isn't. > > Signed-off-by: Derek Foreman > --- > >

Re: [PATCH wayland 3/3] shm: wl_shm_buffer_get_data() requires a valid pool.

2015-07-16 21:57 GMT+03:00 Derek Foreman : > > I'm wondering if buffer->pool can ever actually be NULL anyway... I > have a suspicion that it can't, making the assert and the test a little > silly. It seems to me it can only be NULL if the buffer is created with wl_shm_buffer_create() which is b

Re: Enums, bitfields and wl_arrays

Hi, On Sat, Oct 3, 2015 at 9:05 PM, Erik De Rijcke wrote: > - Defining an uint (bitfield) or int (single enum) in the xml for an enum > argument is the wrong approach. It prescribes, not describes. In some > languages eg Java, there is no such thing as an uint. What is important, is > to know how

Re: [PATCH wayland 1/3 v2] shm: Deprecate wl_shm_buffer_create()

2015-06-26 19:34 GMT+03:00 Derek Foreman : > From irc: > it creates a wl_buffer object in a way that no client can ever > access the storage. > > So, let's replace it with abort(); and mark it with WL_DEPRECATED > in the header. > > Signed-off-by: Derek Foreman > --- > > This time using WL_D

Re: [PATCH v3] weston-launch: Fixed TTY switching

This is broken for me, see comments below. > + /* tty will be deinitialized by child process, so it has to be > +* opened again to correctly cleanup vt handling. */ > + if (wl->tty != STDIN_FILENO) { > + close(wl->tty); > + wl->tty = open(wl->tty_p