Re: Enums, bitfields and wl_arrays

On Mon, Oct 5, 2015 at 6:03 AM, Pekka Paalanen wrote: > For me, that depends only on what requirements a "bitfield" has. Does > it have to be uint? Do the values have to be POT? That's all up to you, > as it has no effect on C bindings nor generated documentation other >

Re: [PATCH wayland 7/8] client: Remove misplaced documentation about main loop intergration

I looked at this about a year ago, and I think both the docs and code are suffering from multiple implementations, and this needs to be fixed. Right now everything is pointing in circles. I believe however that there is a base set of calls in wayland-client-core.h and all the other functions can

Re: [PATCH wayland] shm: add getters for the fd and offset

Sigh, realized this is still in patchwork and I never actually gave it a proper look. Sorry. On 01/07/15 03:25 AM, Giulio Camuffo wrote: > This allows to share the buffer data by mmapping the fd again. > --- > src/wayland-server-core.h | 6 ++ > src/wayland-shm.c | 16

[PATCH v2 wayland] shm: Add shm_buffer ref and shm_pool unref functions

Sometimes the compositor wants to make sure a shm pool doesn't disappear out from under it. For example, in Enlightenment, rendering happens in a separate thread while the main thread can still dispatch events. If a client is destroyed during rendering, all its resources are cleaned up and its

[PATCH weston] doc: Correct absolute path in doxygen graphs.

Adds a config item to prevent doxygen from using absolute paths in generated diagrams. This trims off the base directory during config to leave just relative paths. Signed-off-by: Jon A. Cruz --- doc/doxygen/tooldev.doxygen.in | 1 + doc/doxygen/tools.doxygen.in | 1 + 2

Re: [PATCH weston 1/2] compositor: don't crash if destroying a compositor without a backend

On 03/10/15 08:25 AM, Giulio Camuffo wrote: > Calling weston_compositor_destroy() on a pointer returned by > weston_compositor_create() should be always valid, even if the > compositor does not have yet a backend. > > Signed-off-by: Giulio Camuffo Reviewed-by: Derek

Re: [PATCH weston 2/2] main: fix destroying the compositor on error while starting

On 03/10/15 08:25 AM, Giulio Camuffo wrote: > Signed-off-by: Giulio Camuffo Reviewed-by: Derek Foreman > --- > src/main.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/main.c b/src/main.c > index

Re: [PATCH weston] doc: Correct absolute path in doxygen graphs.

On Mon, Oct 05, 2015 at 12:19:43PM -0700, Jon A. Cruz wrote: > Adds a config item to prevent doxygen from using absolute paths in > generated diagrams. This trims off the base directory during config to > leave just relative paths. > > Signed-off-by: Jon A. Cruz

Re: Enums, bitfields and wl_arrays

Le 2015-10-05 21:53, Nils Chr. Brause a écrit : Bill Spitzak wrote: Similarly it seems like an "open" indicator that can be added to enums (including bitfields) would help, as it sounds like some languages make it difficult or cryptic to allow casting of arbitrary numbers to the enum value.

Re: [PATCH weston 1/4] gl_renderer: allow GL Renderer to be disabled with --disable-gl-renderer

2015-09-10 12:13 GMT+03:00 Pekka Paalanen : > On Sat, 5 Sep 2015 15:01:37 +0100 > John Sadler wrote: > >> Commit a352580285 introduced a dependency on `libdrm` whenever >> EGL support is enabled. However, when building for Raspberry Pi >>

Re: [PATCH v2 weston] compositor-x11: Fix Weston running on a secondary X screen

On Mon, Oct 05, 2015 at 05:27:54PM -0500, Derek Foreman wrote: > From: Marko > > When DISPLAY is anything other than #.0 weston would still use .0 > > Fixes > https://bugs.freedesktop.org/show_bug.cgi?id=90532 > > --- > > This has been around for far too long and it fixes

Re: [PATCH][weston] animation: Fix potential leak of memory pointed to by move

On Sun, Oct 04, 2015 at 06:43:48PM +0300, Giulio Camuffo wrote: > 2015-10-03 17:18 GMT+03:00 Lucas Tanure : > > Free move before return if animation is null. > > > > Signed-off-by: Lucas Tanure > > Reviewed-by: Giulio Camuffo > > >

Re: Enums, bitfields and wl_arrays

I see. You're right. :) On 5 Oct 2015 22:31, "Victor Berger" wrote: > > Le 2015-10-05 21:53, Nils Chr. Brause a écrit : >> >> Bill Spitzak wrote: >>> >>> Similarly it seems like an "open" indicator that can be added to enums >>> (including bitfields) would help, as it

Re: [PATCH weston 1/2] compositor: don't crash if destroying a compositor without a backend

Pushed both in this series. Thanks, Derek On 03/10/15 08:25 AM, Giulio Camuffo wrote: > Calling weston_compositor_destroy() on a pointer returned by > weston_compositor_create() should be always valid, even if the > compositor does not have yet a backend. > > Signed-off-by: Giulio Camuffo

Re: [PATCH wayland v2] scanner: Close input resource when done to prevent leak

Pushed, thanks. On 01/10/15 08:13 PM, Bryce Harrington wrote: > Addresses this error reported by Denis Denisov: > > [src/scanner.c:1415]: (error) Resource leak: input > > Signed-off-by: Bryce Harrington > > v2: Also close input for other exit points in main. >

Re: [PATCH wayland 8/8] client: Use read preparation API in wl_display_dispatch_queue()

On Fri, Oct 02, 2015 at 01:50:09PM -0700, Bryce Harrington wrote: > On Fri, Oct 02, 2015 at 01:42:03PM -0700, Bryce Harrington wrote: > > On Fri, Oct 02, 2015 at 05:32:59PM +0800, Jonas Ådahl wrote: > > > Instead of doing things that do the equivalent of using > > > wl_display_prepare_read() and

Re: Enums, bitfields and wl_arrays

Hi, Auke Booij wrote: > I think that we have an agreement in principle, just not in terms (and > this also goes back to my comment to Victor Berger). What I meant to > express is that any bindings that violate this rule are on the risk of > the bindings writers, rather than the wayland and

[PATCH v2 weston] compositor-x11: Fix Weston running on a secondary X screen

From: Marko When DISPLAY is anything other than #.0 weston would still use .0 Fixes https://bugs.freedesktop.org/show_bug.cgi?id=90532 --- This has been around for far too long and it fixes a real bug... Marko, if you're still paying attention, would you mind testing

Re: Enums, bitfields and wl_arrays

Re-adding the CCs: Jeroen, Jason, Boyan. Jeroen is the one who started the April 2015 thread on this. On Sun, 4 Oct 2015 22:15:12 +0100 Auke Booij wrote: > This email contains a clear suggestions that I'd like everyone to > read, not just Nils and Erik. But Nils and Erik

Re: [PATCH] wayland: add a release request on wl_seat

On 02/10/15 07:20 AM, David FORT wrote: > This is required if we want to correctly remove a wl_seat compositor-side. A > wl_seat is announced as a global object, then it is bound by the client. When > the compositor wants to remove the seat, it shall announce the global removal > of > the object.

Re: [PATCH wayland] shm: Add wl_shm_buffer get/put functions

On 04/10/15 01:21 PM, Bill Spitzak wrote: > On 10/04/2015 08:34 AM, Giulio Camuffo wrote: >> 2015-07-18 0:30 GMT+03:00 Derek Foreman : >>> Sometimes the compositor wants to make sure a shm pool doesn't disappear >>> out from under it. >>> >>> For example, in Enlightenment,

Re: [PATCH wayland] server: Make serial number 0 mean invalid

On 01/10/15 02:59 PM, Jasper St. Pierre wrote: > For the present case, present_with_event will support focus-stealing > prevention if the serial is garbage or not up to date, whereas present > should always steal focus. I thought the intent was that "present" would *never* steal focus, and that

Re: [PATCH wayland] server: Make serial number 0 mean invalid

On 30/09/15 03:23 PM, Jasper St. Pierre wrote: > I don't necessarily like this. The absence of a serial can have > radical meanings on behavior. Being able to pass 0 to mean "no serial" > anywhere we currently rely on a serial seems like poor design to me, > and can easily be done by mistake.

Re: [PATCH wayland] shm: Add wl_shm_buffer get/put functions

On 04/10/15 10:49 AM, Jasper St. Pierre wrote: > I imagine get/put is named after the kernel style. I typically see > ref/unref for userspace names (or ref/destroy, but nobody likes that). Yup, sorry. > On Sun, Oct 4, 2015 at 8:34 AM, Giulio Camuffo > wrote: >>

[weston] Linking native library in cross compiling.

Dear all I'm cross compiling the weston for arm and I have the problem that when linking, it links with the native pixman library. The most recent commit: commit aa9747833efa6e9686ce3af0ec17afcf4efce342 Author: Giulio Camuffo Date: Sun Feb 1 16:18:51 2015 +0200 The