Re: [Patch] weston-launch: Fix tight poll/recvmsg loop on weston exit

2015-10-07 Thread Bruno Prémont
On Wed, 07 Oct 2015 15:27:18 -0500 Derek Foreman wrote: > Still need to decide what to do with this patch... > > comments below. Sorry for not being very responsive, I'm running rather low on time and have had no time to play around with weston to determine which factors are needed in addition to

Re: [PATCH wayland 4/8] client: Move prepare read documentation to .._prepare_read_queue()

2015-10-07 Thread Jonas Ådahl
On Fri, Oct 02, 2015 at 01:32:21PM -0700, Bryce Harrington wrote: > On Fri, Oct 02, 2015 at 05:32:55PM +0800, Jonas Ådahl wrote: > > In the documentation we refer to "an event queue" in various places and > > from the beginning it is unclear what event queue this means. So, > > instead of having a

[PATCH wayland] scanner: Generate 'since' macros for requests as well

2015-10-07 Thread Jonas Ådahl
We already generate WL_[INTERFACE]_[REQUEST]_SINCE_VERSION macros for events in the server protocol headers. Lets do the same for requests in the client protocol headers as well. Signed-off-by: Jonas Ådahl --- src/scanner.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/scanner.c b/src/

Re: [PATCH] weston: release keyboard/touch/pointer objects

2015-10-07 Thread Jonas Ådahl
On Tue, Oct 06, 2015 at 10:59:32AM +0200, David FORT wrote: > This patch adds the missing calls to release when the seat has capabilities > changes. It also fixes a missing release of the touch object. > --- > clients/window.c | 23 +++ > 1 file changed, 19 insertions(+), 4 del

Re: black surface in desktop shell fullscreen mode

2015-10-07 Thread zou lan
>>If a client really wants to use the transparency, and does not want opaque black bars, it can be the client's responsibility to produce a buffer that can fill the screen. This is what the client wants to. The Qt app call "hide" function just wants to implement a function like minimize the window

Re: Signed-off-by in Wayland and Weston projects

2015-10-07 Thread Jonas Ådahl
On Wed, Oct 07, 2015 at 11:05:34AM -0700, Bryce Harrington wrote: > On Wed, Oct 07, 2015 at 11:21:38AM -0500, Derek Foreman wrote: > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA1 > > > > On 07/10/15 02:27 AM, Pekka Paalanen wrote: > > > On Tue, 06 Oct 2015 15:30:17 -0500 Derek Foreman > > >

Re: [PATCH] wayland: add a release request on wl_seat

2015-10-07 Thread Bryce Harrington
On Mon, Oct 05, 2015 at 12:24:19PM -0500, Derek Foreman wrote: > On 02/10/15 07:20 AM, David FORT wrote: > > This is required if we want to correctly remove a wl_seat compositor-side. A > > wl_seat is announced as a global object, then it is bound by the client. > > When > > the compositor wants t

Re: [PATCH] wayland: add a release request on wl_seat

2015-10-07 Thread Bryce Harrington
On Mon, Oct 05, 2015 at 12:24:19PM -0500, Derek Foreman wrote: > On 02/10/15 07:20 AM, David FORT wrote: > > This is required if we want to correctly remove a wl_seat compositor-side. A > > wl_seat is announced as a global object, then it is bound by the client. > > When > > the compositor wants t

Re: [PATCH weston v3 3/3] Introduce wl_relative_pointer interface

2015-10-07 Thread Jonas Ådahl
On Wed, Oct 07, 2015 at 01:32:35PM -0500, Derek Foreman wrote: > On 29/07/15 01:39 AM, Jonas Ådahl wrote: > > A wl_relative_pointer object is an extension to the wl_pointer interface > > only used for emitting relative pointer events. It will only emit events > > when the parent pointer has focus.

Re: [PATCH weston] zoom: Remove unneeded usage of wl_fixed_ts in favour of doubles

2015-10-07 Thread Bryce Harrington
On Wed, Oct 07, 2015 at 09:05:18PM +0300, Giulio Camuffo wrote: > 2015-10-07 20:29 GMT+03:00 Derek Foreman : > > On 07/10/15 12:14 PM, Giulio Camuffo wrote: > >> Signed-off-by: Giulio Camuffo > >> --- > >> > >> This is the first of a series of patches i plan on doing to remove the > >> internal us

Re: [PATCH weston 2/2] input-panel: Fix show_input_panel_surface crash when no surface has focus

2015-10-07 Thread Bryce Harrington
On Tue, Oct 06, 2015 at 10:40:28AM -0500, Derek Foreman wrote: > From: Nicolas Guyomard > > Signed-off-by: Nicolas Guyomard > Signed-off-by: Derek Foreman Thanks, R-b and pushed this one (but not #1 due to derek's NAK): remote: Updating patchwork state for http://patchwork.freedesktop.org/pr

Re: [PATCH weston 2/2] input-panel: Fix show_input_panel_surface crash when no surface has focus

2015-10-07 Thread Bryce Harrington
On Tue, Oct 06, 2015 at 10:40:28AM -0500, Derek Foreman wrote: > From: Nicolas Guyomard > > Signed-off-by: Nicolas Guyomard > Signed-off-by: Derek Foreman Reviewed-by: Bryce Harrington > --- > desktop-shell/input-panel.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/desktop-sh

Re: [PATCH weston 1/2] shell: update pointer focus when surface is minimized.

2015-10-07 Thread Bryce Harrington
On Tue, Oct 06, 2015 at 10:40:27AM -0500, Derek Foreman wrote: > From: Nicolas Guyomard > > Signed-off-by: Nicolas Guyomard > Signed-off-by: Derek Foreman Reviewed-by: Bryce Harrington > --- > desktop-shell/shell.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git

Re: [PATCH weston] doc: Correct absolute path in doxygen graphs.

2015-10-07 Thread Bryce Harrington
On Mon, Oct 05, 2015 at 12:19:43PM -0700, Jon A. Cruz wrote: > Adds a config item to prevent doxygen from using absolute paths in > generated diagrams. This trims off the base directory during config to > leave just relative paths. > > Signed-off-by: Jon A. Cruz Thanks, pushed: remote: Updating

[PATCH weston] tests: Adding simple waycheck validation tool.

2015-10-07 Thread Jon A. Cruz
This is a follow-up breakout of the patches to add 'waycheck' for testing. As the second of three submissions, this is one of the less interesting except for the wtst_fixtures that can be reused elsewhere. A final follow-up patchset will use the fixtures in a Weston-specific test program that will

[PATCH weston] tests: Adding simple waycheck validation tool.

2015-10-07 Thread Jon A. Cruz
Adds an initial implementation of a testing tool that uses the unit test framework to run checks against an arbitrary Wayland compositor. Note that this is not intended for Weston-specific testing, but for generic Wayland testing. Signed-off-by: Jon A. Cruz --- .gitignore

Re: [PATCH] weston-input: Reformat weston_log line to add missing space between words

2015-10-07 Thread Hardening
Le 07/10/2015 18:33, Derek Foreman a écrit : > On 07/10/15 10:59 AM, Chris Michael wrote: >> Signed-off-by: Chris Michael > > Reviewed-by: Derek Foreman > >> --- >> src/input.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/input.c b/src/input.c >> index e230c8

Re: [Patch] weston-launch: Fix tight poll/recvmsg loop on weston exit

2015-10-07 Thread Derek Foreman
Still need to decide what to do with this patch... comments below. On 14/05/15 03:43 PM, Derek Foreman wrote: > On 27/03/15 07:29 AM, Bruno Prémont wrote: >> When weston fails to run while being launched by weston-launch it's >> socketpair causes poll() to notify POLLIN|POLLHUP and lets recvmsg()

Re: [PATCH weston v3 3/3] Introduce wl_relative_pointer interface

2015-10-07 Thread Derek Foreman
On 29/07/15 01:39 AM, Jonas Ådahl wrote: > A wl_relative_pointer object is an extension to the wl_pointer interface > only used for emitting relative pointer events. It will only emit events > when the parent pointer has focus. > > To get a relative pointer object, use the get_relative_pointer req

Re: [PATCH weston] cosmetic: Remove a few double semicolons

2015-10-07 Thread Bryce Harrington
On Wed, Oct 07, 2015 at 11:51:29AM -0500, Derek Foreman wrote: > Signed-off-by: Derek Foreman remote: Updating patchwork state for http://patchwork.freedesktop.org/project/wayland/list/ remote: I: patch #61271 updated using rev bdc8c721e44e214990af7212815eab573b0d18cd remote: I: 1 patch(es) upd

Re: [PATCH] Remove protocol/wayland.dtd

2015-10-07 Thread Bryce Harrington
On Wed, Oct 07, 2015 at 11:25:40AM +0300, Pekka Paalanen wrote: > On Tue, 6 Oct 2015 17:38:02 +0100 > Auke Booij wrote: > > > The wayland scanner defines the protocol. The DTD specification is not used. > > --- > > protocol/wayland.dtd | 29 - > > 1 file changed, 29

Re: [PATCH weston] zoom: Remove unneeded usage of wl_fixed_ts in favour of doubles

2015-10-07 Thread Giulio Camuffo
2015-10-07 20:29 GMT+03:00 Derek Foreman : > On 07/10/15 12:14 PM, Giulio Camuffo wrote: >> Signed-off-by: Giulio Camuffo >> --- >> >> This is the first of a series of patches i plan on doing to remove the >> internal use of wl_fixed_t in weston, if people agree. >> There is really no reason as fa

Re: Signed-off-by in Wayland and Weston projects

2015-10-07 Thread Bryce Harrington
On Wed, Oct 07, 2015 at 11:21:38AM -0500, Derek Foreman wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 07/10/15 02:27 AM, Pekka Paalanen wrote: > > On Tue, 06 Oct 2015 15:30:17 -0500 Derek Foreman > > wrote: > > > >> Hmm, I landed this one but shouldn't have - we require > >> si

Re: [PATCH weston] zoom: Remove unneeded usage of wl_fixed_ts in favour of doubles

2015-10-07 Thread Derek Foreman
On 07/10/15 12:14 PM, Giulio Camuffo wrote: > Signed-off-by: Giulio Camuffo > --- > > This is the first of a series of patches i plan on doing to remove the > internal use of wl_fixed_t in weston, if people agree. > There is really no reason as far as i can see to use it unless you're > sending a

[PATCH weston] zoom: Remove unneeded usage of wl_fixed_ts in favour of doubles

2015-10-07 Thread Giulio Camuffo
Signed-off-by: Giulio Camuffo --- This is the first of a series of patches i plan on doing to remove the internal use of wl_fixed_t in weston, if people agree. There is really no reason as far as i can see to use it unless you're sending a wayland event, and usually code using wl_fixed_ts end up

Re: [PATCH] xwayland: Adjust screen size with rotation

2015-10-07 Thread Adam Jackson
On Sat, 2015-10-03 at 09:46 +1000, Dave Airlie wrote: > On 23 September 2015 at 23:35, Olivier Fourdan > wrote: > > bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92076 > > Signed-off-by: Olivier Fourdan > > Seems sane, > > Reviewed-by: Dave Airlie Merged: remote: I: patch #60158 upd

[PATCH weston] cosmetic: Remove a few double semicolons

2015-10-07 Thread Derek Foreman
Signed-off-by: Derek Foreman --- clients/image.c| 2 +- desktop-shell/shell.c | 2 +- tests/config-parser-test.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/clients/image.c b/clients/image.c index 4126305..db9ccd6 100644 --- a/clients/image.c +++ b/clie

Re: [PATCH weston] desktop-shell: NULL check whether a popup parent is a shell surface

2015-10-07 Thread Derek Foreman
On 07/10/15 01:44 AM, Jonas Ådahl wrote: > get_shell_surface(parent) may return NULL if the client passed a > unassigned wl_surface or a wl_surface with a non-shell surface role > (such as cursor role). > > https://bugs.freedesktop.org/show_bug.cgi?id=92316 > > Signed-off-by: Jonas Ådahl Looks

Re: [PATCH] weston-input: Reformat weston_log line to add missing space between words

2015-10-07 Thread Derek Foreman
On 07/10/15 10:59 AM, Chris Michael wrote: > Signed-off-by: Chris Michael Reviewed-by: Derek Foreman > --- > src/input.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/input.c b/src/input.c > index e230c83..2e5cd04 100644 > --- a/src/input.c > +++ b/src/input.c >

Re: Signed-off-by in Wayland and Weston projects

2015-10-07 Thread Derek Foreman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/10/15 02:27 AM, Pekka Paalanen wrote: > On Tue, 06 Oct 2015 15:30:17 -0500 Derek Foreman > wrote: > >> Hmm, I landed this one but shouldn't have - we require >> signed-off-by for commits. >> >> Could you re-send your other two with Signed-off-

[PATCH] weston-input: Reformat weston_log line to add missing space between words

2015-10-07 Thread Chris Michael
Signed-off-by: Chris Michael --- src/input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/input.c b/src/input.c index e230c83..2e5cd04 100644 --- a/src/input.c +++ b/src/input.c @@ -1571,7 +1571,7 @@ notify_touch(struct weston_seat *seat, uint32_t time, int touch_id,

Re: [PATCH 4/4] compositor-rdp: Add missing '\n' in weston_log usage

2015-10-07 Thread Hardening
Le 01/10/2015 16:51, Chris Michael a écrit : > Signed-off-by: Chris Michael > --- > src/compositor-rdp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/compositor-rdp.c b/src/compositor-rdp.c > index c221eb9..7272f41 100644 > --- a/src/compositor-rdp.c > +++ b/src/c

Re: [weston] Missing header file

2015-10-07 Thread Pekka Paalanen
On Wed, 7 Oct 2015 12:28:58 +0200 Joaquim Duran wrote: > Hello, Hi, please keep the mailing list in CC. > The file protocol/presentation_timing-client-protocol.h is not generated: > > gem-med@gemmed-VirtualBox:~/Logic_BSPs/Linux_3.0/src/weston$ find . > -name "presentation_timing-client-proto

Re: [weston] Missing header file

2015-10-07 Thread Pekka Paalanen
On Wed, 7 Oct 2015 11:02:30 +0200 Joaquim Duran wrote: > Hello, > > I am cross compiling weston for arm architecture witn the following > configuration: > > ./autogen.sh \ > --disable-devdocs \ > --disable-dbus \ > --disable-xwayland \ > --disable-xwayland-test \ > --disable

[weston] Missing header file

2015-10-07 Thread Joaquim Duran
Hello, I am cross compiling weston for arm architecture witn the following configuration: ./autogen.sh \ --disable-devdocs \ --disable-dbus \ --disable-xwayland \ --disable-xwayland-test \ --disable-x11-compositor \ --disable-drm-compositor \ --enable-wayland-composito

Re: [PATCH] Remove protocol/wayland.dtd

2015-10-07 Thread Pekka Paalanen
On Tue, 6 Oct 2015 17:38:02 +0100 Auke Booij wrote: > The wayland scanner defines the protocol. The DTD specification is not used. > --- > protocol/wayland.dtd | 29 - > 1 file changed, 29 deletions(-) > delete mode 100644 protocol/wayland.dtd Reviewed-by: Pekka Pa

Signed-off-by in Wayland and Weston projects

2015-10-07 Thread Pekka Paalanen
On Tue, 06 Oct 2015 15:30:17 -0500 Derek Foreman wrote: > Hmm, I landed this one but shouldn't have - we require signed-off-by for > commits. > > Could you re-send your other two with Signed-off-by? Hi, I think we've been quite liberal with the S-o-b. It certainly is preferred to have, but I h