[PATCH] compositor.h: Remove unused variable from weston_seat structure

This variable may have been used previously when evdev.c was used however that functionality seems to have been consumed by libinput, so there is no need for this variable in the weston_seat structure anymore. Signed-off-by: Chris Michael --- src/compositor.h | 1 - 1

Re: [PATCH] compositor.h: Remove unused variable from weston_seat structure

On 18/11/15 09:22 AM, Chris Michael wrote: > This variable may have been used previously when evdev.c was used > however that functionality seems to have been consumed by libinput, so > there is no need for this variable in the weston_seat structure anymore. > > Signed-off-by: Chris Michael

Re: [PATCH wayland] protocol: Remove incorrect statement that attach must precede damage

On Wed, Nov 18, 2015 at 7:44 AM, Derek Foreman wrote: > The documentation for wl_surface.commit makes it clear that the > application of damage follows attach during the commit, so it > doesn't matter what order the app sends the requests. > > Many existing apps post

Re: Changing wl_output.transform type to unsigned?

On Tue, Nov 17, 2015 at 8:07 PM, Jonas Ådahl wrote: > > > We'll see how that patch is received. If anyone complains it breaks > > their thing, I think we have to revert it, because it is technically > > breaking the stability rules. > > The most obvious thing that would "break"

[PATCH wayland 2/2] scanner: drop altmacro from dtddata.S

From: Pekka Paalanen Stop using .altmacro in dtddata.S, because clang does not yet implement it. Turns out that we do not actually seem to need it, and we can modify the syntax to work without it. Moving the double quotes from the binfile line to the .incbin line

[PATCH wayland 1/2] Makefile: use automake rule for compiling .S

From: Pekka Paalanen Automake seems to have its own rules for compiling an .o from an .S. Essentially it does the same as our hand-crafted rule, but adds some things like dependency file generation. Remove our hand-crafted rule to use the automake rule, it is

[PATCH weston] configure: don't control egl version

The required version only corresponds to version of mesa implementation. This mesa version requirement causes configure errors, when weston is configured for a different egl implementation than mesa. Because the version of the egl drivers are not alligned to the mesa version. Therefore, I deleted

[PATCH weston 11/11] simple-damage: Add --use-buffer-damage flag

Add a new flag for testing damage in buffer co-ordinates Signed-off-by: Derek Foreman --- clients/simple-damage.c | 62 + 1 file changed, 47 insertions(+), 15 deletions(-) diff --git a/clients/simple-damage.c

[PATCH weston 04/11] gl-renderer: Use a bool for needs_full_upload

Signed-off-by: Derek Foreman --- src/gl-renderer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gl-renderer.c b/src/gl-renderer.c index d7231f4..4c231d1 100644 --- a/src/gl-renderer.c +++ b/src/gl-renderer.c @@ -111,7 +111,7 @@ struct

[PATCH weston 05/11] gl-renderer: Make texture_used a bool instead of an int

Signed-off-by: Derek Foreman --- src/gl-renderer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gl-renderer.c b/src/gl-renderer.c index 4c231d1..2c51a83 100644 --- a/src/gl-renderer.c +++ b/src/gl-renderer.c @@ -1173,7 +1173,7 @@

[PATCH weston 00/11] implement damage_buffer

As usual I've included random NOPwork in the vicinity of the important changes. It was convenient to have a way to transform a region with a matrix so I cherry-picked Jason Ekstrand's patch to do so out of my transform series from over a year ago. This changes pixman zooming, which is utterly

[PATCH weston 08/11] compositor: ignore surface_damage with negative height or width

If we pass negative height or width on to pixman we get error messages in the log. Signed-off-by: Derek Foreman --- src/compositor.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/compositor.c b/src/compositor.c index 666bc15..0efb325 100644 ---

[PATCH weston 09/11] compositor: Add buffer_damage

Add an implementation of wl_surface.buffer_damage, similar to wl_surface.damage except it uses buffer co-ordinates. Signed-off-by: Derek Foreman --- src/compositor.c | 90 ++-- src/compositor.h | 4 ++- 2 files

[PATCH weston 01/11] smoke: Don't post extra damage

We're going to post damage when the widget redraw happens anyway. Signed-off-by: Derek Foreman --- clients/smoke.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/clients/smoke.c b/clients/smoke.c index c8fdc06..77120b4 100644 --- a/clients/smoke.c +++

Re: [PATCH weston 11/11] simple-damage: Add --use-buffer-damage flag

As this code is going to be referred to by people trying to figure out wayland, it might be best to use this by default. Fall back to the old damage request only if the api is too old or if a special switch is passed. On Wed, Nov 18, 2015 at 2:32 PM, Derek Foreman wrote:

Re: [PATCH wayland-protocols 2/2] Introduce pointer locking and confinement protocol

On Tue, Nov 17, 2015 at 06:09:18PM +0800, Jonas Ådahl wrote: > This patch introduces a new protocol for locking and confining a > pointer. It consists of a new global object with two requests; one for > locking the surface to a position, one for confining the pointer to a > given region. > >

Re: [PATCH weston 10/11] simple-damage: Offset drawing co-ordinates not buffer start

You sure this has to change? On Wed, Nov 18, 2015 at 2:32 PM, Derek Foreman wrote: > We've been setting up the viewport by moving the start pointer of the > draw buffer, but later when we want to post damage in buffer co-ordinates > we'll need to keep track of the x,y

Re: [PATCH weston v4 09/20] input: Keep per client pointer resources in their own structs

On Tue, Nov 17, 2015 at 06:10:55PM +0800, Jonas Ådahl wrote: > Keep all per client wl_pointer resources in a new struct called > 'weston_pointer_client'. When focus changes, instead of moving a list > of resources between different lists, just change the focused pointer > client. > > The

Re: [PATCH weston v4 10/20] input: Provide microsecond timestamps in motion events

On Tue, Nov 17, 2015 at 06:10:56PM +0800, Jonas Ådahl wrote: > Provide timestamps with microsecond granularity if the backend can > provide it. Backends that can't should set it to 0. > > Signed-off-by: Jonas Ådahl Reviewed-by: Peter Hutterer > ---

Re: [PATCH v5 wayland] protocol: add wl_pointer.frame, axis_source, axis_stop, and axis_discrete

On Wed, Nov 18, 2015 at 2:46 PM, Peter Hutterer wrote: > On Mon, Nov 16, 2015 at 07:07:46PM +, Daniel Stone wrote: > > Hi, > > > > On Monday, 16 November 2015, Bill Spitzak wrote: > > > > > > Since the "frame" event groups everything together, it

Re: [PATCH weston v4 11/20] Implement the relative pointer protocol

On Tue, Nov 17, 2015 at 06:10:57PM +0800, Jonas Ådahl wrote: > A wp_relative_pointer object is an extension to the wl_pointer interface > only used for emitting relative pointer events. It will only emit events > when the parent pointer has focus. > > To get a relative pointer object, use the

Re: [PATCH weston v4 07/20] libinput: Expose unaccelerated motion deltas in motion event struct

On Tue, Nov 17, 2015 at 06:10:53PM +0800, Jonas Ådahl wrote: > Signed-off-by: Jonas Ådahl > --- > src/compositor.h | 3 +++ > src/libinput-device.c | 9 - > 2 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/src/compositor.h b/src/compositor.h >

Re: [PATCH weston 08/11] compositor: ignore surface_damage with negative height or width

On Wed, Nov 18, 2015 at 2:32 PM, Derek Foreman wrote: > If we pass negative height or width on to pixman we get error messages > in the log. > > Signed-off-by: Derek Foreman > --- > src/compositor.c | 3 +++ > 1 file changed, 3 insertions(+) > >

Re: [PATCH weston v4 01/20] input: Make pointer grab motion callbacks take an event struct

On Tue, Nov 17, 2015 at 06:10:47PM +0800, Jonas Ådahl wrote: > Instead of only passing absolute pointer coordinates, effectively > loosing motion event data, pass a struct that can potentially contain > different types of motion events, currently being absolute and relative. > > A helper function

Re: [PATCH weston v4 06/20] compositor: Keep track of what views were activated by clicking

On Tue, Nov 17, 2015 at 06:10:52PM +0800, Jonas Ådahl wrote: > Adds a weston_view_activate() that can be passed an additional active > flag WESTON_ACTIVATE_CLICKED, that the shell passes when a view was > activated by clicking. > > This allows shell independent components implement heuristics

Re: [PATCH weston v4 08/20] input: Don't send wl_pointer.motion if position didn't change

On Tue, Nov 17, 2015 at 06:10:54PM +0800, Jonas Ådahl wrote: > Signed-off-by: Jonas Ådahl Reviewed-by: Peter Hutterer Cheers, Peter > --- > src/input.c | 12 > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git

Re: [PATCH wayland 1/2] Makefile: use automake rule for compiling .S

On Wed, Nov 18, 2015 at 01:07:36PM +0200, Pekka Paalanen wrote: > From: Pekka Paalanen > > Automake seems to have its own rules for compiling an .o from an .S. > Essentially it does the same as our hand-crafted rule, but adds some > things like dependency file

[PATCH weston 02/11] toytoolkit: Remove window_damage()

It's just a direct call to wl_surface_damage() anyway, and the only caller no longer exists. Signed-off-by: Derek Foreman --- clients/window.c | 7 --- clients/window.h | 4 2 files changed, 11 deletions(-) diff --git a/clients/window.c b/clients/window.c index

[PATCH weston 06/11] pixman-renderer: Use output->matrix for region transformations and enable output zoom

From: Jason Ekstrand --- This fixes zoom, but it also changes how pixman's region_global_to_output works... src/pixman-renderer.c | 70 +++ 1 file changed, 60 insertions(+), 10 deletions(-) diff --git

[PATCH weston 03/11] compositor: Change "touched" to bool

Signed-off-by: Derek Foreman --- src/compositor.c | 4 ++-- src/compositor.h | 2 +- src/rpi-renderer.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index f8437e8..67be07d 100644 --- a/src/compositor.c

[PATCH weston 10/11] simple-damage: Offset drawing co-ordinates not buffer start

We've been setting up the viewport by moving the start pointer of the draw buffer, but later when we want to post damage in buffer co-ordinates we'll need to keep track of the x,y offsets anyway. Signed-off-by: Derek Foreman --- clients/simple-damage.c | 58

[PATCH weston 07/11] compositor: Move weston_matrix_transform_region to compositor.c and export it

We're going to use this to replace much of the other transform code so it's no longer just relevant to pixman-renderer.c Signed-off-by: Derek Foreman --- src/compositor.c | 51 +++ src/compositor.h | 4

[PATCH wayland v2] protocol: Add wl_surface.damage_buffer

wl_surface.damage uses surface local co-ordinates. Buffer scale and buffer transforms came along, and EGL surfaces have no understanding of them. Theoretically, clients pass damage rectangles - in Y-inverted surface co-ordinates) to EGLSwapBuffersWithDamage, and the EGL implementation passed

Re: [PATCH v5 wayland] protocol: add wl_pointer.frame, axis_source, axis_stop, and axis_discrete

On Mon, Nov 16, 2015 at 07:07:46PM +, Daniel Stone wrote: > Hi, > > On Monday, 16 November 2015, Bill Spitzak wrote: > > > > Since the "frame" event groups everything together, it does not seem like > > there is a need to talk about "latching". _descrete events are

Re: [PATCH wayland-protocols 1/2] Introduce wp_relative_pointer interface

On Tue, Nov 17, 2015 at 06:09:17PM +0800, Jonas Ådahl wrote: > The wp_relative_pointer interface is an extension to the wl_pointer > interface created from wl_seat. It has the same focus, but adds the > functionality of sending relative pointer motions unhindered by > constraints such as monitor

Re: [PATCH wayland 2/2] scanner: drop altmacro from dtddata.S

On Wed, Nov 18, 2015 at 01:07:37PM +0200, Pekka Paalanen wrote: > From: Pekka Paalanen > > Stop using .altmacro in dtddata.S, because clang does not yet implement > it. Turns out that we do not actually seem to need it, and we can modify > the syntax to work

Re: [PATCH weston v4 12/20] Implement pointer locking and confinement

On Tue, Nov 17, 2015 at 06:10:58PM +0800, Jonas Ådahl wrote: > This patch implements the wp_pointer_constraints protocol used for > locking or confining a pointer. It consists of a new global object with > two requests; one for locking the surface to a position, one for > confining the pointer to

Re: [PATCH wayland v2] protocol: Add wl_surface.damage_buffer

I am certainly not against these changes .. +1 for the effort ;) However, I would like to know (and possible others would also), what does this mean for toolkits ?? Aside from bumping compositor and surface versions, what sort of changes (short version please) should we look at implementing

Re: [PATCH wayland 2/2] scanner: drop altmacro from dtddata.S

On Thu, 19 Nov 2015 08:10:14 +1000 Peter Hutterer wrote: > On Wed, Nov 18, 2015 at 01:07:37PM +0200, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > Stop using .altmacro in dtddata.S, because clang does not yet implement > > it.

Re: [PATCH wayland] protocol: Remove incorrect statement that attach must precede damage

On Wed, Nov 18, 2015 at 09:44:11AM -0600, Derek Foreman wrote: > The documentation for wl_surface.commit makes it clear that the > application of damage follows attach during the commit, so it > doesn't matter what order the app sends the requests. > > Many existing apps post damage before