Re: [PATCH weston 1/2 v2] compositor: change rounding in weston_surface_to_buffer_rect()

pushed this one On 01/12/15 01:00 PM, Derek Foreman wrote: > Rounding both corners of the rectangle down can result in a 0 > width/height rectangle before passing to weston_transformed_rect. > > This showed up as missing damage in weston-simple-damage (the > bouncing ball would leave green

Re: [PATCH] compositor: Remove unused weston_surface_to_buffer function

On 01/12/15 03:30 AM, Pekka Paalanen wrote: > On Mon, 30 Nov 2015 10:23:04 -0500 > Chris Michael wrote: > >> The function 'weston_surface_to_buffer' is unused by compositor and >> clients inside weston, so it should be safe to remove this function >> >> Signed-off-by:

[PATCH libinput] Ignore BTN_TOOL_* events when posting button events

These aren't real button events and they are handled elsewhere, either through proper touch events on touchscreen or through custom handling in the touchpad case. Signed-off-by: Peter Hutterer --- src/evdev.c | 16 +++- 1 file changed, 15 insertions(+), 1

[PATCH libinput 1/8] tablet: drop the tool type 'finger' from the tablet interface

If it's a finger, it's a touchscreen or a touchpad, not a tablet. Signed-off-by: Peter Hutterer --- src/evdev-tablet.c | 6 -- src/evdev-tablet.h | 1 - src/libinput.h | 1 - tools/event-debug.c | 3 --- 4 files changed, 4 insertions(+), 7 deletions(-) diff

[PATCH libinput 0/8] tablet pressure offsets and calibration matrix

This series adds two missing features, pressure offset (6/8) and the use of the calibration matrix for tablets (8/8). Pressure offsets deal with worn-out stylus nibs, unlike the X.Org driver which tries to detect this automatically (and thus needs a config option to turn the automatic detection

[PATCH libinput 4/8] tablet: force the pressure/distance to 0 depending on contact state

If we have pressure but not BTN_TOUCH, force the pressure to 0. Otherwise, force distance to 0. Signed-off-by: Peter Hutterer --- src/evdev-tablet.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/src/evdev-tablet.c

[PATCH libinput 2/8] test: add tablet pressure/distance test cases

Signed-off-by: Peter Hutterer --- test/tablet.c | 60 +++ 1 file changed, 60 insertions(+) diff --git a/test/tablet.c b/test/tablet.c index c268045..125ab4b 100644 --- a/test/tablet.c +++ b/test/tablet.c @@

[PATCH libinput 5/8] Add a atoi_safe helper for basic string conversions

Does what you expect, and returns false on errors. Signed-off-by: Peter Hutterer --- src/libinput-util.h | 23 +++ test/misc.c | 43 ++- 2 files changed, 65 insertions(+), 1 deletion(-) diff --git

[PATCH libinput 6/8] tablet: support tool-specific pressure offsets

If a tool wears out, it may have a pre-loaded pressure offset. In that case, even when the tool is not physically in contact with the tablet surface it will send pressure events. The X.Org wacom driver has automatic pressure preload detection, but it is unreliable. A quick tap can trigger the

[PATCH libinput 7/8] evdev: make evdev_transform_absolute available within libinput

Signed-off-by: Peter Hutterer --- src/evdev.c | 14 +++--- src/evdev.h | 4 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index d56a470..5a73340 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -212,9 +212,9 @@

[PATCH libinput 3/8] tablet: drop pressure when either pressure or distance changed

Keep pressure and distance mutually exclusive regardless which one of the two updates. Signed-off-by: Peter Hutterer --- src/evdev-tablet.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/evdev-tablet.c b/src/evdev-tablet.c index

Re: [PATCH weston 2/2] compositor: Add doxygen for weston_surface_to_buffer_rect()

On Tue, 1 Dec 2015 13:00:44 -0600 Derek Foreman wrote: > Signed-off-by: Derek Foreman > --- > src/compositor.c | 21 - > 1 file changed, 20 insertions(+), 1 deletion(-) > > diff --git a/src/compositor.c b/src/compositor.c >

Re: [PATCH libinput 6/8] tablet: support tool-specific pressure offsets

On Tue, Dec 01, 2015 at 06:48:41PM -0800, Bill Spitzak wrote: > On Tue, Dec 1, 2015 at 5:46 PM, Peter Hutterer > wrote: > > > > > + switch (tool->type) { > > + case LIBINPUT_TABLET_TOOL_TYPE_PEN: > > + strtype = "PEN"; > > +

[PATCH weston 1/2 v2] compositor: change rounding in weston_surface_to_buffer_rect()

Rounding both corners of the rectangle down can result in a 0 width/height rectangle before passing to weston_transformed_rect. This showed up as missing damage in weston-simple-damage (the bouncing ball would leave green trails when --use-viewport was used) Reviewed-by: Daniel Stone

[PATCH weston 2/2] compositor: Add doxygen for weston_surface_to_buffer_rect()

Signed-off-by: Derek Foreman --- src/compositor.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/src/compositor.c b/src/compositor.c index 0118b67..43cd094 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -932,6 +932,24 @@

Re: [PATCH] main: Remove unused function load_backend_new()

On Mon, 30 Nov 2015 14:25:25 -0800 Bryce Harrington wrote: > On Mon, Nov 30, 2015 at 02:54:41PM -0600, Derek Foreman wrote: > > On 30/11/15 02:51 PM, Chris Michael wrote: > > > This function is unused throughout the entire weston source tree, so > > > remove it. It seems

Re: [PATCH] compositor: Remove unused weston_surface_to_buffer function

On Mon, 30 Nov 2015 10:23:04 -0500 Chris Michael wrote: > The function 'weston_surface_to_buffer' is unused by compositor and > clients inside weston, so it should be safe to remove this function > > Signed-off-by: Chris Michael > --- >

Re: [PATCH weston] compositor: change rounding in weston_surface_to_buffer_rect()

On Mon, 30 Nov 2015 13:33:16 -0600 Derek Foreman wrote: > Rounding both corners of the rectangle down can result in a 0 > width/height rectangle before passing to weston_transformed_rect. > > This showed up as missing damage in weston-simple-damage (the > bouncing ball

Re: black surface in desktop shell fullscreen mode

On Tue, 01 Dec 2015 14:27:40 +0900 Hyungwon Hwang wrote: > Hello all, > > Reading the mail thread, I tried to figure out the problem by myself. > Until now, I couldn't find any reason to make fullscreen application > totally opaque. As I found in git history, in my

Re: [PATCH weston] compositor: change rounding in weston_surface_to_buffer_rect()

On 01/12/15 03:48 AM, Pekka Paalanen wrote: > On Mon, 30 Nov 2015 13:33:16 -0600 > Derek Foreman wrote: > >> Rounding both corners of the rectangle down can result in a 0 >> width/height rectangle before passing to weston_transformed_rect. >> >> This showed up as missing