Re: [PATCH weston 4/5] data-device: Implement compositor-chosen actions

2015-12-21 Thread Jonas Ådahl
On Tue, Dec 22, 2015 at 02:33:30AM +0100, Carlos Garnacho wrote: > Set up a keyboard grab during drag-and-drop, so we can translate > modifiers into preferred actions. The compositor chosen action > is stored in the current weston_data_source in order to make it > accessible to the source/offer at

Re: [PATCH weston 3/5] client: Add DnD cursors to the managed cursors list

2015-12-21 Thread Jonas Ådahl
On Tue, Dec 22, 2015 at 02:33:29AM +0100, Carlos Garnacho wrote: > That way we'll be able to set the corresponding pointer surface to > a current DnD operation. > > Signed-off-by: Carlos Garnacho > Reviewed-by: Jonas Ådahl Seems here and in 5/5 the "@" somewhere turned into " at ". Did you mayb

Re: [PATCH weston 2/5] data-device: Implement DnD actions

2015-12-21 Thread Jonas Ådahl
On Tue, Dec 22, 2015 at 02:33:28AM +0100, Carlos Garnacho wrote: > The policy in weston in order to determine the chosen DnD action is > deliberately simple, and is probably the minimals that any compositor > should be doing here. > > Besides honoring the set_actions requests on both wl_data_sourc

Re: [PATCH weston 1/5] data-device: Implement DnD progress notification

2015-12-21 Thread Jonas Ådahl
On Tue, Dec 22, 2015 at 02:33:27AM +0100, Carlos Garnacho wrote: > Weston now sends wl_data_source.dnd_drop_performed and .dnd_finished in > order to notify about the different phases of DnD. > > wl_data_source.cancelled is also used as mentioned in the docs, being > emitted also on DnD when the o

Re: [PATCH wayland 1/2] protocol: Improve data source notification around DnD progress

2015-12-21 Thread Jonas Ådahl
On Tue, Dec 22, 2015 at 02:33:32AM +0100, Carlos Garnacho wrote: > Currently, there's no means for the DnD origin to know whether the > destination is actually finished with the DnD transaction, short of > finalizing it after the first transfer finishes, or leaking it forever. > > But this poses o

Re: [PATCH wayland 2/2] protocol: Add DnD actions

2015-12-21 Thread Jonas Ådahl
On Tue, Dec 22, 2015 at 02:33:33AM +0100, Carlos Garnacho wrote: > These 2 requests have been added: > > - wl_data_source.set_actions: Notifies the compositor of the available > actions on the data source. > - wl_data_offer.set_actions: Notifies the compositor of the available > actions on the

Re: [ANNOUNCE] libinput 1.1.3

2015-12-21 Thread Bryce Harrington
On Tue, Dec 22, 2015 at 12:05:49PM +1000, Peter Hutterer wrote: > On Mon, Dec 21, 2015 at 05:18:37PM -0800, Bryce Harrington wrote: > > On Wed, Dec 16, 2015 at 07:31:37AM +1000, Peter Hutterer wrote: > > > libinput 1.1.3 is now available. Only one change that affects users, and > > > that one is li

Re: [PATCH wayland 1/2] protocol: Improve data source notification around DnD progress

2015-12-21 Thread Jonas Ådahl
On Tue, Dec 22, 2015 at 02:33:32AM +0100, Carlos Garnacho wrote: > Currently, there's no means for the DnD origin to know whether the > destination is actually finished with the DnD transaction, short of > finalizing it after the first transfer finishes, or leaking it forever. > > But this poses o

Re: [ANNOUNCE] libinput 1.1.3

2015-12-21 Thread Peter Hutterer
On Mon, Dec 21, 2015 at 05:18:37PM -0800, Bryce Harrington wrote: > On Wed, Dec 16, 2015 at 07:31:37AM +1000, Peter Hutterer wrote: > > libinput 1.1.3 is now available. Only one change that affects users, and > > that one is limited to users of the Lenovo x220 with an updated touchpad > > firmware

[PATCH wayland 1/2] protocol: Improve data source notification around DnD progress

2015-12-21 Thread Carlos Garnacho
Currently, there's no means for the DnD origin to know whether the destination is actually finished with the DnD transaction, short of finalizing it after the first transfer finishes, or leaking it forever. But this poses other interoperation problems, drag destinations might be requesting several

[PATCH weston 3/5] client: Add DnD cursors to the managed cursors list

2015-12-21 Thread Carlos Garnacho
That way we'll be able to set the corresponding pointer surface to a current DnD operation. Signed-off-by: Carlos Garnacho Reviewed-by: Jonas Ådahl --- clients/window.c | 16 clients/window.h | 3 +++ 2 files changed, 19 insertions(+) diff --git a/clients/window.c b/clients/w

[PATCH weston 4/5] data-device: Implement compositor-chosen actions

2015-12-21 Thread Carlos Garnacho
Set up a keyboard grab during drag-and-drop, so we can translate modifiers into preferred actions. The compositor chosen action is stored in the current weston_data_source in order to make it accessible to the source/offer at the time of calculating the new action, but would conceptually be part of

[PATCH weston/wayland 0/7] drag-and-drop progress notification and actions

2015-12-21 Thread Carlos Garnacho
Hey, I'm resending again the whole batch again. I applied all suggestions from Jonas, in the end I liked his idea to have data source notification triggered explicitly by a wl_data_offer request, so I added the .finish request to wayland 1/2, and added the implementation on weston 1/5. The rest o

[PATCH wayland 2/2] protocol: Add DnD actions

2015-12-21 Thread Carlos Garnacho
These 2 requests have been added: - wl_data_source.set_actions: Notifies the compositor of the available actions on the data source. - wl_data_offer.set_actions: Notifies the compositor of the available actions on the destination side, plus the preferred action. Out of the data from these req

[PATCH weston 1/5] data-device: Implement DnD progress notification

2015-12-21 Thread Carlos Garnacho
Weston now sends wl_data_source.dnd_drop_performed and .dnd_finished in order to notify about the different phases of DnD. wl_data_source.cancelled is also used as mentioned in the docs, being emitted also on DnD when the operation is meant to fail (eg. source and dest didn't agree on a mimetype).

[PATCH weston 2/5] data-device: Implement DnD actions

2015-12-21 Thread Carlos Garnacho
The policy in weston in order to determine the chosen DnD action is deliberately simple, and is probably the minimals that any compositor should be doing here. Besides honoring the set_actions requests on both wl_data_source and wl_data_offer, weston now will emit the newly added "action" events n

[PATCH weston 5/5] dnd: Turn into a full blown example

2015-12-21 Thread Carlos Garnacho
In order to keep things simple, weston-dnd made a few choices that turn out to be unrealistic, a few tweaks have been done to make it less of a playground demo: - It now caters for copy/move operations, instead of just move, which still remains the default nonetheless. - As "move" operations are

[ANNOUNCE] libinput 1.1.4

2015-12-21 Thread Peter Hutterer
One significant change: previously, we used to take the device's fd from open_restricted() and start synching the device immediately. If the fd is not closed between a close_restricted() and a subsequent open_restricted(), or if the time between opening the fd and handing it to libinput is great en

Re: [PATCH] test: add make check

2015-12-21 Thread Jonas Ådahl
On Mon, Dec 21, 2015 at 02:48:49PM -0600, Derek Foreman wrote: > We can now test all the protocol files by running make check (or distcheck) > which will pass them through the scanner. > > Signed-off-by: Derek Foreman > --- > .gitignore | 3 +++ > Makefile.am | 6 ++ > test/scan.sh | 5 ++

Re: [ANNOUNCE] libinput 1.1.3

2015-12-21 Thread Bryce Harrington
On Wed, Dec 16, 2015 at 07:31:37AM +1000, Peter Hutterer wrote: > libinput 1.1.3 is now available. Only one change that affects users, and > that one is limited to users of the Lenovo x220 with an updated touchpad > firmware version 8.1. Please see > http://who-t.blogspot.com/2015/12/libinput-and-l

Re: [libinput] A query regaring key remap functionality

2015-12-21 Thread Peter Hutterer
On Tue, Dec 22, 2015 at 06:28:21AM +0900, Sung-Jin Park wrote: > dh and peter, > thank you for your answer. > Actually I'm trying understand but frankly to say, I don't get the > following comments. And I don't understand why libinput has the left handed > facility as a device configuration. Can yo

Re: [RFC v2] Add Primary Selection Protocol Version 1

2015-12-21 Thread Lyude
On Mon, 2015-12-21 at 13:42 -0600, Derek Foreman wrote: > On 21/12/15 01:27 AM, Pekka Paalanen wrote: > > On Fri, 18 Dec 2015 12:03:46 -0500 > > Lyude wrote: > > > > > Signed-off-by: Lyude > > > --- > > > Changes > > > * Add new interfaces to replace reuse of wl_dat

Re: [RFC v2] Add Primary Selection Protocol Version 1

2015-12-21 Thread Lyude
On Fri, 2015-12-18 at 21:17 +0100, Michal Suchanek wrote: > On 18 December 2015 at 18:03, Lyude wrote: > > Signed-off-by: Lyude > > > + > > +   > > +Sent when the client has permission to read from the primary > > selection > > +buffer. > > + > > +This event is se

Re: [PATCH] test: add make check

2015-12-21 Thread Emmanuel Gil Peyrot
On Mon, Dec 21, 2015 at 02:48:49PM -0600, Derek Foreman wrote: > We can now test all the protocol files by running make check (or distcheck) > which will pass them through the scanner. > > Signed-off-by: Derek Foreman > --- > .gitignore | 3 +++ > Makefile.am | 6 ++ > test/scan.sh | 5 ++

Re: [libinput] A query regaring key remap functionality

2015-12-21 Thread Peter Hutterer
On Mon, Dec 21, 2015 at 02:43:05AM -0500, Christopher Michael wrote: > Peter, > > First, Thanks for taking the time to provide input (no pun intended) here :) > (all else inlined) > > On 12/21/2015 02:29 AM, Peter Hutterer wrote: > >On Mon, Dec 21, 2015 at 12:27:08AM -0500, Chris Michael wrote: >

[PATCH weston] tests: cleanup test runner script.

2015-12-21 Thread Jon A. Cruz
Cleaned up test runner script to unify sections launching weston. This makes the sections more legible and differences easier to spot. Signed-off-by: Jon A. Cruz --- tests/weston-tests-env | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/tests/weston-tes

[PATCH] tests: cleanup test runner script.

2015-12-21 Thread Jon A. Cruz
Cleaned up test runner script to unify sections launching weston. This makes the sections more legible and differences easier to spot. Signed-off-by: Jon A. Cruz --- tests/weston-tests-env | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/tests/weston-tes

Re: [libinput] A query regaring key remap functionality

2015-12-21 Thread Sung-Jin Park
dh and peter, thank you for your answer. Actually I'm trying understand but frankly to say, I don't get the following comments. And I don't understand why libinput has the left handed facility as a device configuration. Can you give me more comments on my doubts? >keymapping is a lot more complex

Re: [PATCH libinput] tablet: invert tilt axes when left-handed is enabled

2015-12-21 Thread Peter Hutterer
On Mon, Dec 21, 2015 at 10:12:24AM -0800, Bill Spitzak wrote: > I find it hard to believe this is what client programs will want. A > painting program wants the axis of an elongated brush to be perpendicular > to the tilt will work correctly only if *both* axes are flipped (as your > code appears

Re: [PATCH] test: add make check

2015-12-21 Thread Derek Foreman
Oops, this should've been [PATCH wayland-protocols]... On 21/12/15 02:48 PM, Derek Foreman wrote: > We can now test all the protocol files by running make check (or distcheck) > which will pass them through the scanner. > > Signed-off-by: Derek Foreman > --- > .gitignore | 3 +++ > Makefile.a

[PATCH] test: add make check

2015-12-21 Thread Derek Foreman
We can now test all the protocol files by running make check (or distcheck) which will pass them through the scanner. Signed-off-by: Derek Foreman --- .gitignore | 3 +++ Makefile.am | 6 ++ test/scan.sh | 5 + 3 files changed, 14 insertions(+) create mode 100755 test/scan.sh diff -

Re: [RFC v2] Add Primary Selection Protocol Version 1

2015-12-21 Thread Derek Foreman
On 21/12/15 01:27 AM, Pekka Paalanen wrote: > On Fri, 18 Dec 2015 12:03:46 -0500 > Lyude wrote: > >> Signed-off-by: Lyude >> --- >> Changes >> * Add new interfaces to replace reuse of wl_data_(source|offer) >> * Get rid of the selection changed event since we now

Re: How to grab the input event exclusively?

2015-12-21 Thread Derek Foreman
On 21/12/15 09:45 AM, Lance Bai wrote: > Hi Pekka, > > thanks for your reply. > > On Mon, Dec 21, 2015 at 3:02 PM, Pekka Paalanen > wrote: > > On Mon, 21 Dec 2015 14:35:14 + > Lance Bai mailto:lance...@gmail.com>> wrote: > > > Dear All, > > >

Re: How to grab the input event exclusively?

2015-12-21 Thread Lance Bai
Hi Pekka, thanks for your reply. On Mon, Dec 21, 2015 at 3:02 PM, Pekka Paalanen wrote: > On Mon, 21 Dec 2015 14:35:14 + > Lance Bai wrote: > > > Dear All, > > > > I have a question regarding grabbing the key input in weston. > > > > I am running weston-1.8.92 on raspberry pi2(i.e composit

Re: How to grab the input event exclusively?

2015-12-21 Thread Pekka Paalanen
On Mon, 21 Dec 2015 14:35:14 + Lance Bai wrote: > Dear All, > > I have a question regarding grabbing the key input in weston. > > I am running weston-1.8.92 on raspberry pi2(i.e compositor-rpi, launch with > weston-launch), and found that the /dev/input/eventX file descriptor is > read by b

How to grab the input event exclusively?

2015-12-21 Thread Lance Bai
Dear All, I have a question regarding grabbing the key input in weston. I am running weston-1.8.92 on raspberry pi2(i.e compositor-rpi, launch with weston-launch), and found that the /dev/input/eventX file descriptor is read by both weston and tty, which means the input will be showed on the tty

Re: [RFC wayland] Track protocol object versions inside wl_proxy.

2015-12-21 Thread Pekka Paalanen
On Fri, 18 Dec 2015 12:26:53 -0600 Derek Foreman wrote: > Just a quick ping on this because conversation has died down and nobody > actually gave a RB or any suggestions for change. > > Someone flagged the patch as RFC in patchwork so it disappeared and I'm > wondering if people may have thought

Re: [PATCH wayland] client: Use a 0 version to mean indeterminate proxy version

2015-12-21 Thread Pekka Paalanen
On Thu, 26 Nov 2015 15:23:52 -0600 Derek Foreman wrote: > This sets wl_display's version (for proxy version query purposes) > to 0. Any proxy created with unversioned API (this happens when > a client compiled with old headers links against new wayland) > will inherit this 0. > > This gives us

Re: [RFC wayland] Track protocol object versions inside wl_proxy.

2015-12-21 Thread Pekka Paalanen
On Thu, 12 Nov 2015 14:01:33 -0600 Derek Foreman wrote: > From: Jason Ekstrand > > This provides a standardized mechanism for tracking protocol object > versions in client code. The wl_display object is created with version 1. > Every time an object is created from within wl_registry_bind, it

Re: RFC: idle protocol

2015-12-21 Thread Pekka Paalanen
On Tue, 08 Dec 2015 14:12:01 +0100 Martin Graesslin wrote: > Hi Wayland-developers, > > at KDE we developed a protocol for our framework kidletime [1]. The idea is > to > notify Wayland clients when a wl_seat has been idle for a specified time. We > use this for example for power management,