Re: [PATCH wayland 1/2] protocol: Improve data source notification around DnD progress

2015-12-22 Thread Carlos Garnacho
Hey, On Tue, Dec 22, 2015 at 2:55 PM, Jonas Ådahl wrote: > On Tue, Dec 22, 2015 at 01:33:08PM +0100, Carlos Garnacho wrote: >> Hey!, >> >> On Tue, Dec 22, 2015 at 3:26 AM, Jonas Ådahl wrote: >> > On Tue, Dec 22, 2015 at 02:33:32AM +0100, Carlos Garnacho

Re: [PATCH libinput] tablet: add libinput_tablet_tool_is_unique()

2015-12-22 Thread Hans de Goede
Hi, On 12/20/2015 11:34 PM, Peter Hutterer wrote: For checking if a tablet tool can be uniquely identified by libinput. In practice this means checking for a nonzero serial number, but let's not restrict ourselves to allowing just that. Signed-off-by: Peter Hutterer

Re: [IDEA] Support several fullscreen behaviors - potentially rename 'fullscreen'

2015-12-22 Thread Jasper St. Pierre
The first thing I thought about with full-window is how, in fullscreen mode, Firefox puts up a status bar when you put your mouse to the top of the window, assuming there's a screen edge there. You are totally allowed to lie -- and that doesn't really need to be "proposed" at all -- you just have

Re: inserting a "wl_display" object

2015-12-22 Thread Jasper St. Pierre
Yeah. wl_display is the "bootstrap" phase on which everything else rests. In the protocol, it's implicit knowledge that there is always an wl_display object with ID 1. It never gets created or destroyed, you just start using ID 1. On Tue, Dec 22, 2015 at 4:55 AM, Pekka Paalanen

[PATCH wayland-protocols] test: add make check

2015-12-22 Thread Derek Foreman
We can now test all the protocol files by running make check (or distcheck) which will pass them through the scanner. Signed-off-by: Derek Foreman --- Changes from v1: Use #~/bin/sh -e and drop the && from each line in the script Discover the scanner's location and use it

Re: [PATCH libinput 1/9] tablet: dump deltas_discrete, replace with a single wheel_discrete variable

2015-12-22 Thread Hans de Goede
Hi, On 12/21/2015 06:56 AM, Peter Hutterer wrote: Only the wheel has a discrete value, no need to keep arrays for a single value. Signed-off-by: Peter Hutterer Entire series looks good to me and is: Reviewed-by: Hans de Goede Regards, Hans

Re: [PATCH wayland-protocols] test: add make check

2015-12-22 Thread Quentin Glidic
On 22/12/2015 19:19, Derek Foreman wrote: We can now test all the protocol files by running make check (or distcheck) which will pass them through the scanner. Signed-off-by: Derek Foreman --- Changes from v1: Use #~/bin/sh -e and drop the && from each line in the

Re: [PATCH libinput] tablet: invert tilt axes when left-handed is enabled

2015-12-22 Thread Hans de Goede
Hi, On 12/21/2015 02:46 AM, Peter Hutterer wrote: Signed-off-by: Peter Hutterer Looks good to me: Reviewed-by: Hans de Goede Regards, Hans --- src/evdev-tablet.c | 4 test/tablet.c | 38 ++

Re: [PATCH wayland 2/2] protocol: Add DnD actions

2015-12-22 Thread Jonas Ådahl
On Tue, Dec 22, 2015 at 06:56:05PM +0100, Carlos Garnacho wrote: > Hey, > > On Tue, Dec 22, 2015 at 1:36 PM, Jonas Ådahl wrote: > > On Tue, Dec 22, 2015 at 12:20:35PM +0100, Carlos Garnacho wrote: > >> Hey!, > >> > >> On Tue, Dec 22, 2015 at 4:12 AM, Jonas Ådahl

Re: [PATCH wayland 1/2] protocol: Improve data source notification around DnD progress

2015-12-22 Thread Jonas Ådahl
On Tue, Dec 22, 2015 at 04:46:37PM +0100, Carlos Garnacho wrote: > Hey, > > On Tue, Dec 22, 2015 at 2:55 PM, Jonas Ådahl wrote: > > On Tue, Dec 22, 2015 at 01:33:08PM +0100, Carlos Garnacho wrote: > >> Hey!, > >> > >> On Tue, Dec 22, 2015 at 3:26 AM, Jonas Ådahl

Re: [PATCH wayland-protocols] test: add make check

2015-12-22 Thread Derek Foreman
On 22/12/15 01:15 PM, Quentin Glidic wrote: > On 22/12/2015 19:19, Derek Foreman wrote: >> We can now test all the protocol files by running make check (or >> distcheck) >> which will pass them through the scanner. >> >> Signed-off-by: Derek Foreman >> --- >> Changes from

Re: [PATCH wayland 2/2] protocol: Add DnD actions

2015-12-22 Thread Carlos Garnacho
Hey, On Tue, Dec 22, 2015 at 1:36 PM, Jonas Ådahl wrote: > On Tue, Dec 22, 2015 at 12:20:35PM +0100, Carlos Garnacho wrote: >> Hey!, >> >> On Tue, Dec 22, 2015 at 4:12 AM, Jonas Ådahl wrote: >> > On Tue, Dec 22, 2015 at 02:33:33AM +0100, Carlos Garnacho

Re: [PATCH 2/2] compositor: Document routines relating to idle behavior

2015-12-22 Thread Bryce Harrington
On Tue, Dec 22, 2015 at 04:24:18PM +0200, Pekka Paalanen wrote: > Hi Bryce > > On Fri, 11 Dec 2015 13:11:38 -0800 > Bryce Harrington wrote: > > > Signed-off-by: Bryce Harrington > > --- > > src/compositor.c | 46

Re: [PATCH wayland 1/2] protocol: Improve data source notification around DnD progress

2015-12-22 Thread Jonas Ådahl
Hi again, I was reading an E-mail in another thread that brought up different types of backward compatibility promises, and it made me think of a potential issue. I'm commenting inline close to the relevant change this patch introduces. On Tue, Dec 22, 2015 at 02:33:32AM +0100, Carlos Garnacho

[PATCH libinput 1/4] tablet: always set the pressure offset

2015-12-22 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/evdev-tablet.c | 8 src/libinput-private.h | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/evdev-tablet.c b/src/evdev-tablet.c index 7804c91..7f6c860 100644 --- a/src/evdev-tablet.c +++

[PATCH libinput 3/4] tablet: add pressure threshold handling

2015-12-22 Thread Peter Hutterer
On tablets with ABS_PRESSURE use a pressure value to determine tip state, not BTN_TOUCH. This enables us (down the road) to have device-specific pressure thresholds. For now we use a 5% default for all devices. The threshold is a range, if we go past the upper range we initiate the tip down, if

[PATCH libinput 2/4] test: fix a bunch of tablet tests for pressure threshold introduction

2015-12-22 Thread Peter Hutterer
Preparation work for a pressure threshold where we can't just send a BTN_TOUCH and expect it to trigger the tip event. So the event sequence now needs to resemble the right order so the threshold will be triggered. In some cases requires processing an axis event before the tip event. That

[PATCH libinput 4/4] tablet: a tip event can replace an axis event

2015-12-22 Thread Peter Hutterer
When we're only dealing with BTN_TOUCH we can make the tip event independent of the axis event. Now that we handle pressure thresholds to trigger tip state this does not work, we'd have to send an axis event with the new pressure and then a tip event. Since the pressure triggers the tip event this

Re: [PATCH 2/3] Introduce WAYLAND_SERVER_SOCKET to change the path where the server will create the socket. It will be possible for a nested compositor to offer a socket located on WAYLAND_SERVER_SOCK

2015-12-22 Thread Pekka Paalanen
On Tue, 3 Mar 2015 13:49:54 +0100 Davide Bettio wrote: > Signed-off-by: Davide Bettio > --- > src/wayland-server.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/src/wayland-server.c

Re: [PATCH wayland 2/2] protocol: Add DnD actions

2015-12-22 Thread Carlos Garnacho
Hey!, On Tue, Dec 22, 2015 at 4:12 AM, Jonas Ådahl wrote: > On Tue, Dec 22, 2015 at 02:33:33AM +0100, Carlos Garnacho wrote: >> These 2 requests have been added: >> >> - wl_data_source.set_actions: Notifies the compositor of the available >> actions on the data source. >> -

Re: [PATCH wayland 2/2] protocol: Add DnD actions

2015-12-22 Thread Jonas Ådahl
On Tue, Dec 22, 2015 at 12:20:35PM +0100, Carlos Garnacho wrote: > Hey!, > > On Tue, Dec 22, 2015 at 4:12 AM, Jonas Ådahl wrote: > > On Tue, Dec 22, 2015 at 02:33:33AM +0100, Carlos Garnacho wrote: > >> These 2 requests have been added: > >> > >> - wl_data_source.set_actions:

[IDEA] Support several fullscreen behaviors - potentially rename 'fullscreen'

2015-12-22 Thread Coroutines
# Summary Wayland compositors like weston have the freedom to display 'fullscreen'-selected content in 3 ways (that I can think of): - full-window - fullscreen - multi-display fullscreen # The Problem Something that I've always wanted to have control over is how an application is shown in in

Re: [PATCH wayland 1/2] protocol: Improve data source notification around DnD progress

2015-12-22 Thread Carlos Garnacho
Hey!, On Tue, Dec 22, 2015 at 3:26 AM, Jonas Ådahl wrote: > On Tue, Dec 22, 2015 at 02:33:32AM +0100, Carlos Garnacho wrote: >> Currently, there's no means for the DnD origin to know whether the >> destination is actually finished with the DnD transaction, short of >>

Re: inserting a "wl_display" object

2015-12-22 Thread Pekka Paalanen
On Tue, 22 Dec 2015 14:34:08 +0200 m...@beroal.in.ua wrote: > Hello, I'm new to Wayland. I need a "wl_display" object in order to > insert "wl_registry" and start working. I see no means of inserting it. > (I want to know how to do that in the Wayland protocol, not in the C > binding to it.)

inserting a "wl_display" object

2015-12-22 Thread me
Hello, I'm new to Wayland. I need a "wl_display" object in order to insert "wl_registry" and start working. I see no means of inserting it. (I want to know how to do that in the Wayland protocol, not in the C binding to it.) ___ wayland-devel mailing

Re: [PATCH wayland 1/2] protocol: Improve data source notification around DnD progress

2015-12-22 Thread Jonas Ådahl
On Tue, Dec 22, 2015 at 01:33:08PM +0100, Carlos Garnacho wrote: > Hey!, > > On Tue, Dec 22, 2015 at 3:26 AM, Jonas Ådahl wrote: > > On Tue, Dec 22, 2015 at 02:33:32AM +0100, Carlos Garnacho wrote: > >> Currently, there's no means for the DnD origin to know whether the > >>

Re: [PATCH 2/2] compositor: Document routines relating to idle behavior

2015-12-22 Thread Pekka Paalanen
Hi Bryce On Fri, 11 Dec 2015 13:11:38 -0800 Bryce Harrington wrote: > Signed-off-by: Bryce Harrington > --- > src/compositor.c | 46 ++ > 1 file changed, 46 insertions(+) > > diff --git

Re: [PATCH weston 2/5] data-device: Implement DnD actions

2015-12-22 Thread Carlos Garnacho
Hey!, On Tue, Dec 22, 2015 at 5:25 AM, Jonas Ådahl wrote: > On Tue, Dec 22, 2015 at 02:33:28AM +0100, Carlos Garnacho wrote: >> The policy in weston in order to determine the chosen DnD action is >> deliberately simple, and is probably the minimals that any compositor >> should

Re: [PATCH 1/2] compositor: Fix a couple comment typos

2015-12-22 Thread Pekka Paalanen
On Fri, 11 Dec 2015 13:11:37 -0800 Bryce Harrington wrote: > Signed-off-by: Bryce Harrington > --- > src/compositor-fbdev.c | 2 +- > src/compositor.h | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git