libinput: Disable tap-and-drag

2016-01-01 Thread Caibin Chen
Hi, I've been working on disabling tap-and-drag feature in libinput because I'm not used to it. The code is on my Github branch: https://github.com/tigersoldier/libinput/tree/wip/disable-tap-to-drag The basic idea is adding a branch at STATE_TOUCHED + EVENT_RELEASE transition: STATE_TOUCHED

Re: [PATCH wayland v2 5/8] client: Fully flush during blocking dispatch

2016-01-01 Thread Daniel Stone
Hi, On 29 December 2015 at 14:24, Jonas Ådahl wrote: > On Tue, Dec 29, 2015 at 11:07:55AM +, Daniel Stone wrote: >> On 29 December 2015 at 02:10, Jonas Ådahl wrote: >> > @@ -1485,27 +1500,28 @@ WL_EXPORT int >> > wl_display_dispatch_queue(struct wl_display *display, >> >

Re: [PATCH wayland-protocols v2 2/2] Introduce pointer locking and confinement protocol

2016-01-01 Thread Daniel Stone
Hi, A couple of (belated) comments ... On 3 December 2015 at 07:28, Jonas Ådahl wrote: > + > + > + The lock_pointer request lets the client request to disable movements > of > + the virtual pointer (i.e. the cursor), effectively locking the pointer > + to a position.

Re: [PATCH wayland-protocols 1/2] Introduce wp_relative_pointer interface

2016-01-01 Thread Daniel Stone
Hi Jonas, On 17 November 2015 at 10:09, Jonas Ådahl wrote: > + > + > + [...] > + > + Relative motions are not coupled to wl_pointer.motion events, and can > be > + sent in combination with such events, but also independently. There > may > + also be scenarious

Re: [PATCH wayland v2 4/8] client: Use read preparation API in wl_display_dispatch_queue()

2016-01-01 Thread Bill Spitzak
I was going to propose the same thing, though I was uncertain if it really was equivalent. IMHO this looks correct as it is almost identical to my patch (mine lacked the changes for EPIPE and had a nested if so there was only one call to dispatch_queue). It would also help to fix the documenta

Re: [PATCH wayland v2 4/8] client: Use read preparation API in wl_display_dispatch_queue()

2016-01-01 Thread Bill Spitzak
On 12/28/2015 06:10 PM, Jonas Ådahl wrote: + ret = wl_display_flush(display); if (ret < 0 && errno != EAGAIN && errno != EPIPE) { With your patch 5/8 EAGAIN will never happen, so you might want to remove it here. ___ wayland-devel ma