Re: [PATCH wayland 3/3] tests: Test proxy versions

2016-01-14 Thread Pekka Paalanen
On Thu, 14 Jan 2016 16:13:53 -0600 Derek Foreman wrote: > On 14/01/16 02:34 AM, Pekka Paalanen wrote: > > Oh wait! > > > > One more thing... > > > > On Thu, 14 Jan 2016 10:28:32 +0200 > > Pekka Paalanen wrote: > > > >> On Tue, 12 Jan 2016 16:28:47 -0600 > >> Derek Foreman wrote: > >> > >

Re: [PATCH weston v7 2/5] data-device: Implement DnD actions

2016-01-14 Thread Jonas Ådahl
Hey, Found a couple of more issues. Comments inline. On Thu, Jan 14, 2016 at 11:46:34PM +0100, Carlos Garnacho wrote: > The policy in weston in order to determine the chosen DnD action is > deliberately simple, and is probably the minimals that any compositor > should be doing here. > > Besides

Re: [PATCH weston 4/5] data-device: Implement compositor-chosen actions

2016-01-14 Thread Jonas Ådahl
This patch doesn't seem to apply any more. Could you resend a rebased version? Jonas On Thu, Dec 24, 2015 at 02:00:40AM +0100, Carlos Garnacho wrote: > Set up a keyboard grab during drag-and-drop, so we can translate > modifiers into preferred actions. The compositor chosen action > is stored in

Re: [PATCH weston v7 2/5] data-device: Implement DnD actions

2016-01-14 Thread Jonas Ådahl
On Thu, Jan 14, 2016 at 11:46:34PM +0100, Carlos Garnacho wrote: > The policy in weston in order to determine the chosen DnD action is > deliberately simple, and is probably the minimals that any compositor > should be doing here. > > Besides honoring the set_actions requests on both wl_data_sourc

Re: [PATCH wayland-protocols v3] Introduce pointer locking and confinement protocol

2016-01-14 Thread Jonas Ådahl
On Thu, Jan 14, 2016 at 04:25:00PM +, Daniel Stone wrote: > Hi, > > On 13 January 2016 at 02:14, Jonas Ådahl wrote: > > This patch introduces a new protocol for locking and confining a > > pointer. It consists of a new global object with two requests; one for > > locking the surface to a posi

Re: [PATCH weston v6 1/5] data-device: Implement DnD progress notification

2016-01-14 Thread Jonas Ådahl
On Thu, Jan 14, 2016 at 11:43:39PM +0100, Carlos Garnacho wrote: > Weston now sends wl_data_source.dnd_drop_performed and .dnd_finished in > order to notify about the different phases of DnD. > > wl_data_source.cancelled is also used as mentioned in the docs, being > emitted also on DnD when the o

[PATCH] server: Add an API to get the socket fd for a client

2016-01-14 Thread Sung-Jin Park
Dear guys and pq, I updated the new version of patch with version 4 and modified its title to the following. Sorry for my mistake. :D "[PATCH v4] server: Add an API to get the file descriptor for a client" ( http://patchwork.freedesktop.org/patch/70475/) Would you plz review it again whether it i

Re: [PATCH wayland v2] client: Fully flush during blocking dispatch

2016-01-14 Thread Jonas Ådahl
On Fri, Jan 15, 2016 at 12:12:09AM +, Auke Booij wrote: > On 12 January 2016 at 04:31, Jonas Ådahl wrote: > > wl_display_flush() may fail with EAGAIN which means that not all data > > waiting in the buffer has been flushed. We later block until there > > + is Fixed locally. > > > data to r

Re: [PATCH wayland v2] client: Fully flush during blocking dispatch

2016-01-14 Thread Jonas Ådahl
On Thu, Jan 14, 2016 at 04:59:48PM -0600, Derek Foreman wrote: > On 11/01/16 10:31 PM, Jonas Ådahl wrote: > > wl_display_flush() may fail with EAGAIN which means that not all data > > waiting in the buffer has been flushed. We later block until there > > data to read, which could mean that we block

[PATCH libinput 2/7] tools: share the axis and tip code where appropriate

2016-01-14 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- tools/event-gui.c | 29 + 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/tools/event-gui.c b/tools/event-gui.c index 636c28b..fa0e1a0 100644 --- a/tools/event-gui.c +++ b/tools/event-gui.c @@ -602,6 +602,9 @@ handle_ev

[PATCH libinput 7/7] tools: add support for tablet relative events to the event-gui

2016-01-14 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- tools/event-gui.c | 77 +++ 1 file changed, 77 insertions(+) diff --git a/tools/event-gui.c b/tools/event-gui.c index fa0e1a0..ce1430f 100644 --- a/tools/event-gui.c +++ b/tools/event-gui.c @@ -51,6 +51,10 @@ s

[PATCH libinput 4/7] tablet: drop delta array, provided by the tablet_axis struct now

2016-01-14 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/evdev-tablet.c | 7 +++ src/evdev-tablet.h | 1 - src/libinput.c | 2 -- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/src/evdev-tablet.c b/src/evdev-tablet.c index 29c86ad..1870e7e 100644 --- a/src/evdev-tablet.c +++ b/src/evdev-tabl

[PATCH libinput 1/7] tools: get pressure/distance/tilt from a tip event too

2016-01-14 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- tools/event-gui.c | 4 1 file changed, 4 insertions(+) diff --git a/tools/event-gui.c b/tools/event-gui.c index a2691d9..636c28b 100644 --- a/tools/event-gui.c +++ b/tools/event-gui.c @@ -632,6 +632,10 @@ handle_event_tablet(struct libinput_event *ev, struc

[PATCH libinput 0/7] tablet: add support for relative x/y motion deltas

2016-01-14 Thread Peter Hutterer
This patchset adds support for relative motion to the tablet branch. AFAICT, this is the last large feature that was still missing. The approach is notably different to the current X driver. There we toggle a property in the driver to switch the tablet into relative mode and then only send out rel

[PATCH libinput 5/7] tablet: add support for relative x/y motion deltas

2016-01-14 Thread Peter Hutterer
Instead of an explicit tablet mode that device must be changed into, let the caller decide which coordinates are preferred. The tablet mode may be application-specific and usually depends on the tool as well. This patch adds an interface to get a motion delta for the x/y axes in pixel-like coordin

[PATCH libinput 3/7] tablet: use a struct rather than a double array for axis values

2016-01-14 Thread Peter Hutterer
Makes the code less generic, but more expressive. No visible functional changes. Signed-off-by: Peter Hutterer --- src/evdev-tablet.c | 172 +++-- src/evdev-tablet.h | 2 +- src/libinput-private.h | 20 -- src/libinput.c | 159 ++

[PATCH libinput 6/7] tablet: hook up relative motion events

2016-01-14 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- doc/pointer-acceleration.dox | 6 + src/evdev-tablet.c | 132 ++-- src/evdev-tablet.h | 4 + src/evdev.c | 13 ++ src/evdev.h | 4 + src/filter.c | 94 ++ sr

Re: [PATCH wayland v2] client: Fully flush during blocking dispatch

2016-01-14 Thread Auke Booij
On 12 January 2016 at 04:31, Jonas Ådahl wrote: > wl_display_flush() may fail with EAGAIN which means that not all data > waiting in the buffer has been flushed. We later block until there + is > data to read, which could mean that we block on input from the > compositor without having sent out

Re: [PATCH wayland v2] client: Fully flush during blocking dispatch

2016-01-14 Thread Derek Foreman
On 11/01/16 10:31 PM, Jonas Ådahl wrote: > wl_display_flush() may fail with EAGAIN which means that not all data > waiting in the buffer has been flushed. We later block until there > data to read, which could mean that we block on input from the > compositor without having sent out all data from t

[PATCH weston v7 2/5] data-device: Implement DnD actions

2016-01-14 Thread Carlos Garnacho
The policy in weston in order to determine the chosen DnD action is deliberately simple, and is probably the minimals that any compositor should be doing here. Besides honoring the set_actions requests on both wl_data_source and wl_data_offer, weston now will emit the newly added "action" events n

[PATCH weston v6 1/5] data-device: Implement DnD progress notification

2016-01-14 Thread Carlos Garnacho
Weston now sends wl_data_source.dnd_drop_performed and .dnd_finished in order to notify about the different phases of DnD. wl_data_source.cancelled is also used as mentioned in the docs, being emitted also on DnD when the operation is meant to fail (eg. source and dest didn't agree on a mimetype).

[PATCH v2 wayland] tests: Test proxy versions

2016-01-14 Thread Derek Foreman
Add a test that confirms that proxy versions are always 0 for display and correct otherwise. Signed-off-by: Derek Foreman --- Changes from v1: Make the global once at a high version, bind it with different versions create a wl_pointer from the wl_seat to test version inheritance also test the g

Re: [PATCH wayland 3/3] tests: Test proxy versions

2016-01-14 Thread Derek Foreman
On 14/01/16 02:34 AM, Pekka Paalanen wrote: > Oh wait! > > One more thing... > > On Thu, 14 Jan 2016 10:28:32 +0200 > Pekka Paalanen wrote: > >> On Tue, 12 Jan 2016 16:28:47 -0600 >> Derek Foreman wrote: >> >>> Add a test that confirms that proxy versions are always 0 for display >>> and corre

[PATCH wayland-protocols] ignore: ignore config.sub and config.guess

2016-01-14 Thread Derek Foreman
Signed-off-by: Derek Foreman --- I think this is my fault and I didn't notice the extra files after my make check changes... sorry about that. :/ .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index ca19ecf..794539b 100644 --- a/.gitignore +++ b/.gitig

Re: [PATCH wayland-protocols 0/3] xdg_surface base interface and xdg_tooltip

2016-01-14 Thread Bill Spitzak
Okay it makes sense. I think the term "toplevel" is rather confusing, since the word "level" is often used when talking about window stacking. Perhaps "normal" or "default"? Other thing is that the argument called "parent" to the set-role methods has got to be renamed. Perhaps to "surface"? I'm

[PATCH wayland] server: validate resource versions at creation time

2016-01-14 Thread Derek Foreman
We shouldn't ever create a resource with version less than 1 or greater than the interface version. Signed-off-by: Derek Foreman --- I'm a little nervous about this one. Anything doing this probably gets what it deserves, but it does break wayland's own resource-test... I guess a compromise is

Re: [PATCH wayland] resource-test: Use wl_seat instead of wl_display for testing

2016-01-14 Thread Daniel Stone
On 14 January 2016 at 20:32, Derek Foreman wrote: > We're creating resources with versions up to 4. wl_display isn't version 4, > so this is technically verifying that we can do something we shouldn't. > > wl_seat already has versions this high, so switch to that. > > Signed-off-by: Derek Foreman

[PATCH wayland] resource-test: Use wl_seat instead of wl_display for testing

2016-01-14 Thread Derek Foreman
We're creating resources with versions up to 4. wl_display isn't version 4, so this is technically verifying that we can do something we shouldn't. wl_seat already has versions this high, so switch to that. Signed-off-by: Derek Foreman --- tests/resources-test.c | 10 +- 1 file changed

Re: [PATCH] clients: fix build on Linux

2016-01-14 Thread Derek Foreman
On 14/01/16 09:44 AM, Olivier Fourdan wrote: > stropts.h is not available on Linux. Well, this is all fascinating. :) I'm going to land the first simpler patch that just removes #include (with my Reviewed-by) linux/videodev2.h includes linux/ioctl.h right away, so I think we're all good. Than

Re: [PATCH wayland] server: Fail to bind object when requested version is 0

2016-01-14 Thread Daniel Stone
On 14 January 2016 at 19:33, Derek Foreman wrote: > 0 is not a valid version number for registry bind requests, so > let's check for it in registry_bind. > > Signed-off-by: Derek Foreman Reviewed-by: Daniel Stone ___ wayland-devel mailing list wayland

[PATCH wayland] server: Fail to bind object when requested version is 0

2016-01-14 Thread Derek Foreman
0 is not a valid version number for registry bind requests, so let's check for it in registry_bind. Signed-off-by: Derek Foreman --- src/wayland-server.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/wayland-server.c b/src/wayland-server.c index 3a7d79d..14e2cf4 100644 --- a/src/w

Re: [PATCH wayland 2/2] server: Test for illegally low interface versions in wl_global_create()

2016-01-14 Thread Daniel Stone
On 14 January 2016 at 17:02, Derek Foreman wrote: > Any version lower than 1 is unreasonable. > > Signed-off-by: Derek Foreman Reviewed-by: Daniel Stone ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/ma

Re: [PATCH wayland 1/2] server: improve failure log message for wl_global_create()

2016-01-14 Thread Daniel Stone
Hi, On 14 January 2016 at 17:02, Derek Foreman wrote: > The gratuitous %m jammed onto the end of the string prints errno > concatenated with the word "version". > > I've removed the %m, and printed some additional information about the > failure. > > Also, reversed the order of the expressions in

[PATCH wayland 1/2] server: improve failure log message for wl_global_create()

2016-01-14 Thread Derek Foreman
The gratuitous %m jammed onto the end of the string prints errno concatenated with the word "version". I've removed the %m, and printed some additional information about the failure. Also, reversed the order of the expressions in the conditional to make it match the english in the log message. S

[PATCH wayland 2/2] server: Test for illegally low interface versions in wl_global_create()

2016-01-14 Thread Derek Foreman
Any version lower than 1 is unreasonable. Signed-off-by: Derek Foreman --- src/wayland-server.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/wayland-server.c b/src/wayland-server.c index c129b7d..3a7d79d 100644 --- a/src/wayland-server.c +++ b/src/wayland-server.c @@ -908,6 +90

Re: [PATCH wayland-protocols v3] Introduce pointer locking and confinement protocol

2016-01-14 Thread Daniel Stone
Hi, On 13 January 2016 at 02:14, Jonas Ådahl wrote: > This patch introduces a new protocol for locking and confining a > pointer. It consists of a new global object with two requests; one for > locking the surface to a position, one for confining the pointer to a > given region. > > Signed-off-by

Re: wayalnd client wants to know the keyboard layout

2016-01-14 Thread Daniel Stone
Hi, On 14 January 2016 at 14:54, Hardening wrote: > I have worked on having the FreeRDP client have a decent wayland > support. On the graphical part everything is quite straight forward > anyway, I'm hitting some troubles with keyboard support (someone could > say as usual when you code somethin

[PATCH] clients: fix build on Linux

2016-01-14 Thread Olivier Fourdan
stropts.h is not available on Linux. Check for this header in the configure script and include it only if available to avoid a build failure on systems which do not have stropts.h. Signed-off-by: Olivier Fourdan --- clients/simple-dmabuf-v4l.c | 2 ++ configure.ac| 1 + 2 files

Re: [PATCH] clients: fix build on Linux

2016-01-14 Thread Olivier Fourdan
Hi Emmanuel, > POSIX.1-2008 (and likely prior versions), and thus Linux as well, > define ioctl() in this header, so it seems strange it doesn’t exist on > your system. I based my patch on a couple of information I found here: https://bugzilla.redhat.com/show_bug.cgi?id=439403 https://bugzilla.r

Re: [PATCH] clients: fix build on Linux

2016-01-14 Thread Emmanuel Gil Peyrot
On Thu, Jan 14, 2016 at 02:46:14PM +0100, Olivier Fourdan wrote: > Cannot find out why stropts.h is needed and Linux doesn't support > streams anyway, so there is no stropts.h. POSIX.1-2008 (and likely prior versions), and thus Linux as well, define ioctl() in this header, so it seems strange it d

wayalnd client wants to know the keyboard layout

2016-01-14 Thread Hardening
Hello, I have worked on having the FreeRDP client have a decent wayland support. On the graphical part everything is quite straight forward anyway, I'm hitting some troubles with keyboard support (someone could say as usual when you code something around keyboard). In X11, xfreerdp queries X abou

[PATCH] clients: fix build on Linux

2016-01-14 Thread Olivier Fourdan
Cannot find out why stropts.h is needed and Linux doesn't support streams anyway, so there is no stropts.h. Signed-off-by: Olivier Fourdan --- clients/simple-dmabuf-v4l.c | 1 - 1 file changed, 1 deletion(-) diff --git a/clients/simple-dmabuf-v4l.c b/clients/simple-dmabuf-v4l.c index 2334e09..2

Re: [PATCH wayland 2/2] protocol: Add DnD actions

2016-01-14 Thread Jonas Ådahl
On Thu, Jan 14, 2016 at 11:50:29AM +0100, Michal Suchanek wrote: > On 14 January 2016 at 01:54, Carlos Garnacho wrote: > > Hi Michal, > > > > On Mon, Jan 11, 2016 at 11:34 AM, Michal Suchanek > > wrote: > >> On 24 December 2015 at 01:58, Carlos Garnacho wrote: > >> > >>> @@ -757,6 +883,40 @@ >

Re: [PATCH wayland 2/2] protocol: Add DnD actions

2016-01-14 Thread Michal Suchanek
On 14 January 2016 at 01:54, Carlos Garnacho wrote: > Hi Michal, > > On Mon, Jan 11, 2016 at 11:34 AM, Michal Suchanek wrote: >> On 24 December 2015 at 01:58, Carlos Garnacho wrote: >> >>> @@ -757,6 +883,40 @@ >>> >>> >>> >>> + >>> + >>> + >>> + >>> + >>> +

Re: [PATCH wayland 3/3] tests: Test proxy versions

2016-01-14 Thread Pekka Paalanen
Oh wait! One more thing... On Thu, 14 Jan 2016 10:28:32 +0200 Pekka Paalanen wrote: > On Tue, 12 Jan 2016 16:28:47 -0600 > Derek Foreman wrote: > > > Add a test that confirms that proxy versions are always 0 for display > > and correct otherwise. > > > > Signed-off-by: Derek Foreman > > ---

Re: [PATCH v7 wayland] protocol: add wl_pointer.frame, axis_source, axis_stop, and axis_discrete

2016-01-14 Thread Jonas Ådahl
On Fri, Jan 08, 2016 at 02:43:10PM +1000, Peter Hutterer wrote: > ping - can we merge this now? Just pushed the protocol patch: 2b236af..c5356e9 master -> master If no one objects, I intend to push the weston implementation patches as well within a couple of days. FWIW, the weston APIs are n

Re: [PATCH wayland 3/3] tests: Test proxy versions

2016-01-14 Thread Pekka Paalanen
On Tue, 12 Jan 2016 16:28:47 -0600 Derek Foreman wrote: > Add a test that confirms that proxy versions are always 0 for display > and correct otherwise. > > Signed-off-by: Derek Foreman > --- > tests/display-test.c | 41 + > 1 file changed, 41 insertions