Re: Moving bugs to Phabricator

The current major issue with Phabricator for me currently is that it doesn't support patch-based code review, unless this has changed in the meantime: http://stackoverflow.com/questions/20756320/how-to-prevent-phabricator-from-eating-my-commit-history ( The linked article has since moved to https

[PATCH v2 weston 09/13] tablet: Add support for moving windows around using the stylus

From: Stephen Chandler Paul Changing the pointer to the appropriate image while moving the stylus around isn't supported yet. Co-authored-by: Peter Hutterer Signed-off-by: Stephen Chandler Paul Signed-off-by: Peter Hutterer --- clients/window.c | 33 +++ desktop-shell/shell.c | 267

[PATCH v2 weston 08/13] client: Add support for tablet cursor motion to window frames in libtoytoolkit

From: Stephen Chandler Paul When it comes to a window frame, a tablet tool and cursor act almost identical; they click things, drag things, etc. The tool type and extra axes don't serve any use in the context of a window frame, so tablet pointers share the frame_pointer structures used for the mo

[PATCH v2 weston 13/13] tablet: Remove tablet-specific tools on disconnect

From: Stephen Chandler Paul Store all tablets that a tool was used on in a list. When the tablet is removed, remove all tools only seen on this tablet. Tools without a serial number are only ever bound to one tablet. Co-authored-by: Peter Hutterer Signed-off-by: Stephen Chandler Paul Signed-o

[PATCH v2 weston 03/13] tablet: add weston grab interfaces for tablet tools

From: Stephen Chandler Paul Co-authored-by: Peter Hutterer Signed-off-by: Stephen Chandler Paul Signed-off-by: Peter Hutterer --- src/compositor.h | 53 src/input.c | 253 +++ 2 files changed, 306 insertions(+) diff --git

[PATCH v2 weston 10/13] tablet: Add tablet support to the top panel of the desktop shell

From: Stephen Chandler Paul Co-authored-by: Peter Hutterer Signed-off-by: Stephen Chandler Paul Signed-off-by: Peter Hutterer --- clients/desktop-shell.c | 56 + 1 file changed, 56 insertions(+) diff --git a/clients/desktop-shell.c b/clients/de

[PATCH v2 weston 02/13] tablet: add handling of tablet focus

From: Stephen Chandler Paul Closely modelled after the pointer focus handling Co-authored-by: Peter Hutterer Signed-off-by: Stephen Chandler Paul Signed-off-by: Peter Hutterer --- src/compositor.h | 10 ++ src/input.c | 92 2

[PATCH v2 weston 11/13] tablet: Add binding to activate surfaces using the tablet tool

From: Stephen Chandler Paul Co-authored-by: Peter Hutterer Signed-off-by: Stephen Chandler Paul Signed-off-by: Peter Hutterer --- desktop-shell/shell.c | 14 ++ src/bindings.c| 39 ++- src/compositor.c | 1 + src/compositor.h

[PATCH v2 weston 12/13] tablet: Add demo application for tablets

From: Stephen Chandler Paul Note that this application does not follow best practices for handling tablet events. The events are grouped by frame, all processing should be done in the frame instead of the respective handler. A good toolkit would accumulate the data in the events and provide them

[PATCH v2 weston 06/13] clients: add support for handling tablets

From: Stephen Chandler Paul Co-authored-by: Peter Hutterer Signed-off-by: Stephen Chandler Paul Signed-off-by: Peter Hutterer --- clients/window.c | 498 +++ clients/window.h | 88 ++ 2 files changed, 586 insertions(+) diff --git a

[PATCH v2 weston 05/13] tablet: handle tablet cursors in the compositor

From: Stephen Chandler Paul The tablet is given a separate cursor. Most tablet interaction is an absolute interaction and shouldn't need a cursor at all, but usually the cursor is used to indicate the type of virtual tool currently assigned. Co-authored-by: Peter Hutterer Signed-off-by: Stephen

[PATCH v2 weston 04/13] tablet: hook up libinput tablet events

From: Stephen Chandler Paul Co-authored-by: Peter Hutterer Signed-off-by: Stephen Chandler Paul Signed-off-by: Peter Hutterer --- src/libinput-device.c | 120 ++ 1 file changed, 120 insertions(+) diff --git a/src/libinput-device.c b/src/libinpu

[PATCH v2 weston 00/13] Add tablet support

Next version of the tablet support patches for weston. This set has been updated for the libinput API that had a few changes since November and for the protocol changes. The segfaults on unplug are now fixed, caused by a erroneous cleanup code that ended up trying to clean up twice. It has the n

[PATCH v2 weston 01/13] tablet: Add initial tablet support to weston

From: Stephen Chandler Paul Introduces two new structs, weston_tablet and weston_tablet_tool with the respective information as it's used on the protocol. Note that tools are independent of tablets, many tools can be used across multiple tablets. The nesting on the protocol level requires a glo

[PATCH v2 weston 07/13] client: Add tablet cursor support into libtoytoolkit

From: Stephen Chandler Paul Again, a lot of this is code that has been reused from the cursor code for pointers. Co-authored-by: Peter Hutterer Signed-off-by: Stephen Chandler Paul Signed-off-by: Peter Hutterer --- clients/window.c | 138 ++

Re: [PATCH weston 00/13] Add tablet support

On Fri, Nov 06, 2015 at 03:13:46PM -0800, Jason Gerecke wrote: > On Thu, Nov 5, 2015 at 8:31 PM, Peter Hutterer > wrote: > > > > This set adds support for graphics tablets to weston. It's not fully > > complete, there are a couple of fixmes in it but the patchset is getting a > > bit unwieldly. A

RE: Recursive dispatch (Re: [PATCH v2] server: Calculate remaining data size after a closure is processed)

> -Original Message- > From: Derek Foreman [mailto:der...@osg.samsung.com] > Sent: Wednesday, February 03, 2016 6:56 AM > To: Pekka Paalanen; Jaeyoon Jung > Cc: 'Jonas Ådahl'; wayland-devel@lists.freedesktop.org > Subject: Re: Recursive dispatch (Re: [PATCH v2] server: Calculate remaining >

[ANNOUNCE] weston 1.9.92

This is the beta for the 1.10 release. This includes a handful of bug fixes beyond the 1.9.91 alpha: Structures used for Xwayland clipboard sources are initialized properly. Touchscreens that send coordinates outside the nominal maximum X/Y coordinates no longer cause a crash. Clients that don't

[ANNOUNCE] wayland 1.9.92

Here's the beta for the upcoming 1.10 release. Changes since the alpha include a few bug fixes, a documentation clarification about wl_data_device_manager per-version requirements, and making DTD error messages slightly more informative. As mentioned in the alpha release note, the upcoming 1.10

[PATCH v4 wayland-protocols] Add the tablet protocol

Signed-off-by: Peter Hutterer --- Changes to v3: - various comment typos fixed as pointed out by Jason - reword initial section talking about extra axes - change tilt to use degrees instead of normalized values Makefile.am| 1 + unstable/tablet/README

Re: [PATCH v3 wayland-protocols] Add the tablet protocol

On Fri, Jan 29, 2016 at 11:40:44AM -0800, Jason Gerecke wrote: > On Thu, Jan 28, 2016 at 8:32 PM, Peter Hutterer > wrote: > > Signed-off-by: Peter Hutterer > > --- > > Changes to v2: > > - renamed hwserial to hardware_serial > > - renamed to hwid event to a hardware_id_wacom. no-one else uses thi

[PATCH] egl: move Null check to eglGetSyncAttribKHR to prevent Segfault

Null-check on "*value" is currently done in _eglGetSyncAttrib, which is after eglGetSyncAttribKHR attempts to copy data at 'value' to 'attrib'. Segfault is enevitable if value==NULL in this case. Therefore, null-check should be moved to beginning of eglGetSyncAttribKHR to avoid any possible segfaul

[PATCH libinput] tablet: change tilt axes to use degrees

The Wacom tilt range is 64 degrees so we map everything into that until we know otherwise. This commit also switches the tilt axes around to align the angles with the x/y orientation, i.e. tilting the top of the stylus towards the positive x axis now generates a positive x tilt. Signed-off-by: Pe

Re: [PATCH v3 wayland-protocols] Add the tablet protocol

On Tue, Feb 2, 2016 at 1:12 PM, Bill Spitzak wrote: > > > On Mon, Feb 1, 2016 at 6:38 PM, Jason Gerecke wrote: >> >> >> Ultimately, the tilt information is almost universally used by >> applications to set brush orientation. To do that, you have to use >> some trig to transform the X and Y tilt v

Re: Recursive dispatch (Re: [PATCH v2] server: Calculate remaining data size after a closure is processed)

On 02/02/16 06:57 AM, Pekka Paalanen wrote: > On Tue, 12 Jan 2016 13:03:19 +0900 "Jaeyoon Jung" > wrote: > >>> -Original Message- From: wayland-devel >>> [mailto:wayland-devel-boun...@lists.freedesktop.org] On Behalf >>> Of Jonas Adahl Sent: Tuesday, January 12, 2016 12:27 PM To: >>> Jaey

Re: [PATCH wayland] scanner: Fix oddities in copyright printing

On 02/02/2016 12:56 PM, Derek Foreman wrote: Some copyright strings could result in broken generated header files with unmatched */ This change: Runs the loop long enough so the copyright[i] == 0 test can actually happen. (if there was no \n no copyright text was printed, */ still was) Prints t

Re: Moving bugs to Phabricator

Can you make a clone of the current Bugzilla state in Phabricator so that we can see what it looks like? On Tue, Feb 2, 2016 at 7:43 AM, Daniel Stone wrote: > Hi, > As previously discussed with a few people (when it was much more in > its infancy than now), I'd like to move our bug tracking fro

Re: [PATCH v3 wayland-protocols] Add the tablet protocol

On Mon, Feb 1, 2016 at 6:38 PM, Jason Gerecke wrote: > > Ultimately, the tilt information is almost universally used by > applications to set brush orientation. To do that, you have to use > some trig to transform the X and Y tilt values into something like > Alt-Az form. Tilt on a scale of 0-1 i

[PATCH wayland] scanner: Fix oddities in copyright printing

Some copyright strings could result in broken generated header files with unmatched */ This change: Runs the loop long enough so the copyright[i] == 0 test can actually happen. (if there was no \n no copyright text was printed, */ still was) Prints the opening /* even if there was whitespace at t

Moving bugs to Phabricator

Hi, As previously discussed with a few people (when it was much more in its infancy than now), I'd like to move our bug tracking from Bugzilla to Phabricator. There's a few reasons behind this. Phabricator is actually a pretty decent suite of utilities, including repository browsing and code revie

Re: [PATCH weston] hmi-controller: remove duplicate commit_changes in random mode

Hi, I don't think this patch is ready to be merged, more below. TL;DR: It would probably be best to just ignore which ivilayer an ivisurface is currently on, and always just remove and add. That would be the simplest solution, if the ivilayout API just allows it. Specifically, do not clear the l

Re: [PATCH v3 wayland-protocols] text: Create second version of text input protocol

Hi Silvan, On 02/02/16 13:23, Silvan Jegen wrote: > Hi > > Please find some comments and spelling corrections below. > > >> There were some shortcomings in the first version of the protocol which >> makes it not really useful in real world applications. It is not really >> possible to fix them

[PATCH v4 wayland-protocols] text: Create second version of text input protocol

There were some shortcomings in the first version of the protocol which makes it not really useful in real world applications. It is not really possible to fix them in a compatible way so introduce a new v2 of the protocol. Fixes some shortcomings of the first version: * Use only one wp_text_inpu

Re: [PATCH wayland-protocols] text: Create second version of text input protocol

On 29/01/16 21:43, Bill Spitzak wrote: > > > On Wed, Jan 27, 2016 at 11:52 PM, Jan Arne Petersen > wrote: > > > + > + > + Notify when a new composing text (pre-edit) should be set > around the > + current cursor position. An

Re: [PATCH wayland-protocols] text: Create second version of text input protocol

On 29/01/16 00:33, Bill Spitzak wrote: > > > On Wed, Jan 27, 2016 at 11:52 PM, Jan Arne Petersen > wrote: > > > + Text is generally UTF-8 encoded, indices and lengths are in > bytes. > > > Remove the word "generally". *All* text in your api's are UTF-

Recursive dispatch (Re: [PATCH v2] server: Calculate remaining data size after a closure is processed)

On Tue, 12 Jan 2016 13:03:19 +0900 "Jaeyoon Jung" wrote: > > -Original Message- > > From: wayland-devel [mailto:wayland-devel-boun...@lists.freedesktop.org] On > > Behalf Of Jonas Adahl > > Sent: Tuesday, January 12, 2016 12:27 PM > > To: Jaeyoon Jung > > Cc: wayland-devel@lists.freedeskt

Re: [PATCH wayland-protocols] text: Create second version of text input protocol

Hi Rui, On 28/01/16 21:16, Rui Tiago Cação Matos wrote: > Hi, > > thanks for sending this. I was actually going to start a discussion > about the existing protocol but let's go from here instead. Comments > inline: > > First a question of scope: a client would only ever need to instance > one te

Re: [PATCH v3 wayland-protocols] text: Create second version of text input protocol

Hi Please find some comments and spelling corrections below. > There were some shortcomings in the first version of the protocol which > makes it not really useful in real world applications. It is not really > possible to fix them in a compatible way so introduce a new v2 of the > protocol. > >

Re: [PATCH wayland-protocols] text: Create second version of text input protocol

Hi, On 28/01/16 13:05, Daiki Ueno wrote: > Hello, > > Jan Arne Petersen writes: > >> Fixes some shortcomings of the first version: >> >> * Use only one wp_text_input per wl_seat (client side should be >> handled by client toolkit) >> * Allow focus tracking without wl_keyboard present > > The

Re: [PATCH wayland-protocols] text: Create second version of text input protocol

On 28/01/16 11:05, Jonas Ådahl wrote: > On Thu, Jan 28, 2016 at 08:52:40AM +0100, Jan Arne Petersen wrote: >> There were some shortcomings in the first version of the protocol which >> makes it not really useful in real world applications. It is not really >> possible to fix them in a compatible

[PATCH v3 wayland-protocols] text: Create second version of text input protocol

There were some shortcomings in the first version of the protocol which makes it not really useful in real world applications. It is not really possible to fix them in a compatible way so introduce a new v2 of the protocol. Fixes some shortcomings of the first version: * Use only one wp_text_inpu

[PATCH v2 wayland-protocols] text: Create second version of text input protocol

There were some shortcomings in the first version of the protocol which makes it not really useful in real world applications. It is not really possible to fix them in a compatible way so introduce a new v2 of the protocol. Fixes some shortcomings of the first version: * Use only one wp_text_inpu