Re: weston-info

2016-04-05 Thread Jonas Ådahl
On Tue, Apr 05, 2016 at 11:55:42AM +0200, Olivier Fourdan wrote: > Hi Pekka, > > On 5 April 2016 at 10:30, Pekka Paalanen wrote: > > > ​[...] > > > > > > this is a good idea indeed. > > > > Originally weston-info was needed in Weston repository, because it was > > useful in reporting specific in

Re: [PATCH weston v2] weston.pc: Properly specify Requires.private

2016-04-05 Thread Bryce Harrington
On Tue, Apr 05, 2016 at 10:11:32AM +0200, Quentin Glidic wrote: > From: Quentin Glidic > > We include wayland-server.h, pixman.h and xkbcommon.h in compositor.h, > but they are not required for linking if the plugin doesn’t use them. > > Signed-off-by: Quentin Glidic On an initial readup of Re

Re: [PATCH wayland] protocol: Correct grammar and spelling

2016-04-05 Thread Yong Bakos
> On Apr 5, 2016, at 8:03 PM, Bryce Harrington wrote: > > On Tue, Apr 05, 2016 at 06:24:01PM -0500, Yong Bakos wrote: >> From: Yong Bakos >> >> Fix grammar, spelling, tense, and other inconsistencies, based on >> correctness, consistency, and precedence both here and influenced >> by wayland-pr

Re: [PATCH wayland] protocol: Correct grammar and spelling

2016-04-05 Thread Bryce Harrington
On Tue, Apr 05, 2016 at 06:24:01PM -0500, Yong Bakos wrote: > From: Yong Bakos > > Fix grammar, spelling, tense, and other inconsistencies, based on > correctness, consistency, and precedence both here and influenced > by wayland-protocols. > > - Standardize lower case for summary attribute valu

Re: [PATCH v2] protocol: Extend wl_touch with touchpoint shape event

2016-04-05 Thread Peter Hutterer
On Tue, Apr 05, 2016 at 01:09:31PM -0700, Dennis Kempin wrote: > This CL updates the wl_touch interface with a shape event. > The shape of a touch point is not relevant for most UI > applications, but allows a better experience in some cases > such as drawing app. > > The shape event is used by th

Re: [PATCH v2 wayland-web] Updated build instructions for wayland-protocols and libwacom

2016-04-05 Thread Bryce Harrington
On Fri, Mar 25, 2016 at 07:37:33PM -0700, spit...@gmail.com wrote: > From: Bill Spitzak > > The Mint instructions have been tested, I had to guess at the Ubuntu12 > instructions as I no longer have that machine. > > v2: Use MAKEFLAGS instead of switches > Use & instead of & > Some reword

Re: [PATCH wayland v2 0/1] protocol: Add summaries to event parameters

2016-04-05 Thread Bryce Harrington
On Mon, Apr 04, 2016 at 04:56:04PM -0500, Yong Bakos wrote: > > On Sat, Apr 2, 2016 at 2:48 PM, Yong Bakos wrote: > > From: Yong Bakos > > > > This v2 patch incorporates some recent feedback per v1. Two things to note: > > > > 1) The 'name' parameter in wl_registry events has been changed to "n

[PATCH wayland] protocol: Correct grammar and spelling

2016-04-05 Thread Yong Bakos
From: Yong Bakos Fix grammar, spelling, tense, and other inconsistencies, based on correctness, consistency, and precedence both here and influenced by wayland-protocols. - Standardize lower case for summary attribute values. - Minor vertical whitespace removal consistency. - Standarize referenc

Re: [PATCH wayland v2 1/1] protocol: Add summaries to event parameters

2016-04-05 Thread Bryce Harrington
On Sat, Apr 02, 2016 at 04:48:12PM -0500, Yong Bakos wrote: > From: Yong Bakos > > All event arg elements now have an appropriate summary attribute. > This was conducted mostly in response to the undocumented parameter > warnings generated during 'make check'. > > Signed-off-by: Yong Bakos Tha

Re: [PATCH wayland 1/2] protocol: fix spelling mistake

2016-04-05 Thread Bryce Harrington
On Sat, Apr 02, 2016 at 05:04:04PM +0100, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom Thanks. For both patches: Reviewed-by: Bryce Harrington and pushed to trunk: 5259084..ae78dcb master -> master > --- > protocol/wayland.xml | 2 +- > 1 file changed, 1 insertion(+), 1 deleti

Re: [PATCH weston 1/3] zunitc: fix spelling mistake

2016-04-05 Thread Bryce Harrington
On Sat, Apr 02, 2016 at 05:03:13PM +0100, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom All look good. For the set: Reviewed-by: Bryce Harrington and pushed to trunk: f8cdb24..d962be1 master -> master > --- > tools/zunitc/inc/zunitc/zunitc.h | 2 +- > 1 file changed, 1 inserti

Re: [PATCH weston] zunitc: remove `break` after `return`

2016-04-05 Thread Bryce Harrington
On Sat, Apr 02, 2016 at 05:02:41PM +0100, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom Reviewed-by: Bryce Harrington Pushed: c49aa5a..f8cdb24 master -> master > --- > tools/zunitc/src/zuc_base_logger.c | 6 -- > tools/zunitc/src/zunitc_impl.c | 11 --- > 2 files

Re: [PATCH wayland-web] reviewing: Add Reviewed-by reply instructions

2016-04-05 Thread Bryce Harrington
On Tue, Apr 05, 2016 at 12:02:40PM -0500, Yong Bakos wrote: > From: Yong Bakos Reviewed-by: Bryce Harrington Pushed: 8745fe8..4022eeb master -> master > Signed-off-by: Yong Bakos > --- > reviewing.html | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/rev

Re: [PATCH libinput] fix spelling mistakes

2016-04-05 Thread Peter Hutterer
On Sun, Apr 03, 2016 at 01:47:43AM +0100, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom applied, thanks. Cheers, Peter > --- > doc/t440-support.dox | 2 +- > src/evdev-tablet.c | 2 +- > src/evdev.c | 2 +- > src/filter.c | 2 +- > src/libinput.h | 8 ---

[PATCH weston v2] systemd: take over sockets created by systemd

2016-04-05 Thread Friedrich, Eugen (ADITG/SW1)
Systemd provides a feature of socket-based activation, details in [1] This commit adds an implementation to check if sockets were provided by systemd and adds this as an additional socket to wayland display. before adding sockets are checked for the correctness: only AF_UNIX of type SOCK_STREAM are

Re: [PATCH] protocol: Extend wl_touch with touch point shape

2016-04-05 Thread Dennis Kempin
Thanks a lot for the comments guys! I agree on all of the above and uploaded a v2 of the patch. I included Peters description about the relationship to the frame event and updated the documentation to better describe how that ellipse is described. What major/minor means, how exactly the orientatio

[PATCH v2] protocol: Extend wl_touch with touchpoint shape event

2016-04-05 Thread Dennis Kempin
This CL updates the wl_touch interface with a shape event. The shape of a touch point is not relevant for most UI applications, but allows a better experience in some cases such as drawing app. The shape event is used by the compositor to inform the client about changes in the shape of a touchpoin

[PATCH wayland-web] reviewing: Add Reviewed-by reply instructions

2016-04-05 Thread Yong Bakos
From: Yong Bakos Signed-off-by: Yong Bakos --- reviewing.html | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/reviewing.html b/reviewing.html index a664c50..7f8ce3d 100644 --- a/reviewing.html +++ b/reviewing.html @@ -69,8 +69,11 @@ the community. So speak up. Espe

Re: [PATCH libinput] fix spelling mistakes (Eric Engestrom)

2016-04-05 Thread Pekka Paalanen
On Tue, 5 Apr 2016 09:28:11 -0500 Yong Bakos wrote: > > On Apr 5, 2016, at 3:52 AM, Pekka Paalanen wrote: > > > > On Mon, 4 Apr 2016 17:55:29 -0500 > > Yong Bakos wrote: > > > >>> Date: Sun, 3 Apr 2016 01:47:43 +0100 > >>> From: Eric Engestrom > >>> To: wayland-devel@lists.freedesktop.org

Re: [PATCH libinput] fix spelling mistakes (Eric Engestrom)

2016-04-05 Thread Yong Bakos
> On Apr 5, 2016, at 3:52 AM, Pekka Paalanen wrote: > > On Mon, 4 Apr 2016 17:55:29 -0500 > Yong Bakos wrote: > >>> Date: Sun, 3 Apr 2016 01:47:43 +0100 >>> From: Eric Engestrom >>> To: wayland-devel@lists.freedesktop.org >>> Cc: Eric Engestrom >>> Subject: [PATCH libinput] fix spelling mist

Re: [PATCH] xdg-shell: add set_max_size request

2016-04-05 Thread The Rasterman
On Mon, 4 Apr 2016 12:05:05 -0700 Bill Spitzak said: > I do not like clients having to update this value continuously as > conditions change. I would prefer any kind of design where the calculation > of the maximum size is deferred until it is actually used, ie at the point > that the user does w

Re: [PATCH] xdg-shell: add set_max_size request

2016-04-05 Thread The Rasterman
On Mon, 4 Apr 2016 22:40:10 -0700 Bill Spitzak said: > I think sending stepping size or aspect is not needed, but steps will > work only if the client can add a constant. Ie the width can be n*A+B > where A and B are specified by the client. The X11 version did not allow > a client to add a bo

RE: [PATCH weston] systemd: take over sockets created by systemd

2016-04-05 Thread Friedrich, Eugen (ADITG/SW1)
> -Original Message- > From: Pekka Paalanen [mailto:ppaala...@gmail.com] > Sent: Dienstag, 5. April 2016 13:08 > To: Friedrich, Eugen (ADITG/SW1) > Cc: wayland mailing list; Natsume, Wataru (ADITJ/SWG); Ucan, Emre > (ADITG/SW1) > Subject: Re: [PATCH weston] systemd: take over sockets create

[PATCH weston] Makefile: fix systemd-notify plugin CFLAGS

2016-04-05 Thread Pekka Paalanen
From: Pekka Paalanen SYSTEMD_DAEMON_LIBS does not belong in CFLAGS, but SYSTEMD_DAEMON_CFLAGS does. Fix that. Add the missing COMPOSITOR_CFLAGS. Otherwise compiling the plugin will use the system wayland-server.h when it should be using the one pointed to by pkg-config. The latter fixes the bui

Re: [PATCH weston] systemd: take over sockets created by systemd

2016-04-05 Thread Pekka Paalanen
On Sun, 3 Apr 2016 20:18:02 + "Friedrich, Eugen (ADITG/SW1)" wrote: > systemd provides a feature of socket-based activation, details in [1] > This commit adds an implementation to check if sockets were provided by > systemd and adds this as an additional socket to wayland display. > before ad

Re: [PATCH] xdg-shell: add set_max_size request

2016-04-05 Thread Bill Spitzak
I do not like clients having to update this value continuously as conditions change. I would prefer any kind of design where the calculation of the maximum size is deferred until it is actually used, ie at the point that the user does whatever action attemts to make the window larger. Perhaps an e

Re: [PATCH weston] systemd: take over sockets created by systemd

2016-04-05 Thread Bill Spitzak
On Sun, Apr 3, 2016 at 1:18 PM, Friedrich, Eugen (ADITG/SW1) < efriedr...@de.adit-jv.com> wrote: > systemd provides a feature of socket-based activation, details in [1] > This commit adds an implementation to check if sockets were provided by > systemd and adds this as an additional socket to wayl

Re: [PATCH] xdg-shell: add set_max_size request

2016-04-05 Thread Bill Spitzak
I think sending stepping size or aspect is not needed, but steps will work only if the client can add a constant. Ie the width can be n*A+B where A and B are specified by the client. The X11 version did not allow a client to add a border that was not a multiple of the steps thick, which made it

Re: weston-info

2016-04-05 Thread Olivier Fourdan
Hi Pekka, On 5 April 2016 at 10:30, Pekka Paalanen wrote: > ​[...] > > > this is a good idea indeed. > > Originally weston-info was needed in Weston repository, because it was > useful in reporting specific information from extensions being > developed in Weston. Nowadays we have wayland-protoco

[PATCH v2] xdg-shell: add preferred min/max size requests

2016-04-05 Thread Olivier Fourdan
Some application may wish to restrict their window in size, but xdg-shell has no mechanism for the client to advertise such a maximum or minimum size the compositor can use. As a result, the compositor may try to maximize or fullscreen a window while the client would not allow for the requested si

Re: [PATCH weston v2 0/7] IVI Layout Notification APIs Rework

2016-04-05 Thread Pekka Paalanen
On Mon, 4 Apr 2016 08:05:03 + "Ucan, Emre (ADITG/SW1)" wrote: > v2 Changes: > - add description to add_listener* APIs. > - squash rework and remove patches into one. > - don't cast void pointers unnecessarily. > - don't remove comma in the end of ivi_layout_interface struct. > > Emre Ucan (7

Re: [PATCH libinput] fix spelling mistakes (Eric Engestrom)

2016-04-05 Thread Pekka Paalanen
On Mon, 4 Apr 2016 17:55:29 -0500 Yong Bakos wrote: > > Date: Sun, 3 Apr 2016 01:47:43 +0100 > > From: Eric Engestrom > > To: wayland-devel@lists.freedesktop.org > > Cc: Eric Engestrom > > Subject: [PATCH libinput] fix spelling mistakes > > Message-ID: <1459644463-5419-1-git-send-email-e...@en

Re: weston-info

2016-04-05 Thread Pekka Paalanen
On Tue, 5 Apr 2016 10:20:28 +0200 Olivier Fourdan wrote: > Hi all, > > weston-info seems like a generally useful tool, even outside of weston, and > gives interesting information on the compositor, supported interfaces, > outputs, inputs... > > Only thing that seems fairly specific is the prese

weston-info

2016-04-05 Thread Olivier Fourdan
Hi all, weston-info seems like a generally useful tool, even outside of weston, and gives interesting information on the compositor, supported interfaces, outputs, inputs... Only thing that seems fairly specific is the presentation timing client protocol. I think it could be beneficial to move t

[PATCH weston v2] weston.pc: Properly specify Requires.private

2016-04-05 Thread Quentin Glidic
From: Quentin Glidic We include wayland-server.h, pixman.h and xkbcommon.h in compositor.h, but they are not required for linking if the plugin doesn’t use them. Signed-off-by: Quentin Glidic --- v2: Was missing wayland-server src/weston.pc.in | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH weston] weston.pc: Properly specify pixman and xkbcommon as Requires.private

2016-04-05 Thread Quentin Glidic
From: Quentin Glidic We include their header in compositor.h, but they are not required for linking if plugins do not use them. Signed-off-by: Quentin Glidic --- src/weston.pc.in | 1 + 1 file changed, 1 insertion(+) diff --git a/src/weston.pc.in b/src/weston.pc.in index 828cb1f..7a09938 1006

Re: [PATCH] xdg-shell: add set_max_size request

2016-04-05 Thread The Rasterman
On Tue, 5 Apr 2016 00:00:08 -0700 "Jasper St. Pierre" said: > "hint" just means "don't bother setting this flag, since it won't do > anything". i don't know what universe you have lived in, but for the past 20 years i've done x11 wm's hints have NEVER meant that. they mean "here is something i'd

Re: [PATCH] xdg-shell: add set_max_size request

2016-04-05 Thread Olivier Fourdan
Hi Jasper, - Original Message - > "hint" just means "don't bother setting this flag, since it won't do > anything". > > If we want min/max size rules, I want them to be enforced. Compositors > SHOULD NOT attempt to configure windows above or below the requested > size. Right, so it gets

Re: [PATCH] xdg-shell: add set_max_size request

2016-04-05 Thread Jasper St. Pierre
"hint" just means "don't bother setting this flag, since it won't do anything". If we want min/max size rules, I want them to be enforced. Compositors SHOULD NOT attempt to configure windows above or below the requested size. On Mon, Apr 4, 2016 at 11:58 PM, Olivier Fourdan wrote: > Hi all, > >