Re: [PATCH weston] Makefile: fix systemd-notify plugin CFLAGS

2016-04-13 Thread Bryce Harrington
On Tue, Apr 05, 2016 at 02:08:11PM +0300, Pekka Paalanen wrote: > From: Pekka Paalanen > > SYSTEMD_DAEMON_LIBS does not belong in CFLAGS, but SYSTEMD_DAEMON_CFLAGS > does. Fix that. > > Add the missing COMPOSITOR_CFLAGS. Otherwise compiling the plugin will > use the system wayland-server.h when

[PATCH libinput] touchpad: enlarge top button area by a factor 3 instead of 1.5

2016-04-13 Thread Peter Hutterer
From: Peter Frühberger When the touchpad is disabled, the top software button on the Lenovo T440 series touchpads currently enlarge by a factor of 1.5 (to 15mm). This is not enough, a user has to rotate the wrist quite uncomfortable when using the left mouse button. When the touchpad itself is o

Re: [PATCH wayland-build-tools] wl_install_deps: Add missing dependencies, remove INCLUDE_XWAYLAND logic

2016-04-13 Thread Bryce Harrington
On Wed, Apr 13, 2016 at 05:29:31PM -0500, Yong Bakos wrote: > From: Yong Bakos > > Building on Ubuntu 15.10 x64 fails due to missing packages: > libtool, libxml2-dev, libpng-dev, libglib2.0-dev, libgudev-1.0-dev, > libgcrypt20-dev, x11proto-scrnsaver-dev, libxfont-dev, and libedit-dev. > > In ad

Re: [PATCH wayland-build-tools] readme: Add instructions

2016-04-13 Thread Bryce Harrington
On Wed, Apr 13, 2016 at 05:28:55PM -0500, Yong Bakos wrote: > From: Yong Bakos > > The original readme just had a link to the official build instructions, > which does not help a user with these build tools. > > Signed-off-by: Yong Bakos Reviewed-by: Bryce Harrington Thanks, pushed: bcc2863

[PATCH libinput] touchpad: add LIBINPUT_MODEL_WOBBLY_TOUCHPAD for the HP 14-ac157tu

2016-04-13 Thread Peter Hutterer
If some elantech touchpads require a hysteresis, let's use some more generic tag for those touchpads that require correct handling of pointer wobbles. https://bugs.freedesktop.org/show_bug.cgi?id=94897 Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c| 3 +++ src/evdev.c

[PATCH wayland-build-tools] wl_install_deps: Add missing dependencies, remove INCLUDE_XWAYLAND logic

2016-04-13 Thread Yong Bakos
From: Yong Bakos Building on Ubuntu 15.10 x64 fails due to missing packages: libtool, libxml2-dev, libpng-dev, libglib2.0-dev, libgudev-1.0-dev, libgcrypt20-dev, x11proto-scrnsaver-dev, libxfont-dev, and libedit-dev. In addition, building with INCLUDE_XWAYLAND=0 causes failures due to missing pa

[PATCH wayland-build-tools] readme: Add instructions

2016-04-13 Thread Yong Bakos
From: Yong Bakos The original readme just had a link to the official build instructions, which does not help a user with these build tools. Signed-off-by: Yong Bakos --- README | 54 +- 1 file changed, 53 insertions(+), 1 deletion(-) diff --

Re: [PATCH wayland-protocols 1/4] stable/presentation-time: swap two paragraphs in 'presented'

2016-04-13 Thread Bryce Harrington
On Wed, Apr 13, 2016 at 11:11:54AM +0300, Pekka Paalanen wrote: > From: Pekka Paalanen > > Associates better with the surrounding paragraphs by not jumping topics > back and forth. > > Suggested-by: Bill Spitzak > Signed-off-by: Pekka Paalanen For all four patches: Reviewed-by: Bryce Harringt

Re: [PATCH wayland-protocols 00/19] Correct writing errors

2016-04-13 Thread Yong Bakos
On Apr 13, 2016, at 2:54 PM, Bryce Harrington wrote: > > On Mon, Apr 11, 2016 at 05:22:47PM -0500, Yong Bakos wrote: >> From: Yong Bakos >> >> This v1 patchset consists of spelling, grammar and minor formatting >> changes to all protocol xml files. The approach here is to be >> minimally invasi

Re: [PATCH wayland-protocols 00/19] Correct writing errors

2016-04-13 Thread Bryce Harrington
On Mon, Apr 11, 2016 at 05:22:47PM -0500, Yong Bakos wrote: > From: Yong Bakos > > This v1 patchset consists of spelling, grammar and minor formatting > changes to all protocol xml files. The approach here is to be > minimally invasive and to not impart stylistic changes; only corrections > and c

Re: [PATCH v6 xdg-shell-unstable-v6] xdg-shell: Add min/max size requests

2016-04-13 Thread Mike Blumenkrantz
Reviewed-By: Mike Blumenkrantz On Wed, Apr 13, 2016 at 2:18 PM Olivier Fourdan wrote: > Just a quick note, not that it matters much, but this should have been v7, > not v6, I got confused with the numbering of iterations :) > > Cheers, > Olivier > > - Original Message - > > Some applica

Re: [PATCH 4/5] compositor: Version the backend configuration structures

2016-04-13 Thread Bryce Harrington
On Wed, Apr 13, 2016 at 02:47:06PM +0300, Pekka Paalanen wrote: > On Tue, 12 Apr 2016 21:44:10 -0700 > Bryce Harrington wrote: > > > On Wed, Apr 06, 2016 at 11:43:54AM +0300, Pekka Paalanen wrote: > > > On Mon, 21 Mar 2016 23:11:29 +0100 > > > Benoit Gschwind wrote: > > > > > > > Hello, > > >

Re: [PATCH weston v5 09/11] drm: Don't hang onto the backend config object post-backend_init

2016-04-13 Thread Bryce Harrington
On Wed, Apr 13, 2016 at 04:54:04PM +0300, Pekka Paalanen wrote: > On Wed, 13 Apr 2016 03:25:13 -0700 > Bryce Harrington wrote: > > > The drm backend was copying most everything out of the config object > > already, but now also copy the use_current_mode parameter and the > > config_output functio

Re: [PATCH v6 xdg-shell-unstable-v6] xdg-shell: Add min/max size requests

2016-04-13 Thread Olivier Fourdan
Just a quick note, not that it matters much, but this should have been v7, not v6, I got confused with the numbering of iterations :) Cheers, Olivier - Original Message - > Some application may wish to restrict their window in size, but > xdg-shell has no mechanism for the client to spec

[PATCH v6 xdg-shell-unstable-v6] xdg-shell: Add min/max size requests

2016-04-13 Thread Olivier Fourdan
Some application may wish to restrict their window in size, but xdg-shell has no mechanism for the client to specify a maximum or minimum size. As a result, the compositor may try to maximize or fullscreen a window while the client would not allow for the requested size. Add new requests "set_max

Re: [PATCH weston v2] Makefile: Fix compilation error when git commit message has quotes

2016-04-13 Thread Pekka Paalanen
On Thu, 7 Apr 2016 10:56:23 -0700 Bryce Harrington wrote: > On Thu, Apr 07, 2016 at 04:53:31PM +, Chokshi, Mitul wrote: > > > > A double-quote in log message prematurely ends the enquoted string > > in src/git-version.h, causing an error during compilation. > > Used stream editor to replace

Re: [PATCH weston v5 00/11] drm: port the drm backend to the new init api

2016-04-13 Thread Pekka Paalanen
On Wed, 13 Apr 2016 03:25:04 -0700 Bryce Harrington wrote: > In following up on my earlier update of Giulio's drm backend config > patch, I've taken the liberty to try and also integrate a couple of > Benoit's other backend configuration patches into this patchset. > > Giulio and Benoit took dif

Re: [PATCH weston v5 09/11] drm: Don't hang onto the backend config object post-backend_init

2016-04-13 Thread Pekka Paalanen
On Wed, 13 Apr 2016 03:25:13 -0700 Bryce Harrington wrote: > The drm backend was copying most everything out of the config object > already, but now also copy the use_current_mode parameter and the > config_output function pointer, so that there are no remaining > references to the config object

Re: [PATCH weston v5 08/11] drm: Code and comments reformatting for consistency with other backend configs

2016-04-13 Thread Pekka Paalanen
On Wed, 13 Apr 2016 03:25:12 -0700 Bryce Harrington wrote: > Signed-off-by: Bryce Harrington > --- > src/compositor-drm.c | 10 ++ > src/compositor-drm.h | 43 --- > src/main.c | 6 -- > 3 files changed, 38 insertions(+), 21 deletio

Re: [PATCH 4/5] compositor: Version the backend configuration structures

2016-04-13 Thread Pekka Paalanen
On Tue, 12 Apr 2016 21:44:10 -0700 Bryce Harrington wrote: > On Wed, Apr 06, 2016 at 11:43:54AM +0300, Pekka Paalanen wrote: > > On Mon, 21 Mar 2016 23:11:29 +0100 > > Benoit Gschwind wrote: > > > > > Hello, > > > > > > I think that struct_version and struct_size should not be belong > > > c

Re: [PATCH 2/5] drm: port the drm backend to the new init api

2016-04-13 Thread Pekka Paalanen
On Tue, 12 Apr 2016 21:34:28 -0700 Bryce Harrington wrote: > On Wed, Apr 06, 2016 at 11:37:57AM +0300, Pekka Paalanen wrote: > > On Wed, 9 Mar 2016 16:49:29 -0800 > > Bryce Harrington wrote: > > > > > From: Giulio Camuffo > > > > > > Signed-off-by: Bryce Harrington > > > Reviewed-by: Quen

[PATCH weston v5 07/11] headless: port the headless backend to the new init api

2016-04-13 Thread Bryce Harrington
refactor configuration API of headless-backend Signed-off-by: Bryce Harrington --- v5: - update to current trunk - fixed typo 'struct weston_wayland_backend_config' - dropped unused variables - dropped weston_headless_backend_config_create() in favor of directly zalloc'ing the o

[PATCH weston v5 00/11] drm: port the drm backend to the new init api

2016-04-13 Thread Bryce Harrington
In following up on my earlier update of Giulio's drm backend config patch, I've taken the liberty to try and also integrate a couple of Benoit's other backend configuration patches into this patchset. Giulio and Benoit took different approaches in their implementations. I've attempted to reconcile

[PATCH weston v5 10/11] Enforce destruction of all backend config objects after initialization

2016-04-13 Thread Bryce Harrington
Since the backend config struct versioning implies that there we expect potential future descrepancy between main's definition of the config object and the backend's, don't allow the backend to hang onto the config object outside the initialization scope. Signed-off-by: Bryce Harrington --- src/

[PATCH weston v5 04/11] drm: Fix gcc warning about missing braces.

2016-04-13 Thread Bryce Harrington
Use double-brackets for config initializer for create_output_for_connector to avoid gcc warning, since first element is another struct. (See GCC bug 53119.) Quells warning: src/compositor-drm.c: In function ‘create_output_for_connector’: src/compositor-drm.c:2292:9: warning: missing braces ar

[PATCH weston v5 05/11] compositor: Document refs for alternatives/assumptions for backend configs

2016-04-13 Thread Bryce Harrington
Signed-off-by: Bryce Harrington --- src/compositor.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/compositor.h b/src/compositor.h index f93d76a..45ffb6c 100644 --- a/src/compositor.h +++ b/src/compositor.h @@ -682,6 +682,12 @@ struct weston_backend_output_config { * passed to t

[PATCH weston v5 09/11] drm: Don't hang onto the backend config object post-backend_init

2016-04-13 Thread Bryce Harrington
The drm backend was copying most everything out of the config object already, but now also copy the use_current_mode parameter and the config_output function pointer, so that there are no remaining references to the config object passed into backend_init(). By decoupling the config struct to the b

[PATCH weston v5 01/11] Revert "main: Remove unused function load_backend_new()"

2016-04-13 Thread Bryce Harrington
This reverts commit 5ffbfffaf7758c33791978516d0a1100773b85e2. Restore load_backend_new() for use with libweston backend configuration. Signed-off-by: Bryce Harrington --- src/main.c | 17 + 1 file changed, 17 insertions(+) diff --git a/src/main.c b/src/main.c index 1850fa6..43d

[PATCH weston v5 03/11] drm: port the drm backend to the new init api

2016-04-13 Thread Bryce Harrington
From: Giulio Camuffo Signed-off-by: Bryce Harrington Reviewed-by: Quentin Glidic Acked-by: Pekka Paalanen --- v5: - Update to reflect format rename to gdb_format - Initialize width/height (suggested by pq) - squash drm structure versioning (suggested by pq) Makefile.am | 3 +

[PATCH weston v5 11/11] drm: Drop use of drm_config config wrapper

2016-04-13 Thread Bryce Harrington
With the use_current_mode moved into the main config class, this small wrapper is redundant. Dropping it helps make the drm backend config initialization more consistent with the other backends. Signed-off-by: Bryce Harrington --- src/main.c | 35 ++- 1 file chan

[PATCH weston v5 08/11] drm: Code and comments reformatting for consistency with other backend configs

2016-04-13 Thread Bryce Harrington
Signed-off-by: Bryce Harrington --- src/compositor-drm.c | 10 ++ src/compositor-drm.h | 43 --- src/main.c | 6 -- 3 files changed, 38 insertions(+), 21 deletions(-) diff --git a/src/compositor-drm.c b/src/compositor-drm.c index aee

[PATCH weston v5 06/11] x11: port the x11 backend to the new init api

2016-04-13 Thread Bryce Harrington
From: Benoit Gschwind Use a "well" defined structure to configure x11-backend and move configuration file parsing inside the weston compositor code. Signed-off-by: Bryce Harrington --- v5: - Update to current trunk - Reformated for style consistency (e.g. spaces in "if(", linebreaks, e

[PATCH weston v5 02/11] compositor: Version the backend configuration structures

2016-04-13 Thread Bryce Harrington
With this struct versioning, it is possible to add new options without breaking the ABI, as long as all additions are made to the end of a struct and nothing existing is modified or removed. When things are added, the structure's size will increase, and we'll use this size as our minor version num

Re: [PATCH libinput] udev: update the hwdb matches to avoid use of ( and )

2016-04-13 Thread Hans de Goede
Hi, On 13-04-16 07:06, Peter Hutterer wrote: libudev's util_replace_chars() replaces the () with underscores so that match would work too but let's use ? instead to make it look like a regex. This now activates the rules for all cyapa touchpads, before they wouldn't have applied to any device.

Re: [PATCH libinput] test: add test for no scroll events before the scroll button timeout

2016-04-13 Thread Hans de Goede
Hi, On 12-04-16 20:50, Peter Hutterer wrote: Signed-off-by: Peter Hutterer Looks good to me: Reviewed-by: Hans de Goede Regards, Hans --- src/evdev.c| 2 ++ test/pointer.c | 31 +++ 2 files changed, 33 insertions(+) diff --git a/src/evdev.c b/src/e

Re: [PATCH v2 2/4 libinput] evdev: split scroll button state check out

2016-04-13 Thread Hans de Goede
Hi, On 12-04-16 20:50, Peter Hutterer wrote: Rather than checking the physical key's state, set a flag for the button to be down. This enables us to use non-physical buttons (middle button emulation). Signed-off-by: Peter Hutterer Looks good to me now: Reviewed-by: Hans de Goede Regards,

[PATCH wayland-protocols 2/4] stable/presentation-time: grammatical improvements by Bryce

2016-04-13 Thread Pekka Paalanen
From: Pekka Paalanen Suggested-by: Bryce Harrington Signed-off-by: Pekka Paalanen --- stable/presentation-time/presentation-time.xml | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/stable/presentation-time/presentation-time.xml b/stable/presentation-time/pre

[PATCH wayland-protocols 4/4] stable/presentation-time: rephrase request intro

2016-04-13 Thread Pekka Paalanen
From: Pekka Paalanen Attempting to clarify the paragraph. The key points are that feedback is double-buffered, part of a commit as all double-buffered state is, and it defines the term "content update" used later. The new phrasing defines not only a content update, but also content submission wh

[PATCH wayland-protocols 3/4] stable/presentation-time: reorganize clock_id documentation

2016-04-13 Thread Pekka Paalanen
From: Pekka Paalanen Move compositor implementors' guidelines to the end. Recombine the affected paragraphs. No changes to the wording are made. Suggested-by: Bryce Harrington Signed-off-by: Pekka Paalanen --- stable/presentation-time/presentation-time.xml | 22 ++ 1 file

[PATCH wayland-protocols 1/4] stable/presentation-time: swap two paragraphs in 'presented'

2016-04-13 Thread Pekka Paalanen
From: Pekka Paalanen Associates better with the surrounding paragraphs by not jumping topics back and forth. Suggested-by: Bill Spitzak Signed-off-by: Pekka Paalanen --- stable/presentation-time/presentation-time.xml | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/

Re: [PATCH v5 xdg-shell-unstable-v6] xdg-shell: Add min/max size requests

2016-04-13 Thread Olivier Fourdan
Hi Bill, > > > > It allows a client to say "I look best below this size, but if the > > > compositor wants to fill a larger rectangle, I can draw something nicer > > > than the compositor can do (the compositor can only pad or scale)". > > > > That's something different, isn't it? The compositor