Re: [PATCH v3] compositor-x11: fix title overflow in x11_backend_create_output

On Jun 5, 2016, at 12:01 PM, Benoit Gschwind wrote: > > sprintf can overflow the fixed length title which is char[32]. This > patch change title to dynamically allocated char array using asprintf or > strdup. If one of them fail we leave returning NULL to indicate the >

Re: [PATCH libinput] touchpad: restore the hysteresis by default

On Fri, Jun 03, 2016 at 12:49:45PM +0200, Hans de Goede wrote: > Hi, > > On 03-06-16 03:59, Peter Hutterer wrote: > > A large part of the bugs seen right now are related to touchpads jittering > > too > > much. Fixing them one by one is entertaining but time consuming. Right now > > the number

Re: [PATCH weston 1/4] README: clarify libweston purpose/goals.

Hi Yong, On 4 June 2016 at 01:58, Yong Bakos wrote: > Hi Emil, > > On Jun 3, 2016, at 8:27 AM, Emil Velikov wrote: >> >> From: Emil Velikov >> >> v2: Rewrap, add a couple of missing words (Pekka). >> >>

Re: [PATCH weston 1/2] Move weston source to compositor/

2016-06-03 17:33 GMT+03:00 Pekka Paalanen : > From: Pekka Paalanen > > This is the start of separating weston-the-compositor source files from > libweston source files. > > This is moving all the files related to the 'weston' binary. Also the >

Re: [PATCH weston 5/5] main: remove unused argument from backend loaders

Maybe it would make sense to squash this with the previous one? Cheers, Giulio 2016-06-03 15:41 GMT+03:00 Pekka Paalanen : > From: Pekka Paalanen > > There is no need to pass the backend name string to these functions > anymore. > >

Re: [PATCH weston 2/5] compositor, main: use weston_compositor_load_backend()

git am complains on this one: Applying patch #91319 using 'git am' Description: [weston,2/5] compositor, main: use weston_compositor_load_backend() Applying: compositor, main: use weston_compositor_load_backend() .git/rebase-apply/patch:44: new blank line at EOF. + warning: 1 line adds whitespace

Re: [PATCH weston 3/5] libweston: remove unused backend_init() arguments

2016-06-03 15:41 GMT+03:00 Pekka Paalanen : > From: Pekka Paalanen > > Backends do not have access to command line elements nor weston_config > anymore. The use the backend-specific config APIs now. Missing a y here, The -> They. Cheers,

Re: [PATCH weston 0/5] Clean up after backend config conversion

Hi, i have a few nitpicks on some patches, but for the whole series: Reviewed-by: Giulio Camuffo 2016-06-03 16:12 GMT+03:00 Quentin Glidic : > On 03/06/2016 14:41, Pekka Paalanen wrote: >> >> From: Pekka Paalanen

[PATCH v3] compositor-x11: fix title overflow in x11_backend_create_output

sprintf can overflow the fixed length title which is char[32]. This patch change title to dynamically allocated char array using asprintf or strdup. If one of them fail we leave returning NULL to indicate the failure. Signed-of-by: Benoit Gschwind --- v3: - fix

[PATCH v2] compositor-x11: fix title overflow in x11_backend_create_output

sprintf can overflow the fixed length title which is char[32]. This patch change title to dynamically allocated char array using asprintf or strdup. If one of them fail we leave returning NULL to indicate the failure. Signed-of-by: Benoit Gschwind --- src/compositor-x11.c |

Re: [PATCH v1] compositor-x11: fix title overflow in x11_backend_create_output

Hello Yong, Thanks for the review. On 05/06/2016 17:47, Yong Bakos wrote: > Hi Benoit, > Other than the comments inline below, this patch is > Reviewed-by: Yong Bakos > Tested-by: Yong Bakos > > On Jun 4, 2016, at 9:08 AM, Benoit Gschwind

[PATCH weston] compositor-wayland: Correct output base make name

From: Yong Bakos Change the output make value from "waywayland" to "wayland". References: 90bc88c710b34f46ef89e1c5765e5f63f8e02847 Signed-off-by: Yong Bakos --- src/compositor-wayland.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH v1] compositor-x11: fix title overflow in x11_backend_create_output

Hi Benoit, Other than the comments inline below, this patch is Reviewed-by: Yong Bakos Tested-by: Yong Bakos On Jun 4, 2016, at 9:08 AM, Benoit Gschwind wrote: > > --- I'd love to see a short message for the patch here