Re: [PATCH weston] weston-simple-im: Make capitalization consistent in error messages

2016-06-16 Thread Yong Bakos
> On Jun 16, 2016, at 12:11 PM, Bryce Harrington wrote: > > On Thu, Jun 16, 2016 at 11:14:01AM -0500, Derek Foreman wrote: >> On 15/06/16 07:59 PM, Bryce Harrington wrote: >>> Signed-off-by: Bryce Harrington >> >> Super important work, proudly >> Reviewed-by: Derek Foreman >> >> Though maybe

[PATCH libinput 4/4] touchpad: re-enable hysteresis by default for all devices

2016-06-16 Thread Peter Hutterer
The removal of the hysteresis even on precise touchpads has led to difficulties controlling the cursor in a few instances. Since 27078b2667d we only have the hysteresis on Apple touchpads and the Lenovo *40 series and later. Even on those do we see some positioning difficulties (bug 94379). So res

[PATCH libinput 3/4] Revert "touchpad: reset the motion history on significant negative pressure changes"

2016-06-16 Thread Peter Hutterer
We will reinstate the hysteresis for all devices making the negative pressure check unncessary. This reverts commit ef48c07a9600733e068a2a437a145862ba07fdab. --- src/evdev-mt-touchpad.c | 4 src/evdev-mt-touchpad.h | 1 - test/litest.c | 38 +++---

[PATCH libinput 2/4] Revert "touchpad: only use negative pressure change check on Lenovo *50 and *60 series"

2016-06-16 Thread Peter Hutterer
We will reinstate the hysteresis for all devices making the negative pressure check unncessary and thus this commit as well. This reverts commit 2f5231cc88fccf389a78270d827f6c9201b86794. --- src/evdev-mt-touchpad.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/evdev-m

[PATCH libinput 1/4] Revert "test: add a test for the T450 dropped motion events"

2016-06-16 Thread Peter Hutterer
This reverts commit b5527fa4c73da687774971ddd7cf6ad2016f89e7. --- test/touchpad.c | 67 - 1 file changed, 67 deletions(-) diff --git a/test/touchpad.c b/test/touchpad.c index 0b1cd0e..4255840 100644 --- a/test/touchpad.c +++ b/test/touchpad.

[PATCH libinput 0/4] Restore hysteresis for all touchpads

2016-06-16 Thread Peter Hutterer
Already enabled for all touchpads but the ones labelled as precise (which is just the apples and the lenovo *40 and later series anyway). Even with those we still see some unexpected pointer movement (e.g. #94379). The small benefit we get from removing the hysteresis isn't worth those drawbacks,

Re: [PATCH wayland-protocols] input-method: Grammar fixups

2016-06-16 Thread Yong Bakos
Hi Bryce, > On Jun 15, 2016, at 6:28 PM, Bryce Harrington wrote: > > From: Bryce Harrington > > Signed-off-by: Bryce Harrington > --- > unstable/input-method/input-method-unstable-v1.xml | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/unstable/input-met

[PATCH v3 libinput 09/10] pad: Allow for a hook to test the sysfs path

2016-06-16 Thread Peter Hutterer
If the LIBINPUT_TEST_TABLET_PAD_SYSFS_PATH udev property is set, use that as sysfs base path. This enables us to re-create the expected sysfs struct in some temporary folder during tests, thus allowing for tests of the mode groups' correct behaviours. Signed-off-by: Peter Hutterer --- Changes to

Re: [PATCH weston] Make config.h inclusion consistent

2016-06-16 Thread Hardening
Le 16/06/2016 03:13, Bryce Harrington a écrit : > Signed-off-by: Bryce Harrington Reviewed-by: David Fort > --- > clients/multi-resource.c | 2 +- > clients/presentation-shm.c| 2 +- > clients/simple-damage.c | 2 +- > clients/simple-dmabuf-intel.c | 2 +- > clients/simple-dmabu

Re: [PATCH weston] terminal: Document console codes less cryptically

2016-06-16 Thread Hardening
Le 16/06/2016 03:36, Bryce Harrington a écrit : > C.f. http://man7.org/linux/man-pages/man4/console_codes.4.html > > Signed-off-by: Bryce Harrington Definitely an improvement. Reviewed-by: David Fort > --- > clients/terminal.c | 72 > +++--- >

Re: [PATCH] Add a new wl_proxy_set_listener function

2016-06-16 Thread Jonas Ådahl
On Thu, Jun 16, 2016 at 11:27:31AM -0500, Derek Foreman wrote: > On 19/03/16 11:14 AM, Giulio Camuffo wrote: > > The wl_proxy_add_listener function is ill-named, because it suggests > > that a proxy can have many listeners. Instead it can only have one so > > deprecate the old function and add a ne

Re: [PATCH weston] weston-simple-im: Make capitalization consistent in error messages

2016-06-16 Thread Bryce Harrington
On Thu, Jun 16, 2016 at 11:14:01AM -0500, Derek Foreman wrote: > On 15/06/16 07:59 PM, Bryce Harrington wrote: > > Signed-off-by: Bryce Harrington > > Super important work, proudly > Reviewed-by: Derek Foreman > > Though maybe we should put . on the end if they're capitalized, make > them compl

Re: [PATCH] Add a new wl_proxy_set_listener function

2016-06-16 Thread Derek Foreman
On 19/03/16 11:14 AM, Giulio Camuffo wrote: > The wl_proxy_add_listener function is ill-named, because it suggests > that a proxy can have many listeners. Instead it can only have one so > deprecate the old function and add a new wl_proxy_set_listener. The > implementation of the new function is ex

Re: [PATCH weston] weston-simple-im: Make capitalization consistent in error messages

2016-06-16 Thread Derek Foreman
On 15/06/16 07:59 PM, Bryce Harrington wrote: > Signed-off-by: Bryce Harrington Super important work, proudly Reviewed-by: Derek Foreman Though maybe we should put . on the end if they're capitalized, make them complete sentences? > --- > clients/weston-simple-im.c | 6 +++--- > 1 file change

Re: [PATCH weston] Make config.h inclusion consistent

2016-06-16 Thread Derek Foreman
On 15/06/16 08:13 PM, Bryce Harrington wrote: > Signed-off-by: Bryce Harrington Reviewed-by: Derek Foreman > --- > clients/multi-resource.c | 2 +- > clients/presentation-shm.c| 2 +- > clients/simple-damage.c | 2 +- > clients/simple-dmabuf-intel.c | 2 +- > clients/simple-dmab

Re: [PATCH weston] terminal: Document console codes less cryptically

2016-06-16 Thread Derek Foreman
On 15/06/16 08:36 PM, Bryce Harrington wrote: > C.f. http://man7.org/linux/man-pages/man4/console_codes.4.html > > Signed-off-by: Bryce Harrington Looks fine to me Reviewed-by: Derek Foreman > --- > clients/terminal.c | 72 > +++--- > 1 file ch

Re: [PATCH weston 3/3] tests: fix the cursor race in internal-screenshot

2016-06-16 Thread Derek Foreman
On 16/06/16 05:36 AM, Pekka Paalanen wrote: > From: Pekka Paalanen > > This fix also depends on "compositor-headless: do not create a seat". > > If we lose the race against weston-desktop-shell setting cursors, which > is very rare, we get a cursor image in the screenshot, causing the test > to

Re: [PATCH weston 0/3] Work around cursors messing up screenshot test

2016-06-16 Thread Derek Foreman
On 16/06/16 05:36 AM, Pekka Paalanen wrote: > From: Pekka Paalanen > > The internal-screenshot test has been failing randomly and rarely. That is > caused by cursors being drawn unexpectedly. This series implements the minimal > fix to the issue. > > Once headless no longer inits its seat, the o

Re: [PATCH weston 0/2] compositor: Support linux_dmabuf multiplanar formats for scanout/sprite planes

2016-06-16 Thread Derek Foreman
On 27/05/16 04:52 AM, Tomohito Esaki wrote: > These patches add support multiplanar formats by using linux_dmabuf instead of > gbm for scanout/sprite plane importing. > > When rendering linux_dmabuf buffers, gbm isn't required, and multiplanar > formats can be supported by using drmModeAddFB2() in

Re: [PATCH weston] compositor-fbdev: drop EGL support

2016-06-16 Thread Derek Foreman
On 13/06/16 06:24 AM, Pekka Paalanen wrote: > From: Pekka Paalanen > > EGL code was added to the fbdev backend in > 4aa756dc7a8d3cf3b4c6f018c3e2a053fff424b0 in 2013, apparently for running > Weston on libhybris with Android hardware drivers. > > This actually had nothing to do with the fbdev bac

[PATCH weston 11/11] tests: implement visualize_image_difference()

2016-06-16 Thread Pekka Paalanen
From: Pekka Paalanen Useful for pointing out where the image comparisons fail. Internal-screenshot-test is modified to save the visualization if the test fails. Signed-off-by: Pekka Paalanen --- tests/internal-screenshot-test.c | 7 +++ tests/weston-test-client-helper.c | 99 +++

[PATCH weston 07/11] tests: rewrite check_surfaces_*() API

2016-06-16 Thread Pekka Paalanen
From: Pekka Paalanen check_surfaces_geometry() is removed as it was not used by anything, and unlikely would be. check_surfaces_equal() is merged into check_surfaces_match_in_clip(), passing a NULL clip means to compare whole images. check_surfaces_match_in_clip() is converted to work on pixman

[PATCH weston 03/11] tests: internal-screenshot-test to use create_shm_buffer_a8r8g8b8()

2016-06-16 Thread Pekka Paalanen
From: Pekka Paalanen This removes the uses of create_shm_buffer() from this test. Signed-off-by: Pekka Paalanen --- tests/internal-screenshot-test.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/tests/internal-screenshot-test.c b/tests/internal-

[PATCH weston 05/11] tests: make create_shm_buffer() static

2016-06-16 Thread Pekka Paalanen
From: Pekka Paalanen No users remain outside the file. This will allow to fix the assumptions in the function. Signed-off-by: Pekka Paalanen --- tests/weston-test-client-helper.c | 2 +- tests/weston-test-client-helper.h | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/te

[PATCH weston 01/11] tests: introduce struct buffer for client-helper

2016-06-16 Thread Pekka Paalanen
From: Pekka Paalanen We are growing more tests that need to handle buffers, both just images and wl_buffers. Particularly the screenshooting facility needs these. Currently everything is in struct surface, which contains more than we need. It is a bit messy. Create a new struct buffer to encapsu

[PATCH weston 08/11] tests: convert reference image loader to pixman

2016-06-16 Thread Pekka Paalanen
From: Pekka Paalanen This rewrites load_surface_from_png() to load_image_from_png(), to return a pixman_image_t instead of a struct surface. A loaded image has no need for wl_buffer or wl_surface or any of the associated attributes. This is part of unifying to make everything use pixman_image_t.

[PATCH weston 06/11] tests: let create_shm_buffer() handle any format

2016-06-16 Thread Pekka Paalanen
From: Pekka Paalanen Change create_shm_buffer() to handle any pixel format known to Pixman. Presumably in the future we might want to test e.g. RGB565 content with screenshot tests. Signed-off-by: Pekka Paalanen --- tests/weston-test-client-helper.c | 60 ++-

[PATCH weston 09/11] tests: convert image saver to pixman

2016-06-16 Thread Pekka Paalanen
From: Pekka Paalanen This rewrites write_surface_as_png() into write_image_as_png(), which operates on a pixman_image_t instead of a struct surface. This is part of the migration to use pixman_image_t everywhere without superfluous parameters/members. Now the image saving handles more than just

[PATCH weston 04/11] tests: ivi_layout-test to use create_shm_buffer_a8r8g8b8()

2016-06-16 Thread Pekka Paalanen
From: Pekka Paalanen This removes the uses of create_shm_buffer() from this test. Signed-off-by: Pekka Paalanen --- tests/ivi_layout-test.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/ivi_layout-test.c b/tests/ivi_layout-test.c index b775abe..320413a 10

[PATCH weston 10/11] tests: make screenshooting return a buffer

2016-06-16 Thread Pekka Paalanen
From: Pekka Paalanen Screenshooting does not involve creating a wl_surface, so using struct surface is superfluous. Return a struct buffer instead. It could have been just a pixman_image_t, but setting up proper destruction would be a bit more work. Should not hurt to keep the wl_buffer around u

[PATCH weston 00/11] tests: wrap all pixel data with Pixman

2016-06-16 Thread Pekka Paalanen
From: Pekka Paalanen Hi, I wanted to refactor the test code handling pixel buffers to use more appropriate data structures. A key to that is to pick a representation of an image. Our current representation cannot deal with arbitrary strides or pixel formats other than a8r8g8b8. There were three

[PATCH weston 02/11] tests: event-test to use create_shm_buffer_a8r8g8b8()

2016-06-16 Thread Pekka Paalanen
From: Pekka Paalanen This removes the uses of create_shm_buffer() from this test. Signed-off-by: Pekka Paalanen --- tests/event-test.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/tests/event-test.c b/tests/event-test.c index b616028..64dd7a0 1

[PATCH weston 1/3] tests: check kbd init in the plugin

2016-06-16 Thread Pekka Paalanen
From: Pekka Paalanen Check that the keyboard init in weston-test.so plugin succeeds. Signed-off-by: Pekka Paalanen --- tests/weston-test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/weston-test.c b/tests/weston-test.c index bda0d91..b9242c3 100644 --- a/tests/w

[PATCH weston 0/3] Work around cursors messing up screenshot test

2016-06-16 Thread Pekka Paalanen
From: Pekka Paalanen The internal-screenshot test has been failing randomly and rarely. That is caused by cursors being drawn unexpectedly. This series implements the minimal fix to the issue. Once headless no longer inits its seat, the only place where kbd init can be checked is the test plugin

[PATCH weston 3/3] tests: fix the cursor race in internal-screenshot

2016-06-16 Thread Pekka Paalanen
From: Pekka Paalanen This fix also depends on "compositor-headless: do not create a seat". If we lose the race against weston-desktop-shell setting cursors, which is very rare, we get a cursor image in the screenshot, causing the test to fail. This is now fixed by moving the (remaining) cursor o

[PATCH weston 2/3] compositor-headless: do not create a seat

2016-06-16 Thread Pekka Paalanen
From: Pekka Paalanen The headless backend was creating a seat, but nothing would ever happen on that seat, except the pointer cursor would show up. Tests do not seem to use this seat either. weston-test.so plugin creates its own seat to be controlled by the tests. This is part of the series to

Re: [PATCH weston 2/2] compositor-drm: Support linux_dmabuf output for sprite planes without gbm

2016-06-16 Thread Pekka Paalanen
On Thu, 16 Jun 2016 15:34:00 +0900 Esaki Tomohito wrote: > Hello Pekka, > > Thanks for reviewing the patchset. > > On 2016/06/15 17:22, Pekka Paalanen wrote: > > On Fri, 27 May 2016 18:52:28 +0900 > > Tomohito Esaki wrote: > > > >> Multiplanar formats are supported by using drmModeAddFB2 an

Re: [PATCH weston] compositor-fbdev: drop EGL support

2016-06-16 Thread Quentin Glidic
On 13/06/2016 13:24, Pekka Paalanen wrote: From: Pekka Paalanen EGL code was added to the fbdev backend in 4aa756dc7a8d3cf3b4c6f018c3e2a053fff424b0 in 2013, apparently for running Weston on libhybris with Android hardware drivers. This actually had nothing to do with the fbdev backend, really.

Re: How to create client in child thread

2016-06-16 Thread Pekka Paalanen
On Thu, 16 Jun 2016 09:54:54 +0800 (CST) 袁嘉伟 wrote: > Yes, I want to achieve that drawing the client from a thread but not > the main thread. Before I have tested that creating display and > drawing surface from main thread, and I try to call the > functions(xdg_surface_) of wayland to contro