[PATCH weston] clients/stacking: Silence a compiler warning

2016-09-28 Thread Armin Krezović
This patch fixes a compiler warning when building with clang, since it doesn't support gnu_printf attribute. v2: - Switch to WL_PRINTF per suggestion from Eric Engestrom. v3: - Explicitly include wayland-util.h Reviewed-by: Eric Engestrom Signed-off-by: Armin

Re: [PATCH weston 08/14 v3] weston: Port Wayland backend to new output handling API

2016-09-28 Thread Armin Krezović
On 27.09.2016 16:04, Pekka Paalanen wrote: > On Thu, 18 Aug 2016 18:42:36 +0200 > Armin Krezović wrote: > >> This is a complete port of the Wayland backend that >> uses recently added output handling API for output >> configuration. >> >> - Output can be configured at

Re: [PATCH weston v2] clients/stacking: Silence a compiler warning

2016-09-28 Thread Armin Krezović
On 27.09.2016 15:56, Eric Engestrom wrote: > On Tue, Sep 27, 2016 at 12:35:55PM +0200, Armin Krezović wrote: >> This patch fixes a compiler warning when building with >> clang, since it doesn't support gnu_printf attribute. >> >> v2: >> >> - Switch to WL_PRINTF per suggestion from Eric Engestrom.

Re: [PATCH weston] gl-renderer: Use EGL_KHR_no_config_context

2016-09-28 Thread Armin Krezović
On 27.09.2016 15:18, Emmanuel Gil Peyrot wrote: > On Tue, Sep 27, 2016 at 12:29:51PM +0200, Armin Krezović wrote: >> This patch makes use of recently implemented >> EGL_KHR_no_config_context extension in Mesa, >> which superseeds EGL_MESA_configless_context. >> >> See also (and the follow-up

[PATCH weston v2] libweston-desktop: destroy wl_shell_surface after the wl_surface is destroyed

2016-09-28 Thread Giulio Camuffo
The wl_shell_surface spec says that it is destroyed automatically by the server when the wl_surface is destroyed, and indeed it does not have a destroy request. So, do that. --- v2: remove the destroy listener when the wl_shell_surface is destroyed libweston-desktop/wl-shell.c | 21

[PATCH weston] libweston-desktop: fix sending the configure event with wl_shell

2016-09-28 Thread Giulio Camuffo
--- libweston-desktop/wl-shell.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libweston-desktop/wl-shell.c b/libweston-desktop/wl-shell.c index 20fe494..49f0f82 100644 --- a/libweston-desktop/wl-shell.c +++ b/libweston-desktop/wl-shell.c @@ -75,6 +75,7 @@

Re: [PATCH weston] libweston-desktop: listen for the wl_surface resource destruction

2016-09-28 Thread Giulio Camuffo
As per the discussion on IRC, i've sent a new one actually destroying the weston_desktop_surface. So, ignore this one. Cheers, Giulio 2016-09-28 11:13 GMT+02:00 Giulio Camuffo : > Weston's desktop shell increments the ref_count on the surfaces so that > when the

[PATCH weston] libweston-desktop: destroy wl_shell_surface after the wl_surface is destroyed

2016-09-28 Thread Giulio Camuffo
The wl_shell_surface spec says that it is destroyed automatically by the server when the wl_surface is destroyed, and indeed it does not have a destroy request. So, do that. --- libweston-desktop/wl-shell.c | 19 +++ 1 file changed, 19 insertions(+) diff --git

Re: [PATCH wayland v2 2/4] wl_array: Set data to invalid address after free

2016-09-28 Thread Eric Engestrom
On Tue, Sep 27, 2016 at 01:03:48PM -0500, Yong Bakos wrote: > From: Yong Bakos > > Explicitly set the data member to an invalid memory address during > wl_array_release, such that re-using a freed wl_array without re-initializing > causes a crash. In addition, this

Re: [PATCH weston] libweston-desktop: fix stale ping when a wl_shell_surface is destroyed

2016-09-28 Thread Giulio Camuffo
Hi, 2016-09-28 1:33 GMT+02:00 nerdopolis : > Hi > > Is this patch for https://bugs.freedesktop.org/show_bug.cgi?id=97892 , or is > it for a different issue that I am getting confused with? > It doesn't seem to fix the issue with wl_shell for qtwayland and EFL

[PATCH weston] libweston-desktop: listen for the wl_surface resource destruction

2016-09-28 Thread Giulio Camuffo
Weston's desktop shell increments the ref_count on the surfaces so that when the wl_resource of the wl_surface is destroyed the weston_surface keeps living. In that case, the weston_desktop_surface keeps living too but the shell resource doesn't. In the xdg_shell case it is destroyed by the client