Taking the last 4 points means factoring in a coordinate that may be more than
40ms in the past - or even more when the finger moves slowly and we don't get
events for a while. This makes the pointer more sluggish and slower to catch up
with what the finger is actually doing.
We already have the m
The hysteresis cuts the first pointer motion by the hysteresis margin. On some
touchpads this causes the tests to fail when the motion history length is
reduced (future patch). Allow the first event to be smaller than the expected
minimum.
This doesn't trigger in current tests because the hysteres
The test is supposed to make sure no motion event is sent and that scrolling
continues once leaving the edge. It does so by moving down the edge, into the
touchpad, then down further. The move from the edge into the touchpad had a
vertical component to it though and could cause the scroll minimum t
This doesn't have an effect in our current tests because the touchpad always
needs 4 motion events to get moving. But for the future, it simplifies the
case of "i want to move between x1/y1 and x2/y2", because it fills in only the
events in between rather than re-using the touch down coordinates an
center + diff is the input coordinate. Simplify the code so it's clear what
we're returning. And document the function to explain what it does.
Signed-off-by: Peter Hutterer
---
src/evdev.h | 38 +++---
1 file changed, 35 insertions(+), 3 deletions(-)
diff --git
On Mon, Nov 21, 2016 at 12:42:36PM +, Daniel Stone wrote:
> Hi,
>
> On 20 November 2016 at 05:14, Peter Hutterer wrote:
> > Rather than relying on input-event-codes, define our own enum that is
> > tailored
> > towards the tablet interface.
> >
> > Signed-off-by: Peter Hutterer
> > ---
> >
Hi Varad,
On 11 November 2016 at 11:40, Varad Gautam wrote:
> handle create_immed() dmabuf import requests and support
> zwp_linux_dmabuf_v1_interface version 2.
Same caveat about holding off on merging applies, but these two patches are:
Reviewed-by: Daniel Stone
Cheers,
Daniel
__
Also add a basic --help option
Signed-off-by: Bryce Harrington
---
clients/editor.c | 80
1 file changed, 58 insertions(+), 22 deletions(-)
diff --git a/clients/editor.c b/clients/editor.c
index 30bf555..b8fc63a 100644
--- a/clients/edito
On Mon, Nov 21, 2016 at 09:08:38PM +0100, Silvan Jegen wrote:
> Hi
>
> > int
> > main(int argc, char *argv[])
> > {
> > struct editor editor;
> > int i;
>
> This is still unused (as pointed out by Daniel) and should be removed.
Oh, thanks, missed that.
Bryce
> Cheers,
>
> Silvan
>
Add support for basic text file loading, to facilitate more expansive
testing of its UTF-8 text editing support.
Signed-off-by: Bryce Harrington
---
clients/editor.c | 67 +++-
1 file changed, 62 insertions(+), 5 deletions(-)
diff --git a/clie
Hi Varad,
On 11 November 2016 at 11:40, Varad Gautam wrote:
> provide a mechanism that allows clients to import the added dmabufs
> and immediately receive the newly created wl_buffer handle. this is
> useful to clients that are sure of their import request succeeding,
> and wish to avoid the wl_
Well, I agree this fix would allow non-compliant implementations to
keep misusing wl_surface.commit, and that could potentially remove any
motivation to find an appropriate resolution for the bug below.
I'm fine with deferring this patch, but I still think applications
should not start setting EGL
Hi,
On 21 November 2016 at 20:59, Yong Bakos wrote:
> On Nov 21, 2016, at 9:14 AM, Daniel Stone wrote:
>> I think removing the final word 'the dispatcher-specific
>> implementation data' is a loss of precision/accuracy. If you don't
>> mind reinstating that final word, I'll merge with my R-b.
>
Hi Daniel,
> On Nov 21, 2016, at 9:14 AM, Daniel Stone wrote:
>
> Hi Yong,
>
> On 21 November 2016 at 13:44, Yong Bakos wrote:
>> - * A dispatcher takes five arguments: The first is the dispatcher-specific
>> - * implementation data associated with the target object. The second is the
>> - *
Hi,
On 17 November 2016 at 11:56, Varad Gautam wrote:
> fill the dmabuf with valid DRM_FORMAT_NV12 +
> DRM_FORMAT_MOD_SAMSUNG_64_32_TILE frame data before importing to display
> a non-gibberish pattern when importing with modifiers.
Just squash this into the previous patch, which I've only just
On 17 November 2016 at 11:56, Varad Gautam wrote:
> From: Varad Gautam
>
> raw SMPTE color bar pattern in drm_fourcc.h format DRM_FORMAT_NV12 with
> modifier DRM_FORMAT_MOD_SAMSUNG_64_32_TILE to be imported as a dmabuf.
>
> Signed-off-by: Varad Gautam
Acked-by: Daniel Stone
___
Hi Varad,
On 17 November 2016 at 11:56, Varad Gautam wrote:
> From: Varad Gautam
>
> mesa's freedreno driver supports importing dmabufs with format
> DRM_FORMAT_NV12 and DRM_FORMAT_MOD_SAMSUNG_64_32_TILE modifier.
> demonstrate weston modifier advertising and import path using this
> combination
Hi Varad,
On 17 November 2016 at 11:56, Varad Gautam wrote:
> diff --git a/configure.ac b/configure.ac
> index d084d32..b959637 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -392,12 +392,21 @@ AC_ARG_ENABLE(simple-dmabuf-drm-client,
> [do not build the simple
Hi Varad,
On 17 November 2016 at 11:55, Varad Gautam wrote:
> From: Varad Gautam
>
> this will allow adding other drm backends later.
It's still not a particularly pretty client, but no worse than what came before.
Reviewed-by: Daniel Stone
Cheers,
Daniel
Hi Varad,
On 17 November 2016 at 11:55, Varad Gautam wrote:
> @@ -1621,6 +1621,21 @@ import_simple_dmabuf(struct gl_renderer *gr,
> }
> }
>
> + if (gr->has_dmabuf_import_modifiers) {
> + if (attributes->n_planes > 3) {
> + attribs[
Hi Varad,
On 17 November 2016 at 11:55, Varad Gautam wrote:
> attribs[atti++] = EGL_NONE;
> @@ -1924,9 +1941,10 @@ gl_renderer_import_dmabuf(struct weston_compositor *ec,
> assert(gr->has_dmabuf_import);
>
> for (i = 0; i < dmabuf->attributes.n_planes; i++) {
> -
Hi Varad,
On 17 November 2016 at 11:55, Varad Gautam wrote:
> implement 'format' and 'modifier' events to communicate available
> formats and modifiers to the client and support zwp_linux_dmabuf_v1
> interface version 3.
When this lands, this will need a wayland-protocols dependency bump in
conf
Hi Varad,
On 17 November 2016 at 11:55, Varad Gautam wrote:
> @@ -1847,6 +1851,69 @@ import_dmabuf(struct gl_renderer *gr,
> }
>
> static bool
> +gl_renderer_query_dmabuf_formats(struct weston_compositor *wc,
> + int **formats, int *num_formats)
> +{
> + stru
On 21 November 2016 at 20:07, Daniel Stone wrote:
> On 17 November 2016 at 11:55, Varad Gautam wrote:
>> +static bool
>> +gl_renderer_query_dmabuf_modifiers(struct weston_compositor *wc, int format,
>> + uint64_t **modifiers,
>> +
Hi
One comment below.
On Mon, Nov 21, 2016 at 10:34:33AM -0800, Bryce Harrington wrote:
> Also add a basic --help option
>
> Signed-off-by: Bryce Harrington
> ---
> clients/editor.c | 78
> +---
> 1 file changed, 57 insertions(+), 21 deletio
Hi Varad,
On 21 November 2016 at 10:17, Varad Gautam wrote:
> advertise the supported fourcc format modifiers along with supported
> formats to the client.
>
> bump zwp_linux_dmabuf_v1, zwp_linux_buffer_params_v1 interface
> versions to 3.
Reviewed-by: Daniel Stone
I'll wait a little while wit
Hi Varad,
On 21 November 2016 at 10:17, Varad Gautam wrote:
> clearly state the request name in format event to avoid abmiguous
> interpretation between 'zwp_linux_buffer_params_v1::create' and
> 'zwp_linux_dmabuf_v1::create_params' requests.
Sorry, I forgot to note that I pushed this earlier.
Hi Quentin,
On 11 July 2016 at 10:29, Quentin Glidic
wrote:
> Currently, layers’ order depends on the module loading order and it does
> not survive runtime modifications (like shell locking/unlocking).
> With this patch, modules can safely add their own layer at the expected
> position in the st
Hi Emmanuel,
On 2 May 2016 at 22:40, Emmanuel Gil Peyrot
wrote:
> Makes it clearer that they don’t use any field specific to drm_output,
> and reduce the amount of churn from the following commits.
I forgot to mention that I think patches 5 and 6 from this look good,
and I'll try to remember to
Hi Emmanuel,
On 2 May 2016 at 22:40, Emmanuel Gil Peyrot
wrote:
> Introduces a “same-as” configuration option for each output, which
> bypasses the rest of the output configuration (mode, scale, transform
> and seat) and instead makes it a clone of the specified output.
>
> This is implemented by
Hi,
On 21 November 2016 at 19:05, Bryce Harrington wrote:
> On Mon, Nov 21, 2016 at 06:06:23PM +, Daniel Stone wrote:
>> On 21 November 2016 at 18:02, Bryce Harrington wrote:
>> > libweston/gl-renderer.c:2862:2: error: ‘for’ loop initial declarations
>> > are only allowed in C99 mode
>>
On Mon, Nov 21, 2016 at 06:06:23PM +, Daniel Stone wrote:
> Hi,
>
> On 21 November 2016 at 18:02, Bryce Harrington wrote:
> > Fixes compilation error introduced by 43cea54c:
> >
> > libweston/gl-renderer.c:2862:2: error: ‘for’ loop initial declarations
> > are only allowed in C99 mode
> >
Add support for basic text file loading, to facilitate more expansive
testing of its UTF-8 text editing support.
Signed-off-by: Bryce Harrington
---
clients/editor.c | 68 +++-
1 file changed, 63 insertions(+), 5 deletions(-)
diff --git a/clie
Also add a basic --help option
Signed-off-by: Bryce Harrington
---
clients/editor.c | 78 +---
1 file changed, 57 insertions(+), 21 deletions(-)
diff --git a/clients/editor.c b/clients/editor.c
index 30bf555..33b43d2 100644
--- a/clients/edito
On Mon, Nov 21, 2016 at 12:55:14PM +, Daniel Stone wrote:
> Hi Bryce,
>
> On 20 November 2016 at 22:00, Bryce Harrington wrote:
> > Add support for basic text file loading, to facilitate more expansive
> > testing of its UTF-8 text editing support.
>
> Honestly, I question the value of turni
Hi,
On 30 August 2016 at 14:05, Olivier Fourdan wrote:
>> Xwayland should probably use a private protocol, like EGL, ideally
>> completely hidden and pid-restricted.
>
> That's the point, I initially thought of a private protocol, but then
> realized it could be useful outside of the Xwayland us
Hi,
On 10 August 2016 at 14:53, Quentin Glidic
wrote:
> From: Quentin Glidic
>
> Signed-off-by: Quentin Glidic
> ---
> libweston/animation.c | 35 +--
> libweston/compositor.h | 7 ++-
> 2 files changed, 35 insertions(+), 7 deletions(-)
Why not.
To ssh:/
Hi,
On 27 June 2016 at 14:15, Pekka Paalanen wrote:
> On Thu, 23 Jun 2016 18:55:17 +0200
> Quentin Glidic wrote:
>> While debugging my notification-area plugin, I had to test proper
>> placement based on panel position and size.
>>
>> So here is a proper implementation of panel position in Westo
Hi,
On 21 November 2016 at 18:02, Bryce Harrington wrote:
> Fixes compilation error introduced by 43cea54c:
>
> libweston/gl-renderer.c:2862:2: error: ‘for’ loop initial declarations
> are only allowed in C99 mode
> for (unsigned i = 0; i < ARRAY_LENGTH(swap_damage_ext_to_entrypoint);
>
Hi,
On 21 November 2016 at 18:01, Armin Krezović wrote:
> On 21.11.2016 18:42, Armin Krezović wrote:
>> v2:
>>
>> - Keep wl_shell code around until xdg_shell is declared stable.
>>
>> Signed-off-by: Armin Krezović
>
> I hereby agree that the following changes can be merged as part of this patch
Fixes compilation error introduced by 43cea54c:
libweston/gl-renderer.c:2862:2: error: ‘for’ loop initial declarations
are only allowed in C99 mode
for (unsigned i = 0; i < ARRAY_LENGTH(swap_damage_ext_to_entrypoint);
i++) {
^
Signed-off-by: Bryce Harrington
---
libweston/gl-ren
On 21.11.2016 18:42, Armin Krezović wrote:
> v2:
>
> - Keep wl_shell code around until xdg_shell is declared stable.
>
> Signed-off-by: Armin Krezović
I hereby agree that the following changes can be merged as part of this patch:
https://phabricator.freedesktop.org/P6
> ---
> Makefile.am
Hi Vincent,
On 7 October 2016 at 16:08, Vincent Abriou wrote:
> @@ -72,6 +72,9 @@ install-libweston_moduleLTLIBRARIES
> install-moduleLTLIBRARIES: install-libLTLIBR
> lib_LTLIBRARIES = libweston-@LIBWESTON_MAJOR@.la
> libweston_@LIBWESTON_MAJOR@_la_CPPFLAGS = $(AM_CPPFLAGS) -DIN_WESTON
> libw
v2:
- Keep wl_shell code around until xdg_shell is declared stable.
Signed-off-by: Armin Krezović
---
Makefile.am| 8 ++-
libweston/compositor-wayland.c | 146 +
2 files changed, 139 insertions(+), 15 deletions(-)
diff --git a/Make
Hi Emil,
On 30 August 2016 at 18:24, Emil Velikov wrote:
> From: Emil Velikov
>
> Use only internally and explicitly marked as such with commit
> cf04b0a18f2 ("Move private definitions and prototypes to new
> zwayland-private.h")
>
> Signed-off-by: Emil Velikov
> ---
> I could not find any user
Hi Yong,
On 21 November 2016 at 13:44, Yong Bakos wrote:
> - * A dispatcher takes five arguments: The first is the dispatcher-specific
> - * implementation data associated with the target object. The second is the
> - * object on which the callback is being invoked (either wl_proxy or
> - * wl_
On 21.11.2016 17:37, Daniel Stone wrote:
> Hi Armin,
>
> On 9 October 2016 at 16:30, Armin Krezović wrote:
>> Signed-off-by: Armin Krezović
>
> Could you please spin another version which doesn't jettison wl_shell
> support? I know it's lame, but it's the only thing which is actually
> stable e
Hi Eric,
On 26 October 2016 at 23:53, Eric Engestrom wrote:
> Supported colour formats are:
> - (0x)(AA)RRGGBB
> - #RGB(A)
> - #RRGGBB(AA)
If I'm honest, I don't entirely see the value in these. Accepting
12345678 as well as 0x12345678 implies, to me at least, that the
former will be interpreted
Hi Armin,
On 28 October 2016 at 23:26, Armin Krezović wrote:
> Signed-off-by: Armin Krezović
I've pushed this one, but need to think some more about the resizing.
Cheers,
Daniel
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https
Hi,
On 9 October 2016 at 16:30, Armin Krezović wrote:
> Signed-off-by: Armin Krezović
Meanwhile, I've reviewed and pushed the series up to this point. Thanks!
To ssh://git.freedesktop.org/git/wayland/weston
e31d95f..2e66252 upstream -> master
Cheers,
Daniel
___
Hi Armin,
On 9 October 2016 at 16:30, Armin Krezović wrote:
> wayland_output_set_fullscreen() already takes care of
> everything and xdg_shell doesn't use any present methods
> so a single call to wayland_output_set_fullscreen() is
> sufficient.
Ha, clever. I kind of wish I'd looked at this clos
Hi Armin,
On 9 October 2016 at 16:30, Armin Krezović wrote:
> Signed-off-by: Armin Krezović
Could you please spin another version which doesn't jettison wl_shell
support? I know it's lame, but it's the only thing which is actually
stable enough to predictably run across a wide range of versions
Hey Derek, Reynaldo,
On 7 September 2016 at 18:58, Derek Foreman wrote:
> diff --git a/libweston-desktop/libweston-desktop-uninstalled.pc.in
> b/libweston-desktop/libweston-desktop-uninstalled.pc.in
> new file mode 100644
> index 000..04af505
> --- /dev/null
> +++ b/libweston-desktop/libwest
Hi,
On 17 November 2016 at 23:01, Bryce Harrington wrote:
> On Thu, Nov 17, 2016 at 09:43:06PM +0100, Silvan Jegen wrote:
>> Signed-off-by: Silvan Jegen
>
> Yep, the value is set via a strdup in main(), so needs free'd.
>
> Reviewed-by: Bryce Harrington
Merged with review, thanks!
To ssh://gi
Hi Emil,
On 18 November 2016 at 19:12, Emil Velikov wrote:
> From: Emil Velikov
>
> v2: Use correct (destroy) API (Dan)
All merged with review now, thanks!
To ssh://git.freedesktop.org/git/wayland/weston
43cea54..5e60408 upstream -> master
Cheers,
Daniel
__
Hi Daniel
Below are two remarks regarding (m/z/c)alloc.
By the way, as a general remark (and maybe a personal opinion) zalloc(x)
is a bit more readable than calloc(1,x)
On 11/16/2016 03:25 PM, Daniel Stone wrote:
> Track dynamic plane state (CRTC, FB, position) in separate structures,
> rathe
On Mon, 21 Nov 2016 14:31:43 +0200
Pekka Paalanen wrote:
> From: Pekka Paalanen
>
> This is a rough intro to what Xwayland is and does, with just one
> implementation detail so far (Window identification).
>
> I paid no attention to formatting details, those can be polished in
> follow-ups. I
Hi Daniel
On 11/16/2016 03:25 PM, Daniel Stone wrote:
> Currently this doesn't actually really do anything, but will be used in
> the future to track the state for both modeset and repaint requests.
> Completion of the request gives us a single request-completion path for
> both pageflip and vbl
Verified that the intent of the return type of wl_dispatcher_func_t is
for an error code. I'm including a response from J Ekstrand, author
of wl_dispatcher_func_t inline below, for the record.
> On Nov 17, 2016, at 8:28 AM, Yong Bakos wrote:
>
> On Nov 17, 2016, at 8:23 AM, Yong Bakos wrote:
>>
Hi Pekka,
On 21 November 2016 at 13:30, Pekka Paalanen wrote:
> On Mon, 21 Nov 2016 12:19:43 + Daniel Stone wrote:
>> I'm would suggest we document that invoking wl_display_flush_clients() /
>> wl_connection_flush() from a request handler may cause undefined behaviour,
>> and that it must on
From: Yong Bakos
Adjust the brief, clarify the behavior and arguments, correct a grammar
error, document the parameters, and document the return type.
Signed-off-by: Yong Bakos
Reviewed-by: Bryce Harrington
---
v2: Document intent of return type.
src/wayland-util.h | 27 +
Please disregard, need to annotate the v2. Apologies for the noise.
y
> On Nov 21, 2016, at 5:40 AM, Yong Bakos wrote:
>
> From: Yong Bakos
>
> Adjust the brief, clarify the behavior and arguments, correct a grammar
> error, document the parameters, and document the return type.
>
> Signed-
Hi Daniel,
On 11/16/2016 03:25 PM, Daniel Stone wrote:
> Instead of setting state members directly in the drm_output_render
> functions (to paint using Pixman or GL), just return a drm_fb, and let
> the core function place it in state.
>
> Signed-off-by: Daniel Stone
>
> Differential Revision: h
From: Yong Bakos
Adjust the brief, clarify the behavior and arguments, correct a grammar
error, document the parameters, and document the return type.
Signed-off-by: Yong Bakos
Reviewed-by: Bryce Harrington
---
src/wayland-util.h | 27 +--
1 file changed, 17 insertions
On Mon, 21 Nov 2016 12:19:43 +
Daniel Stone wrote:
> Hi Hyun Kook,
>
> On 23 September 2016 at 00:40, Hyun Kook Khang
> wrote:
>
> > in wl_client_connection_data(),
> > there is no guarantee that client would never be destroyed in the process
> > of handling the pending input.
> >
> > For
Hi Bryce,
On 20 November 2016 at 22:00, Bryce Harrington wrote:
> Add support for basic text file loading, to facilitate more expansive
> testing of its UTF-8 text editing support.
Honestly, I question the value of turning the editor into something
'real': as soon as we're adding a --version arg
Hi,
On 20 November 2016 at 05:14, Peter Hutterer wrote:
> Rather than relying on input-event-codes, define our own enum that is tailored
> towards the tablet interface.
>
> Signed-off-by: Peter Hutterer
> ---
> Because it's usually easier to pick holes into a patch proposal than come up
> with i
From: Pekka Paalanen
This is a rough intro to what Xwayland is and does, with just one
implementation detail so far (Window identification).
I paid no attention to formatting details, those can be polished in
follow-ups. I just want the prose out.
I also just quickly whacked up the diagram, wou
Hi Hyun Kook,
On 23 September 2016 at 00:40, Hyun Kook Khang
wrote:
> in wl_client_connection_data(),
> there is no guarantee that client would never be destroyed in the process
> of handling the pending input.
>
> For example,
> 1. It comes to wl_client_connection_data()
> 2. wl_closure_invoke(
On Mon, Nov 21, 2016 at 06:36:49AM -0500, Mike Blumenkrantz wrote:
> On Fri, 18 Nov 2016 09:28:56 +0800
> Jonas Ådahl wrote:
>
> > On Wed, Nov 16, 2016 at 10:23:59AM -0500, Mike Blumenkrantz wrote:
> > > some restrictions must be placed on this or else it becomes legal for
> > > the compositor to
On Fri, 18 Nov 2016 09:28:56 +0800
Jonas Ådahl wrote:
> On Wed, Nov 16, 2016 at 10:23:59AM -0500, Mike Blumenkrantz wrote:
> > some restrictions must be placed on this or else it becomes legal for
> > the compositor to place popups in unexpected locations when sliding
> > is allowed
> >
> > Sign
Hi Bryce,
On 18 November 2016 at 00:42, Bryce Harrington wrote:
> The patch isn't applying as of change 66a26aeb (remove inconsistent line
> breaks), but in generating a whitespace patch myself using emacs with
> the Wayland style rules, I am getting a similar looking set of changes.
> While whit
Hi Peter,
On 10 November 2016 at 05:02, Peter Hutterer wrote:
> 8 spaces changed to one tab
Can't say I'm a massive fan of it personally, but that ship's already
sailed, so have applied this; well, manually reconstructed with sed
and taken your commit message / etc.
To ssh://git.freedesktop.org
Hi Yong,
On 13 November 2016 at 19:14, Yong Bakos wrote:
> My ongoing routine of documenting objects and checking for related test
> coverage
> has recently led me to notice that wl_argument_from_va_list does not have a
> specific test in connection-test.c. The 1/1 patch in this RFC describes a
Hi,
On 9 July 2016 at 02:36, Yong Bakos wrote:
> On Jul 8, 2016, at 4:42 PM, Bryce Harrington wrote:
>> The third arg to strtol() specifies the base to assume for the number.
>> When 0 is passed, as is currently done in wayland-client.c, hexadecimal
>> and octal numbers are permitted and automat
Hi Emil,
On 3 November 2016 at 22:38, Emil Velikov wrote:
> @@ -191,14 +205,21 @@ init_egl(struct display *display, struct window *window)
> display->swap_buffers_with_damage = NULL;
> extensions = eglQueryString(display->egl.dpy, EGL_EXTENSIONS);
> if (extensions &&
> -
Hi Yong,
On 20 November 2016 at 16:59, Yong Bakos wrote:
> +/**
> + * Log function type alias
> + *
> + * The C implementation of the Wayland protocol abstracts the details of
> + * logging. Users may customize the logging behavior, with a function
> conforming
> + * to the `wl_log_func_t` type,
Hi Giulio,
On 21 November 2016 at 11:23, Giulio Camuffo wrote:
> When using output scaling a client surface's wicth and height can be
> smaller than the cursor plane's size, even if its buffer is actually
> bigger. So check the buffer size rather than the surface size.
Derek had a similar yet co
> On 21 nov. 2016, at 11:55, Daniel Stone wrote:
>
> Hi,
>
> On 9 October 2016 at 21:04, Samuel Gaist wrote:
>>> On 31 août 2016, at 17:13, Yong Bakos wrote:
>>> On Aug 30, 2016, at 11:50 PM, Samuel Gaist wrote:
No being used to the by email patch workflow, should I send an updated
>>>
When using output scaling a client surface's wicth and height can be
smaller than the cursor plane's size, even if its buffer is actually
bigger. So check the buffer size rather than the surface size.
---
libweston/compositor-drm.c | 17 +
1 file changed, 9 insertions(+), 8 deletio
Hi Yong,
On 31 October 2016 at 13:43, Yong Bakos wrote:
> From: Yong Bakos
>
> Enum entries and message arguments are sometimes preceded by a blank line, but
> often aren't.
>
> Standardize the format of the protocol specification by removing blank lines
> preceding a list of message arguments a
Hi Bryce,
On 17 September 2016 at 04:42, Bryce Harrington wrote:
> @@ -42,7 +42,7 @@
>
>
>
> - This destroys the inhibit manager.
> + Destroy the inhibit manager.
>
>
>
> @@ -75,7 +75,7 @@
>
>
>
> - This removes the inhibitor effect from
> On 21 nov. 2016, at 12:11, Daniel Stone wrote:
>
> Hi Samuel,
>
> On 21 November 2016 at 11:08, Samuel Gaist wrote:
>>> On 21 nov. 2016, at 11:55, Daniel Stone wrote:
>>> Very much overlooked indeed; sorry for the delay. Pushed now.
>>
>> Thank you very much !
>>
>> Can you also take a lo
Hi,
On 30 August 2016 at 01:29, Bryce Harrington wrote:
> On Fri, Aug 26, 2016 at 04:04:03PM -0500, Derek Foreman wrote:
>> this was generating a pkg-config file that said wayland-scanner was
>> wayland/src/wayland-scanner when it's actually wayland/wayland-scanner
>>
>> Signed-off-by: Derek Fore
Hi Samuel,
On 21 November 2016 at 11:08, Samuel Gaist wrote:
>> On 21 nov. 2016, at 11:55, Daniel Stone wrote:
>> Very much overlooked indeed; sorry for the delay. Pushed now.
>
> Thank you very much !
>
> Can you also take a look at:
>
> https://lists.freedesktop.org/archives/wayland-devel/2016
Hi Yong,
On 20 November 2016 at 17:26, Yong Bakos wrote:
> Use declarative voice, remove the unnecessary doxygen \enum tag, and add
> two see-also's. This keeps the output the same but makes the comment
> voice consistent, a little more readable, and refers to documented
> functions that use this
Hi Peter,
On 18 November 2016 at 02:35, Peter Hutterer wrote:
> Because we already rely on it in the callers anyway. This is a retrofit, which
> is not ideal but I'm not sure any compositor out there uses anything else.
> Might as well define it.
Thanks for this.
To ssh://git.freedesktop.org/gi
On Monday 2016-11-21 12:00, Daniel Stone wrote:
>On 18 August 2016 at 10:15, Quentin Glidic
> wrote:
>> @@ -116,7 +116,9 @@ libweston_@LIBWESTON_MAJOR@_la_SOURCES =
>>\
>> lib_LTLIBRARIES += libweston-desktop-@LIBWESTON_MAJOR@.la
>> libweston_desktop_@LIBWESTON_MAJOR@_la_CPP
Hi,
On 18 August 2016 at 12:28, Quentin Glidic
wrote:
> I forgot to explain it, but these are actually defined in Weston, not
> libweston, so any libweston user trying to use them will fail.
Right you are:
To ssh://git.freedesktop.org/git/wayland/weston
c3b6372..46dc9b4 upstream -> master
C
Hi Quentin,
On 18 August 2016 at 10:15, Quentin Glidic
wrote:
> @@ -116,7 +116,9 @@ libweston_@LIBWESTON_MAJOR@_la_SOURCES =
> \
> lib_LTLIBRARIES += libweston-desktop-@LIBWESTON_MAJOR@.la
> libweston_desktop_@LIBWESTON_MAJOR@_la_CPPFLAGS = $(AM_CPPFLAGS) -DIN_WESTON
> libw
Hi,
On 9 October 2016 at 21:04, Samuel Gaist wrote:
>> On 31 août 2016, at 17:13, Yong Bakos wrote:
>> On Aug 30, 2016, at 11:50 PM, Samuel Gaist wrote:
>>> No being used to the by email patch workflow, should I send an updated
>>> patch with the “Reviewed-by” field added ?
>>
>> Samuel, not n
Hi,
On 16 September 2016 at 22:29, Bryce Harrington wrote:
> It is unlikely anyone still needs directions on how to install on this
> old distro -- Ubuntu 12.04 is scheduled to hit end-of-life this April.
>
> Further, no developers (to my knowledge) still test on 12.04, so the
> directions have l
From: Varad Gautam
advertise the supported fourcc format modifiers along with supported
formats to the client.
bump zwp_linux_dmabuf_v1, zwp_linux_buffer_params_v1 interface
versions to 3.
v2: specify request name in event description for clarity (Yong Bakos)
v3: grammar fixup (Yong Bakos)
Sig
From: Varad Gautam
clearly state the request name in format event to avoid abmiguous
interpretation between 'zwp_linux_buffer_params_v1::create' and
'zwp_linux_dmabuf_v1::create_params' requests.
v2: grammar fixup (Yong Bakos)
Suggested-by: Yong Bakos
Signed-off-by: Varad Gautam
Reviewed-by:
Hi Bryce,
On 17 September 2016 at 05:37, Bryce Harrington wrote:
>
>
> - Set the styling information on composing text. The style is applied
> for
> - length in bytes from index relative to the beginning of
> - the composing text (as byte offset). Multiple styles
On 27 July 2016 at 17:06, Derek Foreman wrote:
> This mildly confused me during some debugging, so I guess it wouldn't
> hurt to make the filename more indicative of where it was actually
> created.
>
> Signed-off-by: Derek Foreman
Heh. Branding!
To ssh://git.freedesktop.org/git/wayland/wayland
Hi Dima,
On 4 November 2016 at 06:46, Dima Ryazanov wrote:
> In Fedora, bash is configured to display a desktop notification when a command
> finishes (and the terminal is not focused). weston-terminal complains about
> it;
> let's silence it.
I have no clue about terminal escape codes, but equ
Hi Miguel,
On 15 November 2016 at 04:49, Miguel A. Vico wrote:
> There is nothing that prohibits the underlying EGL_PLATFORM_WAYLAND
> implementation to attach a buffer or commit surfaces right after the
> Wayland EGLSurface has been created.
>
> Since XDG Shell v6 imposes that no buffer attachme
Hi,
On 18 November 2016 at 12:17, Ryo Munakata wrote:
> Signed-off-by: Ryo Munakata
Pushed with review, thanks!
To ssh://git.freedesktop.org/git/wayland/weston
97863d6..08f09e2 upstream -> master
Cheers,
Daniel
___
wayland-devel mailing list
way
Hi,
On 17 November 2016 at 14:41, Pekka Paalanen
wrote:
> On Thu, 17 Nov 2016 12:17:59 +
> Daniel Stone wrote:
>> @@ -148,13 +148,19 @@ bind_to_unix_socket(int display)
>> static int
>> create_lockfile(int display, char *lockfile, size_t lsize)
>> {
>> - char pid[16];
>> + /* 10 d
1 - 100 of 101 matches
Mail list logo